Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-24 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 24, 2014 at 10:31:54AM +0200, Kay Sievers wrote: > On Thu, Apr 24, 2014 at 7:35 AM, Lennart Poettering > wrote: > > On Thu, 24.04.14 07:28, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > >> > Have you checked that EOPNOTSUPP is really the error that is returned by > >> >

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-24 Thread Kay Sievers
On Thu, Apr 24, 2014 at 7:35 AM, Lennart Poettering wrote: > On Thu, 24.04.14 07:28, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: >> > Have you checked that EOPNOTSUPP is really the error that is returned by >> > name_to_handle_at() if the kernel has the entire syscall disabled? Note >>

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-23 Thread Lennart Poettering
On Thu, 24.04.14 07:35, Lennart Poettering (lenn...@poettering.net) wrote: > On Thu, 24.04.14 07:28, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > Have you checked that EOPNOTSUPP is really the error that is returned by > > > name_to_handle_at() if the kernel has the entire syscall

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-23 Thread Lennart Poettering
On Thu, 24.04.14 07:28, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > Have you checked that EOPNOTSUPP is really the error that is returned by > > name_to_handle_at() if the kernel has the entire syscall disabled? Note > > that there are two different cases to distuingish here: a file

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 24, 2014 at 06:35:58AM +0200, Lennart Poettering wrote: > On Thu, 24.04.14 02:47, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > Supporting less reliable operation modes for something that just needs > > > to be configured in the kernel seems the wrong approach, especia

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-23 Thread Lennart Poettering
On Thu, 24.04.14 02:47, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > Supporting less reliable operation modes for something that just needs > > to be configured in the kernel seems the wrong approach, especially > > when it involves filesystem operations on user data like tmpfiles >

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-23 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 21, 2014 at 07:59:52PM +0200, Kay Sievers wrote: > On Sun, Apr 20, 2014 at 8:08 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Sun, Apr 20, 2014 at 03:53:05PM +0200, Kay Sievers wrote: > >> On Sun, Apr 20, 2014 at 5:36 AM, Zbigniew Jędrzejewski-Szmek > >> wrote: > >> > >> > Hi Kay, >

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-21 Thread Kay Sievers
On Sun, Apr 20, 2014 at 8:08 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Apr 20, 2014 at 03:53:05PM +0200, Kay Sievers wrote: >> On Sun, Apr 20, 2014 at 5:36 AM, Zbigniew Jędrzejewski-Szmek >> wrote: >> >> > Hi Kay, >> > it seems that handles are not crucial, and the simplified version below

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-20 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Apr 20, 2014 at 03:53:05PM +0200, Kay Sievers wrote: > On Sun, Apr 20, 2014 at 5:36 AM, Zbigniew Jędrzejewski-Szmek > wrote: > > > Hi Kay, > > it seems that handles are not crucial, and the simplified version below > > works too. Is there something I'm missing? > > The name_to_handle API

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-20 Thread Cristian Rodríguez
El 20/04/14 10:53, Kay Sievers escribió: On Sun, Apr 20, 2014 at 5:36 AM, Zbigniew Jędrzejewski-Szmek wrote: Hi Kay, it seems that handles are not crucial, and the simplified version below works too. Is there something I'm missing? The real problem here is that kernel developers took the q

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-20 Thread Kay Sievers
On Sun, Apr 20, 2014 at 5:36 AM, Zbigniew Jędrzejewski-Szmek wrote: > Hi Kay, > it seems that handles are not crucial, and the simplified version below > works too. Is there something I'm missing? The name_to_handle API works properly with bind mounts, it's the more reliable API. It also was in