Re: [systemd-devel] After=foo.busname oderings although kdbus is disabled

2015-03-14 Thread Michael Biebl
2015-03-14 16:12 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > On Sat, Mar 14, 2015 at 03:56:10PM +0100, Michael Biebl wrote: >> The compiler might warn about the unused const char *n; So this might >> be slightly better: >> [..] > Yep, looks good. Please push :) Pushed as 6962fd3 -- Why is it th

Re: [systemd-devel] After=foo.busname oderings although kdbus is disabled

2015-03-14 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 14, 2015 at 03:56:10PM +0100, Michael Biebl wrote: > The compiler might warn about the unused const char *n; So this might > be slightly better: > > > > diff --git a/src/core/service.c b/src/core/service.c > index db1f1e7..d938550 100644 > --- a/src/core/service.c > +++ b/src/core/se

Re: [systemd-devel] After=foo.busname oderings although kdbus is disabled

2015-03-14 Thread Michael Biebl
The compiler might warn about the unused const char *n; So this might be slightly better: diff --git a/src/core/service.c b/src/core/service.c index db1f1e7..d938550 100644 --- a/src/core/service.c +++ b/src/core/service.c @@ -555,14 +555,16 @@ static int service_add_extras(Service *s) {

Re: [systemd-devel] After=foo.busname oderings although kdbus is disabled

2015-03-14 Thread Michael Biebl
I think this should do it: diff --git a/src/core/service.c b/src/core/service.c index db1f1e7..bcdce33 100644 --- a/src/core/service.c +++ b/src/core/service.c @@ -561,10 +561,12 @@ static int service_add_extras(Service *s) { if (r < 0) return r; +#ifdef

Re: [systemd-devel] After=foo.busname oderings although kdbus is disabled

2015-03-13 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 14, 2015 at 01:41:16AM +0100, Michael Biebl wrote: > Hi, > > in Debian/Ubuntu, kdbus support is disabled. > With version 219 I see the following e.g. for avahi-daemon.service > > After=basic.target org.freedesktop.Avahi.busname avahi-daemon.socket > systemd-journald.socket system.slic