[systemd-devel] [PATCH] missing va_end

2012-09-21 Thread Lukáš Nykrýn
Hello, coverity scan 189->190 only complained about three missing va_ends. See attached patches. Regards Lukas >From 8b5667702257bc561ba7a67301080f0092538333 Mon Sep 17 00:00:00 2001 From: Lukas Nykryn Date: Fri, 21 Sep 2012 10:22:46 +0200 Subject: [PATCH 1/2] shared: call va_end in all cases --

Re: [systemd-devel] [PATCH] missing va_end

2012-09-21 Thread Lennart Poettering
On Fri, 21.09.12 10:47, Lukáš Nykrýn (lnyk...@redhat.com) wrote: > Hello, > coverity scan 189->190 only complained about three missing va_ends. > See attached patches. Applied! Thanks! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel m

Re: [systemd-devel] [PATCH 3/3] journalctl: add SIGWINCH handler in --follow mode

2012-09-21 Thread Lennart Poettering
On Mon, 17.09.12 19:47, Dave Reisner (dreis...@archlinux.org) wrote: > Recalculate the terminal size on SIGWINCH to make sure we take in to > the account the new real estate. Hmpf. this a bit dangerous as this code means accessing environ[] from the signal handler, which might not safe in some ca

Re: [systemd-devel] [PATCH 2/3] bash-completion: fix whitespace

2012-09-21 Thread Lennart Poettering
On Mon, 17.09.12 19:47, Dave Reisner (dreis...@archlinux.org) wrote: > Use spaces for indentation instead of tabs. These two look good to me, please commit (you should have commite access now, after all, please test!) > --- > bash-completion/systemd-bash-completion.sh | 12 ++-- > 1 fil

Re: [systemd-devel] [PATCH] do not ellipsize cgroup members in full status

2012-09-21 Thread Lennart Poettering
On Thu, 20.09.12 16:30, Lukáš Nykrýn (lnyk...@redhat.com) wrote: > Hello, > >From bug report: https://bugzilla.redhat.com/show_bug.cgi?id=858693 > "There is no easy way how to force "systemctl status" not to crop long > lines with ellipsis in a virtual terminal. "-a" or "--full" options > doesn't

Re: [systemd-devel] [PATCH] Arch: default to FONT=""

2012-09-21 Thread Tom Gundersen
Forgot to cc as always... On Fri, Sep 21, 2012 at 12:27 PM, Tom Gundersen wrote: > On Thu, Sep 13, 2012 at 7:29 AM, Lennart Poettering > wrote: >> Hmm, so I am tempted to make this change for everybody instead of just >> Arch. > > I'll submit patch. > >> But before I do that, I have one question

[systemd-devel] [PATCH] vconsole: default to the kernel compiled-in font

2012-09-21 Thread Tom Gundersen
No longer override the default kernel font if nothing is specified in vconsole.conf. The default kernel font[0] provides ISO-8859-1 and box characters. Users of Arabic, Cyrilic or Hebrew must set a different font manually as these character sets were provided by the old default font [1], but are n

Re: [systemd-devel] [PATCH] tmpfiles: allow Age to be set to 0d

2012-09-21 Thread Tom Gundersen
On Tue, Sep 11, 2012 at 12:52 AM, Lennart Poettering wrote: > What is the intended behaviour of an age setting of 0? Not sure I understand your question. For all intents and purposes 0s is the same as 1us (or something else sufficiently small). I.e., the file is cleaned up every time systemd-tmp

[systemd-devel] [PATCH] systemctl: fix misleading warning message

2012-09-21 Thread Michal Sekletar
From: Michal Sekletar When stopping multiple units at once do not print warning about triggering units when they are stopped by the same command. --- src/systemctl/systemctl.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemc

[systemd-devel] Various bug fixes

2012-09-21 Thread Václav Pavlín
You can find few patches for various bugs in attachement. -- Regards Václav Pavlín and Lukáš Nykrýn >From 55fa1c1b09933e55ce105279f2591674381c5345 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=A1clav=20Pavl=C3=ADn?= Date: Fri, 21 Sep 2012 12:04:02 +0200 Subject: [PATCH 01/18] cgtop: missing '-'

[systemd-devel] Dynamic priorities for service loading using systemd ...

2012-09-21 Thread Hoyer, Marko (ADITG/SW2)
Hi all, hope that is the right forum to raise my question. I'm trying to realize a kind of dynamic mandatory / lazy service scenario using systemd. This means in details that services are either mandatory or lazy. Mandatory services are started first, once all man. services have been loaded, t

Re: [systemd-devel] Various bug fixes

2012-09-21 Thread Lennart Poettering
On Fri, 21.09.12 15:25, Václav Pavlín (vpav...@redhat.com) wrote: > You can find few patches for various bugs in attachement. Thanks! I'll let Kay merge the udev related patches. The rest I merged, with a few exceptions: > +r = 0; > if (!isempty(cvtnr)) > -safe_

Re: [systemd-devel] [PATCH] vconsole: default to the kernel compiled-in font

2012-09-21 Thread Bill Nottingham
Tom Gundersen (t...@jklm.no) said: > No longer override the default kernel font if nothing is specified in > vconsole.conf. > > The default kernel font[0] provides ISO-8859-1 and box characters. Users > of Arabic, Cyrilic or Hebrew must set a different font manually as these > character sets were

Re: [systemd-devel] Dynamic priorities for service loading using systemd ...

2012-09-21 Thread Lennart Poettering
On Fri, 21.09.12 12:37, Hoyer, Marko (ADITG/SW2) (mho...@de.adit-jv.com) wrote: > Hi all, > > hope that is the right forum to raise my question. > > I'm trying to realize a kind of dynamic mandatory / lazy service > scenario using systemd. > > This means in details that services are either mand

Re: [systemd-devel] [PATCH] vconsole: default to the kernel compiled-in font

2012-09-21 Thread Tom Gundersen
On Sep 21, 2012 4:54 PM, "Bill Nottingham" wrote: > > Tom Gundersen (t...@jklm.no) said: > > No longer override the default kernel font if nothing is specified in > > vconsole.conf. > > > > The default kernel font[0] provides ISO-8859-1 and box characters. Users > > of Arabic, Cyrilic or Hebrew mu

Re: [systemd-devel] [PATCH] systemctl: fix misleading warning message

2012-09-21 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 17, 2012 at 09:23:49PM +0200, Michal Sekletar wrote: > From: Michal Sekletar > > When stopping multiple units at once do not print warning about > triggering units when they are stopped by the same command. Hi, is this warning actually still generated after 49111a70? Zbyszek > ---

[systemd-devel] [PATCH] Fix compilation error due to wrong __NR_name_to_handle_at definition

2012-09-21 Thread Eelco Dolstra
"__NR_name_to_handle" should read "__NR_name_to_handle_at". This fixes a compilation error on systems with older kernel headers. --- src/shared/missing.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shared/missing.h b/src/shared/missing.h index c5bb71a..14abe4e

[systemd-devel] No TTY and inability to shutdown/reboot from user session

2012-09-21 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Seems to be SELinux patch is causing systemd-logind not to be able to send dbus message to systemd. In the logs I see this message Sep 21 16:57:39 celtics systemd-logind[874]: System is powering down. Sep 21 16:57:39 celtics systemd-logind[874]: Fail

Re: [systemd-devel] [PATCH] Fix compilation error due to wrong __NR_name_to_handle_at definition

2012-09-21 Thread Lennart Poettering
On Fri, 21.09.12 12:55, Eelco Dolstra (eelco.dols...@logicblox.com) wrote: > "__NR_name_to_handle" should read "__NR_name_to_handle_at". This > fixes a compilation error on systems with older kernel headers. Applied. Thanks! Lennart -- Lennart Poettering - Red Hat, Inc. __

[systemd-devel] [ANNOUNCE] systemd 191

2012-09-21 Thread Lennart Poettering
Heya, http://www.freedesktop.org/software/systemd/systemd-191.tar.xz This is primarily a bugfix release. CHANGES WITH 191: * nspawn will now create a symlink /etc/localtime in the container environment, copying the host's timezone setting. Previously this has been do

[systemd-devel] [PATCH] Prevent cryptsetup from logging plain-text passphrases from /etc/crypttab

2012-09-21 Thread Karel Tuma
Just got bitten by this one. Instead, just warn the user legacy syntax is no longer supported. password.patch Description: Binary data ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/syste

Re: [systemd-devel] [ANNOUNCE] systemd 191

2012-09-21 Thread Dave Reisner
On Sat, Sep 22, 2012 at 12:41:49AM +0200, Lennart Poettering wrote: > Heya, > > http://www.freedesktop.org/software/systemd/systemd-191.tar.xz > > This is primarily a bugfix release. This does not build from git: make[2]: *** No rule to make target `src/journal/test-mmap-cache.c', needed by `s

Re: [systemd-devel] [ANNOUNCE] systemd 190

2012-09-21 Thread Eelco Dolstra
Hi, On 20/09/12 16:39, Lennart Poettering wrote: > * We will now mount the cgroup controllers cpu, cpuacct, > cpuset and the controllers net_cls, net_prio together by > default. Joining the cpuset controller with cpu/cpuacct caused problems on my system (NixOS Linux):