Re: [systemd-devel] Lid close event delivered delayed

2013-04-26 Thread Colin Guthrie
'Twas brillig, and Andrey Borzenkov at 17/04/13 18:01 did gyre and gimble: > В Wed, 17 Apr 2013 17:31:14 +0200 > Lennart Poettering пишет: > >> On Wed, 17.04.13 17:20, Jan Engelhardt (jeng...@inai.de) wrote: >> >>> >>> >>> On Wednesday 2013-04-17 16:42, Lennart Poettering wrote: On Wed, 17.0

[systemd-devel] [PATCH] ignore keep_free when creating a new journal

2013-04-26 Thread George McCollister
keep_free should be ignored when creating a new journal, otherwise server_rotate() will fail to setup the new journal if keep_free is exceed and server_vacuum will not be able to reclaim space. There might be more ellegant solutions to this problem but this works in my tests and it's a simple chan

[systemd-devel] [PATCH 1/2] test-hashmap.c first part

2013-04-26 Thread Daniel Buch
Hi, So this is comming along, and i want to finish this soon but i got a question; * What are do you think about using strv_new() + friends for allocateing hashmap values/keys insted of strdup()'s ? --- Makefile.am | 12 +- src/test/test-hashmap.c | 506 ++

[systemd-devel] [PATCH] Add help option to bootchart man page

2013-04-26 Thread Nathaniel Chen
Bootchart has a help option. For the sake of consistency, this patch adds it to the man page. Also, the TODO is updated. Bootcharts were added to the journal in commit c4d58b0. --- TODO | 1 - man/systemd-bootchart.xml | 6 ++ 2 files changed, 6 insertions(+), 1 deletion(

[systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Daniel Buch
--- src/shared/hashmap.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h index 26bd030..f52517f 100644 --- a/src/shared/hashmap.h +++ b/src/shared/hashmap.h @@ -57,11 +57,11 @@ int hashmap_ensure_allocated(Hashmap **h,

Re: [systemd-devel] [PATCH 1/2] test-hashmap.c first part

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 06:40:07PM +0200, Daniel Buch wrote: > Hi, > > So this is comming along, and i want to finish this soon but i got a question; Looks good. I haven't looked at the details, but if passes valgrind, and someone looks it over, it can surely go in. > * What are do you think abou

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: > --- > src/shared/hashmap.h | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h > index 26bd030..f52517f 100644 > --- a/src/shared/hashmap.h > +++ b/src/sh

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Kay Sievers
On Fri, Apr 26, 2013 at 7:49 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: >> --- >> src/shared/hashmap.h | 14 +++--- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h

Re: [systemd-devel] [PATCH 1/2] test-hashmap.c first part

2013-04-26 Thread Kay Sievers
On Fri, Apr 26, 2013 at 7:46 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Apr 26, 2013 at 06:40:07PM +0200, Daniel Buch wrote: >> Hi, >> >> So this is comming along, and i want to finish this soon but i got a >> question; > Looks good. I haven't looked at the details, but if passes valgrind,

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Daniel Buch
I felt the inconsistentsy was kinda awfull. I can change all to void* (instead of, void *) if you like but else leave this patch to the trash? 2013/4/26 Kay Sievers > On Fri, Apr 26, 2013 at 7:49 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buc

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Simon McVittie
On 26/04/13 18:49, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: >> -void* hashmap_get(Hashmap *h, const void *key); >> -void* hashmap_get2(Hashmap *h, const void *key, void **rkey); >> +void *hashmap_get(Hashmap *h, const void *key); >> +void *ha

[systemd-devel] [PATCH] test-hashmap.c: added unit-test for hashmap

2013-04-26 Thread Daniel Buch
Version 2, with leak fix. This should be good enough to be pushed. --- Makefile.am | 12 +- src/test/test-hashmap.c | 508 2 files changed, 519 insertions(+), 1 deletion(-) create mode 100644 src/test/test-hashmap.c diff --git a/Make

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 07:42:34PM +0100, Simon McVittie wrote: > On 26/04/13 18:49, Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: > >> -void* hashmap_get(Hashmap *h, const void *key); > >> -void* hashmap_get2(Hashmap *h, const void *key, void *

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 08:14:07PM +0200, Daniel Buch wrote: > I felt the inconsistentsy was kinda awfull. > > I can change all to void* (instead of, void *) if you like but else leave > this patch to the trash? I think it doesn't matter too much, it can stay as is. Zbyszek __

Re: [systemd-devel] [PATCH] test-hashmap.c: added unit-test for hashmap

2013-04-26 Thread Kay Sievers
On Fri, Apr 26, 2013 at 8:49 PM, Daniel Buch wrote: > Version 2, with leak fix. This should be good enough to be pushed. > +static void test_uint64_compare_func(void) { > +assert_se((uint64_t)trivial_compare_func("a", "a") == (uint64_t)0); > +assert_se((uint64_t)trivial_compare_fu