Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-12 Thread Patrik Flykt
On Tue, 2013-12-10 at 18:48 +0100, Lennart Poettering wrote: I agree with Zbigniew: this should probably be in src/libsystemd-dhcp/, so that this is similar to libsystemd-bus/, libsystemd-id128/ and so on... Sent a patch for that, and in the process of creating an account on freedesktop.org.

Re: [systemd-devel] No security on systemd-journal-gatewayd

2013-12-12 Thread Cecil Westerhof
On 12/12/2013 05:20 AM, Kay Sievers wrote: On Wed, Dec 11, 2013 at 11:53 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 11.12.2013 22:41, schrieb Cecil Westerhof: I tried out systemd-journal-gatewayd. But it looks like that everyone that can contact, can get log info. Is that true, or am I

Re: [systemd-devel] Question regarding the NotifyAccess parameter

2013-12-12 Thread salil GK
I think my system had a bit older minor version of systemd ( systemd-204-8.fc19.x86_64 ). In another system I have tested where I have systemd higher version - where the issue is not there - ( systemd-204-17.fc19.x86_64 ). Thanks Salil On 11 December 2013 06:15, salil GK gksa...@gmail.com

[systemd-devel] [PATCH] bus: Add support for eavesdrop in sd_bus_add_match()

2013-12-12 Thread Lukasz Skalski
Due to this patch, 'busctl monitor' prints all method calls, method errors and signals both for dbus and kdbus. --- src/libsystemd-bus/bus-control.c | 6 ++ src/libsystemd-bus/bus-match.c | 10 ++ src/libsystemd-bus/bus-match.h | 1 + src/libsystemd-bus/busctl.c | 2 +- 4

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-12 Thread Marcel Holtmann
Hi Patrik, I agree with Zbigniew: this should probably be in src/libsystemd-dhcp/, so that this is similar to libsystemd-bus/, libsystemd-id128/ and so on... Sent a patch for that, and in the process of creating an account on freedesktop.org. As that will most probably take some time,

Re: [systemd-devel] [PATCH] dhcp: Move src/dhcp to src/libsystemd-dhcp

2013-12-12 Thread Marcel Holtmann
Hi Patrik, --- Makefile.am | 42 +- src/dhcp/Makefile |1 - src/dhcp/client.c | 1002 - src/dhcp/internal.h | 41 - src/dhcp/network.c

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Marcel Holtmann
Hi Lennart, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap. Well, we don't fork threads/processes for each call but reuse them. What

[systemd-devel] [PATCH 2/3] journal: Try to pass log via /dev/shm to avoid waking up journal

2013-12-12 Thread Karol Lewandowski
Enabled by default for test purposes. --- src/journal/journal-send.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/src/journal/journal-send.c b/src/journal/journal-send.c index 281e154..9c4acc2 100644 --- a/src/journal/journal-send.c +++

[systemd-devel] [PATCH 3/3] journal-feeder: trivial test program to flood journald

2013-12-12 Thread Karol Lewandowski
This is not a systemd patch but simple test program I have used for measurements. --- journal-feeder.c | 64 1 file changed, 64 insertions(+) create mode 100644 journal-feeder.c diff --git a/journal-feeder.c b/journal-feeder.c new file

[systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-12 Thread Karol Lewandowski
Folks, We are trying to apply journald as default (and only) logging system for our ARM-based handhelds. There is one major problem, though - performance. We have found that journald can consume considerable amount of CPU time under moderate load (10-20% of CPU per, for say 100-300msg/s). We

[systemd-devel] [PATCH] logs-show.c: Fix missing sys/socket.h include

2013-12-12 Thread Marcel Holtmann
CC src/shared/logs-show.lo src/shared/logs-show.c: In function 'get_boot_id_for_machine': src/shared/logs-show.c:1153:9: warning: implicit declaration of function 'socketpair' [-Wimplicit-function-declaration] if (socketpair(AF_UNIX, SOCK_DGRAM, 0, sock) 0) ^

Re: [systemd-devel] [PATCH] dhcp: Move src/dhcp to src/libsystemd-dhcp

2013-12-12 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 12, 2013 at 02:00:48PM +0100, Marcel Holtmann wrote: instead of moving everything around after the fact, I would say we better start off with a clean patch set and everything in the right spot in the first place. Hi Marcel, I have a local git-filter-tree-ed branch with the

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Andrey Borzenkov
В Thu, 12 Dec 2013 14:09:42 +0100 Marcel Holtmann mar...@holtmann.org пишет: Hi Lennart, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap.

Re: [systemd-devel] [PATCH] shared: add missing include

2013-12-12 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 12, 2013 at 01:56:13PM +0900, Marc-Antoine Perennou wrote: Needed for socketpair, recv --- src/shared/logs-show.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/logs-show.c b/src/shared/logs-show.c index c99fc75..0e3fd3d 100644 --- a/src/shared/logs-show.c +++

Re: [systemd-devel] [PATCH] logs-show.c: Fix missing sys/socket.h include

2013-12-12 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 12, 2013 at 05:17:27AM -0800, Marcel Holtmann wrote: diff --git a/src/shared/logs-show.c b/src/shared/logs-show.c index c99fc7569429..0e3fd3de2630 100644 --- a/src/shared/logs-show.c +++ b/src/shared/logs-show.c @@ -23,6 +23,7 @@ #include assert.h #include errno.h #include

Re: [systemd-devel] No security on systemd-journal-gatewayd

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 05:20, Kay Sievers (k...@vrfy.org) wrote: On Wed, Dec 11, 2013 at 11:53 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 11.12.2013 22:41, schrieb Cecil Westerhof: I tried out systemd-journal-gatewayd. But it looks like that everyone that can contact, can get log

Re: [systemd-devel] [PATCH] logs-show.c: Fix missing sys/socket.h include

2013-12-12 Thread Marcel Holtmann
Hi Zbyszek, diff --git a/src/shared/logs-show.c b/src/shared/logs-show.c index c99fc7569429..0e3fd3de2630 100644 --- a/src/shared/logs-show.c +++ b/src/shared/logs-show.c @@ -23,6 +23,7 @@ #include assert.h #include errno.h #include sys/poll.h +#include sys/socket.h #include string.h

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 14:09, Marcel Holtmann (mar...@holtmann.org) wrote: Hi Lennart, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap.

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Marcel Holtmann
Hi Andrey, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap. Well, we don't fork threads/processes for each call but reuse them. What

Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-12 Thread Lennart Poettering
On Wed, 11.12.13 15:54, da...@davidstrauss.net (da...@davidstrauss.net) wrote: From: David Strauss da...@davidstrauss.net --- src/shared/install.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/shared/install.c b/src/shared/install.c index 17e8a75..14c0f4b 100644 ---

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 15:20, Marcel Holtmann (mar...@holtmann.org) wrote: Hi Andrey, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap.

Re: [systemd-devel] [PATCH] timedatectl: work with old timedated

2013-12-12 Thread Lennart Poettering
On Wed, 11.12.13 14:04, Shawn Landden (sh...@churchofgit.com) wrote: Which does have TimeUSec. Should we specifically check for this method instead of assuming time=0 means it doesn't exist? Sounds OK to just check against time == 0. +if (i-time) For numeric values please always

Re: [systemd-devel] [PATCH] login: Don't stop a running user manager from garbage-collecting the user.

2013-12-12 Thread Lennart Poettering
On Wed, 11.12.13 19:56, Thomas Bächler (tho...@archlinux.org) wrote: With the current logic, a user will never be garbage-collected, since its manager will always be around. Change the logic such that a user is garbage-collected when it has no sessions and linger is disabled. ---

Re: [systemd-devel] [PATCH] logs-show.c: Fix missing sys/socket.h include

2013-12-12 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 12, 2013 at 03:18:14PM +0100, Marcel Holtmann wrote: Hi Zbyszek, diff --git a/src/shared/logs-show.c b/src/shared/logs-show.c index c99fc7569429..0e3fd3de2630 100644 --- a/src/shared/logs-show.c +++ b/src/shared/logs-show.c @@ -23,6 +23,7 @@ #include assert.h #include

Re: [systemd-devel] [PATCH] libsystemd-bus: Add checking masks creds in bus_creds_dump() function

2013-12-12 Thread Lennart Poettering
On Wed, 11.12.13 15:23, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: log_assert_failed_return macro generates a lot of logs when we use bus_message_dump() function without checking masks in creds. Actually, the checks in the creds object where wrong, they should not have used

Re: [systemd-devel] Last question about systemd before my presentation

2013-12-12 Thread Lennart Poettering
On Wed, 11.12.13 16:33, Cecil Westerhof (cecil.wester...@snow.nl) wrote: On 12/05/2013 08:39 PM, Lennart Poettering wrote: When virtual machines are implementd as a service. You need to let the host define the limits per guest I suppose? Not following? You can pack as many services in

Re: [systemd-devel] [PATCH] login: Don't stop a running user manager from garbage-collecting the user.

2013-12-12 Thread Thomas Bächler
Am 12.12.2013 15:38, schrieb Lennart Poettering: On Wed, 11.12.13 19:56, Thomas Bächler (tho...@archlinux.org) wrote: With the current logic, a user will never be garbage-collected, since its manager will always be around. Change the logic such that a user is garbage-collected when it has no

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 14:12, Karol Lewandowski (k.lewando...@samsung.com) wrote: Folks, We are trying to apply journald as default (and only) logging system for our ARM-based handhelds. There is one major problem, though - performance. We have found that journald can consume considerable

Re: [systemd-devel] [HACK/RFC/PATCH] systemd-su: su on steroids

2013-12-12 Thread Lennart Poettering
On Wed, 11.12.13 15:57, David Herrmann (dh.herrm...@gmail.com) wrote: Hey On Wed, Dec 11, 2013 at 3:27 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 11.12.13 13:54, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Wed, Dec 11, 2013 at 12:18 AM, Lennart

Re: [systemd-devel] [HACK/RFC/PATCH] systemd-su: su on steroids

2013-12-12 Thread David Herrmann
Hi On Thu, Dec 12, 2013 at 3:55 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 11.12.13 15:57, David Herrmann (dh.herrm...@gmail.com) wrote: Hey On Wed, Dec 11, 2013 at 3:27 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 11.12.13 13:54, David Herrmann

Re: [systemd-devel] [PATCH] bus: Add support for eavesdrop in sd_bus_add_match()

2013-12-12 Thread Simon McVittie
On 12/12/13 14:28, Lennart Poettering wrote: kay and Daniel are working on changing the semantics of monitoring entirely. Instead of turning monitoring on and off on an existing connection they want this to be an entirely new connection type Colin Walters wanted to do this in dbus-daemon too

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Marcel Holtmann
Hi Lennart, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap. Well, we don't fork threads/processes for each call but reuse them. What

Re: [systemd-devel] Last question about systemd before my presentation

2013-12-12 Thread Cecil Westerhof
On 12/12/2013 03:43 PM, Lennart Poettering wrote: What I mend was the following: As I understood it, there are Virtual Machine solutions that are implemented as a service. When there are several VM's running in this service and one of those should get a lot more from the processor as the rest,

Re: [systemd-devel] [PATCH] bus: Add support for eavesdrop in sd_bus_add_match()

2013-12-12 Thread Lukasz Skalski
On 12/12/2013 04:22 PM, Simon McVittie wrote: On 12/12/13 14:28, Lennart Poettering wrote: kay and Daniel are working on changing the semantics of monitoring entirely. Instead of turning monitoring on and off on an existing connection they want this to be an entirely new connection type Colin

Re: [systemd-devel] No security on systemd-journal-gatewayd

2013-12-12 Thread Kay Sievers
On Thu, Dec 12, 2013 at 3:08 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 12.12.13 05:20, Kay Sievers (k...@vrfy.org) wrote: On Wed, Dec 11, 2013 at 11:53 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 11.12.2013 22:41, schrieb Cecil Westerhof: I tried out

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-12 Thread Karol Lewandowski
On Thu, Dec 12, 2013 at 03:51:05PM +0100, Lennart Poettering wrote: On Thu, 12.12.13 14:12, Karol Lewandowski (k.lewando...@samsung.com) wrote: (OP here from private email.) Folks, We are trying to apply journald as default (and only) logging system for our ARM-based handhelds. There

Re: [systemd-devel] [PATCH] dhcp: Move src/dhcp to src/libsystemd-dhcp

2013-12-12 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 12, 2013 at 02:41:45PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Dec 12, 2013 at 02:00:48PM +0100, Marcel Holtmann wrote: instead of moving everything around after the fact, I would say we better start off with a clean patch set and everything in the right spot in the

Re: [systemd-devel] [PATCH] bus: Add support for eavesdrop in sd_bus_add_match()

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 15:22, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: On 12/12/13 14:28, Lennart Poettering wrote: kay and Daniel are working on changing the semantics of monitoring entirely. Instead of turning monitoring on and off on an existing connection they want this to be

[systemd-devel] [PATCH] timedatectl: work with old timedated

2013-12-12 Thread Shawn Landden
Which does have TimeUSec. Should we specifically check for this method instead of assuming time=0 means it doesn't exist? Before: shawn@debian-T61:~/git/systemd$ ./timedatectl Local time: Wed 1969-12-31 16:00:00 PST Universal time: Thu 1970-01-01 00:00:00 UTC RTC time: n/a

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 17:42, Karol Lewandowski (lmc...@gmail.com) wrote: Hmm, but this wouldn't be any different from old syslog, right? I mean, old syslog also uses sendv() and recv() on AF_UNIX SOCK_DGRAM sockets... That's true, however, we aren't migrating from syslog, but from Android

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 16:28, Marcel Holtmann (mar...@holtmann.org) wrote: Hi Lennart, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap.

Re: [systemd-devel] [PATCH] bus: Add support for eavesdrop in sd_bus_add_match()

2013-12-12 Thread Kay Sievers
On Thu, Dec 12, 2013 at 6:59 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 12.12.13 15:22, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: On 12/12/13 14:28, Lennart Poettering wrote: kay and Daniel are working on changing the semantics of monitoring entirely. Instead

Re: [systemd-devel] [PATCH] timedatectl: work with old timedated

2013-12-12 Thread Lennart Poettering
On Thu, 12.12.13 10:00, Shawn Landden (sh...@churchofgit.com) wrote: Applied. Dropped the fflush(stderr) bits though as we that's not necessary for stderr, and not even for stdout if an \n was printed anyway... Thanks! diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c

Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-12 Thread David Timothy Strauss
On Thu, Dec 12, 2013 at 6:23 AM, Lennart Poettering lenn...@poettering.net wrote: This isn't right. Units might be symlinked under different names, we need to support that. For example, all template instances carry a different name for the symlink then for the source. Good point, though we

Re: [systemd-devel] [PATCH] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-12 Thread David Timothy Strauss
On Wed, Dec 11, 2013 at 8:36 PM, Andrey Borzenkov arvidj...@gmail.com wrote: This completely changes semantic of what it does. In this case no symlink is needed in the first place - just touch .../unit.wants/other.unit would be enough, as long as we assume units can only be located in standard

Re: [systemd-devel] [PATCH] timedatectl: work with old timedated

2013-12-12 Thread Shawn Landden
On Thu, Dec 12, 2013 at 11:02 AM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 12.12.13 10:00, Shawn Landden (sh...@churchofgit.com) wrote: Applied. Dropped the fflush(stderr) bits though as we that's not necessary for stderr, and not even for stdout if an \n was printed

Re: [systemd-devel] No security on systemd-journal-gatewayd

2013-12-12 Thread David Timothy Strauss
On Thu, Dec 12, 2013 at 8:15 AM, Kay Sievers k...@vrfy.org wrote: We must not give the impression that this is secure in any way, it is not, and cannot generally be used unless it is secured by other things. So, no this is not secure at all, just possibly encrypted, but I doubt that was the

Re: [systemd-devel] [PATCH 6/8] add GOP mode setting and splash drawing support

2013-12-12 Thread Greg KH
On Thu, Dec 12, 2013 at 09:51:43AM +0200, Joonas Lahtinen wrote: Hi Greg, I sent another set of patches, this time from command line, and at least I do not observe any line-wrapping with them when viewing the e-mail source. Did they apply fine for you? Yes, it looked fine, I didn't try to

[systemd-devel] journal: How to limit the file size of runtime system.journal

2013-12-12 Thread WANG Chao
Hi, In kdump environment, memory resource is quite limited. I find that the runtime journal file (/run/log/journal/$id/system.journal) is 4 MB and I think that is too much for a initramfs context. After tuning both RuntimeMaxUse=1% or RuntimeMaxFileSiz=100K, I find system.journal is still 4 MB

Re: [systemd-devel] journal: How to limit the file size of runtime system.journal

2013-12-12 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 13, 2013 at 01:33:17PM +0800, WANG Chao wrote: Hi, In kdump environment, memory resource is quite limited. I find that the runtime journal file (/run/log/journal/$id/system.journal) is 4 MB and I think that is too much for a initramfs context. After tuning both

[systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-12 Thread Shawn Landden
If Distribute=n, turns SO_REUSEPORT on, and spawns n workers to handling incoming requests. SO_REUSEPORT sockets on the same port must all be created by the same uid, therefore using the option allows other root programs (or programs of the same user if running in --user mode) to hijack this