Re: [systemd-devel] Fwd: [Pkg-systemd-maintainers] Bug#732157: Want SIGSTOP-style daemon/service readiness notification

2013-12-16 Thread David Timothy Strauss
If we supported PIDFile= for Type=simple, daemons could drop a PID file to indicate startup completion without having to be full-on Type=forking. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listi

[systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Yin Kangkai
From: Yin Kangkai Otherwise, for example hello arg passed to KDBUS_CMD_HELLO might not be 8 bytes aligned and kernel returns -EFAULT. 319 int bus_kernel_take_fd(sd_bus *b) { 320 struct kdbus_cmd_hello hello; (gdb) p &hello $8 = (struct kdbus_cmd_hello *) 0xb354 --- src/libs

Re: [systemd-devel] Why doe I not see the logging with -u

2013-12-16 Thread Cecil Westerhof
On 12/14/2013 09:22 AM, Cecil Westerhof wrote: I made a first setup to make a service for the H2 database. I made the folowing service file: [Unit] Description=H2 Database [Service] Type=simple ExecStart=/usr/bin/java -cp /home/cecil/java/h2/bin/h2-1.3.174.jar org.h2.too

Re: [systemd-devel] Fwd: [Pkg-systemd-maintainers] Bug#732157: Want SIGSTOP-style daemon/service readiness notification

2013-12-16 Thread Colin Guthrie
'Twas brillig, and David Timothy Strauss at 16/12/13 08:04 did gyre and gimble: > If we supported PIDFile= for Type=simple, daemons could drop a PID > file to indicate startup completion without having to be full-on > Type=forking. Yeah but pidfile is kinda ugly too and has problem when processes

[systemd-devel] Does not start in graphical mode

2013-12-16 Thread Cecil Westerhof
I made a openSUSE 13.1 VM in virtualbox. I start it in graphical mode. But I do not get a X environment. With journalctl I see that it is reached: Dec 16 12:18:33 linux-r4lo.site systemd[1]: Starting Graphical Interface. Dec 16 12:18:33 linux-r4lo.site systemd[1]: Reached target Graphical Inter

Re: [systemd-devel] Does not start in graphical mode

2013-12-16 Thread Colin Guthrie
'Twas brillig, and Cecil Westerhof at 16/12/13 11:32 did gyre and gimble: > I made a openSUSE 13.1 VM in virtualbox. I start it in graphical mode. > But I do not get a X environment. > > With journalctl I see that it is reached: > Dec 16 12:18:33 linux-r4lo.site systemd[1]: Starting Graphical Inte

Re: [systemd-devel] Does not start in graphical mode

2013-12-16 Thread Frederic Crozat
Le lundi 16 décembre 2013 à 12:32 +0100, Cecil Westerhof a écrit : > I made a openSUSE 13.1 VM in virtualbox. I start it in graphical mode. > But I do not get a X environment. > > With journalctl I see that it is reached: > Dec 16 12:18:33 linux-r4lo.site systemd[1]: Starting Graphical Interface.

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-16 Thread Daniel P. Berrange
On Fri, Dec 13, 2013 at 05:20:19PM +0100, Lennart Poettering wrote: > On Fri, 13.12.13 16:15, Lennart Poettering (lenn...@poettering.net) wrote: > > > > We had discussed this back at Linux Plumbers last year, and at the time > > > you had suggested that rather than create /dev/ttyN symlinks we sho

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-16 Thread Karol Lewandowski
On 12/14/2013 05:12 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Dec 13, 2013 at 10:16:16PM +0100, Karol Lewandowski wrote: >> One of the problems I see, though, is that no matter how deep I make >> the queue (`max_dgram_qlen') I still see process sleeping on send() >> way earlier that configur

Re: [systemd-devel] journal: How to limit the file size of runtime system.journal

2013-12-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 16, 2013 at 08:31:46AM +0100, Holger Winkelmann [TP] wrote: > Hi, > > > > > Is there any particular reason? I think thresold for runtime journal > > > > size can lower much because in initramfs it's not supposed to have much > > > > logs. > > > First, there are some data strcutures whi

Re: [systemd-devel] Does not start in graphical mode

2013-12-16 Thread Cecil Westerhof
On 12/16/2013 12:32 PM, Cecil Westerhof wrote: I made a openSUSE 13.1 VM in virtualbox. I start it in graphical mode. But I do not get a X environment. With journalctl I see that it is reached: Dec 16 12:18:33 linux-r4lo.site systemd[1]: Starting Graphical Interface. Dec 16 12:18:33 linux-r4lo.s

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-16 Thread Karol Lewandowski
On 12/14/2013 04:47 AM, Lennart Poettering wrote: > On Fri, 13.12.13 22:16, Karol Lewandowski (lmc...@gmail.com) wrote: >> On Fri, Dec 13, 2013 at 03:45:36PM +0100, Lennart Poettering wrote: >>> On Fri, 13.12.13 12:46, Karol Lewandowski (k.lewando...@samsung.com) wrote: >> One of the problems I se

Re: [systemd-devel] Fwd: [Pkg-systemd-maintainers] Bug#732157: Want SIGSTOP-style daemon/service readiness notification

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 00:04, David Timothy Strauss (da...@davidstrauss.net) wrote: > If we supported PIDFile= for Type=simple, daemons could drop a PID > file to indicate startup completion without having to be full-on > Type=forking. There has been a TODO list item for a long time to introduce Type=p

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 16:21, Yin Kangkai (kangkai@linux.intel.com) wrote: > From: Yin Kangkai > > Otherwise, for example hello arg passed to KDBUS_CMD_HELLO might not be 8 > bytes > aligned and kernel returns -EFAULT. > > 319 int bus_kernel_take_fd(sd_bus *b) { > 320 struct kdbu

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote: > > diff --git a/src/libsystemd-bus/bus-control.c > > b/src/libsystemd-bus/bus-control.c > > index 0072c37..6b2790d 100644 > > --- a/src/libsystemd-bus/bus-control.c > > +++ b/src/libsystemd-bus/bus-control.c > > @@ -207,7

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Kay Sievers
On Mon, Dec 16, 2013 at 4:01 PM, Lennart Poettering wrote: > On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote: > >> > diff --git a/src/libsystemd-bus/bus-control.c >> > b/src/libsystemd-bus/bus-control.c >> > index 0072c37..6b2790d 100644 >> > --- a/src/libsystemd-bus/bus

Re: [systemd-devel] [PATCH] prioq: avoid to swap item index

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 13:15, Yang Chengwei (chengwei.y...@intel.com) wrote: > On Mon, Dec 16, 2013 at 04:57:39AM +0100, Lennart Poettering wrote: > > On Mon, 16.12.13 04:48, Lennart Poettering (lenn...@poettering.net) wrote: > > > > > > > > On Mon, 16.12.13 11:03, Chengwei Yang (chengwei.y...@intel.c

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 15:36, Karol Lewandowski (k.lewando...@samsung.com) wrote: > On 12/14/2013 04:47 AM, Lennart Poettering wrote: > > On Fri, 13.12.13 22:16, Karol Lewandowski (lmc...@gmail.com) wrote: > >> On Fri, Dec 13, 2013 at 03:45:36PM +0100, Lennart Poettering wrote: > >>> On Fri, 13.12.13 12

Re: [systemd-devel] systemd + logind possible deadlock

2013-12-16 Thread Oleksii Shevchuk
> It's not hangin', just pretendin' :) What y'all think about a little > patch like this? Probably this is better than nothing, but will it fix anything? That stuff hangs not for 1 minute, but forever ___ systemd-devel mailing list systemd-devel@lists.fr

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 16:54, Lennart Poettering (lenn...@poettering.net) wrote: > > That's it. > > > > While journal code tries to set buffer size via SO_SNDBUF/SO_RCVBUF > > options to 8MB, kernel limits these to wmem_max/rmem_max. On machines > > I've tested respective values are quite small - aroun

Re: [systemd-devel] systemd + logind possible deadlock

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 18:14, Oleksii Shevchuk (alx...@gmail.com) wrote: > > > It's not hangin', just pretendin' :) What y'all think about a little > > patch like this? > > Probably this is better than nothing, but will it fix anything? That > stuff hangs not for 1 minute, but forever Are you suggest

Re: [systemd-devel] systemd + logind possible deadlock

2013-12-16 Thread Oleksii Shevchuk
> Are you suggesting O_SNDTIMEO doesn't work for you? Normally it should > simply cause the send() to fail if the receiver doesn't take the packet > within some time. I don't take much investigation into this, but looks like systemd-journald dead for some reason, and stay in zombie state, because

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 12:03, Daniel P. Berrange (berra...@redhat.com) wrote: > > Note that this *really* only supports ptys, not any other kinds of ttys, > > sinc for those we require propery device enumeration and notification > > and we don't have those in containers... I still chose to name this > >

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-16 Thread Daniel P. Berrange
On Mon, Dec 16, 2013 at 05:33:12PM +0100, Lennart Poettering wrote: > On Mon, 16.12.13 12:03, Daniel P. Berrange (berra...@redhat.com) wrote: > > > > Note that this *really* only supports ptys, not any other kinds of ttys, > > > sinc for those we require propery device enumeration and notification

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Kay Sievers
On Mon, Dec 16, 2013 at 4:09 PM, Kay Sievers wrote: > On Mon, Dec 16, 2013 at 4:01 PM, Lennart Poettering > wrote: >> On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote: >> >>> > diff --git a/src/libsystemd-bus/bus-control.c >>> > b/src/libsystemd-bus/bus-control.c >>> > i

[systemd-devel] [PATCH] _noreturn_ --> noreturn for C11 compat

2013-12-16 Thread Shawn Landden
also define noreturn w/o --- src/core/main.c | 2 +- src/journal/test-journal-interleaving.c | 2 +- src/shared/log.c| 4 ++-- src/shared/log.h| 4 ++-- src/shared/macro.h | 10 +- src/shared/

[systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
While all the libc implementations I know return NULL when memchr's size parameter is 0: C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length of the array for a function, n can have the value zero on a call to that function. Unless explicitly stated otherwise in the descript

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Lennart Poettering
On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: > While all the libc implementations I know return NULL when memchr's size > parameter is 0: > > C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length > of the array for a function, n can have the value zer

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering wrote: > On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: > >> While all the libc implementations I know return NULL when memchr's size >> parameter is 0: >> >> C11 7.24.1p2: Where an argument declared as "size_t n" specifies

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Thomas H.P. Andersen
On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden wrote: > On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering > wrote: >> On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: >> >>> While all the libc implementations I know return NULL when memchr's size >>> parameter is 0: >>> >>>

Re: [systemd-devel] Is it possible to start other service units by a service unit which was killed?

2013-12-16 Thread Tony Seo
Because I have managed a few processes in systemd, I'd like to just start all processes at the same time when one of the process was failed or dead with kill signal. But I'm curious about "fail" from your answer, now. What is the "fail signal" in systemd? I don't know how to make systemd take "fa

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 11:06 AM, Thomas H.P. Andersen wrote: > On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden wrote: >> On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering >> wrote: >>> On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: >>> While all the libc implementat

Re: [systemd-devel] Is it possible to start other service units by a service unit which was killed?

2013-12-16 Thread Andrey Borzenkov
В Tue, 17 Dec 2013 04:13:33 +0900 Tony Seo пишет: > > But I'm curious about "fail" from your answer, now. > What is the "fail signal" in systemd? When process terminated unexpectedly with any exit status that does not mean "normal exit". See SuccessExitStatus in man systemd.service. ___

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Thomas H.P. Andersen
On Mon, Dec 16, 2013 at 8:15 PM, Shawn Landden wrote: > On Mon, Dec 16, 2013 at 11:06 AM, Thomas H.P. Andersen > wrote: >> On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden wrote: >>> On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering >>> wrote: On Mon, 16.12.13 09:20, Shawn Landden (sh...

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 12:19 PM, Thomas H.P. Andersen wrote: > On Mon, Dec 16, 2013 at 8:15 PM, Shawn Landden wrote: >> On Mon, Dec 16, 2013 at 11:06 AM, Thomas H.P. Andersen >> wrote: >>> On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden >>> wrote: On Mon, Dec 16, 2013 at 10:36 AM, Lennar

[systemd-devel] dmesg: Vacuuming done, freed xxx bytes

2013-12-16 Thread Reindl Harald
is it really needed to pass this messages to dmesg instead syslog or supress them? it is disturbing in cases you "distribute" dmesg over a infrastructure with more than 20 machines [941542.003467] systemd-journald[22511]: Vacuuming done, freed 2879488 bytes [944310.095412] systemd-journald[22511]:

[systemd-devel] [PATCH] journal: fix against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
While all the libc implementations I know return NULL when memchr's size parameter is 0, without accessing any memory, passing NULL to memchr is still invalid: C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length of the array for a function, n can have the value zero on a ca

Re: [systemd-devel] [PATCH] prioq: avoid to swap item index

2013-12-16 Thread Yang Chengwei
> > Sorry, still not getting what you want to say. > > Mayb ethere is some confusion regarding what .idx actually is? .idx is Yes, it proved that I was wrong, that patch is right only and only when both items' idx is NULL, this apparently not the case. Please ignore that patch, thanks for your

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Yin Kangkai
On 2013-12-16, 16:01 +0100, Lennart Poettering wrote: > On Mon, 16.12.13 15:50, Lennart Poettering (lenn...@poettering.net) wrote: > > > > diff --git a/src/libsystemd-bus/bus-control.c > > > b/src/libsystemd-bus/bus-control.c > > > index 0072c37..6b2790d 100644 > > > --- a/src/libsystemd-bus/bus-

Re: [systemd-devel] [PATCH] libsystemd-bus: make sure buf transfered into kenrel is 8 aligned

2013-12-16 Thread Yin Kangkai
On 2013-12-16, 17:49 +0100, Kay Sievers wrote: > On Mon, Dec 16, 2013 at 4:09 PM, Kay Sievers wrote: > Just added __attribute__ ((__aligned__(8))) to kdbus.h for structures > used in ioctls. Yes, your patch is much more cleaner, thanks Kay. Regards, Kangkai __

Re: [systemd-devel] [PATCH] journal: fix against (theoretical) undefined behavior

2013-12-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 16, 2013 at 03:41:00PM -0800, Shawn Landden wrote: > While all the libc implementations I know return NULL when memchr's size > parameter is 0, without accessing any memory, passing NULL to memchr is > still invalid: > > C11 7.24.1p2: Where an argument declared as "size_t n" specifies

[systemd-devel] [PATCH] rtnl: fix for 32bits

2013-12-16 Thread Marc-Antoine Perennou
Commit 0a0dc69b655cfb10cab39133f5d521e7b35ce3d5 broke tests for 32 bits --- src/libsystemd-rtnl/rtnl-message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-rtnl/rtnl-message.c b/src/libsystemd-rtnl/rtnl-message.c index 264cca0..c62eca9 100644 --- a/src/libsys

Re: [systemd-devel] [PATCH] rtnl: fix for 32bits

2013-12-16 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 17, 2013 at 02:13:57PM +0900, Marc-Antoine Perennou wrote: > Commit 0a0dc69b655cfb10cab39133f5d521e7b35ce3d5 broke tests for 32 bits > --- > src/libsystemd-rtnl/rtnl-message.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libsystemd-rtnl/rtnl-message.c

[systemd-devel] udev rules environment variable

2013-12-16 Thread Robert Milasan
Hello, got a small question about creating a rule, like this: ACTION=="add", , ENV{test_device}="1" ACTION=="remove, , ENV{test_device}=="1", RUN+="/path/to/some/script" Does udev save test_device variable someplace and then it can be used later on, when have ACTION=="remove" ? -- R

Re: [systemd-devel] udev rules environment variable

2013-12-16 Thread Hannes Reinecke
On 12/17/2013 08:52 AM, Robert Milasan wrote: > Hello, > got a small question about creating a rule, like this: > > ACTION=="add", , ENV{test_device}="1" > > ACTION=="remove, , ENV{test_device}=="1", > RUN+="/path/to/some/script" > > Does udev save test_device variable someplace and th