[systemd-devel] [PATCH 0/1] gummiboot: Fix regression when Console Control protocol is missing

2014-01-15 Thread Joonas Lahtinen
The lack of nonstandard Console Control protocol should not be treated as an error when attempting to change between graphics and console mode. In original patches the return value was discarded, but currently if the protocol is not found and the call fails, no splash is drawn. This breaks

[systemd-devel] [PATCH 1/1] graphics: Do not require nonstandard console control protocol

2014-01-15 Thread Joonas Lahtinen
Console Control Protocol is a nonstandard UEFI interface and lack of it shall not be treated as an error. Signed-off-by: Joonas Lahtinen joonas.lahti...@linux.intel.com --- src/efi/graphics.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/efi/graphics.c

Re: [systemd-devel] [PATCH 1/1] graphics: Do not require nonstandard console control protocol

2014-01-15 Thread Tom Gundersen
On Wed, Jan 15, 2014 at 12:08 PM, Joonas Lahtinen joonas.lahti...@linux.intel.com wrote: Console Control Protocol is a nonstandard UEFI interface and lack of it shall not be treated as an error. Ah, great! I was struggling to make the splash work on tianocore for the longest time, and this

[systemd-devel] [PATCH] udev: ifname matches given mac

2014-01-15 Thread Umut Tezduyar Lindskog
This covers the case where NamePolicy has mac in it and MACAddress is given. Ex: NamePolicy=mac MACAddress=00:00:00:00:00:00 Interface name becomes [en|wl]x Also cleanup rtnl_set_link_properties --- src/libsystemd/rtnl-util.c | 16 ++---

Re: [systemd-devel] [PATCH] udev: ifname matches given mac

2014-01-15 Thread Tom Gundersen
Hi Umut, I'm not really convinced about this. I think we should be fairly conservative about what names we consider persistent. The way NamePolicy=mac currently works is that it will base the name on the hardware mac address (i.e., not randomly generated by the kernel, set by userspace etc), and

Re: [systemd-devel] [systemd-commits] src/journal

2014-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 15, 2014 at 03:57:08AM -0800, Lukas Nykryn wrote: src/journal/coredumpctl.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 1b2457e16dbbaa5e587c5e36d274a48c585d4840 Author: Lukas Nykryn lnyk...@redhat.com Date: Wed Jan 15 12:46:44 2014 +0100

Re: [systemd-devel] [PATCH 1/1] graphics: Do not require nonstandard console control protocol

2014-01-15 Thread Joonas Lahtinen
Hi, On 15.01.2014 13:34, Tom Gundersen wrote: On Wed, Jan 15, 2014 at 12:08 PM, Joonas Lahtinen joonas.lahti...@linux.intel.com wrote: Console Control Protocol is a nonstandard UEFI interface and lack of it shall not be treated as an error. Ah, great! I was struggling to make the splash work

Re: [systemd-devel] [PATCH] udev: ifname matches given mac

2014-01-15 Thread Umut Tezduyar Lindskog
Hi Tom, -Original Message- From: Tom Gundersen [mailto:t...@jklm.no] Sent: den 15 januari 2014 14:23 To: Umut Tezduyar Lindskog Cc: systemd Mailing List; Umut Tezduyar Lindskog Subject: Re: [systemd-devel] [PATCH] udev: ifname matches given mac Hi Umut, I'm not really

Re: [systemd-devel] [PATCH] udev: ifname matches given mac

2014-01-15 Thread Tom Gundersen
On Wed, Jan 15, 2014 at 3:57 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Hi Tom, -Original Message- From: Tom Gundersen [mailto:t...@jklm.no] Sent: den 15 januari 2014 14:23 To: Umut Tezduyar Lindskog Cc: systemd Mailing List; Umut Tezduyar Lindskog Subject: Re:

Re: [systemd-devel] [PATCH 1/1] graphics: Do not require nonstandard console control protocol

2014-01-15 Thread Tom Gundersen
On Wed, Jan 15, 2014 at 3:55 PM, Joonas Lahtinen joonas.lahti...@linux.intel.com wrote: On 15.01.2014 13:34, Tom Gundersen wrote: On Wed, Jan 15, 2014 at 12:08 PM, Joonas Lahtinen joonas.lahti...@linux.intel.com wrote: Console Control Protocol is a nonstandard UEFI interface and lack of it

[systemd-devel] understanding list-unit-files ...

2014-01-15 Thread Holger Schurig
There is one strange thing here: root@desktop:/etc# systemctl list-unit-files | grep multi multi-user.targetdisabled root@desktop:/etc# systemctl status multi-user.target multi-user.target - Multi-User System Loaded: loaded (/lib/systemd/system/multi-user.target; disabled)

Re: [systemd-devel] understanding list-unit-files ...

2014-01-15 Thread Andrey Borzenkov
В Wed, 15 Jan 2014 16:20:44 +0100 Holger Schurig holgerschu...@gmail.com пишет: There is one strange thing here: root@desktop:/etc# systemctl list-unit-files | grep multi multi-user.targetdisabled root@desktop:/etc# systemctl status multi-user.target multi-user.target -

Re: [systemd-devel] systemd hangs after Welcome message when LogLevel=debug

2014-01-15 Thread Holger Schurig
Educated guess (!) With LogLevel=debug, you generate huge amounts of output. With DefaultStandardOutput=syslog, you're asking systemd to send it's output to syslog. But while systemd is starting your system the syslog might not be ready. Probably systemd has some buffer, where it buffers the

Re: [systemd-devel] systemctl reboot/shutdown freezes client

2014-01-15 Thread Reindl Harald
Am 15.01.2014 16:47, schrieb Reindl Harald: Am 15.01.2014 16:37, schrieb Holger Schurig: Try systemctl --force reboot. The --force will kill the processes, which (for me) closes the incoming ssh session that indeed works interesting question: what has changed in the latest

Re: [systemd-devel] understanding list-unit-files ...

2014-01-15 Thread Holger Schurig
I did not want to disable multi-user.target at all. It's perfectly running, just as intended. I just want to ask why list-unit-files reports erraneous junk. man systemctl is very brief on it's output: list-unit-files List installed unit files. Maybe it would be better to

Re: [systemd-devel] systemctl reboot/shutdown freezes client

2014-01-15 Thread Holger Schurig
Try systemctl --force reboot. The --force will kill the processes, which (for me) closes the incoming ssh session. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 1/2] sd-resolve: get rid of _t post-fixes for sd_ objects

2014-01-15 Thread Daniel Buch
We dont want _t prefixes, right? --- src/libsystemd/resolve-util.h | 2 +- src/libsystemd/sd-resolve.c | 72 +-- src/libsystemd/test-resolve.c | 4 +-- src/systemd/sd-resolve.h | 42 - 4 files changed, 60 insertions(+), 60

[systemd-devel] [PATCH 2/2][RFC] sd-resolve: rename structs to fit coding-style e.g 'struct MixedCase'

2014-01-15 Thread Daniel Buch
lets get this right once, and if not for all, atleast for now :) So comments and input about nameing is very welcome. Cheers --- src/libsystemd/sd-resolve.c | 210 ++-- 1 file changed, 105 insertions(+), 105 deletions(-) diff --git

[systemd-devel] why does nofail imply no After= in /etc/fstab

2014-01-15 Thread Zbigniew Jędrzejewski-Szmek
I was a bit surprised that for mount points the dependency Before=local-fs.target is only added when nofail is not used. This seems to be a concious decision (added by Lennart in 155da457, and then survived all the refactorings by Tom and Thomas...). Do we still want this behaviour? Zbyszek

Re: [systemd-devel] [PATCH 1/1] graphics: Do not require nonstandard console control protocol

2014-01-15 Thread Kay Sievers
On Wed, Jan 15, 2014 at 4:01 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Jan 15, 2014 at 3:55 PM, Joonas Lahtinen joonas.lahti...@linux.intel.com wrote: On 15.01.2014 13:34, Tom Gundersen wrote: On Wed, Jan 15, 2014 at 12:08 PM, Joonas Lahtinen joonas.lahti...@linux.intel.com wrote:

Re: [systemd-devel] why does nofail imply no After= in /etc/fstab

2014-01-15 Thread Dominique Michel
Le Wed, 15 Jan 2014 20:20:18 +0100, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl a écrit : I was a bit surprised that for mount points the dependency Before=local-fs.target is only added when nofail is not used. This seems to be a concious decision (added by Lennart in 155da457, and then

Re: [systemd-devel] why does nofail imply no After= in /etc/fstab

2014-01-15 Thread Tom Gundersen
On Thu, Jan 16, 2014 at 2:01 AM, Dominique Michel dominique.mic...@vtxnet.ch wrote: Le Wed, 15 Jan 2014 20:20:18 +0100, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl a écrit : I was a bit surprised that for mount points the dependency Before=local-fs.target is only added when nofail is not

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we found required kmod files, then we build it with kmod enabled, otherwise, just build without kmod and do not complain to user. However,

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Yang Chengwei
On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we found required kmod files, then we build it with kmod enabled,

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 16, 2014 at 10:05:23AM +0800, Yang Chengwei wrote: On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Yang Chengwei
On Thu, Jan 16, 2014 at 10:05:23AM +0800, Yang Chengwei wrote: On Thu, Jan 16, 2014 at 02:56:27AM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jan 15, 2014 at 01:28:26PM +0800, Chengwei Yang wrote: The situation is: by default, we get a auto value for kmod compiling option, so if we

Re: [systemd-devel] [Patch 0/2] logind: make sure that closed sessions will be cleaned

2014-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 12, 2014 at 02:07:32AM +0100, Djalal Harouni wrote: On Sat, Jan 11, 2014 at 10:26:13PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Jan 03, 2014 at 02:19:19PM +0100, Djalal Harouni wrote: On logout pam_systemd should ensures the following: If the last concurrent session

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Holger Schurig
Chengwai, given that kmod may not available in some distro version I'm on Debian and use my self-compiled systemd v208 with a self-made kmod_15.deb file. Packaging kmod is dead easy, it's a very straightforward package. Using the newest kmod doesn't hurt Debian Stable nor Debian SID. So the

Re: [systemd-devel] [PATCH] Fix: can not pass configure by default kmod build option

2014-01-15 Thread Kay Sievers
On Thu, Jan 16, 2014 at 8:27 AM, Holger Schurig holgerschu...@gmail.com wrote: If they think that it's not worth the hassle, then they could simply apply --disable-kmod. Both systemd and udev source code have the proper #ifdef HAVE_KMOD guarding. Keep in mind that machines with modular

[systemd-devel] consider renaming -.slice

2014-01-15 Thread Holger Schurig
Please consider renamign -.slice, because this sucks: # cd /lib/systemd/system # grep -r user@ * grep: invalid option -- '.' Usage: grep [OPTION]... PATTERN [FILE]... Try 'grep --help' for more information. Yes, I know that I can use grep -r -- user@ *, but this is just inconvenient.

Re: [systemd-devel] consider renaming -.slice

2014-01-15 Thread Kay Sievers
On Thu, Jan 16, 2014 at 8:33 AM, Holger Schurig holgerschu...@gmail.com wrote: Please consider renamign -.slice, because this sucks: It's the same issue as: $ systemctl status -- -.mount It's too late to change the / escaping rules, it's too widely used already. Kay