[systemd-devel] FW: [PATCH] names: clear e->activator when activator has disconnected

2014-02-24 Thread Radoslaw Pajak
If e->activator wasn't released when activator connection has disconnected, there was no possibility to open new activator connection for that name in the case when there was another owner of that name. Signed-off-by: Radoslaw Pajak --- connection.h |1 + names.c |7 ++- 2 files

Re: [systemd-devel] FW: [PATCH] names: clear e->activator when activator has disconnected

2014-02-24 Thread Daniel Mack
On 02/24/2014 09:39 AM, Radoslaw Pajak wrote: > If e->activator wasn't released when activator connection has disconnected, > there was no possibility to open new activator connection for that name > in the case when there was another owner of that name. Interesting. Like in the last patch you sen

[systemd-devel] missing install section in the serial-getty template

2014-02-24 Thread Tim Hardeck
Hi, I am working on a configuration module to set up HVC and IUCVtty instances on a s390 machine. We have a template file for IUCVtty which works fine by running for example `systemctl enable iucvtty@lxterm1.service`. In case of hvc there are eight devices but only for hvc0 a terminal is spawn a

Re: [systemd-devel] FW: [PATCH] names: clear e->activator when activator has disconnected

2014-02-24 Thread Radoslaw Pajak
> On 02/24/2014 10:17 AM, Daniel Mack wrote: > > If e->activator wasn't released when activator connection has > disconnected, > > there was no possibility to open new activator connection for that > name > > in the case when there was another owner of that name. > > Interesting. Like in the last

Re: [systemd-devel] FW: [PATCH] names: clear e->activator when activator has disconnected

2014-02-24 Thread Daniel Mack
On 02/24/2014 12:30 PM, Radoslaw Pajak wrote: > Your patch works if the activator connection is still the owner of > the name, but it doesn't work if activator has lost the ownership. If > regular connection takes over the name than kdbus_name_replace_owner > calls kdbus_name_entry_remove_owner whi

Re: [systemd-devel] [PATCH] make Virtualization an anonymous enum

2014-02-24 Thread Lennart Poettering
On Sun, 23.02.14 22:05, Thomas H.P. Andersen (pho...@gmail.com) wrote: > From: Thomas Hindoe Paaboel Andersen Applied! Thanks! > > --- > src/detect-virt/detect-virt.c | 2 +- > src/hostname/hostnamed.c | 2 +- > src/shared/condition-util.c | 3 +-- > src/shared/virt.c | 2 +-

Re: [systemd-devel] [PATCH] analyze/run: Use bus_open_transport_systemd instead of bus_open_transport.

2014-02-24 Thread Thomas Bächler
Am 21.02.2014 11:55, schrieb Thomas Bächler: > Both systemd-analyze and systemd-run only access org.freedesktop.systemd1 > on the bus. This patch allows using systemd-run --user and systemd-analyze > --user even if the user session's bus is not properly integrated with the > systemd user unit. Pin

Re: [systemd-devel] FW: [PATCH] names: clear e->activator when activator has disconnected

2014-02-24 Thread Radoslaw Pajak
> On 02/24/2014 12:47 PM, Daniel Mack wrote: > Yes, but there's one more pointer that can dangle :) > > As we're not on a fast path here, I think we can really walk the hash > of > all names in the registry of the bus, and clean up the ->activator > pointer. Which should also fix the bug you menti

Re: [systemd-devel] missing install section in the serial-getty template

2014-02-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 24, 2014 at 11:31:28AM +0100, Tim Hardeck wrote: > So I have to set up the instances manually too but the problem is that > the serial-getty template doesn't have an install section. > So unlike described in > http://www.freedesktop.org/wiki/Software/systemd/FrequentlyAskedQuestions/ >

Re: [systemd-devel] FW: [PATCH] names: clear e->activator when activator has disconnected

2014-02-24 Thread Daniel Mack
On 02/24/2014 01:51 PM, Radoslaw Pajak wrote: >> On 02/24/2014 12:47 PM, Daniel Mack wrote: >> Yes, but there's one more pointer that can dangle :) >> >> As we're not on a fast path here, I think we can really walk the hash >> of >> all names in the registry of the bus, and clean up the ->activator

Re: [systemd-devel] [PATCH 2/2] build-sys: Also move libsystemd-journal to rootlibdir

2014-02-24 Thread Alexey Shabalin
2014-02-22 20:57 GMT+04:00 Kay Sievers : > On Sat, Feb 22, 2014 at 5:48 PM, Armin K. wrote: > > On 02/22/2014 05:44 PM, Kay Sievers wrote: > >> On Sat, Feb 22, 2014 at 3:22 PM, Armin K wrote: > >>> --- > >>> Makefile.am | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/Make

Re: [systemd-devel] missing install section in the serial-getty template

2014-02-24 Thread Tim Hardeck
On 02/24/2014 02:00 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Feb 24, 2014 at 11:31:28AM +0100, Tim Hardeck wrote: >> So I have to set up the instances manually too but the problem is that >> the serial-getty template doesn't have an install section. >> So unlike described in >> http://www.f

Re: [systemd-devel] [PATCH 2/2] build-sys: Also move libsystemd-journal to rootlibdir

2014-02-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 24, 2014 at 05:31:46PM +0400, Alexey Shabalin wrote: > Excuse me, but what reason this libs in $rootlibdir ? > All systemd components static linked now with internal libs(for v209). > systemd can boot without $libdir (/usr/lib) mounted. All other software, > why used libsystemd(or compa

Re: [systemd-devel] FW: [PATCH] names: clear e->activator when activator has disconnected

2014-02-24 Thread Daniel Mack
On 02/24/2014 02:17 PM, Daniel Mack wrote: > On 02/24/2014 01:51 PM, Radoslaw Pajak wrote: >>> On 02/24/2014 12:47 PM, Daniel Mack wrote: >>> Yes, but there's one more pointer that can dangle :) >>> >>> As we're not on a fast path here, I think we can really walk the hash >>> of >>> all names in th

[systemd-devel] [PATCH 1/5] backlight: don't hardcode path in binary

2014-02-24 Thread Michal Sekletar
Not that we are going to move things around but it is nicer to have paths configurable rather than hardcoded in the source. --- Makefile.am | 2 ++ src/backlight/backlight.c | 6 +++--- units/systemd-backli...@.service.in | 2 +- 3 files changed, 6 insertions(+),

[systemd-devel] [PATCH 4/5] everywhere: stop using strerror()

2014-02-24 Thread Michal Sekletar
--- src/hostname/hostnamed.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c index 064d9d2..d8938a4 100644 --- a/src/hostname/hostnamed.c +++ b/src/hostname/hostnamed.c @@ -409,8 +409,8 @@ static i

[systemd-devel] [PATCH 2/5] hostnamed: watch for transient hostname changes

2014-02-24 Thread Michal Sekletar
hostnamed parses its state information at the startup time and doesn't update it. This might lead to the situation when we are presenting administrator with inaccurate information. We should watch for changes in the system and update our state information accordingly. --- src/hostname/hostnamed.c

[systemd-devel] [PATCH 5/5] hostnamed: don't check against our cached data when setting new static hostname

2014-02-24 Thread Michal Sekletar
We don't change static hostname in case it is the same as the one we currently know about. This is not ideal, because it might have been changed in the meantime and we just don't know about the change. So allow user the set whatever he desires and don't check, before doing so, against our cached i

[systemd-devel] [PATCH 3/5] hostnamed: correct error message

2014-02-24 Thread Michal Sekletar
We are not parsing timezone data. --- src/hostname/hostnamed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c index 045f24d..064d9d2 100644 --- a/src/hostname/hostnamed.c +++ b/src/hostname/hostnamed.c @@ -719,7 +719,7 @@ int

Re: [systemd-devel] [PATCH 2/2] build-sys: Also move libsystemd-journal to rootlibdir

2014-02-24 Thread Alexey Shabalin
2014-02-24 18:16 GMT+04:00 Zbigniew Jędrzejewski-Szmek : > On Mon, Feb 24, 2014 at 05:31:46PM +0400, Alexey Shabalin wrote: > > Excuse me, but what reason this libs in $rootlibdir ? > > All systemd components static linked now with internal libs(for v209). > > systemd can boot without $libdir (/us

Re: [systemd-devel] [PATCH 4/5] everywhere: stop using strerror()

2014-02-24 Thread Lennart Poettering
On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: > --- > src/hostname/hostnamed.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c > index 064d9d2..d8938a4 100644 > --- a/

Re: [systemd-devel] [PATCH 2/5] hostnamed: watch for transient hostname changes

2014-02-24 Thread Lennart Poettering
On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: > hostnamed parses its state information at the startup time and doesn't update > it. This might lead to the situation when we are presenting administrator with > inaccurate information. We should watch for changes in the system

Re: [systemd-devel] [PATCH 5/5] hostnamed: don't check against our cached data when setting new static hostname

2014-02-24 Thread Lennart Poettering
On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: > We don't change static hostname in case it is the same as the one we currently > know about. This is not ideal, because it might have been changed in the > meantime > and we just don't know about the change. So allow user the

Re: [systemd-devel] [PATCH 1/5] backlight: don't hardcode path in binary

2014-02-24 Thread Lennart Poettering
On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: > Not that we are going to move things around but it is nicer to have paths > configurable rather than hardcoded in the source. > --- > Makefile.am | 2 ++ > src/backlight/backlight.c | 6 +++---

Re: [systemd-devel] [PATCH 3/5] hostnamed: correct error message

2014-02-24 Thread Lennart Poettering
On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: > We are not parsing timezone data. Thanks! Applied! > --- > src/hostname/hostnamed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c > index 045f2

Re: [systemd-devel] [PATCH 4/5] everywhere: stop using strerror()

2014-02-24 Thread Michal Sekletar
On Mon, Feb 24, 2014 at 04:05:36PM +0100, Lennart Poettering wrote: > On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: > > > --- > > src/hostname/hostnamed.c | 26 +- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/src/hostna

[systemd-devel] [PATCH] udev: properly detect reference to unexisting part of PROGRAM's result

2014-02-24 Thread Lukas Nykryn
--- src/udev/udev-event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c index 0b3ade0..5998be2 100644 --- a/src/udev/udev-event.c +++ b/src/udev/udev-event.c @@ -254,6 +254,8 @@ subst: cpos++;

Re: [systemd-devel] [PATCH] analyze/run: Use bus_open_transport_systemd instead of bus_open_transport.

2014-02-24 Thread Lennart Poettering
On Fri, 21.02.14 11:55, Thomas Bächler (tho...@archlinux.org) wrote: > Both systemd-analyze and systemd-run only access org.freedesktop.systemd1 > on the bus. This patch allows using systemd-run --user and systemd-analyze > --user even if the user session's bus is not properly integrated with the

[systemd-devel] [PATCH] udev: properly detect reference to unexisting part of PROGRAM's result

2014-02-24 Thread Lukas Nykryn
--- src/udev/udev-event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c index 0b3ade0..de31fee 100644 --- a/src/udev/udev-event.c +++ b/src/udev/udev-event.c @@ -254,6 +254,8 @@ subst: cpos++;

[systemd-devel] [PATCH] backlight: don't hardcode path in binary

2014-02-24 Thread Michal Sekletar
Not that we are going to move things around but it is nicer to have paths configurable rather than hardcoded in the source. --- Added trailing slash. Thanks! Makefile.am | 2 ++ src/backlight/backlight.c | 6 +++--- units/systemd-backli...@.service.in | 2 +- 3

Re: [systemd-devel] [PATCH 2/5] hostnamed: watch for transient hostname changes

2014-02-24 Thread Michal Sekletar
On Mon, Feb 24, 2014 at 04:32:46PM +0100, Lennart Poettering wrote: > On Mon, 24.02.14 15:59, Michal Sekletar (msekl...@redhat.com) wrote: > > > hostnamed parses its state information at the startup time and doesn't > > update > > it. This might lead to the situation when we are presenting admini

Re: [systemd-devel] [PATCH 2/2] build-sys: Also move libsystemd-journal to rootlibdir

2014-02-24 Thread Kay Sievers
On Mon, Feb 24, 2014 at 4:04 PM, Alexey Shabalin wrote: > Needed only libudev-install-hook, not more. It does not matter for proper filesystem layouts where everything is in one location, in /usr. The split of / vs. /usr never made much sense, it's a very incomplete and broken model. For legacy

Re: [systemd-devel] [PATCH v2 1/2] Smack - relabel directories and files created by systemd

2014-02-24 Thread Lennart Poettering
On Thu, 20.02.14 12:01, Łukasz Stelmach (l.stelm...@samsung.com) wrote: Heya! I applied the three patches now, and made some clean-ups which I folded into your last patch. AMong the changes I made is that I dropped is the hook-up with label_context_set() since that is only for controlling what la

Re: [systemd-devel] [PATCH] analyze/run: Use bus_open_transport_systemd instead of bus_open_transport.

2014-02-24 Thread Thomas Bächler
Am 24.02.2014 17:10, schrieb Lennart Poettering: > On Fri, 21.02.14 11:55, Thomas Bächler (tho...@archlinux.org) wrote: > >> Both systemd-analyze and systemd-run only access org.freedesktop.systemd1 >> on the bus. This patch allows using systemd-run --user and >> systemd-analyzeefau >> --user eve

[systemd-devel] Setting cgroup properties on systemd --user

2014-02-24 Thread Thomas Bächler
I am trying to set properties on scopes or services of my user instance, for example: systemctl --user set-property --runtime foobar.scope CPUShares=150 This command returns without error, but in the journal, I get messages like this: systemd[5054]: Failed to set cpu.shares on /user.slice/user-

[systemd-devel] [ANNOUNCE] systemd 210

2014-02-24 Thread Lennart Poettering
Heya, And here's the next release 210: http://www.freedesktop.org/software/systemd/systemd-210.tar.xz Many bugfixes, but also a couple of new features (see below). One of the more relevant changes is that the compatibility library support no longer makes use of IFUNC. This allows them to build

Re: [systemd-devel] [ANNOUNCE] systemd 210

2014-02-24 Thread David Timothy Strauss
On Mon, Feb 24, 2014 at 2:08 PM, Lennart Poettering wrote: > logind is now a lot more aggressive when suspending the > machine due to a closed laptop lid. Instead of acting only > on the lid close action it will continuously watch the lid > status and act on it. This

Re: [systemd-devel] [ANNOUNCE] systemd 210

2014-02-24 Thread Mathieu Bridon
On Mon, 2014-02-24 at 23:08 +0100, Lennart Poettering wrote: > * A new unit file option AppArmoreProfile= has been added to > set the AppArmor profile for the processes of a unit. I think that should be « AppArmorProfile= », not « AppArmoreProfile= ». At least that's what system

Re: [systemd-devel] [ANNOUNCE] systemd 210

2014-02-24 Thread Lennart Poettering
On Mon, 24.02.14 16:30, David Timothy Strauss (da...@davidstrauss.net) wrote: > > On Mon, Feb 24, 2014 at 2:08 PM, Lennart Poettering > wrote: > > logind is now a lot more aggressive when suspending the > > machine due to a closed laptop lid. Instead of acting only > > on the

Re: [systemd-devel] [ANNOUNCE] systemd 210

2014-02-24 Thread Lennart Poettering
On Tue, 25.02.14 09:04, Mathieu Bridon (boche...@fedoraproject.org) wrote: > > On Mon, 2014-02-24 at 23:08 +0100, Lennart Poettering wrote: > > * A new unit file option AppArmoreProfile= has been added to > > set the AppArmor profile for the processes of a unit. > > I think tha

[systemd-devel] KDBus Signals and Timeouts

2014-02-24 Thread Justin Brown
My apologies if this isn't the correct list, but it seems like the systemd developers are working closely on KDBus. I've been reading over some of the articles about KDBus and have a question about reclaiming memfds. Let's say that I have a process which is sending out a large amount of data over

Re: [systemd-devel] KDBus Signals and Timeouts

2014-02-24 Thread Kay Sievers
On Tue, Feb 25, 2014 at 4:26 AM, Justin Brown wrote: > I've been reading over some of the articles about KDBus and have a > question about reclaiming memfds. Let's say that I have a process > which is sending out a large amount of data over lots of signals, and > there are more than one potential

Re: [systemd-devel] [ANNOUNCE] systemd 210

2014-02-24 Thread Cecil Westerhof
On 02/25/2014 01:30 AM, David Timothy Strauss wrote: On Mon, Feb 24, 2014 at 2:08 PM, Lennart Poettering wrote: logind is now a lot more aggressive when suspending the machine due to a closed laptop lid. Instead of acting only on the lid close action it will continuously w