Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-27 Thread Michal Sekletar
On Sat, Jul 26, 2014 at 09:11:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > Hm, what was wrong with the facility before? I think that we should always add SYSLOG_FACILITY field. Now, if (priority & LOG_FACMASK) == LOG_KERN we don't do that. We set SYSLOG_IDENTIFIER to "kernel" tough. But missin

[systemd-devel] [PATCH] parse_boolean: require exact matches

2014-07-27 Thread Ansgar Burchardt
Require exact matches in all cases instead of treating strings starting with 't' ('f') as true (false). This is required for config_parse_protect_system to parse ProtectSystem=full correctly: it uses parse_boolean and only tries a more specific parsing function if that did not return a valid resul

[systemd-devel] [PATCH] drop_duplicates: copy full BindMount struct

2014-07-27 Thread Ansgar Burchardt
At least t->ignore = f->ignore; is missing here. Just copy the full struct to be sure. --- src/core/namespace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/namespace.c b/src/core/namespace.c index 5466b7b..fe95377 100644 --- a/src/core/namespace.c +++ b/src/c

Re: [systemd-devel] race conditions after SIGTERM

2014-07-27 Thread Reindl Harald
after that happend a few minutes ago systemd on F19: https://bugzilla.redhat.com/show_bug.cgi?id=1123557 since the "sleep 1" was enough over months and now "sleep 6" between "systemctl stop" and rsync is also not relieable my only conclusion is that systemd don't care about the still running MAINP

Re: [systemd-devel] [systemd-commits] factory/etc

2014-07-27 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 27, 2014 at 05:54:15AM -0700, Kay Sievers wrote: > factory/etc/nsswitch.conf |6 ++ > 1 file changed, 6 insertions(+) > > New commits: > commit ccc6fa0d6b8e3ce5e7508ee8a141ee26f380b4a3 > Author: Kay Sievers > Date: Sun Jul 27 14:53:21 2014 +0200 > > factory: nss - add

Re: [systemd-devel] race conditions after SIGTERM

2014-07-27 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jul 26, 2014 at 02:46:05PM +0200, Reindl Harald wrote: > after that happend a few minutes ago systemd on F19: > https://bugzilla.redhat.com/show_bug.cgi?id=1123557 > > since the "sleep 1" was enough over months and now "sleep 6" > between "systemctl stop" and rsync is also not relieable my

Re: [systemd-devel] [PATCH] journald: fix syslog facility for messages coming from kmsg

2014-07-27 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 27, 2014 at 01:11:07PM +0200, Michal Sekletar wrote: > On Sat, Jul 26, 2014 at 09:11:47PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > > Hm, what was wrong with the facility before? > > I think that we should always add SYSLOG_FACILITY field. Now, if (priority & > LOG_FACMASK) == LOG_KE

Re: [systemd-devel] race conditions after SIGTERM

2014-07-27 Thread Reindl Harald
Am 27.07.2014 19:53, schrieb Zbigniew Jędrzejewski-Szmek: > On Sat, Jul 26, 2014 at 02:46:05PM +0200, Reindl Harald wrote: >> after that happend a few minutes ago systemd on F19: >> https://bugzilla.redhat.com/show_bug.cgi?id=1123557 >> >> since the "sleep 1" was enough over months and now "sleep

[systemd-devel] [PATCH v2] shell-completion: prevent mangling unit names (bash)

2014-07-27 Thread Eric Cook
This fixes the issue noted by Zbigniew in most cases. if a unit's name is enclosed in single quotes completion still will not happen after the first `\'. --- shell-completion/bash/systemctl.in | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/shell-completion/bash/s

Re: [systemd-devel] [PATCH v2] shell-completion: prevent mangling unit names (bash)

2014-07-27 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 27, 2014 at 03:07:03PM -0400, Eric Cook wrote: > This fixes the issue noted by Zbigniew in most cases. > if a unit's name is enclosed in single quotes completion still > will not happen after the first `\'. > --- > shell-completion/bash/systemctl.in | 13 - > 1 file changed

Re: [systemd-devel] [PATCH] parse_boolean: require exact matches

2014-07-27 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 27, 2014 at 03:19:00PM +0200, Ansgar Burchardt wrote: > Require exact matches in all cases instead of treating strings > starting with 't' ('f') as true (false). > > This is required for config_parse_protect_system to parse ProtectSystem=full > correctly: it uses parse_boolean and only

Re: [systemd-devel] [PATCH] drop_duplicates: copy full BindMount struct

2014-07-27 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jul 27, 2014 at 04:32:13PM +0200, Ansgar Burchardt wrote: > At least > > t->ignore = f->ignore; > > is missing here. Just copy the full struct to be sure. > --- > src/core/namespace.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/core/namespace.c b/src

[systemd-devel] eye of cylon / timeout timer is cut off

2014-07-27 Thread Michael Biebl
Hi, as you can see at the attached diff, there is a small issue with the timer that is disabled, when systemd is waiting for a job. In this case, the job is already running 1min 17secs, but only 17 secs is displayed, the other part is cut off. This is with v214. Michael -- Why is it that a

[systemd-devel] [PATCH] man: fix outdated example in systemd.network

2014-07-27 Thread Hong Shick Pak
The docs for the DHCP= was updated, but not the example. --- man/systemd.network.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.network.xml b/man/systemd.network.xml index dc34154..b0a9792 100644 --- a/man/systemd.network.xml +++ b/man/systemd.network.xml @@ -

[systemd-devel] [PATCH 2/2] socket: Introduce SCTP support

2014-07-27 Thread Susant Sahani
This patch adds SCTP protcol support for socket activation. SCTP socket can be configured via the conf parameter 'ListenStreamControlTrans' which is kind of too long. --- man/systemd.socket.xml| 3 ++- src/core/load-fragment-gperf.gperf.m4 | 1 + src/core/load-fragment.c

[systemd-devel] [PATCH 1/2] socket: add support for tcp nagle

2014-07-27 Thread Susant Sahani
This patch adds support for TCP TCP_NODELAY socket option. This can be configured via NoDelay conf parameter.TCP Nagle's algorithm works by combining a number of small outgoing messages, and sending them all at once. This controls the TCP_NODELAY socket option --- man/systemd.socket.xml