Re: [systemd-devel] compile with clang broken

2014-08-16 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi dani...@grinta.net wrote: On 15/08/2014 16:30, David Herrmann wrote: Ok, took me a while, but I now figured out how to cause compilation to fail even in expressions that initialize types (_Static_assert is not allowed there): #define

Re: [systemd-devel] compile with clang broken

2014-08-16 Thread Daniele Nicolodi
On 16/08/2014 12:35, David Herrmann wrote: On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi dani...@grinta.net wrote: this may be completely stupid, but if the only use case you have for CONST_MAX() is for computing the size of a data structure, I find something like #define MAXSIZE(A, B)

[systemd-devel] [PATCH 8/8] tests: add missing entry to test-tables

2014-08-16 Thread Ronny Chevalier
--- src/test/test-tables.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test-tables.c b/src/test/test-tables.c index cb9185e..88e7d10 100644 --- a/src/test/test-tables.c +++ b/src/test/test-tables.c @@ -86,6 +86,7 @@ int main(int argc, char **argv) {

[systemd-devel] [PATCH 4/8] tests: add test for fdset_iterate

2014-08-16 Thread Ronny Chevalier
--- src/test/test-fdset.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/test/test-fdset.c b/src/test/test-fdset.c index 3b77415..91df7eb 100644 --- a/src/test/test-fdset.c +++ b/src/test/test-fdset.c @@ -126,12 +126,41 @@ static void

[systemd-devel] [PATCH 3/8] tests: add tests for fileio.c

2014-08-16 Thread Ronny Chevalier
add tests for: - write_string_stream - write_string_file - sendfile_full --- src/test/test-fileio.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/src/test/test-fileio.c b/src/test/test-fileio.c index 1de59fa..e69706c 100644 ---

[systemd-devel] [PATCH 7/8] tests: add tests for time-util.c

2014-08-16 Thread Ronny Chevalier
add tests for: - timezone_is_valid - get_timezones --- src/test/test-time.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/test/test-time.c b/src/test/test-time.c index 7c29f96..87e7ae7 100644 --- a/src/test/test-time.c +++ b/src/test/test-time.c @@ -20,6 +20,7

[systemd-devel] [PATCH 5/8] tests: add tests for util.c

2014-08-16 Thread Ronny Chevalier
add tests for: - is_symlink - pid_is_unwaited - pid_is_alive - search_and_fopen - search_and_fopen_nulstr - glob_exists - execute_directory --- src/test/test-util.c | 165 +++ 1 file changed, 165 insertions(+) diff --git a/src/test/test-util.c

[systemd-devel] [PATCH 6/8] tests: add test-condition-util

2014-08-16 Thread Ronny Chevalier
--- .gitignore | 1 + Makefile.am| 11 - src/test/test-condition-util.c | 107 + 3 files changed, 118 insertions(+), 1 deletion(-) create mode 100644 src/test/test-condition-util.c diff --git a/.gitignore

[systemd-devel] [PATCH 2/8] tests: add missing unlink

2014-08-16 Thread Ronny Chevalier
--- src/test/test-async.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/test-async.c b/src/test/test-async.c index c1c535b..401e685 100644 --- a/src/test/test-async.c +++ b/src/test/test-async.c @@ -46,5 +46,7 @@ int main(int argc, char *argv[]) { assert_se(fcntl(fd,

[systemd-devel] [PATCH 1/8] tests: add tests for socket-util.c

2014-08-16 Thread Ronny Chevalier
add tests for: - socket_address_is - socket_address_is_netlink - sockaddr_equal --- src/test/test-socket-util.c | 50 + 1 file changed, 50 insertions(+) diff --git a/src/test/test-socket-util.c b/src/test/test-socket-util.c index 4e90590..17180db

[systemd-devel] [PATCH] bootchart: use NSEC_PER_SEC

2014-08-16 Thread Ronny Chevalier
--- src/bootchart/store.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index cedcba8..d838a53 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -34,6 +34,7 @@ #include time.h #include util.h +#include

[systemd-devel] [PATCH] man: fix typo

2014-08-16 Thread Ronny Chevalier
--- man/systemd-firstboot.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-firstboot.xml b/man/systemd-firstboot.xml index 42fd753..c3fe0ed 100644 --- a/man/systemd-firstboot.xml +++ b/man/systemd-firstboot.xml @@ -249,7 +249,7 @@

[systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

2014-08-16 Thread Ronny Chevalier
To follow the same behavior that src/core/condition.c do --- src/shared/condition-util.c| 2 +- src/test/test-condition-util.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/shared/condition-util.c b/src/shared/condition-util.c index ff4a8ec..f21786f 100644 ---

[systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-16 Thread Ronny Chevalier
--- src/shared/util.c | 4 1 file changed, 4 insertions(+) diff --git a/src/shared/util.c b/src/shared/util.c index 18d40f3..3a03470 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -3921,6 +3921,10 @@ void execute_directory(const char *directory, DIR *d, usec_t timeout, char

[systemd-devel] suspend-utils and systemd

2014-08-16 Thread Rodolfo García Peñas (kix)
Hi, I am new on the list. Thanks for your work with systemd. I am trying to run systemd and suspend-utils (uswsusp in Debian) and I don't know how to do it. I was checking how to include support for suspend with normal packages (server daemons,...) but I am not sure how to implement it

[systemd-devel] Networkd fails to activate the device on boot

2014-08-16 Thread Thomas Bächler
Hello Tom, I am using systemd 215-4 from Arch Linux. I have the following configuration files in /etc/systemd/network: # 01-lan.network [Match] Name=enp3s0 [Network] Address=10.23.42.4/26 Gateway=10.23.42.3 # 01-qemu.netdev [NetDev] MACAddress=1a:de:ad:be:ef:01 Name=qemu Kind=tap #

[systemd-devel] [PATCH] bus-control: Fix cgroup handling

2014-08-16 Thread Denis Kenzior
On systems without properly setup systemd, cg_get_root_path returns -ENOENT. This means that busctl doesn't display much information. busctl monitor also fails whenever it intercepts messages. This fix fakes creates a fake / root cgroup which lets busctl work on such systems. ---

Re: [systemd-devel] Misleading udev error messages regarding virtual interfaces

2014-08-16 Thread Leonid Isaev
Hi, On Fri, Aug 15, 2014 at 06:20:07PM +0200, Lennart Poettering wrote: On Sun, 06.07.14 12:43, Leonid Isaev (lis...@umail.iu.edu) wrote: Hi, Sorry for a delayed reply. On Thu, Jul 03, 2014 at 01:46:53PM +0200, Lennart Poettering wrote: it would be good to know what the precise

Re: [systemd-devel] Logind error - Failed to abandon session scope: Connection reset

2014-08-16 Thread Roger Qiu
Hello Lennart, The reason why you don't want explicit ordering is because of a slower boot time? When you are referring to patching them out, would that be from upstream systemd/logind? Thanks, Roger On 15/08/2014 7:41 PM, Lennart Poettering wrote: On Fri, 15.08.14 15:04, Roger Qiu