[systemd-devel] [PATCH] dbus1-generator: Always close file in create_dbus_files

2014-08-22 Thread Simon Danner
In the !service case, the first file doesn't get closed automatically, since the second one uses the same FILE*. Close it explicitly. Found by cppcheck Signed-off-by: Simon Danner danner.si...@gmail.com --- src/dbus1-generator/dbus1-generator.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [systemd-devel] timesyncd: Frequent polling when no server could be reached

2014-08-22 Thread Miroslav Lichvar
On Thu, Aug 21, 2014 at 08:15:36PM +0200, Florian Lindner wrote: Aug 21 09:45:00 asaru systemd-timesyncd[317]: Timed out waiting for reply from 216.239.32.15:123 (time1.google.com). Aug 21 09:45:00 asaru systemd-timesyncd[317]: Using NTP server [2001:4860:4802:32::f]:123 (time1.google.com).

Re: [systemd-devel] [PATCH] dbus1-generator: Always close file in create_dbus_files

2014-08-22 Thread Lennart Poettering
On Fri, 22.08.14 08:19, Simon Danner (danner.si...@gmail.com) wrote: In the !service case, the first file doesn't get closed automatically, since the second one uses the same FILE*. Close it explicitly. Found by cppcheck Signed-off-by: Simon Danner danner.si...@gmail.com ---

Re: [systemd-devel] [systemd-commits] man/journalctl.xml src/journal

2014-08-22 Thread Lennart Poettering
On Fri, 22.08.14 01:57, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Thu, Aug 21, 2014 at 05:16:37AM -0700, Harald Hoyer wrote: @@ -276,6 +278,7 @@ static int parse_argv(int argc, char *argv[]) { { file, required_argument, NULL, ARG_FILE

Re: [systemd-devel] compile with clang broken

2014-08-22 Thread David Herrmann
Hi On Sat, Aug 16, 2014 at 1:29 PM, Daniele Nicolodi dani...@grinta.net wrote: On 16/08/2014 12:35, David Herrmann wrote: On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi dani...@grinta.net wrote: this may be completely stupid, but if the only use case you have for CONST_MAX() is for

[systemd-devel] [PATCH] shared: make container_of() use unique variable names

2014-08-22 Thread David Herrmann
If you stack container_of() macros, you will get warnings due to shadowing variables of the parent context. To avoid this, use unique names for variables. Two new helpers are added: UNIQ: This evaluates to a truly unique value never returned by any evaluation of this macro. It's a

Re: [systemd-devel] kdbus: merge 3.17 branch into master?

2014-08-22 Thread Umut Tezduyar Lindskog
Hi, I am having __NR_memfd_create not defined error on mips on systemd 216. I wanted to see the syscall numbers in 3.17 RC1 to patch missing.h but couldn't find them. What am I missing? On Tue, Aug 19, 2014 at 4:24 PM, Daniel Mack dan...@zonque.org wrote: On 08/19/2014 04:21 PM, Greg KH wrote:

Re: [systemd-devel] kdbus: merge 3.17 branch into master?

2014-08-22 Thread Daniel Mack
Hi, On 08/22/2014 03:26 PM, Umut Tezduyar Lindskog wrote: I am having __NR_memfd_create not defined error on mips on systemd 216. I wanted to see the syscall numbers in 3.17 RC1 to patch missing.h but couldn't find them. What am I missing? We don't know the final syscall number yet, as it's

Re: [systemd-devel] kdbus: merge 3.17 branch into master?

2014-08-22 Thread Umut Tezduyar Lindskog
Hi, On Fri, Aug 22, 2014 at 3:47 PM, Daniel Mack dan...@zonque.org wrote: Hi, On 08/22/2014 03:26 PM, Umut Tezduyar Lindskog wrote: I am having __NR_memfd_create not defined error on mips on systemd 216. I wanted to see the syscall numbers in 3.17 RC1 to patch missing.h but couldn't find

[systemd-devel] systemctl preset and chkconfig

2014-08-22 Thread Colin Guthrie
Hi, I recently changed my %post scripts in Mageia to use systemctl preset rather than systemctl enable to allow for policy-based overrides of enable on install behaviour. Sadly, unlike enable, preset does not shell out to chkconfig, so passing a service name that's not got a native unit no

[systemd-devel] [PATCH] sd-bus: kdbus: monitor connections use the KDBUS_HELLO_MONITOR flag

2014-08-22 Thread Djalal Harouni
--- Currently this bus_kernel_create_monitor() is not used. Patch compile tested. src/libsystemd/sd-bus/bus-kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd/sd-bus/bus-kernel.c b/src/libsystemd/sd-bus/bus-kernel.c index 3ca271c..1440e43 100644 ---