Re: [systemd-devel] Improving module loading

2014-12-23 Thread Hoyer, Marko (ADITG/SW2)
Hi Greg, thx a lot for the feedback and hints. You asked for lots of numbers, I tried to add some I have available here at the moment. Find them inline. I'm additionally interested in some more details of some of the ideas you outlined. Would be nice if you could go some more into details at

Re: [systemd-devel] Improving module loading

2014-12-23 Thread Hoyer, Marko (ADITG/SW2)
-Original Message- From: Lucas De Marchi [mailto:lucas.de.mar...@gmail.com] Sent: Monday, December 22, 2014 7:00 PM To: Lennart Poettering Cc: Hoyer, Marko (ADITG/SW2); systemd-devel@lists.freedesktop.org Subject: Re: [systemd-devel] Improving module loading On Mon, Dec 22, 2014

Re: [systemd-devel] [PATCH] hwdb: add rule and first entry for PS/2 mice

2014-12-23 Thread David Herrmann
(CC'ing sd-devel this time.. sorry) On Tue, Dec 23, 2014 at 1:19 AM, Peter Hutterer peter.hutte...@who-t.net wrote: https://bugs.freedesktop.org/show_bug.cgi?id=87037 --- some feedback on the rule would be appreciated, in case there's a better approach to matching. hwdb/70-mouse.hwdb | 4

Re: [systemd-devel] [PATCH 0/9] capabilities: remove include of sys/capability.h where possible

2014-12-23 Thread David Herrmann
Hi On Mon, Dec 22, 2014 at 8:57 PM, Filipe Brandenburger filbran...@google.com wrote: Ping? Also wondering if it makes sense to go ahead and implement our own cap_to_text and cap_from_text to generate capability strings from the bitmaps (and further remove dependency on libcap.) I think it

Re: [systemd-devel] [PATCH][Resend][RFC] core: Fix wrong timestamps in rtc-in-local time mode.

2014-12-23 Thread David Herrmann
Hi On Thu, Dec 18, 2014 at 3:33 PM, Chunhui He hchun...@mail.ustc.edu.cn wrote: Hi all, When the system is configured to read the RTC time in the local time zone, some timestamps recorded by systemd are wrong. Apparently, you never received Lennart's reply on your original mail. Below, you

Re: [systemd-devel] Improving module loading

2014-12-23 Thread Tom Gundersen
On Tue, Dec 23, 2014 at 12:25 PM, Hoyer, Marko (ADITG/SW2) mho...@de.adit-jv.com wrote: Some numbers to the above mentioned arguments: - in an idle system, systemd-udev-trigger.service takes by about 150-200ms just to get the complete device tree to send out add uevents again (udevd was

Re: [systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event v3

2014-12-23 Thread Lennart Poettering
On Mon, 22.12.14 18:54, Shawn Paul Landden (sh...@churchofgit.com) wrote: There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be correct to the rule. Hmm, this seems incomplete, mount.c and path.c also use the structure? Also, maybe the

Re: [systemd-devel] Improving module loading

2014-12-23 Thread Tom Gundersen
On Tue, Dec 23, 2014 at 1:21 PM, Hoyer, Marko (ADITG/SW2) mho...@de.adit-jv.com wrote: -Original Message- From: Lucas De Marchi [mailto:lucas.de.mar...@gmail.com] Sent: Monday, December 22, 2014 7:00 PM To: Lennart Poettering Cc: Hoyer, Marko (ADITG/SW2);

Re: [systemd-devel] [PATCH 2/2] test: wait for cloned thread to exit

2014-12-23 Thread Lennart Poettering
On Mon, 22.12.14 11:57, Filipe Brandenburger (filbran...@google.com) wrote: Ping? I got none of these emails, and they are neither shown in the mailing list archives. There must be something wrong in the mail delivery between google.com and fdo? On Thu, Dec 18, 2014 at 11:24 AM, Filipe

Re: [systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event v3

2014-12-23 Thread Lennart Poettering
On Mon, 22.12.14 18:54, Shawn Paul Landden (sh...@churchofgit.com) wrote: There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be correct to the rule. BTW, not sure how you are getting these emails, but apparently you do given that you

Re: [systemd-devel] Improving module loading

2014-12-23 Thread Tom Gundersen
On Tue, Dec 23, 2014 at 12:25 PM, Hoyer, Marko (ADITG/SW2) mho...@de.adit-jv.com wrote: Some numbers to the above mentioned arguments: - in an idle system, systemd-udev-trigger.service takes by about 150-200ms just to get the complete device tree to send out add uevents again (udevd was

Re: [systemd-devel] Improving module loading

2014-12-23 Thread Kay Sievers
On Tue, Dec 23, 2014 at 3:22 PM, Tom Gundersen t...@jklm.no wrote: On Tue, Dec 23, 2014 at 12:25 PM, Hoyer, Marko (ADITG/SW2) mho...@de.adit-jv.com wrote: Some numbers to the above mentioned arguments: - in an idle system, systemd-udev-trigger.service takes by about 150-200ms just to get the

[systemd-devel] systemd-gpt-auto-generator does not appear to remount rootfs rw

2014-12-23 Thread Dimitri John Ledkov
I'm using systemd 218 (stock upstream, unpatched) dracut 040 (stock upstream, unpatched). I'm trying to build a basic GPT disk image to boot in a VM with gpt-auto-generator discovery of partitions. I create three partitions: ESP, swap and rootfs with the following type ids set: sgdisk

Re: [systemd-devel] systemd-gpt-auto-generator does not appear to remount rootfs rw

2014-12-23 Thread Dimitri John Ledkov
On 23/12/14 16:56, Dimitri John Ledkov wrote: I'm using systemd 218 (stock upstream, unpatched) dracut 040 (stock upstream, unpatched). I'm trying to build a basic GPT disk image to boot in a VM with gpt-auto-generator discovery of partitions. I create three partitions: ESP, swap and

[systemd-devel] [PATCH 1/2] test: only use assert_se in test_raw_clone

2014-12-23 Thread Filipe Brandenburger
The asserts used in the tests should never be allowed to be optimized away. --- src/test/test-util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/test-util.c b/src/test/test-util.c index 222af9a..57fd19b 100644 --- a/src/test/test-util.c +++

[systemd-devel] [PATCH 2/2] test: wait for cloned thread to exit

2014-12-23 Thread Filipe Brandenburger
In test_raw_clone, make sure the cloned thread calls _exit() and in the parent thread call waitpid(..., __WCLONE) to wait for the child thread to terminate, otherwise there is a race condition where the child thread will log to the console after the test process has already exited and the

Re: [systemd-devel] [PATCH 2/2] test: wait for cloned thread to exit

2014-12-23 Thread Filipe Brandenburger
Hi, On Tue, Dec 23, 2014 at 6:43 AM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 22.12.14 11:57, Filipe Brandenburger (filbran...@google.com) wrote: Ping? I got none of these emails, and they are neither shown in the mailing list archives. There must be something wrong in the

[systemd-devel] [PATCH 0/9] capabilities: remove include of sys/capability.h where possible

2014-12-23 Thread Filipe Brandenburger
This is a first cleanup step towards removing the dependency on libcap. The idea of removing the libcap dependency was brought up by Lennart in: http://lists.freedesktop.org/archives/systemd-devel/2014-December/026155.html It is mainly removing the include of sys/capability.h where the only

[systemd-devel] [PATCH 4/9] capabilities: remove spurious include of sys/capability.h from hostnamed.c

2014-12-23 Thread Filipe Brandenburger
It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant in use by this file comes from linux/capability.h imported through missing.h. Tested that systemd-hostnamed builds cleanly and works after this change. --- src/hostname/hostnamed.c | 1 - 1 file changed, 1

[systemd-devel] [PATCH 3/9] capabilities: remove spurious include of sys/capability.h from tmpfiles.c

2014-12-23 Thread Filipe Brandenburger
It does not use any functions from libcap directly. The CAP_MKNOD constant in use by this file comes from linux/capability.h imported through missing.h. Tested that systemd-tmpfiles builds cleanly and works after this change. --- src/tmpfiles/tmpfiles.c | 1 - 1 file changed, 1 deletion(-) diff

[systemd-devel] [PATCH 7/9] capabilities: remove spurious include of sys/capability.h from pam_systemd.c

2014-12-23 Thread Filipe Brandenburger
It does not use any functions or constants from libcap directly. Tested that pam_systemd.la builds cleanly and works after this change. --- src/login/pam_systemd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c index 111e2b7..d5b29c8 100644

[systemd-devel] [PATCH 6/9] capabilities: remove spurious include of sys/capability.h from timedated.c

2014-12-23 Thread Filipe Brandenburger
It does not use any functions from libcap directly. The CAP_SYS_TIME constant in use by this file comes from linux/capability.h imported through missing.h. Tested that systemd-timedated builds cleanly and works after this change. --- src/timedate/timedated.c | 1 - 1 file changed, 1 deletion(-)

[systemd-devel] [PATCH 1/9] capabilities: remove spurious include of sys/capability.h from nspawn.c

2014-12-23 Thread Filipe Brandenburger
It does not use any functions from libcap directly. The CAP_* constants in use through this file come from missing.h which will import linux/capability.h and complement it with CAP_* constants not defined by the current kernel headers. Add an explicit import of our capability.h since it does use

[systemd-devel] [PATCH 8/9] capabilities: remove spurious include of sys/capability.h from machined sources

2014-12-23 Thread Filipe Brandenburger
They do not use any functions from libcap directly. The CAP_KILL constant in use by these files comes from linux/capability.h imported through missing.h. Tested that systemd-machined builds cleanly and works after this change. --- src/machine/machine-dbus.c | 1 - src/machine/machined-dbus.c |

[systemd-devel] [PATCH 5/9] capabilities: remove spurious include of sys/capability.h from localed.c

2014-12-23 Thread Filipe Brandenburger
It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant in use by this file comes from linux/capability.h imported through missing.h. Tested that systemd-localed builds cleanly and works after this change. --- src/locale/localed.c | 1 - 1 file changed, 1 deletion(-)

[systemd-devel] [PATCH 9/9] capabilities: remove spurious include of sys/capability.h from sd-dbus sources

2014-12-23 Thread Filipe Brandenburger
They do not use any functions from libcap directly. The CAP_SYS_ADMIN constant in use by bus-objects.c comes from linux/capability.h imported through missing.h. The missing.h header is imported through util.h which gets imported in bus-util.h. Tested that everything builds cleanly after this

Re: [systemd-devel] [PATCH 0/9] capabilities: remove include of sys/capability.h where possible

2014-12-23 Thread Filipe Brandenburger
On Tue, Dec 23, 2014 at 5:23 AM, David Herrmann dh.herrm...@gmail.com wrote: I cannot find these patches on systemd-devel@lists.freedesktop.org. This might be due to fdo mail-server issues, or me just being incapable of searching through my emails... Anyway, would you mind resending those?

[systemd-devel] [PATCHv2] update .gitignore to include test-lldp

2014-12-23 Thread Filipe Brandenburger
--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 1b5d60f..078fd9a 100644 --- a/.gitignore +++ b/.gitignore @@ -207,6 +207,7 @@ /test-libudev-sym* /test-list /test-unaligned +/test-lldp /test-locale-util /test-local-addresses /test-log --

[systemd-devel] [PATCHv2 1/2] build-sys: do not use pkgconfig dbus-1.pc to find dbus directories

2014-12-23 Thread Filipe Brandenburger
Do not use the dbus-1.pc pkgconfig settings to determine dbus directories. Use directories relative to ${sysconfdir} and ${datadir} instead. This approach was suggested by Simon McVittie in: http://lists.freedesktop.org/archives/systemd-devel/2014-October/024388.html Tested by building and

[systemd-devel] [PATCHv2 2/2] build-sys: remove references to dbusinterfacedir

2014-12-23 Thread Filipe Brandenburger
This directory is not used by systemd. Tested by running a full build, running `make install` and comparing the file list in the target trees and making sure that `make distcheck` still works. --- configure.ac | 7 --- 1 file changed, 7 deletions(-) diff --git a/configure.ac b/configure.ac

Re: [systemd-devel] [systemd-commits] 8 commits - Makefile.am TODO src/bus-proxyd src/core src/import src/libsystemd src/machine src/shared src/test

2014-12-23 Thread Filipe Brandenburger
Hi, On Tue, Dec 23, 2014 at 10:15 AM, Lennart Poettering lenn...@kemper.freedesktop.org wrote: commit 3c70e3bb022f0de3317f3600c9366a2f4597339e Author: Lennart Poettering lenn...@poettering.net Date: Tue Dec 23 18:36:04 2014 +0100 core: rearrange code so that libsystemd/sd-bus/ does not

[systemd-devel] [PATCH] timesync: remove square(), use pow instead

2014-12-23 Thread Cristian Rodríguez
In any case, the compiler generates the same code inline and never actually calls the library function. --- src/timesync/timesyncd-manager.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index

Re: [systemd-devel] Improving module loading

2014-12-23 Thread Greg KH
On Tue, Dec 23, 2014 at 11:25:23AM +, Hoyer, Marko (ADITG/SW2) wrote: What do you mean by this? What is limiting this? What is your limit? How large are these kernel modules that you are having a hard time to build into your kernel image? - As far as I remember, we have special

[systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event v5

2014-12-23 Thread Shawn Paul Landden
There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be correct to the rule. --- src/core/mount.c | 4 ++-- src/core/path.c | 4 ++-- src/journal/sd-journal.c | 4 ++-- src/shared/util.c| 5 ++---

[systemd-devel] [PATCHv2] test: do not use last cap from kernel in test-cap-list

2014-12-23 Thread Filipe Brandenburger
The new test-cap-list introduced in commit 2822da4fb7f891 uses the included table of capabilities. However, it uses cap_last_cap() which probes the kernel for the last available capability. On an older kernel (e.g. 3.10 from RHEL 7) that causes the test to fail with the following message:

Re: [systemd-devel] systemd-gpt-auto-generator does not appear to remount rootfs rw

2014-12-23 Thread Lennart Poettering
On Tue, 23.12.14 16:56, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: Heya, I'm using systemd 218 (stock upstream, unpatched) dracut 040 (stock upstream, unpatched). I'm trying to build a basic GPT disk image to boot in a VM with gpt-auto-generator discovery of partitions. I

Re: [systemd-devel] [PATCH] hwdb: add rule and first entry for PS/2 mice

2014-12-23 Thread Peter Hutterer
On Tue, Dec 23, 2014 at 02:16:15PM +0100, David Herrmann wrote: (CC'ing sd-devel this time.. sorry) On Tue, Dec 23, 2014 at 1:19 AM, Peter Hutterer peter.hutte...@who-t.net wrote: https://bugs.freedesktop.org/show_bug.cgi?id=87037 --- some feedback on the rule would be appreciated, in

Re: [systemd-devel] [PATCH] util: fix strict aliasing violations in use of struct inotify_event v5

2014-12-23 Thread Lennart Poettering
On Tue, 23.12.14 13:47, Shawn Paul Landden (sh...@churchofgit.com) wrote: There is alot of cleanup that will have to happen to turn on -fstrict-aliasing, but I think our code should be correct to the rule. Applied with some minor changes! (we try to use _t only for things that actually feel

Re: [systemd-devel] [systemd-commits] 8 commits - Makefile.am TODO src/bus-proxyd src/core src/import src/libsystemd src/machine src/shared src/test

2014-12-23 Thread Lennart Poettering
On Tue, 23.12.14 11:13, Filipe Brandenburger (filbran...@google.com) wrote: Hi, On Tue, Dec 23, 2014 at 10:15 AM, Lennart Poettering lenn...@kemper.freedesktop.org wrote: commit 3c70e3bb022f0de3317f3600c9366a2f4597339e Author: Lennart Poettering lenn...@poettering.net Date: Tue Dec

[systemd-devel] [PATCH 1/3] machined: add org.freedesktop.machine1.policy.in to POTFILES.in

2014-12-23 Thread Filipe Brandenburger
The new polkit file was introduced in commit d04c1fb8e21560 (machined: introduce polkit for OpenLogin() call). --- po/POTFILES.in | 1 + 1 file changed, 1 insertion(+) diff --git a/po/POTFILES.in b/po/POTFILES.in index 2829c87..344c307 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -1,5

[systemd-devel] [PATCH 2/3] build-sys: update path in reference to sd-lldp.h

2014-12-23 Thread Filipe Brandenburger
The file was moved from src/libsystemd-network to src/systemd in commit 7a6f1457462840 (sd-lldp: minor header cleanup). This fixes make distcheck. --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 4173147..8446469 100644 ---

[systemd-devel] [PATCH 1/2] libudev: fix strict aliasing violation

2014-12-23 Thread Shawn Paul Landden
--- src/libudev/libudev-monitor.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/libudev/libudev-monitor.c b/src/libudev/libudev-monitor.c index e8d6b4a..484fefe 100644 --- a/src/libudev/libudev-monitor.c +++ b/src/libudev/libudev-monitor.c @@

[systemd-devel] [PATCH 2/2] udev: fix another strict aliasing issue

2014-12-23 Thread Shawn Paul Landden
--- src/udev/ata_id/ata_id.c | 62 +++- 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/src/udev/ata_id/ata_id.c b/src/udev/ata_id/ata_id.c index 89628c9..fc13819 100644 --- a/src/udev/ata_id/ata_id.c +++ b/src/udev/ata_id/ata_id.c @@

[systemd-devel] How to write two .mount units for the same directory?

2014-12-23 Thread CUI Hao
Hi all, I want to write 2 mount unit to mount the same directory. When the first failed to mount, then the second is called via OnFailure= setting. (Think of an NTFS partition after Windows' hiberation. I'd like to write a backup unit to mount it readonly.) But there is a rule that Where=

Re: [systemd-devel] Improving module loading

2014-12-23 Thread Alison Chaiken
Marko Hoyer: Are you talking about Save To RAM, Save to Disk, or a hybrid combination of both? Or do you have something completely different in mind? GKH: A number of devices in the past have done a save system image to flash, and then when starting up, just load the system image into