[systemd-devel] [PATCH] libsystemd-network: fix typo in lldp

2015-01-05 Thread Torstein Husebø
--- src/libsystemd-network/lldp-internal.h | 2 +- src/libsystemd-network/sd-lldp.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libsystemd-network/lldp-internal.h b/src/libsystemd-network/lldp-internal.h index c7235c11ee..8e09ee8f3a 100644 --- a/sr

[systemd-devel] logind: support of shared devices

2015-01-05 Thread Oleg Samarin
Hello! The default systemd behavior is to grant/revoke access on devices attached to a seat when the user activates/deactivates a session on the seat. But sometimes it needs the user has an access to some device when he/she activates a session with ANY seat. For example, I have two seats: seat0

[systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Michael Biebl
See attached patch. The commit message reads: The list of provided facility names as specified via Provides: in the LSB header was originally implemented by adding those facilities to the Names= property via unit_add_name(). In commit 95ed3294c632f5606327149f10cef1eb34422862 the internal SysV su

[systemd-devel] [PATCH] po: update Italian translation

2015-01-05 Thread Daniele Medri
--- po/it.po | 207 +++ 1 file changed, 127 insertions(+), 80 deletions(-) diff --git a/po/it.po b/po/it.po index 90a5fe0..93a1e79 100644 --- a/po/it.po +++ b/po/it.po @@ -1,14 +1,14 @@ # Italian translations for systemd package # Trad

[systemd-devel] [PATCH] sysv-generator: avoid wrong orderings for failing units

2015-01-05 Thread Michael Biebl
If a service fails to load, we skip fix_order() and the generator uses the static start priorities. This induces bogus orderings against unrelated services. So instead, just don't add a service to the all_services hash_map, if it fails to load. Bug-Debian: https://bugs.debian.org/771118 See attac

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Igor Bukanov
It could be that this is SELinux-related. If I copy the rsync binary to a new location and change the test service unit to use it, then the log appeared as it should. However, I have no indications of any rsync-related issues in any SELinux logs. Another thing is that if I run under strace the orig

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Mantas Mikulėnas
On Mon, Jan 5, 2015 at 12:58 PM, Igor Bukanov wrote: > It could be that this is SELinux-related. If I copy the rsync binary > to a new location and change the test service unit to use it, then the > log appeared as it should. However, I have no indications of any > rsync-related issues in any SELi

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Igor Bukanov
On 5 January 2015 at 12:21, Mantas Mikulėnas wrote: > Run it under `strace -D` – the problem may be related to rsync's > parent being pid1. Under strace -D the problem disappeared as well. The problem also disappears if I run rsync like in: ExecStart=/usr/bin/bash -c 'exec /usr/bin/rsync -vv /et

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Mantas Mikulėnas
On Mon, Jan 5, 2015 at 1:44 PM, Igor Bukanov wrote: > On 5 January 2015 at 12:21, Mantas Mikulėnas wrote: >> Run it under `strace -D` – the problem may be related to rsync's >> parent being pid1. > > Under strace -D the problem disappeared as well. The problem also > disappears if I run rsync lik

Re: [systemd-devel] [PATCH] libsystemd-network: fix typo in lldp

2015-01-05 Thread Lennart Poettering
On Mon, 05.01.15 09:55, Torstein Husebø (torst...@huseboe.net) wrote: Applied! Thanks! > --- > src/libsystemd-network/lldp-internal.h | 2 +- > src/libsystemd-network/sd-lldp.c | 12 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/libsystemd-network/l

Re: [systemd-devel] [PATCH v4] Do not clear parent mount flags when setting up namespaces

2015-01-05 Thread Lennart Poettering
On Sun, 04.01.15 20:51, Topi Miettinen (toiwo...@gmail.com) wrote: > When setting up a namespace, mount flags like noexec, nosuid and > nodev are cleared, so the mounts always have exec, suid and dev > flags enabled. > > Copy source directory mount flags to target mount when remounting > the bind

Re: [systemd-devel] is a unix shell (zsh, bash, sh) still required by systemd?

2015-01-05 Thread Lennart Poettering
On Wed, 31.12.14 00:16, ivo welch (ivo.we...@gmail.com) wrote: > [2] on http://freedesktop.org/wiki/Software/systemd/, this list is > noted as appropriate not only for for "general development" but for > "technical discussion," too. alas, because this is not about > developing systemd, but develo

Re: [systemd-devel] [PATCH] po: update Italian translation

2015-01-05 Thread Lennart Poettering
On Mon, 05.01.15 10:35, Daniele Medri (dme...@gmail.com) wrote: Applied! Thanks! > --- > po/it.po | 207 > +++ > 1 file changed, 127 insertions(+), 80 deletions(-) > > diff --git a/po/it.po b/po/it.po > index 90a5fe0..93a1e79 100644 >

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Lennart Poettering
On Sun, 04.01.15 21:06, Igor Bukanov (i...@mir2.org) wrote: > Hello, > > I have a strange case when there is no output in the journal from > rsync when the command is run from a service. This is on Fedora 21 > with systemd 217. > > Consider the following trivial test unit: > > # cat /etc/system

Re: [systemd-devel] [PATCH 2/2] accelerometer: display short options too

2015-01-05 Thread Lennart Poettering
On Wed, 31.12.14 01:14, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Tue, Dec 30, 2014 at 08:29:27PM +0100, Paul Menzel wrote: > > Am Dienstag, den 30.12.2014, 18:58 +0100 schrieb Robert Milasan: > > > --- > > > src/udev/accelerometer/accelerometer.c | 4 ++-- > > > 1 file changed,

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Mantas Mikulėnas
On Mon, Jan 5, 2015 at 2:56 PM, Lennart Poettering wrote: > Hmm, quite possibly rsync has some logic built-in that checks whether > it is run with PID 1 as parent process, and then changes its logging > behaviour. On sysvinit that made some sense, but it certainly doesn't > on any other init syste

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Lennart Poettering
On Thu, 01.01.15 04:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Sounds generally OK. > A disadvantage of the solution implemented here, otoh, is that both > systemd and journald must be restarted for it to take effect. This is something I am concerned about. This will break update

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Tomasz Torcz
On Mon, Jan 05, 2015 at 02:12:45PM +0100, Lennart Poettering wrote: > On Thu, 01.01.15 04:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > Sounds generally OK. > > > A disadvantage of the solution implemented here, otoh, is that both > > systemd and journald must be restarted for it

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: > See attached patch. > > The commit message reads: > > The list of provided facility names as specified via Provides: in the > LSB header was originally implemented by adding those facilities to the > Names= property via unit_add_nam

[systemd-devel] [PATCH] bus-proxyd: don't allow to acquire org.freedesktop.DBus name

2015-01-05 Thread Lukasz Skalski
--- src/bus-proxyd/bus-proxyd.c | 4 1 file changed, 4 insertions(+) diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c index a7818f5..fc70cce 100644 --- a/src/bus-proxyd/bus-proxyd.c +++ b/src/bus-proxyd/bus-proxyd.c @@ -829,6 +829,10 @@ static int process_driver(sd_bus

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 02:12:45PM +0100, Lennart Poettering wrote: > On Thu, 01.01.15 04:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > Sounds generally OK. > > > A disadvantage of the solution implemented here, otoh, is that both > > systemd and journald must be restarted for it

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 02:24:35PM +0100, Tomasz Torcz wrote: > On Mon, Jan 05, 2015 at 02:12:45PM +0100, Lennart Poettering wrote: > > On Thu, 01.01.15 04:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > Sounds generally OK. > > > > > A disadvantage of the solution impleme

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Igor Bukanov
I attach strace log for systemd. I have in my test unit: # cat test.service [Service] ExecStart=/usr/bin/bash -c 'echo rsync copy' ExecStart=/var/rsync -vv /etc/hostname /tmp/h6 ExecStart=/usr/bin/bash -c 'echo system rsync' ExecStart=/usr/bin/rsync -vv /etc/hostname /tmp/h2 ExecStart=/usr/bin/bas

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Igor Bukanov
On 5 January 2015 at 15:08, Daniel J Walsh wrote: > chcon -t bin_t /usr/bin/rsync, should stop SELinux from interfering, or > set the rsync_client boolean. > > http://danwalsh.livejournal.com/61646.html Yes, that solved the problem. Now, why there were no any error messages about discarded rsync

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Lennart Poettering
On Mon, 05.01.15 14:55, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Mon, Jan 05, 2015 at 02:12:45PM +0100, Lennart Poettering wrote: > > On Thu, 01.01.15 04:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > Sounds generally OK. > > > > > A disadvantage of th

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Lennart Poettering
On Mon, 05.01.15 15:02, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > What we can do instead is to implement daemon-reexec equivalent for > journald. It would simply reexec itself to a new binary and pass all > the fds. Some serialization/de-serialization protocol would be necessary > t

Re: [systemd-devel] [PATCH] bus-proxyd: don't allow to acquire org.freedesktop.DBus name

2015-01-05 Thread Daniel Mack
On 01/05/2015 02:45 PM, Lukasz Skalski wrote: > --- > src/bus-proxyd/bus-proxyd.c | 4 > 1 file changed, 4 insertions(+) Applied, thanks! > > diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c > index a7818f5..fc70cce 100644 > --- a/src/bus-proxyd/bus-proxyd.c > +++ b/s

Re: [systemd-devel] systemctl ; tmpfiles 'D'

2015-01-05 Thread Lennart Poettering
On Mon, 05.01.15 00:33, Elias Probst (m...@eliasprobst.eu) wrote: > "systemd-tmpfiles --create" fails with "chmod(/var/run/samba) failed: No > such file or directory" after d7b8eec7 > https://bugs.freedesktop.org/show_bug.cgi?id=87953 Fixed this one, too! Thanks! Lennart -- Lennart Poetteri

[systemd-devel] [PATCH] bus-proxyd: overwrite 'sender' field in process_driver() function

2015-01-05 Thread Lukasz Skalski
To keep compatibility with dbus-1, before we use synthetic_reply_method_*() functions, we should overwrite 'sender' field - otherwise functions sd_bus_message_new_method_return() and sd_bus_message_new_method_error() never set 'destination' field. Thanks to this we have proper 'destination' value:

Re: [systemd-devel] [PATCH 2/4] systemctl: edit: improve error messages, report actual error for units which could not be loaded

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
This is a minor thing, but makes things easier, especially when using gitk or git format-patch: please keep the patch subject at around 80 characters (<=72 is best). I know we don't always to this, sometimes it just isn't possible, but in this case something like 'systemctl: report actual load err

Re: [systemd-devel] [PATCH 3/4] systemctl: edit: further reword error messages

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 05:08:09PM +0300, Ivan Shapovalov wrote: > --- > src/systemctl/systemctl.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c > index 658793e..20c367c 100644 > --- a/src/sy

Re: [systemd-devel] [PATCH 4/4] systemctl: unit_find_paths(): unify error handling in two code pathes

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
"two code paths". 1/4 and 4/4 are fine, but I think it's better to have them applied adjacent to the remaing two, so I leave them for now too. Zbyszek On Fri, Dec 19, 2014 at 05:08:10PM +0300, Ivan Shapovalov wrote: > --- > src/systemctl/systemctl.c | 63 > ++---

Re: [systemd-devel] [PATCH 1/4] path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 05:08:07PM +0300, Ivan Shapovalov wrote: > --- > src/shared/install.c | 16 > src/shared/path-lookup.c | 16 > src/shared/path-lookup.h | 4 > src/systemctl/systemctl.c | 6 +- > 4 files changed, 21 insertions(+), 21 delet

Re: [systemd-devel] [PATCH] machine: add reference to machine-dbus.h to Makefile.am

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 02, 2015 at 09:45:23AM -0800, Filipe Brandenburger wrote: > On Mon, Dec 29, 2014 at 3:22 PM, Filipe Brandenburger > wrote: > > Commit 003dffde2c1b93 ("machined: Move image discovery logic into > > src/shared, > > so that we can make use of it from nspawn") moved some definitions from

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 03:25:33PM +0100, Igor Bukanov wrote: > On 5 January 2015 at 15:08, Daniel J Walsh wrote: > > chcon -t bin_t /usr/bin/rsync, should stop SELinux from interfering, or > > set the rsync_client boolean. > > > > http://danwalsh.livejournal.com/61646.html > > Yes, that solved t

Re: [systemd-devel] systemd: Program terminated with signal SIGFPE, Arithmetic exception.

2015-01-05 Thread Lennart Poettering
On Tue, 30.12.14 16:51, Paul Menzel (paulepan...@users.sourceforge.net) wrote: > Dear systemd folks, > > > using Debian Sid/unstable with systemd 215-8, I still have problems that > there are time-outs between systemd and D-Bus, even with the current > D-Bus 1.8.12 [1]. Experiencing this again,

Re: [systemd-devel] Delegate=yes and user instance's resource controlling

2015-01-05 Thread Lennart Poettering
On Thu, 25.12.14 23:38, Ivan Shapovalov (intelfx...@gmail.com) wrote: > Hi! > > Judging from commit a931ad47a8623163a29d898224d8a8c1177ffdaf, > the systemd user instance is intentionally restricted from touching > !systemd hierarchies. So, things like > "systemctl --user set-property foo.service

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 02:55:11PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > SO_PEERCRED apparently returns the euid/egid of the original > > process. The UNIX "saved" uid was invented precisely to allow > > temporarily lowering the euid and later on returning to it. Maybe > > that's what we sh

Re: [systemd-devel] systemd: Program terminated with signal SIGFPE, Arithmetic exception.

2015-01-05 Thread Paul Menzel
Am Montag, den 05.01.2015, 17:57 +0100 schrieb Lennart Poettering: > On Tue, 30.12.14 16:51, Paul Menzel (paulepan...@users.sourceforge.net) wrote: > > using Debian Sid/unstable with systemd 215-8, I still have problems that > > there are time-outs between systemd and D-Bus, even with the current

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Michael Biebl
Hi, 2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: >> +link = strjoin(arg_dest, "/", alias, NULL); >> +if (!link) >> +return log_oom(); > path_join()? I borrowed from the existing code in a

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 12:01:35AM +0100, Michael Biebl wrote: > Hi, > > > 2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > > On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: > >> +link = strjoin(arg_dest, "/", alias, NULL); > >> +if (!link) > >> +

Re: [systemd-devel] systemd: Program terminated with signal SIGFPE, Arithmetic exception.

2015-01-05 Thread Lennart Poettering
On Mon, 05.01.15 23:38, Paul Menzel (paulepan...@users.sourceforge.net) wrote: > > Is it possible that something in your boot causes the systemd > > configuration to be reloaded? > > Sorry, I do not know. Any idea, how I can check that? Check the logs if it says "reloading" from systemd anywhere

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Lennart Poettering
On Mon, 05.01.15 16:03, Lennart Poettering (lenn...@poettering.net) wrote: > On Mon, 05.01.15 15:02, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > What we can do instead is to implement daemon-reexec equivalent for > > journald. It would simply reexec itself to a new binary and pas

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 03:28:09AM +0100, Lennart Poettering wrote: > On Mon, 05.01.15 16:03, Lennart Poettering (lenn...@poettering.net) wrote: > > > On Mon, 05.01.15 15:02, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > > What we can do instead is to implement daemon-reexec

Re: [systemd-devel] [PATCH] Clarify path escaping and reference systemd-escape

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 04:35:34PM -0500, Chris Atkinson wrote: > See Bug 87688 (https://bugs.freedesktop.org/show_bug.cgi?id=87688). > This patch adds more detail to the description of how path escaping > operates and provides a pointer to the systemd-escape program. Either > would serve to answer

Re: [systemd-devel] Relative links in tmpfiles.d/etc.conf

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 03, 2015 at 12:07:59PM +0100, Umut Tezduyar Lindskog wrote: > Hi, > > Our /etc is a sym link and due to that all the links created by > tmpfiles.d/etc.conf are wrong. Is there a reason why the links are > relative? They are relative so that if you're looking into a container (or a syst

[systemd-devel] List of unit states.

2015-01-05 Thread dE
Hi. I dont have a better term. When you look at the status of a unit or check the output of list-units, there's a 'load/loaded' column/field also there's an active field/column. What do these mean? I suspect load/loaded states weather they've been enabled at startup and active should show i

Re: [systemd-devel] List of unit states.

2015-01-05 Thread Andrei Borzenkov
В Tue, 06 Jan 2015 10:52:17 +0530 dE пишет: > Hi. > > I dont have a better term. > > When you look at the status of a unit or check the output of list-units, > there's a 'load/loaded' column/field also there's an active field/column. > > What do these mean? I suspect load/loaded states weath

Re: [systemd-devel] systemd: Program terminated with signal SIGFPE, Arithmetic exception.

2015-01-05 Thread Paul Menzel
Am Dienstag, den 06.01.2015, 01:50 +0100 schrieb Lennart Poettering: > On Mon, 05.01.15 23:38, Paul Menzel (paulepan...@users.sourceforge.net) wrote: > > > > Is it possible that something in your boot causes the systemd > > > configuration to be reloaded? > > > > Sorry, I do not know. Any idea, h