[systemd-devel] [PATCH] networkd: use valid bus paths

2015-02-06 Thread Mantas Mikulėnas
Object path components must start with [A-Za-z_] (AFAIK). Also the value of 'p' is undefined if asprintf fails. Compare to user_bus_path() in src/login/logind-user-dbus.c:281. --- src/network/networkd-link-bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [systemd-devel] directive for executing a script on service failure

2015-02-06 Thread Mantas Mikulėnas
On Fri, Feb 6, 2015 at 5:26 PM, George Karakougioumtzis mad-proffes...@hotmail.com wrote: Hi. Congrats for the near perfect job on systemd! I was searching for a directive to execute a script upon systemd service failure. I would like to receive desktop notifications about such failures. I

Re: [systemd-devel] directive for executing a script on service failure

2015-02-06 Thread Alexandre Detiste
Le vendredi 6 février 2015, 21:23:14 Mantas Mikulėnas a écrit : On Fri, Feb 6, 2015 at 5:26 PM, George Karakougioumtzis mad-proffes...@hotmail.com wrote: Hi. Congrats for the near perfect job on systemd! I was searching for a directive to execute a script upon systemd service failure. I

Re: [systemd-devel] directive for executing a script on service failure

2015-02-06 Thread George Karakougioumtzis
Interesting point, thanks for the clarifications. I thought that it would be as simple as setting the environmental variables DBUS_SESSION_BUS_ADRESS and DISPLAY at each unit file that you would want to receive notifications from.I thought that i might have not seen all the directives of systemd

[systemd-devel] [PATCH v2] sysv-generator: Skip init scripts for existing native services

2015-02-06 Thread Martin Pitt
Hello all, this update now uses the logic from src/shared/install.h, and also documents the rationale better: The primary reason is to actually respect a disabled native unit instead of re-enabling it through the backdoor via a corresponding enabled sysv init script. Thanks for considering,

[systemd-devel] Handling of mount points that are stacked one on top of another on the exact same mount point

2015-02-06 Thread John Lane
Two years ago I raised a query about bind mounting a subdirectory on top of its parent mount point. I supplied a patch to allow this; it was discussed but wasn't accepted. At that time, there was talk about implementing a BindSubdir option to systemd.mount but I don't think anything ever came of

Re: [systemd-devel] [RFC PATCH 2/2] localed: add LANGUAGE= fallback when LANG= is specified

2015-02-06 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 02, 2015 at 03:10:37PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Feb 02, 2015 at 11:56:39AM +0100, Martin Pitt wrote: Zbigniew Jędrzejewski-Szmek [2015-01-31 20:20 +0100]: I think the implementation is fine, since it is rather trivial, but I'm less certain about the

[systemd-devel] [PATCH] config_parse_exec_mount_flags: get rid of unnecessary copy

2015-02-06 Thread Maciej Wereski
--- src/core/load-fragment.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index 90bf563..6108d12 100644 --- a/src/core/load-fragment.c +++ b/src/core/load-fragment.c @@ -1203,21 +1203,15 @@ int

[systemd-devel] directive for executing a script on service failure

2015-02-06 Thread George Karakougioumtzis
Hi. Congrats for the near perfect job on systemd! I was searching for a directive to execute a script upon systemd service failure. I would like to receive desktop notifications about such failures. I stumbled upon OnFailure and FailureAction but these have hardcoded list of actions? Any hints

Re: [systemd-devel] About systemd call dbus session bus

2015-02-06 Thread Simon McVittie
On 06/02/15 03:32, 张洋 wrote: dbus-daemon --session --print-address --fork /tmp/session_amgr This is a security flaw (the search keywords to look for are symlink attack). export DBUS_SESSION_BUS_ADDRESS=`cat /tmp/session_amgr` This only affects the environment of the shell script that is

Re: [systemd-devel] About systemd call dbus session bus

2015-02-06 Thread Mantas Mikulėnas
On Fri, Feb 6, 2015 at 2:02 PM, Simon McVittie simon.mcvit...@collabora.co.uk wrote: On 06/02/15 03:32, 张洋 wrote: dbus-daemon --session --print-address --fork /tmp/session_amgr This is a security flaw (the search keywords to look for are symlink attack). True, although systemd sets

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-06 Thread Colin Guthrie
Michael Biebl wrote on 04/02/15 19:59: 2015-02-04 13:42 GMT+01:00 Lennart Poettering lenn...@poettering.net: Hello all, a little while ago, Jon Severinsson wrote a sysv generator optimization to not go through all the parsing of init.d scripts and creation of units if there already is a

[systemd-devel] [PATCH] bus-proxyd: fix 'ListQueuedOwners' call

2015-02-06 Thread Lukasz Skalski
Set proper kdbus_cmd_list object size, otherwise: dbus-send --system --dest=org.freedesktop.DBus --type=method_call \ print-reply / org.freedesktop.DBus.ListQueuedOwners string:org.freedesktop.systemd1 Error org.freedesktop.DBus.Error.InvalidArgs: Invalid argument diff --git