Re: [systemd-devel] [PATCH] readahead: read /usr files last for rotational media, skip /var

[Stephan Kulow]

Am Freitag, 30. September 2011, 16:52:01 schrieb Tom Gundersen:
 On Fri, Sep 30, 2011 at 4:26 PM, Paolo Bonzini bonz...@gnu.org wrote:
  On 09/30/2011 03:39 PM, Kay Sievers wrote:
  Sure. I just think that this is not what we really want in the end.
  
  That I agree with, but good is the enemy of perfect...
 
 How about this:
 
 Rather than making the split between / and /usr, make it between
 Before and After basic.target (as basic.target is roughly what
 traditionally would require files to be on /). This would require us
 to associate files to be readahead with services, but based on what
 you wrote in a previous message that should be easy enough.
 
That's what we achieved with SUSE's preload - through systemtap
we got all relevant syscalls to later determine a process tree and
IO done by what service. This way we could later readahead only
the files of a given service before starting it.

It made a huge difference, but it was also pretty complex and fragile.

Greetings, Stephan

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 2/2] .include directive does not include as textual include it includes by parsing the include file.

[Barry Scott]

This means that section headers must be used inside of
a .include file otherwise all the lines are ignored.

Signed-off-by: Barry Scott barry.sc...@onelan.co.uk
---
 man/systemd.unit.xml |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/man/systemd.unit.xml b/man/systemd.unit.xml
index bf8de32..e47c146 100644
--- a/man/systemd.unit.xml
+++ b/man/systemd.unit.xml
@@ -121,8 +121,9 @@
 
 paraIf a line starts with option.include/option
 followed by a file name, the specified file will be
-read as if its contents were listed in place of the
-option.include/option directive./para
+parsed at this point. Make sure that the file that is
+included has the appropiate section headers before
+any directives./para
 
 paraAlong with a unit file
 filenamefoo.service/filename a directory
-- 
1.7.6

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 1/2-V2] For ExecStart= provide more details on env var substitution and how that turns into arguments.

[Barry Scott]

For EnvironmentFile= explain that double quotes can be used
to protect whitespace.

Signed-off-by: Barry Scott barry.sc...@onelan.co.uk
---

Change since V1:
* fix wording to be normal english

 man/systemd.exec.xml|5 +
 man/systemd.service.xml |   23 ---
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/man/systemd.exec.xml b/man/systemd.exec.xml
index 609484b..96260cd 100644
--- a/man/systemd.exec.xml
+++ b/man/systemd.exec.xml
@@ -279,6 +279,11 @@
 assignments. Empty lines and lines
 starting with ; or # will be ignored,
 which may be used for commenting. The
+parser for will strip leading and
+trailing whitespace from the values
+of assignments, unless you use
+double quotes ().
+The
 argument passed should be an absolute
 file name, optionally prefixed with
 -, which indicates that if the file
diff --git a/man/systemd.service.xml b/man/systemd.service.xml
index 4f11020..7e3679d 100644
--- a/man/systemd.service.xml
+++ b/man/systemd.service.xml
@@ -311,18 +311,19 @@
 main process of the daemon. The
 command line accepts % specifiers as
 described in
-
citerefentryrefentrytitlesystemd.unit/refentrytitlemanvolnum5/manvolnum/citerefentry.
 On
-top of that basic environment variable
-substitution is supported, where
-literal${FOO}/literal is replaced
-by the string value of the environment
-variable of the same name. Also
-literal$FOO/literal may appear as
-separate word on the command line in
-which case the variable is replaced by
-its value split at whitespaces. Note
+
citerefentryrefentrytitlesystemd.unit/refentrytitlemanvolnum5/manvolnum/citerefentry./para
+paraOn top of that basic environment variable
+substitution is supported. Use 
literal${FOO}/literal
+as part of a word, or as word of its own on the
+command line, in which case it will be replaced
+by the value of the env var including all
+whitespace it contains, resulting in 1 
argument.
+Use literal$FOO/literal as a separate word
+on the command line, in which case it will be
+replaced by the value of the env var split up 
at
+whitespace, resulting in 0 or more arguments. 
Note
 that the first argument (i.e. the
-binary to execute) may not be a
+program to execute) may not be a
 variable, and must be a literal and
 absolute path name./para/listitem
 /varlistentry
-- 
1.7.6

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel