[systemd-devel] [PATCH] man: Add reason for disk model info not working

2013-02-17 Thread William Giokas
In systemd-bootchart, the disk model information will not be found unless the root device is specified using `root=/dev/sdxY` on the kernel line. Just add a note as to why this doesn't happen. --- man/systemd-bootchart.xml | 4 1 file changed, 4 insertions(+) diff --git

[systemd-devel] High CPU usage of journald

2013-02-17 Thread Holger Freyther
Dear maintainers, first of all the good news. The same setup used to exhibit high memory usage (and exploding virtual address space). In a relatively idle system I see a constant CPU usage of journald of around 20% ( using the busybox top). The main issue with that is that the system starts to

Re: [systemd-devel] [bug] (char*)NULL should be used in variadic functions

2013-02-17 Thread Vasily Kulikov
On Mon, Feb 04, 2013 at 20:22 +0100, Lennart Poettering wrote: On Mon, 04.02.13 11:37, Michał Bartoszkiewicz (mbartoszkiew...@gmail.com) wrote: On Mon, Feb 4, 2013 at 11:15 AM, Lennart Poettering lenn...@poettering.net wrote: We actually care about readability of the sources and

[systemd-devel] masked services and a lot of warnings

2013-02-17 Thread Reindl Harald
can we gat rid of this messages somehow? i know that they are masked and can not be started this as the reason to mask them nobody needs upower on a virtual machine because he connects via SSH and opens a X application with X-Forwarding Feb 17 17:32:21 buildserver dbus-daemon[450]: dbus[450]:

Re: [systemd-devel] High CPU usage of journald

2013-02-17 Thread Holger Freyther
Holger Freyther holger at freyther.de writes: I am currently re-compiling my rootfs to not omit the framepointers and then will hopefully be able to have useful output of perf. Is the current behavior expected/wanted? Somehow backtrace generation is still broken (perf should be able to walk

Re: [systemd-devel] High CPU usage of journald

2013-02-17 Thread Cristian Rodríguez
El 17/02/13 14:54, Holger Freyther escribió: So where does _int_malloc come from? I have used gdb to 'sample' it by hand. So the answer is from a lot of places. Do you consider cutting back on how you dynamically allocate strings? E.g. stop using fopen, fgets, only have one dynamically tmp

Re: [systemd-devel] masked services and a lot of warnings

2013-02-17 Thread Cristian Rodríguez
El 17/02/13 14:33, Reindl Harald escribió: can we gat rid of this messages somehow? i know that they are masked and can not be started this as the reason to mask them nobody needs upower on a virtual machine because he connects via SSH and opens a X application with X-Forwarding Huh ? isnt

Re: [systemd-devel] masked services and a lot of warnings

2013-02-17 Thread Reindl Harald
Am 17.02.2013 19:33, schrieb Cristian Rodríguez: El 17/02/13 14:33, Reindl Harald escribió: can we gat rid of this messages somehow? i know that they are masked and can not be started this as the reason to mask them nobody needs upower on a virtual machine because he connects via SSH and

Re: [systemd-devel] masked services and a lot of warnings

2013-02-17 Thread Cristian Rodríguez
El 17/02/13 15:37, Reindl Harald escribió: Am 17.02.2013 19:33, schrieb Cristian Rodríguez: El 17/02/13 14:33, Reindl Harald escribió: can we gat rid of this messages somehow? i know that they are masked and can not be started this as the reason to mask them nobody needs upower on a virtual

[systemd-devel] [PATCH] inhibit: make the output more readable

2013-02-17 Thread Mantas Mikulėnas
The columnar output can become pretty horrible. When GNOME inhibits power/suspend/hibernate keys, the WHAT column's text extends to WHO and even WHY. At the same time, all texts in WHY are of the form GNOME handlin...sses Receiving sle...ions GNOME needs t...reen This patch splits

Re: [systemd-devel] masked services and a lot of warnings

2013-02-17 Thread Reindl Harald
Am 17.02.2013 19:48, schrieb Cristian Rodríguez: El 17/02/13 15:37, Reindl Harald escribió: Am 17.02.2013 19:33, schrieb Cristian Rodríguez: El 17/02/13 14:33, Reindl Harald escribió: can we gat rid of this messages somehow? i know that they are masked and can not be started this as the

[systemd-devel] [PATCH 1/3] test-strv.c: added strv_split_nulstr() test

2013-02-17 Thread Daniel Buch
--- src/test/test-strv.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index a8801b5..ea1f088 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -100,6 +100,18 @@ static void test_strv_join(void) {

[systemd-devel] [PATCH 2/3] test-strv.c: added OOM check for current tests

2013-02-17 Thread Daniel Buch
--- src/test/test-strv.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index ea1f088..e33568c 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -85,18 +85,23 @@ static void test_strv_join(void) { };

[systemd-devel] [PATCH 3/3] test-strv.c: ported test_specifier_printf() to _cleanup_free_ + assert_se + cleanup

2013-02-17 Thread Daniel Buch
--- src/test/test-strv.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index e33568c..1718f56 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -27,7 +27,7 @@ #include strv.h static void

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Kay Sievers
On Thu, Feb 7, 2013 at 3:52 PM, Robert Milasan rmila...@suse.com wrote: Hi, seems that using some strange usb devices with really bogus serial numbers usb_id creates links with junk strings in it: /dev/disk/by-id/usb-TSSTcorp_BDDVDW_SE-506AB_㡒䍌䜶䉗ぁㄴ㌴†ँ-0:0 Initially was believed that usb_id

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Reindl Harald
Am 17.02.2013 22:30, schrieb Kay Sievers: On Thu, Feb 7, 2013 at 3:52 PM, Robert Milasan rmila...@suse.com wrote: Hi, seems that using some strange usb devices with really bogus serial numbers usb_id creates links with junk strings in it:

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Kay Sievers
On Sun, Feb 17, 2013 at 10:33 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 22:30, schrieb Kay Sievers: Initially was believed that usb_id is to blame, then the kernel, but it We use the same rules now as described here:

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Reindl Harald
Am 17.02.2013 22:59, schrieb Kay Sievers: On Sun, Feb 17, 2013 at 10:33 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 22:30, schrieb Kay Sievers: Initially was believed that usb_id is to blame, then the kernel, but it We use the same rules now as described here:

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Kay Sievers
On Sun, Feb 17, 2013 at 11:11 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 22:59, schrieb Kay Sievers: On Sun, Feb 17, 2013 at 10:33 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 22:30, schrieb Kay Sievers: Initially was believed that usb_id is to blame,

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Cristian Rodríguez
El 17/02/13 18:33, Reindl Harald escribió: Am 17.02.2013 22:30, schrieb Kay Sievers: On Thu, Feb 7, 2013 at 3:52 PM, Robert Milasan rmila...@suse.com wrote: Hi, seems that using some strange usb devices with really bogus serial numbers usb_id creates links with junk strings in it:

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Reindl Harald
Am 17.02.2013 23:18, schrieb Kay Sievers: On Sun, Feb 17, 2013 at 11:11 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 22:59, schrieb Kay Sievers: On Sun, Feb 17, 2013 at 10:33 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 22:30, schrieb Kay Sievers:

Re: [systemd-devel] [PATCHv2] man: Add reason for disk model info not working

2013-02-17 Thread Kok, Auke-jan H
On Sat, Feb 16, 2013 at 8:04 PM, William Giokas 1007...@gmail.com wrote: In systemd-bootchart, the disk model information will not be found unless the root device is specified using `root=/dev/sdxY` on the kernel line. Just add a note as to why this doesn't happen. --- Sorry, forgot to pull.

Re: [systemd-devel] usb_id gets bogus serial and makes a mess

2013-02-17 Thread Dave Reisner
On Feb 17, 2013 5:36 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 23:18, schrieb Kay Sievers: On Sun, Feb 17, 2013 at 11:11 PM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 22:59, schrieb Kay Sievers: On Sun, Feb 17, 2013 at 10:33 PM, Reindl Harald

Re: [systemd-devel] masked services and a lot of warnings

2013-02-17 Thread David Strauss
Couldn't you also just disable or mask the sources of activation? On Sun, Feb 17, 2013 at 11:12 AM, Reindl Harald h.rei...@thelounge.net wrote: Am 17.02.2013 19:48, schrieb Cristian Rodríguez: El 17/02/13 15:37, Reindl Harald escribió: Am 17.02.2013 19:33, schrieb Cristian Rodríguez: El

Re: [systemd-devel] python - reading the journal

2013-02-17 Thread David Strauss
Great progress! A few more remarks: * Class methods ought to be verbs. this_machine and this_boot are the key ones that come to mind. Maybe add_machine_match and add_boot_match? * In methods like this_machine that have special handling for the None value as myself, the function should use

Re: [systemd-devel] masked services and a lot of warnings

2013-02-17 Thread Mantas Mikulėnas
On Mon, Feb 18, 2013 at 3:17 AM, David Strauss da...@davidstrauss.net wrote: Couldn't you also just disable or mask the sources of activation? I'm not sure if this can be done when services are activated via DBus – other than removing the files in /usr/share/dbus-1/system-services/, which is