Re: [systemd-devel] python-systemd wait bug

2013-04-06 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 06, 2013 at 11:13:08PM +0100, Steven Hiscocks wrote: > Hi, > > I noticed an issue in the Reader class within python systemd.journal > wait method. Fix is trivial, but patch below to highlight the issue. > > diff --git a/src/python-systemd/journal.py b/src/python-systemd/journal.py > i

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Apr 07, 2013 at 03:07:06AM +0400, Askar Safin wrote: > > Also, > > with debian/ubuntu multiarch, the difference between primary arch > > and the rest is quite thin. > No. Debian has library multiarch only. This means you can install two libc > (x86_64 and i386) but cannot install two bashe

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Askar Safin
> Also, > with debian/ubuntu multiarch, the difference between primary arch > and the rest is quite thin. No. Debian has library multiarch only. This means you can install two libc (x86_64 and i386) but cannot install two bashes (x86_64 and i386). Moreover, "dpkg --print-architecture" will always

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 06, 2013 at 10:41:44PM +0200, Reindl Harald wrote: > > > Am 06.04.2013 22:37, schrieb Askar Safin: > >> What is "primary arch"? The arch of init? ls? the package manager? > > As far as I know today there is no true symmetric multiarch. Every > > multiarched system has one clear prim

[systemd-devel] python-systemd wait bug

2013-04-06 Thread Steven Hiscocks
Hi, I noticed an issue in the Reader class within python systemd.journal wait method. Fix is trivial, but patch below to highlight the issue. diff --git a/src/python-systemd/journal.py b/src/python-systemd/journal.py index c918c43..d47a7ba 100644 --- a/src/python-systemd/journal.py +++ b/src/p

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Reindl Harald
Am 06.04.2013 22:37, schrieb Askar Safin: >> What is "primary arch"? The arch of init? ls? the package manager? > As far as I know today there is no true symmetric multiarch. Every > multiarched system has one clear primary arch. And several additional arches. > So, today (I think) the paramet

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Askar Safin
> What is "primary arch"? The arch of init? ls? the package manager? As far as I know today there is no true symmetric multiarch. Every multiarched system has one clear primary arch. And several additional arches. So, today (I think) the parameter ARCH should content all arches and the primary a

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Reindl Harald
Am 06.04.2013 20:00, schrieb Tollef Fog Heen: > ]] Askar Safin > >>> What should it look like when you have multiple architectures enabled? >> >> We can write all architectures separated by spaces (and primary arch goes >> first). > > What is "primary arch"? The arch of init? ls? the package

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Tollef Fog Heen
]] Askar Safin > > What should it look like when you have multiple architectures enabled? > > We can write all architectures separated by spaces (and primary arch goes > first). What is "primary arch"? The arch of init? ls? the package manager? -- Tollef Fog Heen UNIX is user friendly, it's

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Askar Safin
> What should it look like when you have multiple architectures enabled? We can write all architectures separated by spaces (and primary arch goes first). ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mai

[systemd-devel] [PATCH v5] systemd-analyze: filter dot output

2013-04-06 Thread Łukasz Stelmach
Make "systemd-analyze dot" output only lines with units matching given glob(7) patterns. Add --from-pattern and --to-pattern options. Without any patterns all relationships are printed as before. A relationship must match the follwing expression: (isempty(from) || from[0] || from[1] || .. ||

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-06 Thread Tollef Fog Heen
]] Askar Safin > I. e. I suggest this parameter to contain architecture of the distro, > i. e. userspace, not kernel. So, you can even name it USERSPACE_ARCH > or DISTRO_ARCH, but I think this is too long. What should it look like when you have multiple architectures enabled? -- Tollef Fog Hee

[systemd-devel] [PATCH 2/2] RFC: journald: Do not dynamically allocate _UID/_GID/_PID strings

2013-04-06 Thread Holger Hans Peter Freyther
Avoid the dynamic allocation for the _UID, _GID, and _PID strings. The maximum size of the string can be determined at compile time. The code has only been compile tested. --- src/journal/journald-server.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[systemd-devel] [PATCH 1/2] RFC: journald: Do not always record _AUDIT_SESSION and _AUDIT_LOGINUID

2013-04-06 Thread Holger Hans Peter Freyther
When systemd was compiled without audit support, do not collect the audit session and loginuid in the journal. This is saving a couple of syscalls and memory allocations per log message. --- src/journal/journald-server.c |4 1 file changed, 4 insertions(+) diff --git a/src/journal/journa

[systemd-devel] [PATCH 0/2] RFC for avoid dynamic allocation in journald

2013-04-06 Thread Holger Hans Peter Freyther
The following two patches are compile tested only. The first one is to avoid work when systemd is compiled without audit support. The second is starting to remove dynamic allocations from the dispatch_message_real method. Variables that can easily be statically allocated: _SYSTEMD_OWNER_UID _SOU

[systemd-devel] [PATCH] RFC: util: Avoid memory allocations for formatting paths

2013-04-06 Thread Holger Hans Peter Freyther
From: Holger Hans Peter Freyther Avoid memory allocations to construct the path for files in the procfs. The procfs paths are way shorter than the PATH_MAX so we can use snprintf on a string located on the stack. This shows up as a win on x86 using the benchmark program below. $ make libsystemd-