Re: [systemd-devel] [PATCH] service: kill processes with SIGKILL on watchdog failure

2013-05-24 Thread Hoyer, Marko (ADITG/SW2)
 Just calling service_enter_dead() does not kill any processes.
  As a result, the old process may still be running when the new one is 

Thx for the fast response and alternative patch. I tested it in my 
environment as well and it works as expected killing the processes 
without executing the stop stuff.

  After a watchdog failure the service is in an undefined state.
  Using the normal shutdown mechanism makes no sense. Instead all 
processes are
  just killed and the service can try to restart.

This might depend a bit on how one sees the intention of the stop stuff. 
You regard ExecStop and ExecStopPost as mechanism to support stopping a 
service using any thinkable way.

If you use ExecStopPost to do things (cleaning up or whatever) whenever 
the process has been stopped, this functionality might even make sense 
when the process is killed due to a missed watchdog notification.

Btw: ExecStopPost and ExecStop are called, when a process is killed by 
an external kill or even when it exits itsself properly. So this is 
somehow similar to the watchdog case, isn't it?

Best regards

Marko Hoyer

Advanced Driver Information Technology GmbH
Software Group II (ADITG/SW2)
Robert-Bosch-Str. 200
31139 Hildesheim

Tel. +49 5121 49 6948
Fax +49 5121 49 6999

ADIT is a joint venture company of Robert Bosch GmbH/Robert Bosch Car 
Multimedia GmbH and DENSO Corporation
Sitz: Hildesheim, Registergericht: Amtsgericht Hildesheim HRB 3438
Geschaeftsfuehrung: Wilhelm Grabow, Katsuyoshi Maeda
systemd-devel mailing list

[systemd-devel] [PATCH] Fix CPUShares configuration option

2013-05-24 Thread Eelco Dolstra
This fixes the error message Unknown or unsupported cgroup attribute
 src/core/cgroup-semantics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/cgroup-semantics.c b/src/core/cgroup-semantics.c
index 82b02bb..7df9d01 100644
--- a/src/core/cgroup-semantics.c
+++ b/src/core/cgroup-semantics.c
@@ -255,7 +255,7 @@ static int map_blkio(const CGroupSemantics *s, const char 
*value, char **ret) {
 static const CGroupSemantics semantics[] = {
-{ cpu, cpu.shares, CPUShare,  
false, parse_cpu_shares,  NULL,   NULL },
+{ cpu, cpu.shares, CPUShares, 
false, parse_cpu_shares,  NULL,   NULL },
 { memory,  memory.soft_limit_in_bytes, MemorySoftLimit,   
false, parse_memory_limit,NULL,   NULL },
 { memory,  memory.limit_in_bytes,  MemoryLimit,   
false, parse_memory_limit,NULL,   NULL },
 { devices, devices.allow,  DeviceAllow,   
true,  parse_device,  map_device, NULL },

systemd-devel mailing list

[systemd-devel] syslog web page formatting error

2013-05-24 Thread Andrey Borzenkov
The page contains

[[!format txt  [Unit] Description=System Logging Service 

[Service] ExecStart=/usr/sbin/syslog-ng -n StandardOutput=null

[Install] Alias=syslog.service ]] 

I guess this is not exactly what is intended.
systemd-devel mailing list