Re: [systemd-devel] [PATCH] cryptsetup-generator: allow specifying options in /proc/cmdline

2013-09-13 Thread Tom Gundersen
On Fri, Sep 13, 2013 at 6:18 PM, Lennart Poettering wrote: > On Fri, 13.09.13 11:52, Tom Gundersen (t...@jklm.no) wrote: > >> >> On Thu, Sep 12, 2013 at 12:10 PM, Harald Hoyer >> wrote: >> > On 09/11/2013 05:35 PM, Lennart Poettering wrote: >> >> On Mon, 19.08.13 00:15, Tom Gundersen (t...@jklm.

Re: [systemd-devel] [HEADSUP] What to backport?

2013-09-13 Thread Gabriel de Perthuis
> -- You need to pull the notes from the git repo using a command like > the following: > > $ git fetch fetch origin refs/notes/*:refs/notes/* > > I added an alias to my ~/.gitconfig for this: > > [alias] > pullnotes = fetch origin refs/notes/*:refs/notes/* > > That wa

Re: [systemd-devel] [PATCH] cryptsetup-generator: allow specifying options in /proc/cmdline

2013-09-13 Thread Lennart Poettering
On Fri, 13.09.13 11:52, Tom Gundersen (t...@jklm.no) wrote: > > On Thu, Sep 12, 2013 at 12:10 PM, Harald Hoyer wrote: > > On 09/11/2013 05:35 PM, Lennart Poettering wrote: > >> On Mon, 19.08.13 00:15, Tom Gundersen (t...@jklm.no) wrote: > >> > >>> The main usecase for this is to make it possible

Re: [systemd-devel] systemd shutdown vs ostree

2013-09-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Sep 13, 2013 at 04:48:37PM +0100, Colin Guthrie wrote: > 'Twas brillig, and Zbigniew Jędrzejewski-Szmek at 13/09/13 16:33 did > gyre and gimble: > > On Fri, Sep 13, 2013 at 08:50:06AM +0100, Colin Guthrie wrote: > >> 'Twas brillig, and Lennart Poettering at 13/09/13 00:02 did gyre and > >>

Re: [systemd-devel] systemd shutdown vs ostree

2013-09-13 Thread Colin Guthrie
'Twas brillig, and Zbigniew Jędrzejewski-Szmek at 13/09/13 16:33 did gyre and gimble: > On Fri, Sep 13, 2013 at 08:50:06AM +0100, Colin Guthrie wrote: >> 'Twas brillig, and Lennart Poettering at 13/09/13 00:02 did gyre and gimble: >>> On Thu, 12.09.13 23:31, Colin Guthrie (gm...@colin.guthr.ie) wro

Re: [systemd-devel] systemd shutdown vs ostree

2013-09-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Sep 13, 2013 at 08:50:06AM +0100, Colin Guthrie wrote: > 'Twas brillig, and Lennart Poettering at 13/09/13 00:02 did gyre and gimble: > > On Thu, 12.09.13 23:31, Colin Guthrie (gm...@colin.guthr.ie) wrote: > > > >> > >> 'Twas brillig, and Lennart Poettering at 12/09/13 21:51 did gyre and

Re: [systemd-devel] [PATCH 1/3] systemctl: check for triggering units before calling StopUnit

2013-09-13 Thread Michal Sekletar
On Wed, Sep 11, 2013 at 08:04:38PM +0200, Lennart Poettering wrote: > On Fri, 09.08.13 16:00, Michal Sekletar (msekl...@redhat.com) wrote: > > Heya, Hi Lennart, > > Hmm, so what I don't really like about this patch is that the stop might > have caused the triggering units also to go away via so

[systemd-devel] [PATCH 1/2] util, utf8: make ellipsize and ellipsize_mem take into account multi-byte characters

2013-09-13 Thread Shawn Landden
rename old versions to ascii_* Do not take into account zerowidth characters, but do consider double-wide characters. Import needed utf8 helper code from glib. --- TODO | 4 -- src/shared/utf8.c | 120 ++ src/shared/utf8.h | 100

[systemd-devel] [PATCH 2/2] test: test for new ellipsize_mem (requires user)

2013-09-13 Thread Shawn Landden
--- Makefile.am | 7 +++ src/test/test-ellipsize.c | 42 ++ 2 files changed, 49 insertions(+) create mode 100644 src/test/test-ellipsize.c diff --git a/Makefile.am b/Makefile.am index 7b7539a..0e4f58c 100644 --- a/Makefile.am +++ b/Makef

[systemd-devel] [PATCH 1/2] util, utf8: make ellipsize and ellipsize_mem take into account multi-byte characters

2013-09-13 Thread Shawn Landden
rename old versions to ascii_* Do not take into account zerowidth characters, but do consider double-wide characters. Import needed utf8 helper code from glib. --- TODO | 4 -- src/shared/utf8.c | 120 ++ src/shared/utf8.h | 100

Re: [systemd-devel] [ANNOUNCE] systemd 207

2013-09-13 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 13/09/13 03:16 did gyre and gimble: > * The option "discard" (as known from Debian) is now > synonymous to "allow-discards" in /etc/crypttab. In fact, > the latter is preferred now (since it is easier to remember > and t

Re: [systemd-devel] [PATCH] core: get rid the start job when transitioning to deactivating

2013-09-13 Thread Michal Sekletar
On Thu, Sep 12, 2013 at 06:51:49PM +0200, Lennart Poettering wrote: > On Fri, 19.07.13 09:17, Lukáš Nykrýn (lnyk...@redhat.com) wrote: > > > Hi, > > when service has StopWhenUnneeded=yes and it is requested by forking > > service, which fails during initialization, the first unit is not > > stoppe

Re: [systemd-devel] [PATCH 1/2] libudev: fix move_later comparison

2013-09-13 Thread Harald Hoyer
On 09/13/2013 03:25 PM, Harald Hoyer wrote: > On 09/13/2013 02:12 PM, Lukas Nykryn wrote: >> At the beginning move_later is set to -1, but it is set to different >> value only if expression !move_later is true. >> --- >> src/libudev/libudev-enumerate.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [systemd-devel] [PATCH 1/2] libudev: fix move_later comparison

2013-09-13 Thread Harald Hoyer
On 09/13/2013 02:12 PM, Lukas Nykryn wrote: > At the beginning move_later is set to -1, but it is set to different > value only if expression !move_later is true. > --- > src/libudev/libudev-enumerate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libudev/libudev-e

Re: [systemd-devel] [PATCH] core/cgroup: first print then free

2013-09-13 Thread Lennart Poettering
On Fri, 13.09.13 14:31, Lukas Nykryn (lnyk...@redhat.com) wrote: Thanks! Applied! > --- > src/core/cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/core/cgroup.c b/src/core/cgroup.c > index 3eeb475..513450a 100644 > --- a/src/core/cgroup.c > +++ b/src/core/c

Re: [systemd-devel] [PATCH 2/2] random-seed: we should return errno of failed loop_write

2013-09-13 Thread Lennart Poettering
On Fri, 13.09.13 14:12, Lukas Nykryn (lnyk...@redhat.com) wrote: Thanks! Applied this one! > --- > src/random-seed/random-seed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/random-seed/random-seed.c b/src/random-seed/random-seed.c > index 4776c07..afbd500 100644

Re: [systemd-devel] [PATCH] cgroup: fix incorrectly setting memory cgroup

2013-09-13 Thread Lennart Poettering
On Fri, 13.09.13 14:43, Gao feng (gaof...@cn.fujitsu.com) wrote: > If the memory_limit of unit is -1, we should write "-1" > to the file memory.limit_in_bytes. not the (unit64_t) -1. > > otherwise the memory.limit_in_bytes will be set to zero. Thanks! Applied! > --- > src/core/cgroup.c | 15 +++

Re: [systemd-devel] [PATCH 2/2] cgroup: correct the log information

2013-09-13 Thread Lennart Poettering
On Fri, 13.09.13 11:17, Gao feng (gaof...@cn.fujitsu.com) wrote: > it should be memory.soft_limit_in_bytes. Thanks! Applied both! > --- > src/core/cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/core/cgroup.c b/src/core/cgroup.c > index fba0b2f..aee93ba 10

Re: [systemd-devel] [PATCH] automount: rename repeat_unmont to repeat_unmount

2013-09-13 Thread Lennart Poettering
On Thu, 12.09.13 19:45, David Mackey (tdmac...@booleanhaiku.com) wrote: > - Trivial cleanup of repeat_unmount() spelling. Thanks! Applied! > > Signed-off-by: David Mackey > --- > src/core/automount.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/core/auto

[systemd-devel] [PATCH] core/cgroup: first print then free

2013-09-13 Thread Lukas Nykryn
--- src/core/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/cgroup.c b/src/core/cgroup.c index 3eeb475..513450a 100644 --- a/src/core/cgroup.c +++ b/src/core/cgroup.c @@ -395,8 +395,8 @@ static int unit_create_cgroups(Unit *u, CGroupControllerMask mask) {

Re: [systemd-devel] [PATCH 1/5] cgroup: add the setting memory.use_hierarchy support for systemd

2013-09-13 Thread Lennart Poettering
On Fri, 13.09.13 17:49, Gao feng (gaof...@cn.fujitsu.com) wrote: > Some programs need to set the memory.use_hierarchy(such as libvirt), > Add this feature. Hmm, should this really be an option? Shouldn't we much rather turn this on unconditionally if the memory controller is used for a unit? Thi

[systemd-devel] Should systemd-logind provide a DM-independent specification for per seat autologin settings and others?

2013-09-13 Thread Laércio Benedito Sivali de Sousa
Hi guys! With systemd-logind, we finally have a "canonical" way to implement multiseat in Linux. As current display managers implement completely logind's protocol for automatic multiseat support, per seat configuration in these DMs is almost unneeded. However, even with complete automatic multis

[systemd-devel] [PATCH 2/2] random-seed: we should return errno of failed loop_write

2013-09-13 Thread Lukas Nykryn
--- src/random-seed/random-seed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/random-seed/random-seed.c b/src/random-seed/random-seed.c index 4776c07..afbd500 100644 --- a/src/random-seed/random-seed.c +++ b/src/random-seed/random-seed.c @@ -157,7 +157,7 @@ int main(int

[systemd-devel] [PATCH 1/2] libudev: fix move_later comparison

2013-09-13 Thread Lukas Nykryn
At the beginning move_later is set to -1, but it is set to different value only if expression !move_later is true. --- src/libudev/libudev-enumerate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libudev/libudev-enumerate.c b/src/libudev/libudev-enumerate.c index bc1e37d

[systemd-devel] [PATCH 3/3] gpt-auto: use default dependencies

2013-09-13 Thread Tom Gundersen
Make this in line with how we handle fstab entries. --- src/gpt-auto-generator/gpt-auto-generator.c | 28 1 file changed, 28 deletions(-) diff --git a/src/gpt-auto-generator/gpt-auto-generator.c b/src/gpt-auto-generator/gpt-auto-generator.c index 880661e..164538d 100

[systemd-devel] [PATCH 2/3] mount: move the last of the default dependency handling to core

2013-09-13 Thread Tom Gundersen
With this also Before, RequiredBy and WantedBy is handled by core. It is dependent on the decoupling of the automount units from the mount options. --- src/core/mount.c | 53 +++-- src/fstab-generator/fstab-generator.c | 88 ---

[systemd-devel] [PATCH 1/3] [RFC] automount: decouple from corresponding mount unit

2013-09-13 Thread Tom Gundersen
Also, move all the default dependency logic into core, this introduces a functional change compared to the fstab generator: We no longer care about the type (network or local) or options (nofail) of filesystem corresponding to the automount, but consider an automount unit as a local mount point wh

[systemd-devel] [RFC] mount/automount/swap: unify the remaining default dependency handling

2013-09-13 Thread Tom Gundersen
This moves the last bits of the default dependency handling from the fstab generator to core, and uses it also in the gpt-auto generator; making the logic the same no matter how you set up your mount points. The first patch may be controversial as it changes the semantics of automount points quite

[systemd-devel] [PATCH] build: check for build/link flags harder

2013-09-13 Thread David Herrmann
Use AC_LINK_IFELSE instead of AC_COMPILE_IFELSE to test for flags that might succeed during compilation but not during linking. An example is gcc compiled with libssp support but gnu-ld without it. In this case -fstack-protector works fine during compilation but fails during linking as several inte

Re: [systemd-devel] [PATCH] cryptsetup-generator: allow specifying options in /proc/cmdline

2013-09-13 Thread Tom Gundersen
On Thu, Sep 12, 2013 at 12:10 PM, Harald Hoyer wrote: > On 09/11/2013 05:35 PM, Lennart Poettering wrote: >> On Mon, 19.08.13 00:15, Tom Gundersen (t...@jklm.no) wrote: >> >>> The main usecase for this is to make it possible to use cryptsetup in >>> the initrd without it having to include a host-s

[systemd-devel] [PATCH 4/5] man: add manpage for MemoryHierarchy

2013-09-13 Thread Gao feng
add the manpage for MemoryHierarchy. --- man/systemd.cgroup.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/man/systemd.cgroup.xml b/man/systemd.cgroup.xml index cc0eb15..80fc2e2 100644 --- a/man/systemd.cgroup.xml +++ b/man/systemd.cgroup.xml @@ -135,6 +135,17 @@ along with s

[systemd-devel] [PATCH 5/5] machine.slice: enable MemoryHierarchy by default

2013-09-13 Thread Gao feng
We can simply limit the total memory usage of machines through setting the memory usage limit of machine.slice. --- units/machine.slice | 3 +++ 1 file changed, 3 insertions(+) diff --git a/units/machine.slice b/units/machine.slice index 3d40dfd..c959598 100644 --- a/units/machine.slice +++ b/uni

[systemd-devel] [PATCH 3/5] systemctl: support setting MemoryHierarchy through systemctl

2013-09-13 Thread Gao feng
support setting MemoryHierarchy of unit through systemctl. --- src/systemctl/systemctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 57e5bb9..87388bb 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -3643,

[systemd-devel] [PATCH 2/5] cgroup: show MemoryHierarchy in cgroup_context_dump

2013-09-13 Thread Gao feng
Show MemoryHierarchy in cgroup_context_dump. --- src/core/cgroup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/cgroup.c b/src/core/cgroup.c index 336d394..2c8aa22 100644 --- a/src/core/cgroup.c +++ b/src/core/cgroup.c @@ -91,6 +91,7 @@ void cgroup_context_dump(CGroupContext *c,

[systemd-devel] [PATCH 1/5] cgroup: add the setting memory.use_hierarchy support for systemd

2013-09-13 Thread Gao feng
Some programs need to set the memory.use_hierarchy(such as libvirt), Add this feature. --- src/core/cgroup.c | 9 + src/core/cgroup.h | 1 + src/core/dbus-cgroup.c| 16 src/core/load-fragment-gperf.gperf.m4 | 1 +

Re: [systemd-devel] [HEADSUP] What to backport?

2013-09-13 Thread Colin Guthrie
'Twas brillig, and Frederic Crozat at 13/09/13 08:32 did gyre and gimble: > Le vendredi 13 septembre 2013 à 02:40 +0200, Lennart Poettering a > écrit : >> Heya! >> >> I'd like to announce a new service for systemd downstream packagers. In >> the upstream git repository we have started indicating wi

Re: [systemd-devel] systemd shutdown vs ostree

2013-09-13 Thread Colin Guthrie
'Twas brillig, and Lennart Poettering at 13/09/13 00:02 did gyre and gimble: > On Thu, 12.09.13 23:31, Colin Guthrie (gm...@colin.guthr.ie) wrote: > >> >> 'Twas brillig, and Lennart Poettering at 12/09/13 21:51 did gyre and gimble: >>> On Thu, 12.09.13 21:27, Colin Guthrie (gm...@colin.guthr.ie) w

Re: [systemd-devel] [HEADSUP] What to backport?

2013-09-13 Thread Frederic Crozat
Le vendredi 13 septembre 2013 à 02:40 +0200, Lennart Poettering a écrit : > Heya! > > I'd like to announce a new service for systemd downstream packagers. In > the upstream git repository we have started indicating with "git notes" > which commits are particularly good candidates for backporting i