Re: [systemd-devel] Duplicate Messages in Journal

2013-12-19 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 19, 2013 at 09:11:17PM -0500, Garry T. Williams wrote: > I see these messages in my journal: > > Dec 19 20:58:57 tfr systemd[1]: Started Load/Save Screen Backlight Brightness > of acpi_video0. > > Why is the message repeated so many times? Usually because something resets the brightn

[systemd-devel] Duplicate Messages in Journal

2013-12-19 Thread Garry T. Williams
I see these messages in my journal: Dec 19 20:58:57 tfr systemd[1]: Started Load/Save Screen Backlight Brightness of acpi_video0. Dec 19 20:58:57 tfr systemd[1]: Started Load/Save Screen Backlight Brightness of acpi_video0. Dec 19 20:58:57 tfr systemd[1]: Started Load/Save Screen Backlight Brigh

[systemd-devel] [PATCH] man: grammar and wording improvements

2013-12-19 Thread Jan Engelhardt
This is a recurring submission and includes corrections to various issue spotted: comma setting, missing words/preposition choice. Of note is the change of /lib to /usr/lib, because that is what most distros are using as the system-wide location for systemd/udev files. --- man/journalctl.xml

Re: [systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-19 Thread Shawn Landden
ping? On Fri, Dec 13, 2013 at 8:23 PM, Shawn Landden wrote: > If Distribute=n, turns SO_REUSEPORT on, and spawns > n workers to handling incoming requests. > > SO_REUSEPORT sockets on the same port must all be created > by the same uid, therefore using the option allows > other root programs (or

[systemd-devel] symbolic link for systemd-stdio-bridge

2013-12-19 Thread Umut Tezduyar Lindskog
It is broken when bindir is /usr/bin and /lib is not symbolic link to /usr/lib. bus-proxyd-install-hook: $(AM_V_LN)$(LN_S) -f ../../lib/systemd/systemd-bus-proxyd $(DESTDIR)$(bindir)/systemd-stdio-bridge Maybe best to use full path. ___ syste

[systemd-devel] [PATCH] Set loaded_policy in smack_setup()

2013-12-19 Thread Łukasz Stelmach
With loaded_policy set to true mount_setup() relabels /dev properly. Signed-off-by: Łukasz Stelmach --- src/core/main.c|2 +- src/core/smack-setup.c |6 +- src/core/smack-setup.h |2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/core/main.c b/src/c

[systemd-devel] [PATCH 11/11] util: remove union dirent_storage

2013-12-19 Thread Florian Weimer
--- TODO | 1 - src/shared/util.h | 6 -- 2 files changed, 7 deletions(-) diff --git a/TODO b/TODO index 2e3becc..1e8f2b0 100644 --- a/TODO +++ b/TODO @@ -48,7 +48,6 @@ Features: - ensure scope units may be started only a single time * code cleanup - - get rid of readdir_r

[systemd-devel] [PATCH 10/11] journal: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
This commit also adds error handling for failures during directory reading. --- src/journal/sd-journal.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/journal/sd-journal.c b/src/journal/sd-journal.c index bb116df..283d593 100644 --- a/src/journal

[systemd-devel] [PATCH 03/11] delta: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
--- src/delta/delta.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/delta/delta.c b/src/delta/delta.c index 0785e7b..dcf25d1 100644 --- a/src/delta/delta.c +++ b/src/delta/delta.c @@ -280,13 +280,12 @@ static int enumerate_dir(Hashmap *top, Hashmap *bottom, Hashma

[systemd-devel] [PATCH 07/11] util: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
This fixes rm_rf_children_dangerous to detect errors during directory reading. Previously, it could dereference an uninitialized pointer. --- src/shared/util.c | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/src/shared/util.c b/src/share

[systemd-devel] [PATCH 04/11] core: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
--- src/core/load-dropin.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/core/load-dropin.c b/src/core/load-dropin.c index a877e66..3504009 100644 --- a/src/core/load-dropin.c +++ b/src/core/load-dropin.c @@ -63,12 +63,13 @@ static int iterate_dir( for (

[systemd-devel] [PATCH 05/11] conf-files: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
--- src/shared/conf-files.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shared/conf-files.c b/src/shared/conf-files.c index 92204a6..c86bb03 100644 --- a/src/shared/conf-files.c +++ b/src/shared/conf-files.c @@ -53,13 +53,13 @@ static int files_add(Hashmap *h, c

[systemd-devel] [PATCH 09/11] journald/server: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
The available_space function now returns 0 if reading the directory fails. Previously, such errors were silently ignored. --- src/journal/journald-server.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c ind

[systemd-devel] [PATCH 08/11] journal/vacuum: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
--- src/journal/journal-vacuum.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/journal/journal-vacuum.c b/src/journal/journal-vacuum.c index d4a1c6c..b2b47d6 100644 --- a/src/journal/journal-vacuum.c +++ b/src/journal/journal-vacuum.c @@ -180,9 +180,7 @@ int jour

[systemd-devel] [PATCH 06/11] install: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
The old code incorrectly assumed that readdir_r updates errno. --- src/shared/install.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/shared/install.c b/src/shared/install.c index 17e8a75..5001ad4 100644 --- a/src/shared/install.c +++ b/src/shared

[systemd-devel] [PATCH 01/11] tmpfiles: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
--- src/tmpfiles/tmpfiles.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index b7f6a2e..e83a73e 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -543,15 +543,15 @@ static int recursive_relabel_chi

[systemd-devel] [PATCH 02/11] login: replace readdir_r with readdir

2013-12-19 Thread Florian Weimer
--- src/login/sd-login.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/login/sd-login.c b/src/login/sd-login.c index c9a2e8a..2930b87 100644 --- a/src/login/sd-login.c +++ b/src/login/sd-login.c @@ -555,13 +555,13 @@ _public_ int sd_get_uids(uid_t **users) {

[systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-19 Thread Florian Weimer
This patch series removes all uses of readdir_r. The changes are not entirely mechanical, some of the patches fix bugs in error handling. readdir_r is rather broken on Linux because there are some directories it cannot read. Florian Weimer (11): tmpfiles: replace readdir_r with readdir login

[systemd-devel] [PATCH] localectl: log error if bus_map_all_properties() fails

2013-12-19 Thread Djalal Harouni
--- src/locale/localectl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/locale/localectl.c b/src/locale/localectl.c index b0abe7b..5929169 100644 --- a/src/locale/localectl.c +++ b/src/locale/localectl.c @@ -128,8 +128,10 @@ static int show_status(sd_bus *bus, char **

Re: [systemd-devel] [PATCH] Avoid a busy systemd-journald in LXC environments

2013-12-19 Thread Dr. Werner Fink
On Wed, Dec 18, 2013 at 07:30:57PM +0100, Lennart Poettering wrote: > On Wed, 18.12.13 15:30, Dr. Werner Fink (wer...@suse.de) wrote: > > > > Anyway, I suggested in my original reply that I'd be happy to merge a > > > patch that downgrades the warning message to debug on ENOENT. I have now > > > m