Re: [systemd-devel] Corrections to documentation

2014-05-08 Thread Tom Gundersen 
On Thu, May 8, 2014 at 1:27 AM, Jan Engelhardt jeng...@inai.de wrote:
 On Tuesday 2014-05-06 23:09, Tom Gundersen wrote:

Applied 1,2 and 5. Thanks! However, I was not able to apply 3 and 4,
care to take a look?

 There is - no doubt - fluctuation in that area. I'm resending a rebased
 one in a minute.

Thanks! (I see it has already been applied :) ).

Cheers,

Tom
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] Check the right variable for failed open()

2014-05-08 Thread Łukasz Stelmach 
---
I am not quite sure but checking r in this if does not make much sense.

 src/core/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/cgroup.c b/src/core/cgroup.c
index 3aeaf56..29ab645 100644
--- a/src/core/cgroup.c
+++ b/src/core/cgroup.c
@@ -920,7 +920,7 @@ int manager_setup_cgroup(Manager *m) {
 safe_close(m-pin_cgroupfs_fd);
 
 m-pin_cgroupfs_fd = open(path, 
O_RDONLY|O_CLOEXEC|O_DIRECTORY|O_NOCTTY|O_NONBLOCK);
-if (r  0) {
+if (m-pin_cgroupfs_fd  0) {
 log_error(Failed to open pin file: %m);
 return -errno;
 }
-- 
1.9.1

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] Check the right variable for failed open()

2014-05-08 Thread David Herrmann 
Hi

On Thu, May 8, 2014 at 12:57 PM, Łukasz Stelmach l.stelm...@samsung.com wrote:
 ---
 I am not quite sure but checking r in this if does not make much sense.

Nice catch. Applied.

Thanks
David

  src/core/cgroup.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/core/cgroup.c b/src/core/cgroup.c
 index 3aeaf56..29ab645 100644
 --- a/src/core/cgroup.c
 +++ b/src/core/cgroup.c
 @@ -920,7 +920,7 @@ int manager_setup_cgroup(Manager *m) {
  safe_close(m-pin_cgroupfs_fd);

  m-pin_cgroupfs_fd = open(path, 
 O_RDONLY|O_CLOEXEC|O_DIRECTORY|O_NOCTTY|O_NONBLOCK);
 -if (r  0) {
 +if (m-pin_cgroupfs_fd  0) {
  log_error(Failed to open pin file: %m);
  return -errno;
  }
 --
 1.9.1

 ___
 systemd-devel mailing list
 systemd-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/systemd-devel
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2 1/2] hostnamed: expose KernelVersion on the bus

2014-05-08 Thread Djalal Harouni 
On Thu, Apr 24, 2014 at 11:45:24PM +0200, Zbigniew Jędrzejewski-Szmek wrote:
 On Thu, Apr 24, 2014 at 10:34:05PM +0100, Djalal Harouni wrote:
  On Thu, Apr 24, 2014 at 08:53:27AM +0200, Lennart Poettering wrote:
   On Wed, 23.04.14 23:03, Djalal Harouni (tix...@opendz.org) wrote:
   
This is needed to fix bug:

https://bugs.freedesktop.org/show_bug.cgi?id=76498
   
   Hmm, do we really want to expose the version here? I fail to see the
   general usefulness of this value. The release is a lot more useful and
   we already expose that, so do we really want the version here?
  Speaking about the version it shows if this is an SMP kernel, and if the
  kernel is preemtible, IOW build with CONFIG_PREEMPT
  
  Now, how many preemtible kernels are running systemd?
  
  And by coincidence, here we are speaking about systemd-analyze :-)
  
  Not to mention the build time stamp that will tell you if two same
  kernels differ... used in the embedded world.
 It might be useful to distinguish bootcharts generated with different
 kernels when comparing compilation options or whatever. I'd be
 inclined to keep it.
Lennart please, can we close this bugzilla entry?

Thanks in advance!

-- 
Djalal Harouni
http://opendz.org
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel