Re: [systemd-devel] localization of console

2014-06-18 Thread Andrey Borzenkov
В Thu, 19 Jun 2014 02:04:53 +0400 Alexey Shabalin пишет: > 2014-06-19 0:06 GMT+04:00 Jason St. John : > > On Wed, Jun 18, 2014 at 12:19 PM, Alexey Shabalin > > wrote: > >> Hello. > >> > >> I do not understand how the should work localization of console. > >> - systemd-vconsole-setup.service for

Re: [systemd-devel] [PATCH] dd-dhcp-server: fix a leak

2014-06-18 Thread Tom Gundersen
Thanks, and sorry for not getting to this sooner. Cheers, Tom On Wed, Jun 18, 2014 at 11:49 PM, Thomas H.P. Andersen wrote: > On Fri, Jun 13, 2014 at 10:58 PM, Thomas H.P. Andersen > wrote: >> From: Thomas Hindoe Paaboel Andersen >> >> We must use free instead of dhcp_lease_free here to avoi

Re: [systemd-devel] localization of console

2014-06-18 Thread Alexey Shabalin
2014-06-19 0:06 GMT+04:00 Jason St. John : > On Wed, Jun 18, 2014 at 12:19 PM, Alexey Shabalin > wrote: >> Hello. >> >> I do not understand how the should work localization of console. >> - systemd-vconsole-setup.service for an early boot (for enter password >> in cryptsetup? but people do not us

Re: [systemd-devel] [PATCH] dd-dhcp-server: fix a leak

2014-06-18 Thread Thomas H.P. Andersen
On Fri, Jun 13, 2014 at 10:58 PM, Thomas H.P. Andersen wrote: > From: Thomas Hindoe Paaboel Andersen > > We must use free instead of dhcp_lease_free here to avoid freeing > client_id.data. > --- > src/libsystemd-network/sd-dhcp-server.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [systemd-devel] localization of console

2014-06-18 Thread Jason St. John
On Wed, Jun 18, 2014 at 12:19 PM, Alexey Shabalin wrote: > Hello. > > I do not understand how the should work localization of console. > - systemd-vconsole-setup.service for an early boot (for enter password > in cryptsetup? but people do not used non-latin letters for password) > > - getty@.servi

[systemd-devel] systemd-networkd: no network connectivity with 214/master due to 63a070415db09f5b5bcc5c

2014-06-18 Thread Friedrich Kröner
Hello, when trying systemd-networkd with >=214 and the following config: [Match] Name=eth* [Network] DHCP=yes Address=2001:db8::1234:5678/64 DNS=8.8.8.8 DNS=2001:db8:1::ab9:C0A8:102 I get lots of DHCP DISCOVER events and it doesn't aquire an IPv4 address, nor sets the configured IPv6. Jun 1

Re: [systemd-devel] udevd: skip cd/dvd devices in synthesize_change

2014-06-18 Thread Robert Milasan
On Wed, 18 Jun 2014 20:57:35 +0200 "Kay Sievers" wrote: > On Wed, Jun 18, 2014 at 8:17 PM, Robert Milasan > wrote: > > If we are running udevd from a LiveCD or ISO image, it can happen > > that udevd wont find the cd/dvd in time, causing a failure. > > > > I've attached the patch which seems to

Re: [systemd-devel] udevd: skip cd/dvd devices in synthesize_change

2014-06-18 Thread Kay Sievers
On Wed, Jun 18, 2014 at 8:17 PM, Robert Milasan wrote: > If we are running udevd from a LiveCD or ISO image, it can happen that > udevd wont find the cd/dvd in time, causing a failure. > > I've attached the patch which seems to fix the issue. Change events are triggered when some tool has opened

[systemd-devel] udevd: skip cd/dvd devices in synthesize_change

2014-06-18 Thread Robert Milasan
If we are running udevd from a LiveCD or ISO image, it can happen that udevd wont find the cd/dvd in time, causing a failure. I've attached the patch which seems to fix the issue. -- Robert Milasan L3 Support Engineer SUSE Linux (http://www.suse.com) email: rmila...@suse.com GPG fingerprint: B6

Re: [systemd-devel] [PATCH 10/11] Avoid doubling the efforts for /var/log/journal

2014-06-18 Thread Goffredo Baroncelli
Hi Fink On 06/13/2014 04:41 PM, Werner Fink wrote: > That is: set NOATIME, NOCOW, and NOCOMP for the journal directory > > --- > src/journal/journald-server.c | 29 +++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git src/journal/journald-server.c sr

[systemd-devel] localization of console

2014-06-18 Thread Alexey Shabalin
Hello. I do not understand how the should work localization of console. - systemd-vconsole-setup.service for an early boot (for enter password in cryptsetup? but people do not used non-latin letters for password) - getty@.service contains TTYReset=yes (or https://bugzilla.redhat.com/show_bug.cgi?

Re: [systemd-devel] Systemd-networkd: Prepend static nameserver to DHCP-discovered nameservers

2014-06-18 Thread Runiq
On 17.06.2014 14:43:25, Mantas Mikulėnas wrote: On Jun 17, 2014 2:14 PM, "Runiq" wrote: Hello all, I'm using systemd 213 on Arch Linux, and systemd-networkd/resolved with DHCP to connect to the internet. I'm also running a caching DNS server on 127.0.0.1. I'd like to make this caching server

Re: [systemd-devel] [PATCH 02/24] sd-dhcp6-client: Add Router Solicitation and Advertisement support

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 18, 2014 at 03:24:31PM +0200, Tom Gundersen wrote: > > Did anyone have further comments on this initial patch set? Shall I send > > the updated version to the mailing list or how do we want to proceed? > > Go ahead and push. It is probably simpler to make further > suggestions/comments

Re: [systemd-devel] [PATCH 12/24] sd-dhcp6-client: Add DHCPv6 Solicit message creation and sending

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote: > On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek > wrote: > >> +if (client->fd > 0) > >> +safe_close(client->fd); > >> +client->fd = -1; > > client->fd = safe_close(client->fd); > >

Re: [systemd-devel] [PATCH 24/24] networkd: Add initial DHCPv6 support

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 13, 2014 at 04:45:14PM +0300, Patrik Flykt wrote: > Enable DHCPv6 support by creating a DHCPv6 boolean in the Network > section. Add necessary dhcp6 structures and initial function calls. > --- > src/network/networkd-link.c | 75 > > src/n

Re: [systemd-devel] [PATCH 16/24] sd-dhcp6-client: Receive and parse Advertise messages

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 13, 2014 at 04:45:06PM +0300, Patrik Flykt wrote: > When receiving DHCPv6 messages, discard the ones that are not meant > for DHCPv6 clients and verify the transaction id. Once that is done, > process the Advertise message and select the Advertise with the > highest preference. > > Cre

[systemd-devel] NoNewPrivileges and Postfix

2014-06-18 Thread Marco d'Itri
I tried using NoNewPrivileges=yes in my inn package, but then I noticed that the daemon was unable to send emails: Jun 18 07:59:38 bongo boot[4623]: postdrop: warning: mail_queue_enter: create file maildrop/111862.4636: Permission denied This happens because postdrop is SGID to be able to secur

Re: [systemd-devel] [PATCH 15/24] sd-dhcp6-client: Add IA Address option parsing

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 13, 2014 at 04:45:05PM +0300, Patrik Flykt wrote: > Add functionality to parse DHCPv6 Identity Association for > Non-temporary (IA_NA) and Temporary Addresses (IA_TA) options. > Both of them contain one or more IA Address (IAADDR) options > and optinally a status code option. Only the I

Re: [systemd-devel] [PATCH 12/24] sd-dhcp6-client: Add DHCPv6 Solicit message creation and sending

2014-06-18 Thread Filipe Brandenburger
On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek wrote: >> +if (client->fd > 0) >> +safe_close(client->fd); >> +client->fd = -1; > client->fd = safe_close(client->fd); > > That's what safe_close is for :) And shouldn't the check be for client->fd >= 0?

Re: [systemd-devel] [PATCH 13/24] sd-dhcp6-client: Add RA and DHCPv6 Solicit test case

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 13, 2014 at 04:45:03PM +0300, Patrik Flykt wrote: > Copy Router Advertisement functions and data from the previous > test case and verify the created Solicit message. The test will > take some non-trivial time to run due to the DHCPv6 initial delay. > --- > Makefile.am

Re: [systemd-devel] [PATCH 12/24] sd-dhcp6-client: Add DHCPv6 Solicit message creation and sending

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 13, 2014 at 04:45:02PM +0300, Patrik Flykt wrote: > Implement the initial functionality used for creating a DHCPv6 Solicit > message containing the needed options and send it to the DHCPv6 > broadcast address. Increase the sent message count and ensure that > the Solicit Initial Retrans

Re: [systemd-devel] [PATCH 10/24] sd-dhcp6-client: Add basic DHCPv6 option handling

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 13, 2014 at 04:45:00PM +0300, Patrik Flykt wrote: > +*optvalue = &(*buf)[4]; > +*buflen -= (*optlen + 4); > +(*buf) += (*optlen + 4); The parens on the right and left seem strange. Zbyszek ___ systemd-devel mailing l

Re: [systemd-devel] [PATCH 09/24] sd-dhcp6-client: Add DHCPv6 client Solicitation timeout handling

2014-06-18 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jun 13, 2014 at 04:44:59PM +0300, Patrik Flykt wrote: > Add the core of DHCPv6 client message retransmission and upper bound > timer and message count handling according to RFC 3315 Secions 7.1.2 ^ 17.1.2 ? > and 14. Omit the

Re: [systemd-devel] [PATCH 02/24] sd-dhcp6-client: Add Router Solicitation and Advertisement support

2014-06-18 Thread Tom Gundersen
On Wed, Jun 18, 2014 at 2:26 PM, Patrik Flykt wrote: > On Mon, 2014-06-16 at 12:39 +0300, Patrik Flykt wrote: >> > 1) usage of struct ether_addr may prevent correct operation on >> > non-ethernet links, like Infiniband or PPP or GRE. They don't have >> > 6-byte MAC addresses, so anywhere that cur

Re: [systemd-devel] [PATCH 02/24] sd-dhcp6-client: Add Router Solicitation and Advertisement support

2014-06-18 Thread Patrik Flykt
On Mon, 2014-06-16 at 12:39 +0300, Patrik Flykt wrote: > > 1) usage of struct ether_addr may prevent correct operation on > > non-ethernet links, like Infiniband or PPP or GRE. They don't have > > 6-byte MAC addresses, so anywhere that currently uses a MAC address > > I'd suggest passing "u8*, u8

Re: [systemd-devel] [PATCH 01/11] Ensure that systemd-sysctl.service is applied after modules are loaded

2014-06-18 Thread Dr. Werner Fink
On Mon, Jun 16, 2014 at 06:02:37PM +0200, Tom Gundersen wrote: > On Mon, Jun 16, 2014 at 5:19 PM, Frederic Crozat wrote: > > > > See https://bugzilla.novell.com/show_bug.cgi?id=725412 > > Hm, that really does not look convincing. There is a fundamental > problem here (as Ludwig Nessel points out

Re: [systemd-devel] [PATCH 10/11] Avoid doubling the efforts for /var/log/journal

2014-06-18 Thread Dr. Werner Fink
On Mon, Jun 16, 2014 at 11:10:15AM -0400, Cristian Rodríguez wrote: > El 13/06/14 10:41, Werner Fink escribió: > > That is: set NOATIME, NOCOW, and NOCOMP for the journal directory > > > > --- > > src/journal/journald-server.c | 29 +++-- > > 1 file changed, 27 insertion