[systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel command line.

2014-11-05 Thread Richard W.M. Jones
--- src/udev/udevd.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 193702c..340812b 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -968,6 +968,7 @@ static void kernel_cmdline_options(struct udev

[systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel

2014-11-05 Thread Richard W.M. Jones
This avoids the hard-coded string offsets by using strlen. It's a bit of a strange coding style. Mainly I was interested to see if gcc could optimize this, and (gcc-4.9.2 / x86-64 / -O2) it did - all calls to strlen are removed from the assembly and replaced by constants. When I compile systemd

Re: [systemd-devel] [question] networkd: Any support for hooks?

2014-11-05 Thread Lennart Poettering
On Tue, 04.11.14 14:48, Dan Williams (d...@redhat.com) wrote: Can you be more specific what precisely you intend to hook in there? I'd really prefer if we could find different solutions for the common usecases. Example: I'd like to add interface to proper firewalld zone.

Re: [systemd-devel] systemd-nspawn - exporting /dev/video0

2014-11-05 Thread Lennart Poettering
On Tue, 04.11.14 23:43, MohanR (mohan...@gmail.com) wrote: Hi, I'm in need to passthrough /dev/video0 for a gstreamer based application development. Is it possible using systemd-nspawn? I tried enabling CAP_MKNOD and manually creating /dev/video0. But it was not recognized. Is there any

Re: [systemd-devel] [RFC] [PATCH] cgroup: don't trim cgroup trees created by someone else

2014-11-05 Thread Lennart Poettering
On Mon, 03.11.14 17:27, Michal Sekletar (msekl...@redhat.com) wrote: On Tue, Oct 21, 2014 at 09:16:16PM +0200, Lennart Poettering wrote: On Fri, 19.09.14 17:14, Michal Sekletar (msekl...@redhat.com) wrote: snip I do see the usecase though for those projects. I'd probably suggest not

Re: [systemd-devel] instantiated services set up

2014-11-05 Thread Lennart Poettering
On Tue, 04.11.14 21:42, Tomasz Torcz (to...@pipebreaker.pl) wrote: On Tue, Nov 04, 2014 at 08:56:48PM +0100, Jan Včelák wrote: Hi! OK. I will remove the syslog. But I will have to keep network.target for now as we support non-Linux systems as well. Adding support for rtnl or

Re: [systemd-devel] [PATCH] buildsys: test-util needs -lm for fabs()

2014-11-05 Thread David Herrmann
Hi On Wed, Nov 5, 2014 at 12:48 AM, Cristian Rodríguez crrodrig...@opensuse.org wrote: --- Makefile.am | 1 + 1 file changed, 1 insertion(+) Looks good, applied! Thanks David diff --git a/Makefile.am b/Makefile.am index ff5f61b..3686103 100644 --- a/Makefile.am +++ b/Makefile.am @@

Re: [systemd-devel] [PATCH v2] udev: Fix parsing of udev.event-timeout kernel parameter.

2014-11-05 Thread David Herrmann
Hi On Wed, Nov 5, 2014 at 12:45 AM, Richard W.M. Jones rjo...@redhat.com wrote: --- src/udev/udevd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied! Thanks David diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 2e6c713..193702c 100644 --- a/src/udev/udevd.c +++

Re: [systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel command line.

2014-11-05 Thread David Herrmann
Hi On Wed, Nov 5, 2014 at 10:16 AM, Richard W.M. Jones rjo...@redhat.com wrote: --- src/udev/udevd.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 193702c..340812b 100644 --- a/src/udev/udevd.c +++

Re: [systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel command line.

2014-11-05 Thread Richard W.M. Jones
On Wed, Nov 05, 2014 at 12:54:21PM +0100, David Herrmann wrote: Hi On Wed, Nov 5, 2014 at 10:16 AM, Richard W.M. Jones rjo...@redhat.com wrote: --- src/udev/udevd.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/udev/udevd.c

[systemd-devel] Rationale for mirroring cpu and systemd cgroup subsystems

2014-11-05 Thread Umut Tezduyar Lindskog
Hi, What is the reasoning for not joining cpu subsystem with systemd subsystem? There are couple ways you can mirror [1] cpu and systemd subsystems and doing so can result completely different cpu bandwidth for processes. I am wondering why we don't mirror them by default. Not mirroring them

Re: [systemd-devel] Put user@.service cgroups into all controllers (user LXC)

2014-11-05 Thread Lennart Poettering
On Mon, 03.11.14 16:25, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello all, LXC upstream (in CC:) supports unprivileged containers, i. e. you can create a rootfs in your $HOME and then run lxc-start on it with some initial preparation [1]. While of course they have some limits, they are

Re: [systemd-devel] Rationale for mirroring cpu and systemd cgroup subsystems

2014-11-05 Thread Lennart Poettering
On Wed, 05.11.14 13:41, Umut Tezduyar Lindskog (u...@tezduyar.com) wrote: Hi, What is the reasoning for not joining cpu subsystem with systemd subsystem? There are couple ways you can mirror [1] cpu and systemd subsystems and doing so can result completely different cpu bandwidth for

[systemd-devel] [PATCH] login: rerun vconsole-setup when switching from vgacon to fbcon

2014-11-05 Thread Ray Strode
From: Ray Strode rstr...@redhat.com The initialization performed by systemd-vconsole-setup is reset when changing console drivers (say from vgacon to fbcon), so we need to run it in that case. See http://lists.freedesktop.org/archives/systemd-devel/2014-October/023919.html

Re: [systemd-devel] [PATCH] login: rerun vconsole-setup when switching from vgacon to fbcon

2014-11-05 Thread David Herrmann
Hi Ray On Wed, Nov 5, 2014 at 2:30 PM, Ray Strode halfl...@gmail.com wrote: From: Ray Strode rstr...@redhat.com The initialization performed by systemd-vconsole-setup is reset when changing console drivers (say from vgacon to fbcon), so we need to run it in that case. See

Re: [systemd-devel] [PATCH] login: rerun vconsole-setup when switching from vgacon to fbcon

2014-11-05 Thread Lennart Poettering
On Wed, 05.11.14 14:43, David Herrmann (dh.herrm...@gmail.com) wrote: TAG==uaccess, SUBSYSTEM!=sound, TAG+=seat SUBSYSTEM==sound, KERNEL==card*, TAG+=seat SUBSYSTEM==input, KERNEL==input*, TAG+=seat SUBSYSTEM==graphics, KERNEL==fb[0-9]*, TAG+=seat, TAG+=master-of-seat

[systemd-devel] [PATCH] s/commandline/command line/g

2014-11-05 Thread harald
From: Harald Hoyer har...@redhat.com --- TODO | 2 +- m4/attributes.m4 | 2 +- man/systemd-bootchart.xml | 4 ++-- man/systemd-delta.xml | 2 +- man/systemd-run.xml| 2 +-

[systemd-devel] [PATCH] rules: rerun vconsole-setup when switching from vgacon to fbcon

2014-11-05 Thread Ray Strode
From: Ray Strode rstr...@redhat.com The initialization performed by systemd-vconsole-setup is reset when changing console drivers (say from vgacon to fbcon), so we need to run it in that case. See http://lists.freedesktop.org/archives/systemd-devel/2014-October/023919.html

Re: [systemd-devel] [PATCH] manager: Ensure user's systemd runtime directory exists.

2014-11-05 Thread Colin Guthrie
Colin Guthrie wrote on 03/11/14 08:02: Zbigniew Jędrzejewski-Szmek wrote on 02/11/14 18:18: On Sun, Nov 02, 2014 at 02:04:20PM +, Colin Guthrie wrote: This mirrors code in dbus.c when creating the private socket and avoids error messages like: systemd[1353]:

Re: [systemd-devel] [PATCH] rules: rerun vconsole-setup when switching from vgacon to fbcon

2014-11-05 Thread David Herrmann
Hi Ray On Wed, Nov 5, 2014 at 3:48 PM, Ray Strode halfl...@gmail.com wrote: From: Ray Strode rstr...@redhat.com The initialization performed by systemd-vconsole-setup is reset when changing console drivers (say from vgacon to fbcon), so we need to run it in that case. See

Re: [systemd-devel] Rationale for mirroring cpu and systemd cgroup subsystems

2014-11-05 Thread Umut Tezduyar Lindskog
On Wed, Nov 5, 2014 at 2:05 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 05.11.14 13:41, Umut Tezduyar Lindskog (u...@tezduyar.com) wrote: Hi, What is the reasoning for not joining cpu subsystem with systemd subsystem? There are couple ways you can mirror [1] cpu and systemd

[systemd-devel] [PATCH] bus-proxy: --clone-smack-label option

2014-11-05 Thread Przemyslaw Kedzierski
This patch adds a '--clone-smack-label' option to systemd-bus-proxyd. When dbus client connects to systemd-bus-proxyd through Unix domain socket and this option is enabled proxy takes client's smack label and sets for itself. It is done before and independent of dropping privileges. The reason

Re: [systemd-devel] [PATCH] rules: rerun vconsole-setup when switching from vgacon to fbcon

2014-11-05 Thread Ray Strode
Hi, On Wed, Nov 5, 2014 at 9:53 AM, David Herrmann dh.herrm...@gmail.com wrote: I had that change locally, but didn't push it because vconsole is optional. Thus, this rule must be optional, too. I'm now digging into autoconf+m4 to see how to do this... but I'm getting nowhere so far... Well

Re: [systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-11-05 Thread Colin Guthrie
Hiya, Martin Pitt wrote on 28/10/14 11:18: @@ -275,30 +281,43 @@ _public_ struct udev_hwdb *udev_hwdb_new(struct udev *udev) { hwdb-refcount = 1; udev_list_init(udev, hwdb-properties_list, true); -hwdb-f = fopen(/etc/udev/hwdb.bin, re); +/* find

Re: [systemd-devel] systemd presentation slides?

2014-11-05 Thread Colin Guthrie
Tom Gundersen wrote on 28/10/14 10:40: Hi Mihamina, On Tue, Oct 28, 2014 at 11:06 AM, Mihamina Rakotomandimby mihamina.rakotomandi...@rktmb.org wrote: Would you have some bookmarks of some slide presenting systemd? We try to gather all such resources here:

[systemd-devel] Udev rules hardware database

2014-11-05 Thread Patrick Häcker
Dear all, sorry if this list is not the correct one for my post. In this case please just point me to the correct list. I you want to have permanent power saving activated for your devices, the recommended way is to use udev (e.g.

Re: [systemd-devel] [PATCH] bus-proxy: --clone-smack-label option

2014-11-05 Thread Lennart Poettering
On Wed, 05.11.14 16:08, Przemyslaw Kedzierski (p.kedzier...@samsung.com) wrote: This patch adds a '--clone-smack-label' option to systemd-bus-proxyd. When dbus client connects to systemd-bus-proxyd through Unix domain socket and this option is enabled proxy takes client's smack label and sets

Re: [systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-11-05 Thread Martin Pitt
Hey Colin, Colin Guthrie [2014-11-05 15:30 +]: While it's a nice error message, I wonder if it should be reverted back to being dbg again for the initrd use case or perhaps some other mechanism could be used to suppress the error in that case? Oh indeed, I didn't consider that this would

[systemd-devel] [PATCH] hostnamed: add chassis type robot

2014-11-05 Thread Noé Rubinstein
--- man/hostnamectl.xml | 3 ++- man/machine-info.xml | 3 ++- shell-completion/bash/hostnamectl | 2 +- shell-completion/zsh/_hostnamectl | 2 +- src/hostname/hostnamed.c | 3 ++- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git

Re: [systemd-devel] [RFC] [PATCH] cgroup: don't trim cgroup trees created by someone else

2014-11-05 Thread Lennart Poettering
On Wed, 05.11.14 12:27, Lennart Poettering (mzerq...@0pointer.de) wrote: it doesn't seem to be correct solution either. systemd will happily remove cgroup in which there are processes. Oh. right, systemd is stricter there than I remembered: we will actually migrate the PIDs before

Re: [systemd-devel] Rationale for mirroring cpu and systemd cgroup subsystems

2014-11-05 Thread Lennart Poettering
On Wed, 05.11.14 16:00, Umut Tezduyar Lindskog (u...@tezduyar.com) wrote: On Wed, Nov 5, 2014 at 2:05 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 05.11.14 13:41, Umut Tezduyar Lindskog (u...@tezduyar.com) wrote: Hi, What is the reasoning for not joining cpu subsystem

Re: [systemd-devel] systemd-machined sigterm, cgroups trimmed

2014-11-05 Thread Major Hayden
Apologize for the self-reply, but upgrading to dbus-1.8.6 seems to have fixed the cgroup trimming issue. However, systemd-machined still gets a sigterm within a minute or two after a VM starts. For what it's worth, throwing a loop in bash that calls machinectl every 10 seconds will keep

Re: [systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

2014-11-05 Thread Colin Guthrie
Martin Pitt wrote on 05/11/14 17:04: Hey Colin, Colin Guthrie [2014-11-05 15:30 +]: While it's a nice error message, I wonder if it should be reverted back to being dbg again for the initrd use case or perhaps some other mechanism could be used to suppress the error in that case? Oh

Re: [systemd-devel] systemd-machined sigterm, cgroups trimmed

2014-11-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Nov 04, 2014 at 08:38:51AM -0600, Major Hayden wrote: Hello there, I'm currently running systemd 216 on Fedora 21 and I've found an issue where systemd-machined stops running and cgroups are trimmed from the scope of running qemu virtual machines. The series of events looks like

Re: [systemd-devel] [systemd-commits] units/basic.target units/poweroff.target units/reboot.target

2014-11-05 Thread Lennart Poettering
On Wed, 05.11.14 17:46, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: Ahum. This needs more discussion. units: disable job timeouts For boot, we might kill fsck in the middle, with likely catastrophic consequences. This I can agree with for now.

Re: [systemd-devel] Udev rules hardware database

2014-11-05 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Nov 05, 2014 at 04:55:52PM +0100, Patrick Häcker wrote: - If not, is udev the correct piece in the Linux stack to put this? Most likely the kernel should do this by itself. What where the devices that you had to disable power saving on? - What is the general way to contribute udev

Re: [systemd-devel] [PATCH] hostnamed: add chassis type robot

2014-11-05 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Nov 05, 2014 at 06:40:51PM +0100, Noé Rubinstein wrote: --- man/hostnamectl.xml | 3 ++- man/machine-info.xml | 3 ++- shell-completion/bash/hostnamectl | 2 +- shell-completion/zsh/_hostnamectl | 2 +- src/hostname/hostnamed.c | 3 ++- 5 files

Re: [systemd-devel] [systemd-commits] units/basic.target units/poweroff.target units/reboot.target

2014-11-05 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 06, 2014 at 03:22:09AM +0100, Lennart Poettering wrote: On Wed, 05.11.14 17:46, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: Ahum. This needs more discussion. units: disable job timeouts For boot, we might kill fsck in the middle,