Re: [systemd-devel] [PATCH v2] smack: introduce new SmackLabelAccess option

2014-11-23 Thread WaLyong Cho
On 11/24/2014 02:36 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Nov 21, 2014 at 03:16:01PM +0900, WaLyong Cho wrote: >> In case of systemd has "_" label and run as root, if a service file >> has "User=" option and the command line file has a special SMACK label >> then systemd will fail to acc

Re: [systemd-devel] serialization bug, swap bug, etc.

2014-11-23 Thread Mantas Mikulėnas
On Mon, Nov 24, 2014 at 2:59 AM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Thu, Nov 20, 2014 at 09:13:02AM +0200, Mantas Mikulėnas wrote: > > ~ If there are two .swap units for the same partition (one made by > > fstab-generator, another by gpt-generator), systemd tries to swapon

[systemd-devel] [PATCH v2 1/5] mount: use libmount to enumerate /proc/self/mountinfo

2014-11-23 Thread Chris Leech
This lets libmount add in user options from /run/mount/utab, like _netdev which is needed to get proper ordering against remote-fs.target Signed-off-by: Chris Leech --- .travis.yml | 2 +- Makefile.am | 4 +++- README | 1 + configure.ac | 10 + src/core/build.

[systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-11-23 Thread Chris Leech
This adds auto detection for iSCSI and some FCoE drivers and treats mounts to file-systems on those devices as remote-fs. Signed-off-by: Chris Leech --- src/core/mount.c | 168 +++ 1 file changed, 158 insertions(+), 10 deletions(-) diff --git

[systemd-devel] [PATCH v2 0/5] mount unit handling improvments with libmount

2014-11-23 Thread Chris Leech
This patch set is an attempt to use libmount for mount unit handling, in order to address the issues I raised with the _netdev option and remote-fs ordering not working as expected. In addition, given the feedback on my previous posting I went ahead and implemented auto-detection of iSCSI and the

[systemd-devel] [PATCH v2 4/5] mount: add remote-fs dependencies if needed after change

2014-11-23 Thread Chris Leech
This is an attempt to add it the remote-fs dependencies to a mount unit if the options change, like when the utab options are picked up after mountinfo has already been processed. It just adds the remote-fs dependencies, leaving the local-fs ones in place. With this change I always get mount unit

[systemd-devel] [PATCH v2 3/5] mount: monitor for utab changes with inotify

2014-11-23 Thread Chris Leech
Parsing the mount table with libmount races against the mount command, which will handle the actual mounting before updating utab. This means the poll event on /proc/self/mountinfo can kick of a reparse in systemd before the utab information is available. This change adds in an additional event s

[systemd-devel] [PATCH v2 2/5] mount: check options as well as fstype for network mounts

2014-11-23 Thread Chris Leech
When creating a new mount unit after an event on /proc/self/mountinfo, check the mount options as well as the fstype to determine if this is a remote mount that requires network access. Signed-off-by: Chris Leech --- src/core/mount.c | 21 - 1 file changed, 12 insertions(+),

Re: [systemd-devel] serialization bug, swap bug, etc.

2014-11-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 20, 2014 at 09:13:02AM +0200, Mantas Mikulėnas wrote: > ~ I'm getting this on every reload: > > systemd[1]: Unknown serialization item 'subscribed=:1.1' Lukas' patch should fix that. > Doesn't seem to break anything though. > > ~ I'm also getting this on every reload: > > systemd[1]

Re: [systemd-devel] [PATCH] dbus: return non-zero return value in the case that prefix won't match

2014-11-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 20, 2014 at 04:06:18PM +0100, Lukas Nykryn wrote: > strv_extend returns 0 in the case of success which means that > else if (bus_track_deserialize_item(&m->deserialized_subscribed, l) == 0) > log_warning("Unknown serialization item '%s'", l); > will be printed when value is adde

Re: [systemd-devel] systemd-run checks path on host before running on container

2014-11-23 Thread Peter Hutterer
On Sun, Nov 23, 2014 at 02:40:29AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Nov 23, 2014 at 12:14:32AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Sat, Nov 22, 2014 at 02:47:49PM +0100, David Herrmann wrote: > > > Hi > > > > > > On Fri, Nov 21, 2014 at 5:00 AM, Peter Hutterer > > >

Re: [systemd-devel] [PATCH v2 0/2] Empty environment variables in unit files work

2014-11-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 20, 2014 at 09:18:22PM +0100, Iago López Galeiras wrote: > Clarified commit message (thanks Koen Kooi) > > Iago López Galeiras (2): > test: support empty environment variables in unit files > update TODO > > TODO | 2 -- > src/test/test-unit-file.c | 22

Re: [systemd-devel] [PATCH v2] smack: introduce new SmackLabelAccess option

2014-11-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 21, 2014 at 03:16:01PM +0900, WaLyong Cho wrote: > In case of systemd has "_" label and run as root, if a service file > has "User=" option and the command line file has a special SMACK label > then systemd will fail to access to given file. SMACK label is ignored > for root uid process

Re: [systemd-devel] [PATCH 2/2] networkd: integrate LLDP

2014-11-23 Thread Tom Gundersen
On Sun, Nov 23, 2014 at 1:31 PM, Mantas Mikulėnas wrote: > On Sun, Nov 23, 2014 at 1:01 PM, Tomasz Torcz wrote: >> >> On Sun, Nov 23, 2014 at 10:15:10AM +0530, Susant Sahani wrote: >> > This patch integrates LLDP with networkd. >> >> In Fedora, we already have LLDP receiver/broadcaster – ladvd.

Re: [systemd-devel] [PATCH 2/2] networkd: integrate LLDP

2014-11-23 Thread Tom Gundersen
On Sun, Nov 23, 2014 at 12:01 PM, Tomasz Torcz wrote: > On Sun, Nov 23, 2014 at 10:15:10AM +0530, Susant Sahani wrote: >> This patch integrates LLDP with networkd. > > In Fedora, we already have LLDP receiver/broadcaster – ladvd. > It has this neat feature of abusing ifAlias by putting endpoint

Re: [systemd-devel] [PATCH 2/2] networkd: integrate LLDP

2014-11-23 Thread Mantas Mikulėnas
On Sun, Nov 23, 2014 at 1:01 PM, Tomasz Torcz wrote: > On Sun, Nov 23, 2014 at 10:15:10AM +0530, Susant Sahani wrote: > > This patch integrates LLDP with networkd. > > In Fedora, we already have LLDP receiver/broadcaster – ladvd. > It has this neat feature of abusing ifAlias by putting endpoint

Re: [systemd-devel] systemctl list-dependencies: consider "BindsTo" as well?

2014-11-23 Thread Peter Mattern
Thanks for fixing this. May I suggest to adjust man systemctl accordingly, too? Necessary parts would be the one about option --reverse and command list-dependencies. As for the latter I'd suggest another change while you're at it. Phrase "required and wanted units" is rather ambiguous as it mi

Re: [systemd-devel] [PATCH 2/2] networkd: integrate LLDP

2014-11-23 Thread Tomasz Torcz
On Sun, Nov 23, 2014 at 10:15:10AM +0530, Susant Sahani wrote: > This patch integrates LLDP with networkd. In Fedora, we already have LLDP receiver/broadcaster – ladvd. It has this neat feature of abusing ifAlias by putting endpoint name there. This gives port information right at "ip l" output

Re: [systemd-devel] [BUG] too many rfkill services

2014-11-23 Thread Andrei Borzenkov
В Fri, 21 Nov 2014 01:26:36 +0100 Lennart Poettering пишет: > On Thu, 20.11.14 19:56, Lukasz Stelmach (stl...@poczta.fm) wrote: > > > I talked to the kernel guys at my office and they told me that it is > > quite usual (at least for USB devices, and my wlan and bt are USB) > > that devices are s