[systemd-devel] [PATCH] importd: add CAP_DAC_OVERRIDE capability

2015-04-13 Thread Lubomir Rintel
Fedora's filesystem package ships /usr/bin (and other directories) which are not writable by its owner. machinectl pull-dkr (and possibly others) are not able to extract those: 14182 mkdirat(3, usr, 0700) = 0 14182 mkdirat(3, usr/bin, 0500) = 0 14182 openat(3, usr/bin/[,

Re: [systemd-devel] issuing 'reboot' command does not print the familiar 'Restarting system.' message

2015-04-13 Thread Ani Sinha
On Sun, Apr 12, 2015 at 6:46 AM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 10.04.15 12:35, Ani Sinha (a...@arista.com) wrote: On Fri, Apr 10, 2015 at 10:18 AM, Ani Sinha a...@arista.com wrote: Thanks Lennart for the clarification. Much appreciated! Ani On Fri, Apr 10,

Re: [systemd-devel] [PATCH v2 1/2] input_id: Make test_pointer / test_keys return if they've found anything

2015-04-13 Thread Peter Hutterer
On Mon, Apr 13, 2015 at 03:08:53PM +0200, Hans de Goede wrote: Hi, On 13-04-15 14:41, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Apr 13, 2015 at 11:15:00AM +0200, Hans de Goede wrote: Make test_pointer / test_keys return a boolean indicating whether or not they've set any properties on the

Re: [systemd-devel] [PATCH] journal: Introduce journal-syslogd

2015-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 10, 2015 at 12:45:34PM +0200, Lennart Poettering wrote: On Thu, 09.04.15 23:43, Susant Sahani (sus...@redhat.com) wrote: This tiny daemon enables to pull journal entries and push to a UDP multicast address in syslog RFC 5424 format. systemd-journal-syslogd runs with own

Re: [systemd-devel] [PATCH] journal: Introduce journal-syslogd

2015-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Apr 09, 2015 at 11:43:15PM +0530, Susant Sahani wrote: This tiny daemon enables to pull journal entries and push to a UDP multicast address in syslog RFC 5424 format. systemd-journal-syslogd runs with own user systemd-journal-syslog. It starts running after the network is up. V2:

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-13 Thread Dimitri John Ledkov
On 11 April 2015 at 13:41, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Apr 10, 2015 at 03:17:37PM +0300, Tomasz Bursztyka wrote: Hi, As it has been discussed in the systemd hackfest during the Linux Conference Europe, one daemon could centralize the management of all network

Re: [systemd-devel] [PATCH] network: allow domain names up to 255 characters

2015-04-13 Thread Nick Owens
sorry, supercalifragilisticexpialidocioussupercalifragilisticexpialidocious was a bad example. it would not be valid since it is longer than a label. On Sun, Apr 12, 2015 at 9:37 AM, Lennart Poettering lenn...@poettering.net wrote: On Sun, 12.04.15 09:21, Nick Owens (misch...@offblast.org)

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 13, 2015 at 09:51:05AM -0700, Marcel Holtmann wrote: Hi Zbyszek, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ +

Re: [systemd-devel] 'is-enabled' supported for legacy sysvinit scripts?

2015-04-13 Thread Nusenu
thanks for your reply. systemctl should still support it if your system supports chkconfig to manage initscripts. chkconfig was indeed not installed, but even after installing it, the is-enabled command output and return codes do not change: Output in such cases: Failed to get unit

Re: [systemd-devel] [PATCH 5/6] network: fix strict aliasing issue

2015-04-13 Thread Lennart Poettering
On Sun, 12.04.15 18:32, Shawn Landden (sh...@churchofgit.com) wrote: On Sun, Apr 12, 2015 at 12:43 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 11.03.15 08:13, Shawn Landden (sh...@churchofgit.com) wrote: We shouldn't assume 64-bit arch with the way we do math either.

[systemd-devel] [PATCH v2 1/2] input_id: Make test_pointer / test_keys return if they've found anything

2015-04-13 Thread Hans de Goede
Make test_pointer / test_keys return a boolean indicating whether or not they've set any properties on the device. While touching allmost all test_bit() using lines anyways also remove the extra space between the function name and the '(' (coding style issue). Signed-off-by: Hans de Goede

[systemd-devel] [PATCH v2 2/2] input_id: Identify scroll-wheel device on Trust TB7300 tablet as keyboard

2015-04-13 Thread Hans de Goede
The Trust TB7300 (relabelled Waltop?) tablet has a scrollwheel which shows up as a /dev/input/event# node all by itself. Currently input_id does not set any ID_INPUT_FOO attr on this causing it it to not be recognized by Xorg / libinput. This commit fixes this by marking it with ID_INPUT_KEY.

Re: [systemd-devel] [PATCH v2] efi-boot-generator: Continue if /boot does not exist

2015-04-13 Thread Tobias Hunger
Hi Zbigniew, thanks for merging my rumblings. I was thinking about merging those lines, but at this point I really do not feel comfortable enough to change code just to make it look better to me:-) Maybe a few patches down the line I'll get to that point. Now I just need to wait for a systemd

Re: [systemd-devel] Check if systems is container in systemd-remount-fs.service

2015-04-13 Thread Lennart Poettering
On Mon, 13.04.15 02:31, Ivan Shapovalov (intelfx...@gmail.com) wrote: On 2015-04-09 at 10:04 +0200, Lennart Poettering wrote: [...] Also, current versions of fstab-generator skip device entries in containers anyway, so I am not sure how you even managed to generate an error in this case,

Re: [systemd-devel] 'is-enabled' supported for legacy sysvinit scripts?

2015-04-13 Thread Nusenu
Hi Andrei, thanks for your reply. systemctl should still support it if your system supports chkconfig to manage initscripts. chkconfig was indeed not installed, but even after installing it, the is-enabled command output and return codes do not change: Output in such cases: Failed to get

Re: [systemd-devel] [PATCH 2/4] Allow systemd-tmpfiles to set the file/directory attributes

2015-04-13 Thread Lennart Poettering
On Sun, 12.04.15 22:19, Goffredo Baroncelli (kreij...@libero.it) wrote: However the original code catch also the case where the file is a soft-link. The same check is performed also by chattr(1); I suggest to leave the original behavior, changing fd = open(path,

Re: [systemd-devel] [RFC 1/6] proxy-discoveryd: Basic core added

2015-04-13 Thread Tomasz Bursztyka
Hi Lennart, + +[Unit] +Description=Proxy service +DefaultDependencies=no Hmm, should this really be an early-boot service? Can you explain? That's a mistake indeed. +Requires=dbus.socket +After=dbus.socket +Before=remote-fs.target Which this dependency? Took that quickly from

Re: [systemd-devel] [RFC 1/6] proxy-discoveryd: Basic core added

2015-04-13 Thread Tomasz Bursztyka
Hi Tom, +int manager_new(Manager **ret); +Manager *manager_free(Manager *m); + +DEFINE_TRIVIAL_CLEANUP_FUNC(Manager*, manager_free); +#define _cleanup_manager_free_ _cleanup_(manager_freep) We generally try to avoid this define in internal code, and just use _cleanup_(manager_freep) inline.

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Tomasz Bursztyka
Le 10/04/2015 18:49, Lennart Poettering a écrit : On Fri, 10.04.15 15:17, Tomasz Bursztyka (tomasz.burszt...@linux.intel.com) wrote: +struct PAC { +duk_context *ctx; +}; + +static int get_addresses_from_interface(int ifindex, union in_addr_union *address) { +struct ifreq ifr

Re: [systemd-devel] dbus-1/kdbus - question about 'queued owners'

2015-04-13 Thread Lukasz Skalski
On 04/13/2015 01:46 PM, Daniel Mack wrote: Hi Lukasz, Hi, [+dbus ML] On 04/10/2015 04:20 PM, Lukasz Skalski wrote: Currently I'm working on some testsuite (let's call it dbus1-spec-test) for dbus-1 specification. My idea is to test dbus-1 specification coverage on systems with

Re: [systemd-devel] [RFC 1/6] proxy-discoveryd: Basic core added

2015-04-13 Thread Tom Gundersen
On Mon, Apr 13, 2015 at 12:05 PM, Tomasz Bursztyka tomasz.burszt...@linux.intel.com wrote: +int manager_new(Manager **ret); +Manager *manager_free(Manager *m); + +DEFINE_TRIVIAL_CLEANUP_FUNC(Manager*, manager_free); +#define _cleanup_manager_free_ _cleanup_(manager_freep) We generally try

Re: [systemd-devel] [RFC 5/6] proxy-discoveryd: Add the basic parts for handling DBus methods

2015-04-13 Thread Tomasz Bursztyka
Hi Lennart, Hmm, is this right? Shouldn't we return the error code to the client instead of eating up and returning DIRECT? Also, why allocate DIRECT with strdup() at all? There are no errors. Either you get a proxy directive or you return DIRECT to indicate no proxy. What would you do in an

Re: [systemd-devel] [RFC 2/6] proxy-discoveryd: Add the basics for parsing the default configuration

2015-04-13 Thread Tomasz Bursztyka
Hi Marcel and Lennart, The config file will be in /etc/systemd/proxy/filename.conf It currently only load Proxy parts, with the key PAC. Rest is ignored. The PAC keyword is a path to a .pac file (a specific js script for proxy configuration). Only one PAC based proxy configuration will be

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Tomasz Bursztyka
Hi Tom, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ + src/proxy-discovery/duktape.c \ These files are not included in the patch, how

Re: [systemd-devel] issuing 'reboot' command does not print the familiar 'Restarting system.' message

2015-04-13 Thread Daniel Mack
On 04/12/2015 03:46 PM, Lennart Poettering wrote: On Fri, Apr 10, 2015 at 10:18 AM, Ani Sinha a...@arista.com wrote: OK I see it now. shutdownd.c eventually issues 'shutdown -r now'. This gets parsed by shutdown_parse_argv(). Eventually we end up calling halt_main() -halt_now()

Re: [systemd-devel] [RFC 4/6] proxy-discoveryd: Execute the PAC based proxy in a thread

2015-04-13 Thread Tomasz Bursztyka
Hi Lennart and Marcel, I'll stick to the thread solution for now, moving the dbus handling in the main process. I forgot to check about this issue. We could have a timeout in the pac runtime, so it would cancel the duktape context relevantly, so no need to track the threads from the main

[systemd-devel] [PATCH] [RFC] umount: reduce verbosity

2015-04-13 Thread Alban Crequy
From: Alban Crequy al...@endocode.com When a systemd-nspawn container terminates, systemd umounts all bind mounts that were mounted in the container and generates a log for each umount. This additional log_info was added by bce93b7ac7642426039863493694d8c12812e2a7 for debugging shutdown. But

Re: [systemd-devel] dbus-1/kdbus - question about 'queued owners'

2015-04-13 Thread Daniel Mack
Hi Lukasz, [+dbus ML] On 04/10/2015 04:20 PM, Lukasz Skalski wrote: Currently I'm working on some testsuite (let's call it dbus1-spec-test) for dbus-1 specification. My idea is to test dbus-1 specification coverage on systems with dbus-daemon and on systems without dbus-daemon (but with

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-13 Thread Tomasz Bursztyka
Hi, Have you looked into MuJS instead of duktape? http://mujs.com/ It has a C api similar to Lua, with all state encapsulated in an opaque structure, that you interface with via a virtual stack. It could be easily tested. I did so the PAC related code is contained in a specific place,

[systemd-devel] systemd.network and IPv6 addrlabel

2015-04-13 Thread Christian Brunotte
Hello I'm playing around with systemd's network configuration and try to convert the following Debian configuration. iface eth1 inet6 auto # Static IP and random dynamic IPs for external targets autoconf 1 use_tempaddr 2 privext 1 # My static IP up ip addr add

Re: [systemd-devel] [PATCH 2/2] udev: Allow detection of udevadm settle timeout

2015-04-13 Thread Nir Soffer
On Sat, Apr 11, 2015 at 6:58 PM, David Herrmann dh.herrm...@gmail.com wrote: A program running this tool can detect a timeout (expected) or an error (unexpected), and can change the program flow based on this result. Without this, the only way to detect a timeout is to implement the timeout

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 13, 2015 at 01:24:57PM +0300, Tomasz Bursztyka wrote: Hi Tom, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ +

Re: [systemd-devel] [PATCH 2/4] Allow systemd-tmpfiles to set the file/directory attributes

2015-04-13 Thread Lennart Poettering
On Mon, 13.04.15 11:31, Lennart Poettering (lenn...@poettering.net) wrote: On Sun, 12.04.15 22:19, Goffredo Baroncelli (kreij...@libero.it) wrote: However the original code catch also the case where the file is a soft-link. The same check is performed also by chattr(1); I suggest to leave

Re: [systemd-devel] SystemD, Gnome permission problems

2015-04-13 Thread Lennart Poettering
On Mon, 13.04.15 02:37, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Now, of these the first item is a work-around for broken daemons, and this should really be better fixed in the daemons themselves. A daemon that does not require tmpfiles is a good daemon. The third item is a

Re: [systemd-devel] 'is-enabled' supported for legacy sysvinit scripts?

2015-04-13 Thread Lennart Poettering
On Sun, 12.04.15 21:00, Nusenu (nus...@openmailbox.org) wrote: Hi, I'm trying to find out whether I'm looking at an ansible or systemctl bug. Does systemctl aim to support the 'is-enabled' command for legacy sysv initscripts? On Fedora, when systemctl encounters a sysv service it

Re: [systemd-devel] [PATCH] journal: don't complain about audit socket errors in a container.

2015-04-13 Thread Lennart Poettering
On Sun, 12.04.15 20:51, frank.thalb...@tuta.io (frank.thalb...@tuta.io) wrote: This fixes an issue within journald aborting when running inside archlinux container via systemd-nspawn on a debian host with audit enabled kernel. What kind of containers are these? LXC? docker? nspawn at least

Re: [systemd-devel] [PATCH] udevd: fix synchronization with settle when handling inotify events

2015-04-13 Thread Daniel Drake
On Sat, Apr 11, 2015 at 5:13 AM, David Herrmann dh.herrm...@gmail.com wrote: Nice catch! There's indeed a small race between handling inotify and queuing up the change-event. We need to re-loop there. One day we should switch to sd-event to avoid such bugs... I mean the symptom is inherent to

Re: [systemd-devel] [PATCH 2/2] Add +C attrib to the journal files directories

2015-04-13 Thread Lennart Poettering
On Sun, 12.04.15 20:30, Goffredo Baroncelli (kreij...@libero.it) wrote: From: Goffredo Baroncelli kreij...@inwind.it Add +C attrib to the journal files directories. The journal file format behaves bad on a BTRFS filesystem: the performances decrease during the time. To avoid this issue,

Re: [systemd-devel] [RFC 4/6] proxy-discoveryd: Execute the PAC based proxy in a thread

2015-04-13 Thread Lennart Poettering
On Mon, 13.04.15 14:37, Tomasz Bursztyka (tomasz.burszt...@linux.intel.com) wrote: Hi Lennart and Marcel, I'll stick to the thread solution for now, moving the dbus handling in the main process. I forgot to check about this issue. I think the cancellation issue should not be ignored.

Re: [systemd-devel] 'is-enabled' supported for legacy sysvinit scripts?

2015-04-13 Thread Martin Pitt
Jon Severinsson [2015-04-13 15:18 +0200]: Debian patches the systemd legacy sysv support to use update-rc.d (the Debian- native equivalent) instead of chkconfig, but update-rc.d does not have a is- enabled feature, so is-enabled will not work on legacy init scripts in the Debian build of

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-13 Thread Marcel Holtmann
Hi Tomasz, Have you looked into MuJS instead of duktape? http://mujs.com/ It has a C api similar to Lua, with all state encapsulated in an opaque structure, that you interface with via a virtual stack. It could be easily tested. I did so the PAC related code is contained in a specific

Re: [systemd-devel] [PATCH v2 1/2] input_id: Make test_pointer / test_keys return if they've found anything

2015-04-13 Thread Hans de Goede
Hi, On 13-04-15 14:41, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Apr 13, 2015 at 11:15:00AM +0200, Hans de Goede wrote: Make test_pointer / test_keys return a boolean indicating whether or not they've set any properties on the device. While touching allmost all test_bit() using lines anyways

Re: [systemd-devel] 'is-enabled' supported for legacy sysvinit scripts?

2015-04-13 Thread Jon Severinsson
måndagen den 13 april 2015 07:26:14 skrev Nusenu: Hi Andrei, thanks for your reply. systemctl should still support it if your system supports chkconfig to manage initscripts. chkconfig was indeed not installed, but even after installing it, the is-enabled command output and return

Re: [systemd-devel] [PATCH v2 1/2] input_id: Make test_pointer / test_keys return if they've found anything

2015-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 13, 2015 at 11:15:00AM +0200, Hans de Goede wrote: Make test_pointer / test_keys return a boolean indicating whether or not they've set any properties on the device. While touching allmost all test_bit() using lines anyways also remove the extra space between the function name

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 13, 2015 at 08:43:32AM -0700, Marcel Holtmann wrote: Hi Zbyszek, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ +

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Marcel Holtmann
Hi Zbyszek, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ + src/proxy-discovery/duktape.c \ These files are not included in the

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-13 Thread Dan Williams
On Sun, 2015-04-12 at 20:31 +0200, Lennart Poettering wrote: On Fri, 10.04.15 14:05, Dan Williams (d...@redhat.com) wrote: So idea would basically be that we provide in all three daemons calls like: SetAdditionalNTP(ias) SetAdditionalDNS(ia(uay))

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Marcel Holtmann
Hi Zbyszek, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ + src/proxy-discovery/duktape.c \ These files are not included in the