Re: [systemd-devel] [PATCH] sd-bus: make sure type=error messages are also dumped

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432885691-22650-1-git-send-email-umut.tezduyar%40axis.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Andrei Borzenkov
On Fri, May 29, 2015 at 11:05 AM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On May 28, 2015 2:28 PM, aaron_wri...@selinc.com wrote: I'm working on an embedded system, and I ran into a situation where a non-root user needs to runs systemctl, but when I try I get: ~ $ systemctl status

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Dimitri John Ledkov
On 29 May 2015 at 01:21, aaron_wri...@selinc.com wrote: Brandon Philips bran...@ifup.co wrote on 05/28/2015 05:10:33 PM: Access to the system dbus is controlled by dbus policies. You will need to write a policy for giving this user access to the systemd1 object. I compiled systemd without

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Umut Tezduyar Lindskog
On Fri, May 29, 2015 at 10:23 AM, Andrei Borzenkov arvidj...@gmail.com wrote: On Fri, May 29, 2015 at 11:05 AM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On May 28, 2015 2:28 PM, aaron_wri...@selinc.com wrote: I'm working on an embedded system, and I ran into a situation where a

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Daniel Mack
On 05/29/2015 05:26 AM, Andrei Borzenkov wrote: If you do not use D-Bus daemon systemd will be listening on private socket. In this case the only check it does is that peer runs as UID=0 (note - not EUID, so suid does not really help). I wonder how access control is implemented in kdbus

Re: [systemd-devel] [ANNOUNCE] Separating gudev from systemd

2015-05-29 Thread Michael Biebl
2015-05-19 17:06 GMT+02:00 David Herrmann dh.herrm...@gmail.com: Hi We're about to remove gudev from the systemd repository, as it is in no way related to the systemd code-base, nor used by the systemd project. To preserve backwards compatibility, gudev was extracted into a separate

[systemd-devel] [PATCH] sd-bus: make sure type=error messages are also dumped

2015-05-29 Thread Umut Tezduyar Lindskog
--- src/libsystemd/sd-bus/sd-bus.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/libsystemd/sd-bus/sd-bus.c b/src/libsystemd/sd-bus/sd-bus.c index edc27ae..a6096f9 100644 --- a/src/libsystemd/sd-bus/sd-bus.c +++

Re: [systemd-devel] 'udevadm settle' brakes lvm on top of imsm raid

2015-05-29 Thread Oleg Samarin
Thanks, I made more debbuging with LVM and I realised, that lvm always uses the last device it has scanned. Scanning of devices is called by udev rules using lvm pvscan --cache device command. So the reason of using /dev/sdb2 instead of /dev/md126p2 is that udev runs lvm in the following order:

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Daniel Mack
On 05/29/2015 05:18 AM, Michael Biebl wrote: 2015-05-28 19:47 GMT+02:00 Filipe Brandenburger filbran...@google.com: We're actually still missing a small part of it (A sentence like Files in /etc have the highest priority, files in /run take precedence over files with the same name in

Re: [systemd-devel] [PATCH] build-sys: pass originally configured --enable-split-usr to distcheck

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:20150529054907.GD3340%40piware.de -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Dimitri John Ledkov
On 29 May 2015 at 11:25, Lennart Poettering lenn...@poettering.net wrote: On Fri, 29.05.15 00:24, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: On 28 May 2015 at 18:08, Lennart Poettering lenn...@poettering.net wrote: On Thu, 28.05.15 16:42, Dimitri John Ledkov

[systemd-devel] [PATCH] build-sys: fix typo

2015-05-29 Thread Karel Zak
There is nothing like systemd_verify_* in Makefile.am. The bug has been invisible because automake uses the default CFLAGS when component CFLAGS are undefined. --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index d6010c5..ed5135d

Re: [systemd-devel] [PATCH] build-sys: fix typo

2015-05-29 Thread Martin Pitt
Hey Karel, Karel Zak [2015-05-29 13:42 +0200]: There is nothing like systemd_verify_* in Makefile.am. The bug has been invisible because automake uses the default CFLAGS when component CFLAGS are undefined. Applied, looks/works fine. Thanks! Martin -- Martin Pitt|

Re: [systemd-devel] systemctl disable service not working as expected

2015-05-29 Thread Belal, Awais
Hi Martin, Thanks for the very quick reply :) So, are you saying that there is no guaranteed way in which PA can be enabled/disabled in a systemd based system? That too, if I want to keep the binary in so if a user needs he can enable/disable PA as per need. How can I disable PA in such a

Re: [systemd-devel] systemctl disable service not working as expected

2015-05-29 Thread Martin Pitt
Hello Belal, Belal, Awais [2015-05-29 11:19 +]: I am working on an x86_64 platform with a yocto based environment. I was trying to disable pulseaudio which is included in the system by default so I did a 'systemctl disable pulseaudio' but when I reboot it seems pulseaudio is still run for

Re: [systemd-devel] 'udevadm settle' brakes lvm on top of imsm raid

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 11:15, Oleg Samarin (osamari...@gmail.com) wrote: Thanks, I made more debbuging with LVM and I realised, that lvm always uses the last device it has scanned. Scanning of devices is called by udev rules using lvm pvscan --cache device command. So the reason of using

Re: [systemd-devel] Alienware graphics amplifier scancodes

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 13:25, Mario Limonciello (mario_limoncie...@dell.com) wrote: On 05/28/2015 11:48 AM, Lennart Poettering wrote: On Wed, 27.05.15 15:59, Mario Limonciello (mario_limoncie...@dell.com) wrote: You are aware that the kernel has PCI hotplug support? It sounds really weird

Re: [systemd-devel] [PATCH] shared: do not include aux_h if it is off

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432892866-27109-1-git-send-email-umut.tezduyar%40axis.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 10:54, Umut Tezduyar Lindskog (u...@tezduyar.com) wrote: On Fri, May 29, 2015 at 10:23 AM, Andrei Borzenkov arvidj...@gmail.com wrote: On Fri, May 29, 2015 at 11:05 AM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On May 28, 2015 2:28 PM, aaron_wri...@selinc.com

[systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread harald
From: Harald Hoyer har...@redhat.com If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. If possible /dev/block/maj:min is used, otherwise the original argv[3] is used. This enables password agents like petera [1] to

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 17:21, aaron_wri...@selinc.com (aaron_wri...@selinc.com) wrote: Brandon Philips bran...@ifup.co wrote on 05/28/2015 05:10:33 PM: Access to the system dbus is controlled by dbus policies. You will need to write a policy for giving this user access to the systemd1 object.

Re: [systemd-devel] [PATCH] build-sys: Stop depending on current configure options for EXTRA_DIST

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 12:20 +0200]: From all I can see this looks fine. Please push. Pushed. -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Mantas Mikulėnas
On Fri, May 29, 2015 at 1:02 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 28.05.15 17:21, aaron_wri...@selinc.com (aaron_wri...@selinc.com) wrote: Brandon Philips bran...@ifup.co wrote on 05/28/2015 05:10:33 PM: Access to the system dbus is controlled by dbus policies. You

[systemd-devel] systemctl disable service not working as expected

2015-05-29 Thread Belal, Awais
Hi, I am working on an x86_64 platform with a yocto based environment. I was trying to disable pulseaudio which is included in the system by default so I did a 'systemctl disable pulseaudio' but when I reboot it seems pulseaudio is still run for a very short period of time and this is messing

Re: [systemd-devel] Alienware graphics amplifier scancodes

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 13:53, Mario Limonciello (mario_limoncie...@dell.com) wrote: On 05/28/2015 01:46 PM, Greg KH wrote: You can't guarantee that there is another GPU to display things on. Yes you can. Wait, what? No, you can't. 1) Not everyone has multiple monitors plugged into multiple

Re: [systemd-devel] [PATCH] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 21:03, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello Lennart, Lennart Poettering [2015-05-28 19:44 +0200]: On Wed, 27.05.15 10:07, Martin Pitt (martin.p...@ubuntu.com) wrote: -int fd_is_mount_point(int fd) { +int fd_is_mount_point(int fd, const char *parent) {

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 03:03, Daniel Mack (zon...@kemper.freedesktop.org) wrote: Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6096d9ccc3f0b963010a47febce7e44c8632c23b Author: Daniel Mack dan...@zonque.org Date: Fri May 29 12:00:58 2015 +0200

Re: [systemd-devel] [PATCH] build-sys: Stop depending on current configure options for EXTRA_DIST

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 12:16, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello all, for the quest of doing daily builds/distcheck/etc. on Debian/Ubuntu I started running distcheck on current trunk. It failed with GEN units/kmod-static-nodes.service make[3]: *** No rule to make target

Re: [systemd-devel] [PATCH v2] udev: input_id: fix detection of various touchscreens

2015-05-29 Thread Andreas Pokorny
Hi, On Fri, May 29, 2015 at 2:07 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, May 28, 2015 at 02:47:35PM +0200, Andreas Pokorny wrote: There are touch screens that do not provide 'BTN_TOUCH' and hence no 'EV_KEY'. Previously those would not get any properties assigned and

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432894632-2417-1-git-send-email-harald%40redhat.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

Re: [systemd-devel] I am adding RegisterMachine to docker.

2015-05-29 Thread Colin Guthrie
Daniel J Walsh wrote on 28/05/15 21:05: When container stops machinectl still shows it registered? Do I need to Unregister the machine? I though systemd would notice the pid died and remove the machine. IIRC there was a really old problem with lingering machine name registrations. It

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Lennart Poettering
On Thu, 28.05.15 10:47, Filipe Brandenburger (filbran...@google.com) wrote: On Thu, May 28, 2015 at 10:44 AM, Michael Biebl mbi...@gmail.com wrote: 2015-05-28 19:41 GMT+02:00 Martin Pitt martin.p...@ubuntu.com: \o/ Many thanks Filipe, that's great! Biggest patch gone :) A huge thanks

[systemd-devel] [PATCH] shared: do not include aux_h if it is off

2015-05-29 Thread Umut Tezduyar Lindskog
--- src/shared/random-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shared/random-util.c b/src/shared/random-util.c index 88f5182..b230044 100644 --- a/src/shared/random-util.c +++ b/src/shared/random-util.c @@ -23,7 +23,9 @@ #include sys/stat.h #include fcntl.h #include

Re: [systemd-devel] [PATCH] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 11:33 +0200]: Exactly, that's why I called it parent; but I'm not fussed about the name, dir or containing_dir would work as well. I'd just not call it filename as that would be confusing -- this is *not* the file name of fd, but the directory it lives in (i.

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Daniel Mack
On 05/29/2015 12:07 PM, Lennart Poettering wrote: On Fri, 29.05.15 03:03, Daniel Mack (zon...@kemper.freedesktop.org) wrote: Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6096d9ccc3f0b963010a47febce7e44c8632c23b Author: Daniel Mack

[systemd-devel] systemd-logind and selinux enforcing: Assertion failed

2015-05-29 Thread George Karakougioumtzis
As i was trying to enforce selinux on a fedora 21 i got this which seems more related to systemd-mailing list rather than the selinux one. systemd-logind[355]: Assertion 's-user-slice' failed at ../src/login/logind-session.c:496, function session_start_scope(). Aborting. As a result loginctl

[systemd-devel] [PATCH v3 0/3] udev: input_id - extended device detection for touch screens

2015-05-29 Thread Andreas Pokorny
Hi, This is the revised version, split up into a series of changes. The first separates evdev property evaluation from decision taking and udev property application. The second adds INPUT_PROP_DIRECT and MT axis to detect touch screens. The final one adds a check for overlapping axis ranges.

[systemd-devel] [PATCH v3 1/3] udev: input_id - refactor device detection

2015-05-29 Thread Andreas Pokorny
This change switches to bools and separates bit flag evaluation from decision making and application of udev properties, while hopefully keeping the same semantics. Apart from using BTN_LEFT instead of BTN_MOUSE for mouse detection. --- src/udev/udev-builtin-input_id.c | 134

[systemd-devel] [PATCH v3 3/3] udev: input_id - use ABS_MT_SLOT{-1} to exclude non touch screen devices

2015-05-29 Thread Andreas Pokorny
Require touch screens to have a ABS_MT_SLOT axis while exclude devices that overlap with the MT range of axes. --- src/udev/udev-builtin-input_id.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/udev/udev-builtin-input_id.c b/src/udev/udev-builtin-input_id.c index

[systemd-devel] [PATCH v3 2/3] udev: input_id - use direct property and mt axis for touch screen detection

2015-05-29 Thread Andreas Pokorny
A lot of touch screens use INPUT_PROP_DIRECT to indicate that touch input maps directly to the underlying screen, while the BTN_TOUCH bit might not be set. --- src/udev/udev-builtin-input_id.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH v3 3/3] udev: input_id - use ABS_MT_SLOT{-1} to exclude non touch screen devices

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432904094-28288-4-git-send-email-andreas.pokorny%40canonical.com -- Generated by https://github.com/haraldh/mail2git ___

Re: [systemd-devel] systemctl disable service not working as expected

2015-05-29 Thread Mantas Mikulėnas
On Fri, May 29, 2015 at 3:04 PM, Belal, Awais awais_be...@mentor.com wrote: Hi Martin, Thanks for the very quick reply :) So, are you saying that there is no guaranteed way in which PA can be enabled/disabled in a systemd based system? pulseaudio is *very rarely* run as a system service in

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 12:42, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: On 29 May 2015 at 11:25, Lennart Poettering lenn...@poettering.net wrote: On Fri, 29.05.15 00:24, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: On 28 May 2015 at 18:08, Lennart Poettering

Re: [systemd-devel] systemd-logind and selinux enforcing: Assertion failed

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 14:04, George Karakougioumtzis (mad-proffes...@hotmail.com) wrote: As i was trying to enforce selinux on a fedora 21 i got this which seems more related to systemd-mailing list rather than the selinux one. systemd-logind[355]: Assertion 's-user-slice' failed at

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 12:26, Daniel Mack (dan...@zonque.org) wrote: On 05/29/2015 12:07 PM, Lennart Poettering wrote: On Fri, 29.05.15 03:03, Daniel Mack (zon...@kemper.freedesktop.org) wrote: Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit

[systemd-devel] [PATCH] install: follow symlinks when enabling unit files from /usr/

2015-05-29 Thread Michal Sekletar
Right now it is difficult for distros to ship convenience/compat alias for some service, e.g. mariadb aliased to mysql or nfs-server to nfs. If service which comes with alias is not enabled by default then user must refer to its new unit file name when trying to enable the service. Contrary, using

Re: [systemd-devel] systemctl disable service not working as expected

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 11:19, Belal, Awais (awais_be...@mentor.com) wrote: Hi, I am working on an x86_64 platform with a yocto based environment. I was trying to disable pulseaudio which is included in the system by default so I did a 'systemctl disable pulseaudio' but when I reboot it seems

Re: [systemd-devel] [PATCH] install: follow symlinks when enabling unit files from /usr/

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432908009-16682-1-git-send-email-msekleta%40redhat.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 13:56, Mantas Mikulėnas (graw...@gmail.com) wrote: systemd will always use D-Bus (the protocol) for IPC, that's not optional, and you cannot turn it off neither during build-time nor during runtime. systemd does not use libdbus to implement this however, but instead it

Re: [systemd-devel] [PATCH] build-sys: pass originally configured --enable-split-usr to distcheck

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 16:28 +0200]: Looks good. Please push. Pushed. Any chance you can connect this thing to #systemd on IRC? Would really love to be notified about failures, but ideall without email-spam... Yes, I'd like that too. I haven't looked at how to create IRC bots, but

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: +static char* disk_maj_min(const char *path) { I'd really not abbreivate things here... call it major and minor. there's no point in saving two ors... +struct stat st, st2; +char *i = NULL; +int

[systemd-devel] [PATCH V2] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread harald
From: Harald Hoyer har...@redhat.com If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. If possible /dev/block/maj:min is used, otherwise the original argv[3] is used. This enables password agents like petera [1] to

Re: [systemd-devel] [PATCH] zsh-completion: a more style/tag aware _systemctl

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432910411-14517-1-git-send-email-llua%40gmx.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing list

[systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
Hello, Lennart Poettering [2015-05-28 19:44 +0200]: I really think this should work as close as the usual *at() calls work. i.e. take a dir fd as first argument, and a filename *within*that*directory* to check. Maybe even give it the _at() suffix: int fd_is_mount_point_at(int fd, const char

[systemd-devel] [PATCH V3] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread harald
From: Harald Hoyer har...@redhat.com If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. If possible /dev/block/maj:min is used, otherwise the original argv[3] is used. This enables password agents like petera [1] to

[systemd-devel] [PATCH] zsh-completion: a more style/tag aware _systemctl

2015-05-29 Thread Eric Cook
using _wanted instead of calling compadd directly. this allows the user to customize possible matches. An example being, grouping units by type: autoload -Uz compinit; compinit zstyle ':completion:*' menu select zstyle ':completion:*' group-name '' zstyle ':completion:*' format 'Completing %d'

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Dimitri John Ledkov
On 29 May 2015 at 14:41, Lennart Poettering lenn...@poettering.net wrote: On Fri, 29.05.15 12:42, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: On 29 May 2015 at 11:25, Lennart Poettering lenn...@poettering.net wrote: On Fri, 29.05.15 00:24, Dimitri John Ledkov

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 15:45, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: On 29 May 2015 at 11:17, har...@redhat.com wrote: From: Harald Hoyer har...@redhat.com If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:02 +0200]: I'd really just introduce a new kernel cmdline option: systemd.debug-unified-cgroup=1 or so. A simple boolean that gets you either one or the other behaviour. Maybe make the default for this setting configurable with a configure script switch. And

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:09, Martin Pitt (martin.p...@ubuntu.com) wrote: Lennart Poettering [2015-05-29 17:02 +0200]: I'd really just introduce a new kernel cmdline option: systemd.debug-unified-cgroup=1 or so. A simple boolean that gets you either one or the other behaviour. Maybe make the

Re: [systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:31 +0200]: I think this: flags = flags ~AT_SYMLINK_FOLLOW; should better be written like this: flags = ~AT_SYMLINK_FOLLOW; this matches the other if branch better then... Of course, little brainfart.. Looks good otherwise, please

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Filipe Brandenburger
Hi, I was thinking about this one recently... I really think the correct solution is for man/custom-entities.ent to be generated by configure from a man/custom-entities.ent.in template instead. I haven't really checked if that's viable though, if configure knows about every variable it will

Re: [systemd-devel] [PATCH V3] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432916659-16919-1-git-send-email-harald%40redhat.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Martin Pitt
Harald Hoyer [2015-05-29 16:50 +0200]: I was more thinking about symlinks pointing to the same device. Naïvely I'd think that resolving symlinks would still be more readable than major/minor numbers; why would that be worse? Thanks, Martin -- Martin Pitt|

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: Harald Hoyer [2015-05-29 16:50 +0200]: I was more thinking about symlinks pointing to the same device. Naïvely I'd think that resolving symlinks would still be more readable than major/minor numbers; why would that be

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Harald Hoyer
Am 29.05.2015 um 17:04 schrieb Lennart Poettering: On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: +static char* disk_maj_min(const char *path) { I'd really not abbreivate things here... call it major and minor. there's no point in saving two ors... +

Re: [systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:22, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello, Lennart Poettering [2015-05-28 19:44 +0200]: I really think this should work as close as the usual *at() calls work. i.e. take a dir fd as first argument, and a filename *within*that*directory* to check. Maybe

Re: [systemd-devel] [PATCH V3] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 18:24, har...@redhat.com (har...@redhat.com) wrote: +static int disk_major_minor(const char *path, char **ret) { +struct stat st; + +assert(path); + +if (stat(path, st) 0) +return -errno; + +if (!S_ISBLK(st.st_mode)) +

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Dimitri John Ledkov
On 29 May 2015 at 11:17, har...@redhat.com wrote: From: Harald Hoyer har...@redhat.com If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. I'm not sure why this is needed... if the device path is not good enough, there

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Harald Hoyer
Am 29.05.2015 um 16:38 schrieb Lennart Poettering: On Fri, 29.05.15 16:30, Harald Hoyer (har...@redhat.com) wrote: Am 29.05.2015 um 16:26 schrieb Lennart Poettering: On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: From: Harald Hoyer har...@redhat.com If cryptsetup is

Re: [systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:25, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello, and this is the second part which updates the signature of path_is_mount_point() to replace bool allow_symlink to an openat()-like flags. This patch does not change visible behaviour, it's just a stylistic issue.

Re: [systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:50 +0200]: Looks good too. Please push! Pushed. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 16:30, Harald Hoyer (har...@redhat.com) wrote: Am 29.05.2015 um 16:26 schrieb Lennart Poettering: On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: From: Harald Hoyer har...@redhat.com If cryptsetup is called with a source device as argv[3], then

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 15:52, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: And yeah, getting proper notifications especially for the container case is the most important thing for me too. Right. I have it as compile option at the moment, and i'm booting fresh VMs with it. I do

[systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Martin Pitt
Hello, and this is the second part which updates the signature of path_is_mount_point() to replace bool allow_symlink to an openat()-like flags. This patch does not change visible behaviour, it's just a stylistic issue. Martin -- Martin Pitt| http://www.piware.de Ubuntu

Re: [systemd-devel] [PATCH V2] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432914850-2569-1-git-send-email-harald%40redhat.com -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

Re: [systemd-devel] systemctl as non-root

2015-05-29 Thread Aaron_Wright
I compiled systemd without dbus support (--disable-dbus), and there is no dbus daemon or dbus lib on the system. Is that a requirement to get the functionality I want? I didn't see much need for dbus as the system works quite well without it. Well, except for this of course.

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Michael Biebl
2015-05-29 15:56 GMT+02:00 Lennart Poettering lenn...@poettering.net: I think it's ok to expect people to run make clean after touching the makefile to get the man pages fixed. Atm, man/custom-entities.ent is only cleaned up on make distclean. I think we should move that from DISTCLEANFILES to

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 09:45, Filipe Brandenburger (filbran...@google.com) wrote: Hi, I was thinking about this one recently... I really think the correct solution is for man/custom-entities.ent to be generated by configure from a man/custom-entities.ent.in template instead. I haven't really

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Harald Hoyer
Am 29.05.2015 um 16:45 schrieb Dimitri John Ledkov: On 29 May 2015 at 11:17, har...@redhat.com wrote: From: Harald Hoyer har...@redhat.com If cryptsetup is called with a source device as argv[3], then craft the ID for the password agent with a unique device path. I'm not sure why this is

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:11, Harald Hoyer (har...@redhat.com) wrote: Am 29.05.2015 um 17:04 schrieb Lennart Poettering: On Fri, 29.05.15 12:17, har...@redhat.com (har...@redhat.com) wrote: +static char* disk_maj_min(const char *path) { I'd really not abbreivate things here... call it

[systemd-devel] [HEADSUP] nspawn/networkd: moving from iptables to nftables

2015-05-29 Thread Lennart Poettering
Heya, just a small heads-up: Currently there are two firewall APIs used on Linux: iptables and nftables. iptables is the older one, nftables the new replacement. systemd-nspawn and systemd-networkd currently interface with iptables via the libiptc library: nspawn to implement the --port= switch

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 11:05, Daniel Mack (dan...@zonque.org) wrote: On 05/29/2015 05:18 AM, Michael Biebl wrote: 2015-05-28 19:47 GMT+02:00 Filipe Brandenburger filbran...@google.com: We're actually still missing a small part of it (A sentence like Files in /etc have the highest priority, files

Re: [systemd-devel] fsck, /home, btrfs, multiple partitions/drives, boot failure [Ubuntu 15.04]

2015-05-29 Thread Roger Binns
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/28/2015 08:40 PM, Andrei Borzenkov wrote: Try booting with udev.log-priority=debug rd.udev.log-priority=debug, this may give some hint what happens. Wow did that produce a lot of output! No. You can set nofail in which case boot will

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Filipe Brandenburger
Hi Daniel, I haven't tested it, but I do have a few comments. First, why not use rootlibdir instead of rootprefixlibdir? There's already similar rootbindir and rootlibexecdir defined there, so I think we could stick to the same convention. From a few lines down in Makefile.am: # And these

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:24 GMT+02:00 Daniel Mack dan...@zonque.org: Fine for me, just go ahead if you have an implementation in mind :) I was lazy and just copied ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-archive/normpath.html The resulting diff would look something like diff --git

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Filipe Brandenburger
On Fri, May 29, 2015 at 5:21 PM, Michael Biebl mbi...@gmail.com wrote: autoconf already strips trailing slashes for all default directory variables [1]. How does it handle --prefix=/ though? Does it turn it into an empty string? I think we should do the same for *all* our custom

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:53 GMT+02:00 Michael Biebl mbi...@gmail.com: 2015-05-30 2:50 GMT+02:00 Michael Biebl mbi...@gmail.com: 2015-05-30 2:24 GMT+02:00 Daniel Mack dan...@zonque.org: Fine for me, just go ahead if you have an implementation in mind :) I was lazy and just copied

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-29 Thread Daniel Mack
On 05/29/2015 07:37 PM, Filipe Brandenburger wrote: I haven't tested it, but I do have a few comments. First, why not use rootlibdir instead of rootprefixlibdir? Because $(rootlibdir) resolves to /usr/lib64 on my system. [...] On Fri, May 29, 2015 at 2:05 AM, Daniel Mack dan...@zonque.org

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:05 GMT+02:00 Daniel Mack dan...@zonque.org: Make sure the variable set via --with-rootprefix= does not contain a trailing slash, so man pages can use entities like rootprefix;/lib without ending up having double slashes. --- configure.ac | 3 ++- 1 file changed, 2

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:50 GMT+02:00 Michael Biebl mbi...@gmail.com: 2015-05-30 2:24 GMT+02:00 Daniel Mack dan...@zonque.org: Fine for me, just go ahead if you have an implementation in mind :) I was lazy and just copied ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-archive/normpath.html

Re: [systemd-devel] [PATCH 2/2] man: replace hard-coded /usr/lib

2015-05-29 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1432944333-3566-2-git-send-email-daniel%40zonque.org -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

[systemd-devel] [PATCH 2/2] man: replace hard-coded /usr/lib

2015-05-29 Thread Daniel Mack
Replace some /usr/lib occurences in man/ with rootprefix;/lib. --- man/hwdb.xml| 4 ++-- man/systemd.link.xml| 4 ++-- man/systemd.netdev.xml | 4 ++-- man/systemd.network.xml | 4 ++-- man/udev.xml| 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff

[systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Daniel Mack
Make sure the variable set via --with-rootprefix= does not contain a trailing slash, so man pages can use entities like rootprefix;/lib without ending up having double slashes. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:30 GMT+02:00 Filipe Brandenburger filbran...@google.com: On Fri, May 29, 2015 at 5:21 PM, Michael Biebl mbi...@gmail.com wrote: autoconf already strips trailing slashes for all default directory variables [1]. How does it handle --prefix=/ though? Does it turn it into an empty

Re: [systemd-devel] [systemd-commits] Makefile.am

2015-05-29 Thread Daniel Mack
On 05/29/2015 06:53 PM, Lennart Poettering wrote: On Fri, 29.05.15 09:45, Filipe Brandenburger (filbran...@google.com) wrote: Atm, man/custom-entities.ent is only cleaned up on make distclean. I think we should move that from DISTCLEANFILES to CLEANFILES. Yes I think that's a good start and

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Daniel Mack
On 05/30/2015 02:21 AM, Michael Biebl wrote: 2015-05-30 2:05 GMT+02:00 Daniel Mack dan...@zonque.org: Make sure the variable set via --with-rootprefix= does not contain a trailing slash, so man pages can use entities like rootprefix;/lib without ending up having double slashes. ---

[systemd-devel] [PATCH v2 5/5] core/cgroup: Add cgroup.populated inotify watches, when available.

2015-05-29 Thread Dimitri John Ledkov
--- src/core/cgroup.c| 81 ++-- src/core/manager.c | 7 - src/core/manager.h | 3 ++ src/core/service.c | 2 +- src/shared/cgroup-util.c | 28 + src/shared/cgroup-util.h | 6 ++-- src/test/test-cgroup.c

[systemd-devel] [PATCH v2 4/5] unified-cgroup: fix cg_pid_get_path() and cg_get_path().

2015-05-29 Thread Dimitri John Ledkov
--- src/shared/cgroup-util.c| 8 src/test/test-cgroup-util.c | 18 ++ 2 files changed, 26 insertions(+) diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index 2bca32a..eae9f5d 100644 --- a/src/shared/cgroup-util.c +++ b/src/shared/cgroup-util.c @@

[systemd-devel] [PATCH v2 1/5] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Dimitri John Ledkov
It appears in /proc/self/cgroup as `0::/' --- src/shared/cgroup-util.c| 4 src/test/test-cgroup-util.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index 9988e5c..2bca32a 100644 --- a/src/shared/cgroup-util.c

  1   2   >