Re: [systemd-devel] libsystemd export message_append_cmdline

2016-08-15 Thread Mantas Mikulėnas
On Mon, Aug 15, 2016 at 6:05 PM, Brad Bishop 
wrote:

> Hi list
>
> I am developing an sd-event+sd-bus application that simply blocks until a
> property changes to a specific value using org.freedesktop.DBus.
> ObjectManager.PropertiesChanged and org.freedesktop.DBus.Properties.Get.
>
> I plan on using this application from service units to express ordering
> dependencies.
>
> A couple questions:
>
> 1 - Does anyone have any feedback on this approach in general?
>

Depends on how you're going to use the app. I think that's exactly how
(After=)NetworkManager-wait-online.service is implemented, for example.


> 2 - Should I not be writing my own app - i.e. is this something busctl can
> do or makes sense to extend it to do?
>

I think I've seen someone do this in shell, using dbus-send and
dbus-monitor... please don't.

-- 
Mantas Mikulėnas 
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] Head ups - upstream first no longer applies to the kernel.

2016-08-15 Thread Jóhann B . Guðmundsson



On 08/15/2016 04:08 PM, Zbigniew Jędrzejewski-Szmek wrote:

On Mon, Aug 15, 2016 at 10:53:56AM +, Jóhann B. Guðmundsson wrote:

>Just a heads up based on the merge  of [1] systemd no longer
>requires features to have been accepted in the upstream kernel
>before merging it.

See the man page:

 Due to the lack of consensus in the kernel community, the CPU controller
 support on the unified cgroup hierarchy requires out-of-tree kernel 
patches.
 See cgroup-v2-cpu.txt[3].

I think that's pretty clear. If you think it should be made more clear, let
me know how.


Irrelevant if it's clear or not and repeating does not change the fact that 
merging this into the master branch means the policy of upstream first no 
longer applies so it can never be used as an argument used against merging 
submitted code against the entire systemd codebase.

This ought have been rejected or resided in it's own "experimental" branch of 
the systemd codebase until they have sorted the cgroupv2 stuff out upstream.

JBG
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] Head ups - upstream first no longer applies to the kernel.

2016-08-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Aug 15, 2016 at 10:53:56AM +, Jóhann B. Guðmundsson wrote:
> Just a heads up based on the merge  of [1] systemd no longer
> requires features to have been accepted in the upstream kernel
> before merging it.

See the man page:

Due to the lack of consensus in the kernel community, the CPU controller
support on the unified cgroup hierarchy requires out-of-tree kernel patches.
See cgroup-v2-cpu.txt[3].

I think that's pretty clear. If you think it should be made more clear, let
me know how.

Also, I'll repeat what I wrote on the PR: that patch has no effect on v1 users,
or on v2-vanilla-kernel users, and only affects v2-patched-kernel users.
And what Tejun Heo said: the opposition upstream is not to the details of
the interface, but to general cgroups-v2 design. It's a bit late for that, but
even if the design is significantly changed, the interface is likely to be as
proposed in those patches.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] libsystemd export message_append_cmdline

2016-08-15 Thread Brad Bishop
Hi list

I am developing an sd-event+sd-bus application that simply blocks until a 
property changes to a specific value using 
org.freedesktop.DBus.ObjectManager.PropertiesChanged and 
org.freedesktop.DBus.Properties.Get.

I plan on using this application from service units to express ordering 
dependencies.

A couple questions:

1 - Does anyone have any feedback on this approach in general?
2 - Should I not be writing my own app - i.e. is this something busctl can do 
or makes sense to extend it to do?
3 - If I write my own application, message_append_cmdline seems to be a perfect 
fit for parsing cmdlines…how does the community feel about exporting it?

Thanks for your time and feedback.

brad bishop
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] Head ups - upstream first no longer applies to the kernel.

2016-08-15 Thread Jóhann B . Guðmundsson
Just a heads up based on the merge  of [1] systemd no longer requires 
features to have been accepted in the upstream kernel before merging it.


Adjust you expectation accordingly for submission and potential 
downstream breakage for type units in which upstream might have decided 
to take advantages of such merged features in systemd.


JBG

1. https://github.com/systemd/systemd/pull/3905

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel