Re: [systemd-devel] Fragile journal interleaving

2017-12-12 Thread Uoti Urpala
On Tue, 2017-12-12 at 21:38 +0100, Lennart Poettering wrote: > Maybe the approach needs to be that we immedately increase the read > record ptr of a specific file by one when we read it, so that we know > we monotonically progress through the file. And then change the logic > that looks for the nex

Re: [systemd-devel] Fragile journal interleaving

2017-12-12 Thread Lennart Poettering
On Di, 12.12.17 21:00, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: > On Tue, 2017-12-12 at 17:09 +0100, Lennart Poettering wrote: > > On Mo, 11.12.17 00:36, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: > > > consider a clear bug: there's code in next_beyond_location() which > > > skips the next e

Re: [systemd-devel] Fragile journal interleaving

2017-12-12 Thread Uoti Urpala
On Tue, 2017-12-12 at 17:09 +0100, Lennart Poettering wrote: > On Mo, 11.12.17 00:36, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: > > consider a clear bug: there's code in next_beyond_location() which > > skips the next entry in a file if it's not in the expected direction > > from the previous gl

Re: [systemd-devel] Fragile journal interleaving

2017-12-12 Thread Lennart Poettering
On Mo, 11.12.17 00:36, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: > The code that tries to determine which of two journal entries is > "earlier" (similar logic in journal_file_comparare_locations() and > compare_with_location()) does this by trying different progressively > less reliable ways to