Re: [systemd-devel] hash context not closed.

2018-02-03 Thread vcaputo
On Sat, Feb 03, 2018 at 09:14:40PM +0100, Stef Bon wrote: > The testing of the new code requires me too much (meson is required.. > and I don't want to replace my existing systemd) and I do not expect > to add more patches is near future. > > I've got a patch: > > diff --git

Re: [systemd-devel] hash context not closed.

2018-02-03 Thread Stef Bon
The testing of the new code requires me too much (meson is required.. and I don't want to replace my existing systemd) and I do not expect to add more patches is near future. I've got a patch: diff --git a/src/basic/gcrypt-util.c b/src/basic/gcrypt-util.c index 1bfb77672..c7c07e3b7 100644 ---

Re: [systemd-devel] hash context not closed.

2018-02-03 Thread vcaputo
On Sat, Feb 03, 2018 at 08:38:38PM +0100, Stef Bon wrote: > 2018-02-03 20:27 GMT+01:00 : > > > > > Nice catch, that indeed looks like a leak. Would you like to prep a > > PR fixing it? > > > > PR? I do not know what you mean. A pull request? > I can write a patch. The

Re: [systemd-devel] hash context not closed.

2018-02-03 Thread Stef Bon
2018-02-03 20:27 GMT+01:00 : > > Nice catch, that indeed looks like a leak. Would you like to prep a > PR fixing it? > PR? I do not know what you mean. A pull request? I can write a patch. Stef ___ systemd-devel mailing list

Re: [systemd-devel] hash context not closed.

2018-02-03 Thread vcaputo
On Sat, Feb 03, 2018 at 07:26:24PM +0100, Stef Bon wrote: > Hi, > > when I look at the function string_hashsum it looks like the context > is not closed when done. > > After a succesfull gcry_md_open the hash context md should be closed > when leaving this function. That does not happen. >

Re: [systemd-devel] hash context not closed.

2018-02-03 Thread Stef Bon
2018-02-03 19:26 GMT+01:00 Stef Bon : > Hi, Oh and this in in file src/basic/gcrypt-util.c. > > Stef ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] hash context not closed.

2018-02-03 Thread Stef Bon
Hi, when I look at the function string_hashsum it looks like the context is not closed when done. After a succesfull gcry_md_open the hash context md should be closed when leaving this function. That does not happen. Stef ___ systemd-devel mailing

[systemd-devel] Improvement of Battery Drain DELL Notebook XPS-13 9365 Possible?!

2018-02-03 Thread Axel Klein
Hi *, On my Dell XPS-13 9365k Notebook I experience pretty accurately a battery drain of 5% per hour in suspend when running Ubuntu. Compared to this 5% per hour battery drain while in sleep, I've found a maximum battery drain of 2-3% independent of sleep time when the Dell Notebook 9365 runs