Re: [systemd-devel] [PATCH] udev: Allow acpi_index and index to be "0"

2018-09-28 Thread systemd github import bot 
Patchset imported to github.
To create a pull request, one of the main developers has to initiate one via:


--
Generated by https://github.com/haraldh/mail2git
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] udev: Allow acpi_index and index to be "0"

2018-09-28 Thread Joe Hershberger 
0 can be a valid index returned by the BIOS, so allow that literal while
still checking for 0 as a failed conversion by strtoul(). Also, unsigned
long cannot be negative, so don't misleadingly check for less than 0.

Signed-off-by: Joe Hershberger 
---
 src/udev/udev-builtin-net_id.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/udev/udev-builtin-net_id.c b/src/udev/udev-builtin-net_id.c
index 5341d3788..338a2d4c4 100644
--- a/src/udev/udev-builtin-net_id.c
+++ b/src/udev/udev-builtin-net_id.c
@@ -232,7 +232,7 @@ static int dev_pci_onboard(struct udev_device *dev, struct 
netnames *names) {
 return -ENOENT;
 
 idx = strtoul(attr, NULL, 0);
-if (idx <= 0)
+if (idx == 0 && strcmp("0", attr))
 return -EINVAL;
 
 /* Some BIOSes report rubbish indexes that are excessively high 
(2^24-1 is an index VMware likes to report for
-- 
2.11.0

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2] meson: use the host architecture compiler/linker for src/boot/efi

2018-09-28 Thread Zbigniew Jędrzejewski-Szmek 
On Fri, Sep 28, 2018 at 01:19:27PM +0100, Simon McVittie wrote:
> On Fri, 28 Sep 2018 at 10:40:28 +0200, Lennart Poettering wrote:
> > On Do, 27.09.18 17:17, Helmut Grohne (hel...@subdivi.de) wrote:
> > 
> > > cross building systemd to arm64 presently fails, because the build
> > > system uses plain gcc and plain ld (build architecture compiler and
> > > linker respectively) for building src/boot/efi. These values come from
> > > the efi-cc and efi-ld options respectively. It rather should be using
> > > host tools here.
> > > 
> > > Fixes: b710072da441 ("add support for building efi modules")
> > 
> > Hmm, any chance you could submit this through github please?
> 
> This is an updated version for
>  which is owned by mbiebl
> (presumably Helmut isn't sending his own pull requests for whatever
> reason).

I already submitted a new PR.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2] meson: use the host architecture compiler/linker for src/boot/efi

2018-09-28 Thread Simon McVittie 
On Fri, 28 Sep 2018 at 10:40:28 +0200, Lennart Poettering wrote:
> On Do, 27.09.18 17:17, Helmut Grohne (hel...@subdivi.de) wrote:
> 
> > cross building systemd to arm64 presently fails, because the build
> > system uses plain gcc and plain ld (build architecture compiler and
> > linker respectively) for building src/boot/efi. These values come from
> > the efi-cc and efi-ld options respectively. It rather should be using
> > host tools here.
> > 
> > Fixes: b710072da441 ("add support for building efi modules")
> 
> Hmm, any chance you could submit this through github please?

This is an updated version for
 which is owned by mbiebl
(presumably Helmut isn't sending his own pull requests for whatever
reason).

smcv
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2] meson: use the host architecture compiler/linker for src/boot/efi

2018-09-28 Thread Lennart Poettering 
On Do, 27.09.18 17:17, Helmut Grohne (hel...@subdivi.de) wrote:

> cross building systemd to arm64 presently fails, because the build
> system uses plain gcc and plain ld (build architecture compiler and
> linker respectively) for building src/boot/efi. These values come from
> the efi-cc and efi-ld options respectively. It rather should be using
> host tools here.
> 
> Fixes: b710072da441 ("add support for building efi modules")

Hmm, any chance you could submit this through github please?

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel