Re: [systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown

2019-06-10 Thread Eric DeVolder

Hi Lennart,
I've applied the coding style guidelines, and created a pull request 
#12768 via GitHub. Let me know what I may have done wrong, my first 
attempt via GitHub.

Thanks,
eric

On 5/16/19 9:34 AM, Lennart Poettering wrote:

On Do, 16.05.19 09:28, Eric DeVolder (eric.devol...@oracle.com) wrote:

Could you please submit this via github as PR? Review is so much nicer
there, in particular for complex patch sets, and this qualifies as
complex I think. This also has the benefit that the code is
automatically analyzed by our CI tools.

https://github.com/systemd/systemd/pulls

Moreover, please make sure to to read our coding style guidelines
here:

https://systemd.io/CODING_STYLE

Form a very brief glance it appears the code doesn't follow formatting
rules for example.

Thanks!

Lennart

--
Lennart Poettering, Berlin


___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] Information from Dorian Rosse system

2019-06-10 Thread Dorian ROSSE
I went to launch the last kernel by screen choose option I have a lot of 
systemd programs broken I will firstly repair by myself if I fail to repair I 
will send to you systemd commande line info about systemd programs broken

Regards.


Dorian Rosse.

Télécharger Outlook pour Android

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] sd-bus read message with ConnMan

2019-06-10 Thread Mantas Mikulėnas
On Fri, Jun 7, 2019 at 9:08 PM Salman Ahmed  wrote:

> Hello,
>
> I am trying to communicate with connman using sdbus from my application.
> Basically I want to replicate the following cmd line procedure to get
> values for "object path" and string "Host" (underlined below)
> I do
> *dbus-send --system  --dest=net.connman.vpn
> --type=method_call--print-reply /
>  net.connman.vpn.Manager.GetConnections*
>
> and I get
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> *   array [  struct { object path
> "/net/connman/vpn/connection/uk_london_privateinternetaccess_com_privateinternetaccess_com"
>array [dict entry(   string "State"
>  variant   string "idle")dict
> entry(   string "Type"   variant
> string "openvpn")dict entry(   string
> "Name"   variant   string "PIA VPN"
> )dict entry(   string "Host"   variant
>   string "uk-london.privateinternetaccess.com
> ")dict
> entry(   string "Index"   variant
> int32 0)dict entry(   string "Domain"
>  variant   string "privateinternetaccess.com
> ")dict entry(
>string "Immutable"   variant
> boolean true)dict entry(   string
> "Nameservers"   variant   array [
> ])dict entry(   string
> "UserRoutes"   variant   array [
>   ])dict entry(   string
> "ServerRoutes"   variant   array [
> ]) ]  }   ]*
>
>
> In my application I am doing
>r = sd_bus_call_method( bus,
>"net.connman.vpn",
>"/",
>"net.connman.vpn.Manager",
>"GetConnections",
>,
>,  NULL, NULL);
>
> Which succeeds.
> Afterwards I want to do  sd_bus_message_read(m, "a(oa{sv})") but I have no
> idea what kind of arguments should I pass in what order to get object path
> and host string. I think I got the a(oa{sv}) part right?
>

Use sd_bus_message_enter_container() first. Here's a very similar example:

https://github.com/systemd/systemd/blob/master/src/core/dbus-manager.c#L802


-- 
Mantas Mikulėnas
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Building systemd

2019-06-10 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jun 09, 2019 at 05:58:16PM -0300, Leonardo Akel Daher wrote:
> Hi,
> 
> I am trying to make a Pull Request for systemd, but I am struggling running
> the tests locally (before making any code changes). I get the error of the
> attached image when running "ninja -C build/ test".

Hi,

please don't attach error logs as messages. Just copy & paste the error
text into your mail.

You are hitting a bug in meson. Since you installed meson using pip, you
have a very new meson, which you are using with a rather old python.
It's likely that this combination is not tested very well.
But it *should* work. Maybe you can get more help from Ubuntu users.

> I then decided to try using mkosi to create an image, but then I get this
> other error (attached on this other image). I currently use Ubuntu, so
> should I change the file mkosi.default so it includes Ubuntu's file instead
> of Fedora's?

You are using an old mkosi version that doesn't know about newer Fedora.
Either update, or switch to Ubuntu images as you say.

> Another problem I faced, but have already fixed was while installing Meson.
> In Ubuntu's package manager, the latest Meson version is < 0.46, so when
> running "meson build", it renders an error stating that my Meson version
> should be >= 0.46. I fixed this by installing Meson through Python's
> package manager, pip. But, I think this would be a problem when trying to
> build the Ubuntu image with mkosi. How would I install the pip's version of
> Meson instead of Ubuntu package manager's?

You can run arbitrary scripts during image creation, so in principle you
could do 'pip install' then. But it quickly becomes very messy and complicated.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel