[systemd-devel] [RFC] socket-proxyd: resolve addrinfo using sd-resolve

2014-02-20 Thread Daniel Buch
Hi, Hope this is not completly ridiculous? I havnt tested this since im not entirely sure how to do it. So tips and comments regarding that are very welcome, im tempt to research further and maybe eventually provide a test for socket-proxy. Best regards. --- Makefile.am |

[systemd-devel] [PATCH] tests: add set -e

2014-02-28 Thread Daniel Buch
--- TODO| 1 - test/TEST-01-BASIC/test.sh | 2 ++ test/TEST-02-CRYPTSETUP/test.sh | 2 ++ test/TEST-03-JOBS/test-jobs.sh | 1 + test/TEST-03-JOBS/test.sh | 2 ++ test/rules-test.sh | 2 ++ 6 files changed, 9 insertions(+), 1 deletion(-) diff

[systemd-devel] [PATCH] socket.c: make use of union sockaddr_union

2014-03-12 Thread Daniel Buch
--- src/core/socket.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/core/socket.c b/src/core/socket.c index 35531ed..8ecc9f9 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -597,13 +597,7 @@ static void socket_dump(Unit *u, FILE *f, const char *prefix)

[systemd-devel] [PATCH] test-resolve.c: cleanup alittle bit and make use of sockaddr_pretty()

2014-03-15 Thread Daniel Buch
/test-resolve.c +++ b/src/libsystemd/sd-resolve/test-resolve.c @@ -4,6 +4,7 @@ This file is part of systemd. Copyright 2005-2008 Lennart Poettering + Copyright 2014 Daniel Buch systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General

[systemd-devel] [PATCH] test-resolve.c: Cleanup and make use of sockaddr_pretty()

2014-03-26 Thread Daniel Buch
/test-resolve.c +++ b/src/libsystemd/sd-resolve/test-resolve.c @@ -4,6 +4,7 @@ This file is part of systemd. Copyright 2005-2008 Lennart Poettering + Copyright 2014 Daniel Buch systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General

[systemd-devel] [PATCH] build-sys: workaround scan-build bug to fix ./autogen.sh s

2014-04-01 Thread Daniel Buch
It seems to be a clang-analyzer problem since it don't behave like clang-compiler regarding -std={c99,gnu99} --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 9b4781c..449a2e6 100755 --- a/autogen.sh +++ b/autogen.sh @@ -72,7 +72,7 @@

[systemd-devel] [KDBUS PATCH] remove unused variable

2014-04-09 Thread Daniel Buch
--- connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection.c b/connection.c index 2d69f17..5e7d553 100644 --- a/connection.c +++ b/connection.c @@ -1024,7 +1024,7 @@ int kdbus_cmd_msg_recv(struct kdbus_conn *conn, /* just drop the message */

Re: [systemd-devel] [KDBUS PATCH] remove unused variable

2014-04-09 Thread Daniel Buch
No problem :) 2014-04-09 11:46 GMT+02:00 Daniel Mack dan...@zonque.org: On 04/09/2014 11:43 AM, Daniel Buch wrote: --- connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection.c b/connection.c index 2d69f17..5e7d553 100644 --- a/connection.c

Re: [systemd-devel] error: undefined reference to `sd_event_source_unref' while the function exists in source

2014-05-14 Thread Daniel Buch
Have you compiled with: -lsystemd? 2014-05-14 11:48 GMT+02:00 Hurry Zeng winew...@qq.com: Hi All, i tried to compile some source code on archlinux (v 2014.05.01), but i got an error: (header missing ?) fatal error:* systemd/sd-event.h*: No such file or directory #include

[systemd-devel] [PATCH] bus-policy.c: use draw_special_char(DRAW_ARROW)

2014-06-08 Thread Daniel Buch
Lets allow LC_ALL=C without corrupted output --- src/bus-proxyd/bus-policy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bus-proxyd/bus-policy.c b/src/bus-proxyd/bus-policy.c index 053495c..2df4bf7 100644 --- a/src/bus-proxyd/bus-policy.c +++

[systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Daniel Buch
Not sure this is an appropiate fix, feel free to leave it out --- src/shared/ask-password-api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/ask-password-api.c b/src/shared/ask-password-api.c index 5997a03..39eab0d 100644 --- a/src/shared/ask-password-api.c +++

Re: [systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Daniel Buch
(prerelease) (GCC) 2014-06-26 13:12 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Thu, Jun 26, 2014 at 12:50:40PM +0200, Daniel Buch wrote: Not sure this is an appropiate fix, feel free to leave it out --- src/shared/ask-password-api.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [systemd-devel] [PATCH] ask-password-api.c: fix assigned but not read warning

2014-06-26 Thread Daniel Buch
You are right! Sorry for the confusion 2014-06-26 14:04 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Thu, Jun 26, 2014 at 01:49:56PM +0200, Daniel Buch wrote: Well we assign fd to be -1 above signalfd() and afterwards never read it. That's what my compiler complained about

[systemd-devel] [PATCH] systemd-verify: call help() and exit if no CL-argument

2014-07-21 Thread Daniel Buch
Im not sure if we want the help approach or just fail? I can change this and resed if you want. Assertion 'strv_uniq(ans)' failed at src/verify/verify.c:53, function generate_path(). Aborting. [1]4795 abort (core dumped) systemd-verify --- src/verify/verify.c | 9 - 1 file

[systemd-devel] [PATCH] coredump: suppress uninitialized sz warning

2014-07-23 Thread Daniel Buch
Its false positive but lets make gcc happy --- src/journal/coredump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/journal/coredump.c b/src/journal/coredump.c index 182c2b1..a361a51 100644 --- a/src/journal/coredump.c +++ b/src/journal/coredump.c @@ -700,7 +700,7 @@

[systemd-devel] [PATCH] analyze: fix seg-fault with no cl-argument

2014-07-24 Thread Daniel Buch
We need to check if argv[1] is set before compare --- src/analyze/analyze.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/analyze/analyze.c b/src/analyze/analyze.c index 66e2aab..83da7f5 100644 --- a/src/analyze/analyze.c +++ b/src/analyze/analyze.c @@ -1349,7 +1349,7 @@

[systemd-devel] systemd-timesync fails

2014-08-13 Thread Daniel Buch
With current git i noticed systemd-timesyncd failed and complain like this, log attached below. aug 13 20:12:08 dbuch-laptop systemd[1]: Starting Network Time Synchronization... aug 13 20:12:08 dbuch-laptop systemd[1]: systemd-timesyncd.service: main process exited, code=exited, status=1/FAILURE

Re: [systemd-devel] systemd-timesync fails

2014-08-13 Thread Daniel Buch
: 1407956263.730 constant : 1 offset : -0.355 sec freq offset : +0 (0 ppm) interval/delta/delay/jitter/drift 32s/-0.355s/0.040s/0.000s/+0ppm 2014-08-13 20:47 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Wed, 13.08.14 20:35, Daniel Buch (boogiewasth...@gmail.com) wrote

Re: [systemd-devel] systemd-timesync fails

2014-08-13 Thread Daniel Buch
Cool, its fixed. 2014-08-13 21:08 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Wed, 13.08.14 21:01, Daniel Buch (boogiewasth...@gmail.com) wrote: Indeed, i run gnome and gnomes NetworkManager. I just tested the binary approach with LOG_LEVEL=debug (log attached below

[systemd-devel] [PATCH] networkctl: color status dump without link name

2014-08-13 Thread Daniel Buch
Lets mimic colored operational state dump as if link name is appiled --- src/network/networkctl.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/network/networkctl.c b/src/network/networkctl.c index 731ad27..9c4c1b7 100644 --- a/src/network/networkctl.c +++

Re: [systemd-devel] [PATCH] resolved: fix warnings

2014-08-14 Thread Daniel Buch
I just hit this assert on my arch system with gcc 4.9, dbuch-laptop systemd-resolved[457]: Assertion 's-protocol == DNS_PROTOCOL_LLMNR' failed at src/resolve/resolved-dns-scope.c:369 2014-08-14 19:58 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 19.07.14 10:37, Thomas H.P.

[systemd-devel] [PATCH 1/2] path_lookup: moved _cleanup_lookup_paths_free_ from install.c to path-lookup.h

2013-10-27 Thread Daniel Buch
--- src/shared/install.c | 1 - src/shared/path-lookup.h | 2 ++ src/systemctl/systemctl.c | 4 +--- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/shared/install.c b/src/shared/install.c index 3bced1a..987b36d 100644 --- a/src/shared/install.c +++ b/src/shared/install.c

[systemd-devel] [PATCH 2/2] test-strv.c: added STRV_FOREACH and STRV_FOREACH_BACKWARDS

2013-10-27 Thread Daniel Buch
--- src/test/test-strv.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index c3d536d..de5cef0 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -282,6 +282,34 @@ static void test_strv_append(void) {

[systemd-devel] [PATCH 1/3] test-strv.c: added strv_split

2013-10-31 Thread Daniel Buch
--- src/test/test-strv.c | 16 1 file changed, 16 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index f32d02e..e96200e 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -156,6 +156,21 @@ static void test_strv_quote_unquote(const char* const

[systemd-devel] [PATCH 2/3] test-strv.c: added strv_split_newline

2013-10-31 Thread Daniel Buch
--- src/test/test-strv.c | 16 1 file changed, 16 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index e96200e..9b51d82 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -171,6 +171,21 @@ static void test_strv_split(void) { } }

[systemd-devel] [PATCH 3/3] test-strv.c: added test_strv_remove_prefix

2013-10-31 Thread Daniel Buch
--- src/test/test-strv.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index 9b51d82..e468859 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -199,6 +199,22 @@ static void test_strv_split_nulstr(void) {

[systemd-devel] test-strv.c

2013-10-31 Thread Daniel Buch
Hi there, By these 3 patches test_strv.c should be complete Sorry for the tap mess i pushed, wont happen again ;) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] test-strv.c

2013-11-06 Thread Daniel Buch
zbys...@in.waw.pl On Thu, Oct 31, 2013 at 10:03:07AM +0100, Daniel Buch wrote: Hi there, By these 3 patches test_strv.c should be complete Applied as one patch. Sorry for the tap mess i pushed, wont happen again ;) Mess, what mess? :) Zbyszek

[systemd-devel] [PATCH] tree-wide usage of %m specifier instead of strerror(errno)

2013-11-26 Thread Daniel Buch
Also for log_error() except where a specific error is specified e.g. errno ? strerror(errno) : Some user specified message --- TODO | 2 -- src/core/automount.c | 2 +- src/core/main.c| 2 +- src/core/manager.c | 2 +-

[systemd-devel] [RFC] Initial work for asyncns push

2013-12-10 Thread Daniel Buch
Hi, So i layed the foundation of this libary to fit systemd But what is actually desired? C99 or C89? Do we want it to be public or private? Is modernization desired? Daniel Buch (1): Initial libsystemd-asyncns commit Makefile.am | 23 + src/libsystemd-asyncns

Re: [systemd-devel] [RFC] Initial work for asyncns push

2013-12-10 Thread Daniel Buch
Cool, thanks you for the very decent reply.. I will work on this the next few days, you can then expect some new RFC's :) 2013/12/11 Lennart Poettering lenn...@poettering.net On Wed, 11.12.13 02:18, Lennart Poettering (lenn...@poettering.net) wrote: C99 or C89? Do we want it to be public

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2014-01-03 Thread Daniel Buch
Yes im still working on it (Should have been finished days ago. 24 hours a day is again not enough -.-). So far i went for the threaded version, and cleaned up stuff according to this mail thread. And i updated it to match systemd with c99 null initialisation of structs etc. That might be wrong

[systemd-devel] [PATCH] initial sd-dns commit

2014-01-06 Thread Daniel Buch
Hi again, Im hopeing we can continue in-tree since its easier from here, and im unable to get the time i want at the moment. But i will ofcourse continue to help where i can when time permits. I think the file nameing and locations are right? Anyway heres what i got so far --- Makefile.am

[systemd-devel] [BUG] 8b255ecd99dfee

2014-01-11 Thread Daniel Buch
Hi, bisect tells me this commit, 8b255ecd99dfee, causes gdm to crash when --enable-kdbus is configured and the kdbus module isn't loaded. Gdm starts but crashes and restarts as you enter your (correct)password. Is this correct? Or am i missing something?

[systemd-devel] [PATCH 2/2] sd-dns: rename structs and functions with sd_ prefix

2014-01-12 Thread Daniel Buch
--- src/libsystemd-bus/dns-util.h | 12 ++--- src/libsystemd-bus/sd-dns.c | 100 +- src/libsystemd-bus/test-dns.c | 26 +-- src/systemd/sd-dns.h | 46 +-- 4 files changed, 92 insertions(+), 92 deletions(-) diff --git

[systemd-devel] [PATCH 1/2] sd-dns: Codeing style cleanup

2014-01-12 Thread Daniel Buch
--- src/libsystemd-bus/sd-dns.c | 34 -- src/libsystemd-bus/test-dns.c | 21 ++--- 2 files changed, 30 insertions(+), 25 deletions(-) diff --git a/src/libsystemd-bus/sd-dns.c b/src/libsystemd-bus/sd-dns.c index 8126cb3..0f90d02 100644 ---

Re: [systemd-devel] [PATCH 2/2] sd-dns: rename structs and functions with sd_ prefix

2014-01-13 Thread Daniel Buch
Ohh.. that sounds reasonable, i can do the git mv and renameig (And squash to a single commit) when the decision is set :) 2014/1/13 Tom Gundersen t...@jklm.no On Mon, Jan 13, 2014 at 8:56 AM, Daniel Buch boogiewasth...@gmail.com wrote: Okay, guess thats right? Second opinion, lennart? Kay

[systemd-devel] [PATCH 1/2] sd_resolv: Rename structs- and function names to sd_resolv

2014-01-14 Thread Daniel Buch
--- src/libsystemd/resolv-util.h | 12 +++--- src/libsystemd/sd-resolv.c | 100 +-- src/libsystemd/test-resolv.c | 38 src/systemd/sd-resolv.h | 80 +- 4 files changed, 115 insertions(+), 115

[systemd-devel] [PATCH 2/2] sd-resolv: rename old asyncns variables

2014-01-14 Thread Daniel Buch
--- src/libsystemd/sd-resolv.c | 282 +-- src/libsystemd/test-resolv.c | 26 ++-- src/systemd/sd-resolv.h | 48 3 files changed, 178 insertions(+), 178 deletions(-) diff --git a/src/libsystemd/sd-resolv.c b/src/libsystemd/sd-resolv.c

[systemd-devel] [PATCH] sd-resolv: declare functions from .h public

2014-01-14 Thread Daniel Buch
--- src/libsystemd/sd-resolv.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/libsystemd/sd-resolv.c b/src/libsystemd/sd-resolv.c index b8288ba..cd79a6c 100644 --- a/src/libsystemd/sd-resolv.c +++ b/src/libsystemd/sd-resolv.c @@

Re: [systemd-devel] [PATCH] sd-resolv: declare functions from .h public

2014-01-14 Thread Daniel Buch
releases (we'll use it internally first to make sure it is the way we want it). Or are there any benefits to these annotations even when the symbols are not exported? -t On Tue, Jan 14, 2014 at 3:04 PM, Daniel Buch boogiewasth...@gmail.com wrote: --- src/libsystemd/sd-resolv.c | 38

[systemd-devel] [PATCH 1/2] sd-resolve: get rid of _t post-fixes for sd_ objects

2014-01-15 Thread Daniel Buch
We dont want _t prefixes, right? --- src/libsystemd/resolve-util.h | 2 +- src/libsystemd/sd-resolve.c | 72 +-- src/libsystemd/test-resolve.c | 4 +-- src/systemd/sd-resolve.h | 42 - 4 files changed, 60 insertions(+), 60

[systemd-devel] [PATCH 2/2][RFC] sd-resolve: rename structs to fit coding-style e.g 'struct MixedCase'

2014-01-15 Thread Daniel Buch
lets get this right once, and if not for all, atleast for now :) So comments and input about nameing is very welcome. Cheers --- src/libsystemd/sd-resolve.c | 210 ++-- 1 file changed, 105 insertions(+), 105 deletions(-) diff --git

[systemd-devel] [PATCH 2/3] sd-resolve: Allocate objects with new()

2014-01-18 Thread Daniel Buch
--- src/libsystemd/sd-resolve.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libsystemd/sd-resolve.c b/src/libsystemd/sd-resolve.c index 6958aa9..7cc8dc4 100644 --- a/src/libsystemd/sd-resolve.c +++ b/src/libsystemd/sd-resolve.c @@ -423,7 +423,7 @@ sd_resolve*

[systemd-devel] [PATCH 1/3] sd-resolve: get rid of sd_resolve_freeanswer()

2014-01-18 Thread Daniel Buch
--- TODO | 1 - src/libsystemd/resolve-util.h | 2 -- src/libsystemd/sd-resolve.c | 11 --- src/libsystemd/test-resolve.c | 2 +- 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/TODO b/TODO index a567669..91a7bda 100644 --- a/TODO +++ b/TODO @@

[systemd-devel] [PATCH 3/3] sd-resolve: rename get_next() and get_n_queries() + cleanup

2014-01-18 Thread Daniel Buch
--- TODO| 1 - src/libsystemd/sd-resolve.c | 4 ++-- src/systemd/sd-resolve.h| 9 +++-- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 91a7bda..a842158 100644 --- a/TODO +++ b/TODO @@ -38,7 +38,6 @@ Features: - maybe simplify

[systemd-devel] [PATCH 2/4] sd-resolve: Allocate objects with new()

2014-01-18 Thread Daniel Buch
--- src/libsystemd/sd-resolve.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libsystemd/sd-resolve.c b/src/libsystemd/sd-resolve.c index 6958aa9..7cc8dc4 100644 --- a/src/libsystemd/sd-resolve.c +++ b/src/libsystemd/sd-resolve.c @@ -423,7 +423,7 @@ sd_resolve*

[systemd-devel] [PATCH 3/4] sd-resolve: rename get_next() and get_n_queries() + cleanup

2014-01-18 Thread Daniel Buch
--- TODO| 1 - src/libsystemd/sd-resolve.c | 4 ++-- src/systemd/sd-resolve.h| 9 +++-- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 91a7bda..a842158 100644 --- a/TODO +++ b/TODO @@ -38,7 +38,6 @@ Features: - maybe simplify

[systemd-devel] [PATCH 1/4] sd-resolve: get rid of sd_resolve_freeanswer()

2014-01-18 Thread Daniel Buch
--- TODO | 1 - src/libsystemd/resolve-util.h | 2 -- src/libsystemd/sd-resolve.c | 11 --- src/libsystemd/test-resolve.c | 2 +- 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/TODO b/TODO index a567669..91a7bda 100644 --- a/TODO +++ b/TODO @@

[systemd-devel] [PATCH 4/4] sd-resolv: declare functions from .h public

2014-01-18 Thread Daniel Buch
--- src/libsystemd/sd-resolve.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/libsystemd/sd-resolve.c b/src/libsystemd/sd-resolve.c index b6bf8d4..464967b 100644 --- a/src/libsystemd/sd-resolve.c +++ b/src/libsystemd/sd-resolve.c @@

[systemd-devel] [PATCH] NEWS: sd-resolv.h is sd-resolve.h

2014-02-17 Thread Daniel Buch
--- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 6a6635b..5da5891 100644 --- a/NEWS +++ b/NEWS @@ -212,7 +212,7 @@ CHANGES WITH 209: time, and those which should be run only at boot (for example, a line that creates

[systemd-devel] tests

2013-01-30 Thread Daniel Buch
I did some improvements on strv-test.c and added additional test, more is on its way. Patch files is attached. What do you think? 0001-test-strv.c-Split-tests-into-seperate-functions.patch Description: Binary data 0002-test-strv.c-test-strv_join-added.patch Description: Binary data

[systemd-devel] strv tests

2013-02-11 Thread Daniel Buch
I made tests for: strv_merge strv_merge_concat strv_append ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] strv tests

2013-02-11 Thread Daniel Buch
And now with patch files. 2013/2/11 Daniel Buch boogiewasth...@gmail.com I made tests for: strv_merge strv_merge_concat strv_append 0003-test-strv.c-added-strv_append-test.patch Description: Binary data 0002-test-strv.c-added-strv_merge_concat-test.patch Description: Binary data

[systemd-devel] [PATCH 1/4] test-strv.c: added strv_merge test

2013-02-13 Thread Daniel Buch
--- src/test/test-strv.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index 07aac3a..3ed5a09 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -158,6 +158,24 @@ static void test_strv_sort(void) {

[systemd-devel] [PATCH 2/4] test-strv.c: added strv_merge_concat test

2013-02-13 Thread Daniel Buch
--- src/test/test-strv.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index 3ed5a09..fabc26e 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -158,6 +158,20 @@ static void test_strv_sort(void) {

[systemd-devel] [PATCH 3/4] test-strv.c: added strv_append test

2013-02-13 Thread Daniel Buch
--- src/test/test-strv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index fabc26e..535685f 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -190,6 +190,19 @@ static void test_strv_merge(void) {

[systemd-devel] [PATCH 4/4] test-strv.c: Changed assert() to assert_se()

2013-02-13 Thread Daniel Buch
test-strv.c: Indent fix --- src/test/test-strv.c | 96 ++-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index 535685f..a8801b5 100644 --- a/src/test/test-strv.c +++

[systemd-devel] [PATCH 1/3] test-strv.c: added strv_split_nulstr() test

2013-02-17 Thread Daniel Buch
--- src/test/test-strv.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index a8801b5..ea1f088 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -100,6 +100,18 @@ static void test_strv_join(void) {

[systemd-devel] [PATCH 2/3] test-strv.c: added OOM check for current tests

2013-02-17 Thread Daniel Buch
--- src/test/test-strv.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index ea1f088..e33568c 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -85,18 +85,23 @@ static void test_strv_join(void) { };

[systemd-devel] [PATCH 3/3] test-strv.c: ported test_specifier_printf() to _cleanup_free_ + assert_se + cleanup

2013-02-17 Thread Daniel Buch
--- src/test/test-strv.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index e33568c..1718f56 100644 --- a/src/test/test-strv.c +++ b/src/test/test-strv.c @@ -27,7 +27,7 @@ #include strv.h static void

[systemd-devel] [PATCH] test-strv.c: added OOM check for current tests

2013-02-18 Thread Daniel Buch
New OOM check patch: I do assert_se() before variable is used to do correct check. --- src/test/test-strv.c | 16 1 file changed, 16 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index d2eb225..504415a 100644 --- a/src/test/test-strv.c +++

[systemd-devel] [PATCH] test-hashmap.c first part

2013-03-26 Thread Daniel Buch
This is first part of hashmap test unit - last part is in development. So review is much appreciated Thanks in advance. --- Makefile.am | 10 +++ src/test/test-hashmap.c | 203 2 files changed, 213 insertions(+) create mode 100644

[systemd-devel] [PATCH 1/2] test-hashmap.c first part

2013-04-26 Thread Daniel Buch
-hashmap.c @@ -0,0 +1,506 @@ +/*** + This file is part of systemd + + Copyright 2013 Daniel Buch + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either version 2.1

[systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Daniel Buch
--- src/shared/hashmap.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h index 26bd030..f52517f 100644 --- a/src/shared/hashmap.h +++ b/src/shared/hashmap.h @@ -57,11 +57,11 @@ int hashmap_ensure_allocated(Hashmap **h,

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Daniel Buch
at 06:40:08PM +0200, Daniel Buch wrote: --- src/shared/hashmap.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h index 26bd030..f52517f 100644 --- a/src/shared/hashmap.h +++ b/src/shared/hashmap.h @@ -57,11

[systemd-devel] [PATCH] test-hashmap.c: added unit-test for hashmap

2013-04-26 Thread Daniel Buch
/test/test-prioq.c diff --git a/src/test/test-hashmap.c b/src/test/test-hashmap.c new file mode 100644 index 000..7c55c87 --- /dev/null +++ b/src/test/test-hashmap.c @@ -0,0 +1,508 @@ +/*** + This file is part of systemd + + Copyright 2013 Daniel Buch + + systemd is free software; you can

Re: [systemd-devel] [PATCH] test-hashmap.c: added unit-test for hashmap

2013-05-02 Thread Daniel Buch
Thanks for review, kay! I adabted the code. So trivial_cmp() is tested with INT_TO_PTR('a') - i guess its ok to use 'a' since its evaulated to int? The casts.. Dont know :p they are removed :) 2013/4/26 Kay Sievers k...@vrfy.org On Fri, Apr 26, 2013 at 8:49 PM, Daniel Buch boogiewasth

[systemd-devel] [PATCH] test-hashmap.c: added unit-test for hashmap

2013-05-02 Thread Daniel Buch
-hashmap.c b/src/test/test-hashmap.c new file mode 100644 index 000..2aead79 --- /dev/null +++ b/src/test/test-hashmap.c @@ -0,0 +1,508 @@ +/*** + This file is part of systemd + + Copyright 2013 Daniel Buch + + systemd is free software; you can redistribute it and/or modify it + under the terms

[systemd-devel] [Question/bug] Timeout after bus_event_loop_with_idle() change.

2014-10-03 Thread Daniel Buch
Hi, With current git and since 430e21c2f7e77d600257ead56419f51 i keep on getting timeout on these units dbuch@dbuch-laptop ~/dev/systemd (git)-[master] % systemctl --failed UNIT LOAD ACTIVE SUBDESCRIPTION ● systemd-hostnamed.service loaded failed failed Hostname

Re: [systemd-devel] [Question/bug] Timeout after bus_event_loop_with_idle() change.

2014-10-04 Thread Daniel Buch
]: systemd-hostnamed.service failed. 2014-10-04 7:12 GMT+02:00 Andrei Borzenkov arvidj...@gmail.com: В Fri, 3 Oct 2014 22:00:50 +0200 Daniel Buch boogiewasth...@gmail.com пишет: Hi, With current git and since 430e21c2f7e77d600257ead56419f51 i keep on getting timeout on these units dbuch

Re: [systemd-devel] [Question/bug] Timeout after bus_event_loop_with_idle() change.

2014-10-06 Thread Daniel Buch
18:26 GMT+02:00 David Herrmann dh.herrm...@gmail.com: Hi On Fri, Oct 3, 2014 at 10:00 PM, Daniel Buch boogiewasth...@gmail.com wrote: Hi, With current git and since 430e21c2f7e77d600257ead56419f51 i keep on getting timeout on these units I also occasionally get timeouts on bus

Re: [systemd-devel] [Question/bug] Timeout after bus_event_loop_with_idle() change.

2014-10-09 Thread Daniel Buch
No runtime kdbus but --enable-kdbus configuration at build time Den 08/10/2014 17.11 skrev Lennart Poettering lenn...@poettering.net: On Fri, 03.10.14 22:00, Daniel Buch (boogiewasth...@gmail.com) wrote: Hi, With current git and since 430e21c2f7e77d600257ead56419f51 i keep on getting

Re: [systemd-devel] [Question/bug] Timeout after bus_event_loop_with_idle() change.

2014-10-09 Thread Daniel Buch
'systemctl list-unit-files'. They used to timeout after 2 minutes so this looks promising. 2014-10-09 18:23 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Fri, 03.10.14 22:00, Daniel Buch (boogiewasth...@gmail.com) wrote: Hi, With current git and since 430e21c2f7e77d600257ead56419f51 i

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-11 Thread Daniel Buch
Nice, I was in the process of implementing this. Looks good to me. But I think it would be better to use vi instead of vim if no editor is set. Vim is not installed on every system as default but vi is most likely. Den 11/10/2014 18.37 skrev Ronny Chevalier chevalier.ro...@gmail.com: It helps

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-14 Thread Daniel Buch
My general understanding is equal to dale. But with some consideration it led me to agree with the warning approach. Its no big deal setting EDITOR. Den 14/10/2014 01.06 skrev Ronny Chevalier chevalier.ro...@gmail.com: 2014-10-13 16:13 GMT+02:00 Simon McVittie simon.mcvit...@collabora.co.uk :

Re: [systemd-devel] [PATCH] switch_root: do not fail, if base_filesystem_create() failed

2014-11-04 Thread Daniel Buch
I think you might want to cast it to avoid compiler warning. Like: (void) base_filesystem_create() Den 04/11/2014 17.36 skrev har...@redhat.com: From: Harald Hoyer har...@redhat.com Not all switch roots are like base_filesystem_create() wants them to look like. They might even boot, if they

[systemd-devel] [PATCH] sysusers.c: make use of negative_errno()

2014-11-04 Thread Daniel Buch
This is recently added by david. And i like replace return -errno treewide if desired? I suppose its safe and correct to assume every return -errno can be replaced? --- src/sysusers/sysusers.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [systemd-devel] [PATCH] sysusers.c: make use of negative_errno()

2014-11-04 Thread Daniel Buch
Nevermind, ignore this. This is of course only where gcc complaints. Den 04/11/2014 20.53 skrev Daniel Buch boogiewasth...@gmail.com: This is recently added by david. And i like replace return -errno treewide if desired? I suppose its safe and correct to assume every return -errno can

Re: [systemd-devel] test-capabilities fail and systemd-timesyncd broken

2015-02-04 Thread Daniel Buch
Okay, Tom fixed this with 057255fbbf2ecb1c46e025b04087fa9340d9880d. 2015-02-03 21:50 GMT+01:00 Daniel Buch boogiewasth...@gmail.com: Hi, This commit 51ddf61540976fc7b09ce5 solved systemd-resolved, but broke systemd-timesyncd. Atleast on my system. dbuch@dbuch-laptop ~ % lscpu | grep -i

[systemd-devel] test-capabilities fail and systemd-timesyncd broken

2015-02-03 Thread Daniel Buch
Hi, This commit 51ddf61540976fc7b09ce5 solved systemd-resolved, but broke systemd-timesyncd. Atleast on my system. dbuch@dbuch-laptop ~ % lscpu | grep -i byte Byte Order:Little Endian dbuch@dbuch-laptop ~ % SYSTEMD_LOGLEVEL=debug sudo /usr/lib/systemd/systemd-timesyncd Failed to

Re: [systemd-devel] avahi disconnects from bus with kdbus

2015-02-11 Thread Daniel Buch
Nice, everything works flawlessly with current git now. Good job! 2015-02-10 10:34 GMT+01:00 Daniel Buch boogiewasth...@gmail.com: Hi, This is just a heads up. Avahi-daemon doesn't work on my system with kdbus and bus-proxyd. I appended a log. I hope this helps. Otherwise every thing works

Re: [systemd-devel] avahi disconnects from bus with kdbus

2015-02-12 Thread Daniel Buch
No problem, i will try do some extensive testing the next couple of days. kdbus is now added to kernel entry cmdline :) 2015-02-12 19:12 GMT+01:00 David Herrmann dh.herrm...@gmail.com: Hi On Wed, Feb 11, 2015 at 11:17 AM, Daniel Buch boogiewasth...@gmail.com wrote: Nice, everything works

Re: [systemd-devel] avahi disconnects from bus with kdbus

2015-02-12 Thread Daniel Buch
-daemon 0.6.31 exiting. This happens when you try to log on empathy, more specifically Peoples Nearby. Let me know if you want additional logs or anything. Cheers, Daniel 2015-02-12 23:46 GMT+01:00 Daniel Buch boogiewasth...@gmail.com: No problem, i will try do some extensive testing the next

[systemd-devel] avahi disconnects from bus with kdbus

2015-02-10 Thread Daniel Buch
Hi, This is just a heads up. Avahi-daemon doesn't work on my system with kdbus and bus-proxyd. I appended a log. I hope this helps. Otherwise every thing works quite well for me with current systemd,kdbus git. feb 10 10:11:12 dbuch-laptop avahi-daemon[2561]: avahi-daemon 0.6.31 exiting. feb 10

Re: [systemd-devel] avahi disconnects from bus with kdbus

2015-02-15 Thread Daniel Buch
at 11:32 PM, Daniel Buch boogiewasth...@gmail.com wrote: Hi again, I found another problem, again with avahi-daemon but in combination with Telepathy haze. feb 13 08:26:39 dbuch-laptop systemd-coredump[1211]: Process 1167 (telepathy-haze) of user 1000 dumped core

[systemd-devel] journal-.gitignore-add-audit_type-from-name

2015-04-30 Thread Daniel Buch
From 785b1367fedb912e91074360c0961209ac5dc9f8 Mon Sep 17 00:00:00 2001 From: Daniel Buch boogiewasth...@gmail.com Date: Thu, 30 Apr 2015 21:20:57 +0200 Subject: [PATCH] journal: .gitignore add audit_type-from-name* --- src/journal/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git

[systemd-devel] PATCH: systemctl: null-initialize pointer with cleanup attribute

2015-05-06 Thread Daniel Buch
Patch attached. (git send-email currently brokken) declarations with _cleanup_free_ attribute needs to be NULL initialized. From e242049410bb8373f8724ac24328e0f024b9929b Mon Sep 17 00:00:00 2001 From: Daniel Buch boogiewasth...@gmail.com Date: Wed, 6 May 2015 10:28:08 +0200 Subject: [PATCH

[systemd-devel] Testing kdbus and bus-proxy

2015-07-01 Thread Daniel Buch
Hi, I been testing kdbus (v4.1 branch) and bus-proxy on kernel v4.1 (arch linux) and i just came across an inconsistency with my plain laptop/desktop setup. dleyna crashes as i start gnome-calendar. Also calendar doesn't seem to run aswell, im not able to check my entries (Not sure what's

Re: [systemd-devel] Testing kdbus and bus-proxy

2015-07-01 Thread Daniel Buch
Alright, i just updated kdbus branch, and these issues is solved.. ons. 1. jul. 2015 kl. 22.20 skrev Daniel Buch boogiewasth...@gmail.com: Hi, I been testing kdbus (v4.1 branch) and bus-proxy on kernel v4.1 (arch linux) and i just came across an inconsistency with my plain laptop/desktop