[systemd-devel] [PATCH] man/systemctl: document enable on masked units

2014-10-08 Thread Jan Synacek
--- man/systemctl.xml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/man/systemctl.xml b/man/systemctl.xml index b28a3b7..d2fa3b3 100644 --- a/man/systemctl.xml +++ b/man/systemctl.xml @@ -924,6 +924,9 @@ kobject-uevent 1 systemd-udevd-kernel.socket

Re: [systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-08 Thread Jan Synacek
() for the standard errno? -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] journalctl: make --utc work everywhere

2014-10-08 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Fri, 03.10.14 09:51, Jan Synacek (jsyna...@redhat.com) wrote: The --utc option was introduced by commit 9fd290443f5f99fca0dcd4216b1de70f7d3b8db1. Howerver, the implementation was incomplete. --- src/journal/journalctl.c | 14

Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-07 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Mon, 06.10.14 13:21, Jan Synacek (jsyna...@redhat.com) wrote: Hmm with this change in place we'd have different behaviour for the cases where systemctl executes the operation client-side, and when it goes via the bus. We really should keep

[systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-07 Thread Jan Synacek
--- src/shared/install.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/shared/install.c b/src/shared/install.c index fa064c2..945bb27 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -1516,6 +1516,19 @@ int unit_file_enable( return r;

[systemd-devel] [PATCH v2] core: don't allow enabling if unit is masked

2014-10-07 Thread Jan Synacek
to a common path, so uses with and without dbus are affected Jan Synacek (1): core: don't allow enabling if unit is masked src/shared/install.c | 13 + 1 file changed, 13 insertions(+) -- 1.9.3 ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-06 Thread Jan Synacek
https://bugzilla.redhat.com/show_bug.cgi?id=1149069 --- src/core/dbus-manager.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c index 533ce43..c2d52b2 100644 --- a/src/core/dbus-manager.c +++ b/src/core/dbus-manager.c

[systemd-devel] [PATCH] journalctl: make --utc work everywhere

2014-10-03 Thread Jan Synacek
The --utc option was introduced by commit 9fd290443f5f99fca0dcd4216b1de70f7d3b8db1. Howerver, the implementation was incomplete. --- src/journal/journalctl.c | 14 +++--- src/shared/logs-show.c | 2 +- src/shared/time-util.c | 19 +++ src/shared/time-util.h | 3 ++-

[systemd-devel] [PATCH] journalctl: add --utc option

2014-10-02 Thread Jan Synacek
Introduce option to display time in UTC. --- man/journalctl.xml | 7 +++ src/journal/journalctl.c | 11 ++- src/shared/logs-show.c | 8 +--- src/shared/output-mode.h | 1 + 4 files changed, 23 insertions(+), 4 deletions(-) diff --git a/man/journalctl.xml

[systemd-devel] [PATCH v2] journalctl: add --utc option

2014-10-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Thu, 02.10.14 09:36, Jan Synacek (jsyna...@redhat.com) wrote: This should not be part of OutputMode, but of OutputFlags! Fixed. Otherwise looks good. Do you have commit access? If so, please push after fixing the issue above. I don't

Re: [systemd-devel] [PATCH v2] journalctl: add --utc option

2014-10-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Thu, 02.10.14 14:39, Jan Synacek (jsyna...@redhat.com) wrote: Introduce option to display time in UTC. Thanks! Applied! Thanks! I just realized that the patch was incomplete. There are at least two different places that need

Re: [systemd-devel] Incorrect logic when /etc/machine-id is missing

2014-10-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Mon, 22.09.14 11:27, Jan Synacek (jsyna...@redhat.com) wrote: Hello, I believe that the following code is not correct: src/core/machine-id-setup.c:188-190: mkdir_parents(etc_machine_id, 0755); fd = open(etc_machine_id, O_RDWR

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Jan Synacek
Karel Zak k...@redhat.com writes: On Thu, Oct 02, 2014 at 03:32:54PM +0200, Lennart Poettering wrote: On Thu, 25.09.14 09:54, Jan Synacek (jsyna...@redhat.com) wrote: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-30 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: I pushed your patch with some significant changes, and some follow-up cleanups. Please check that things work for you. The problem with reading but back discards settings remains. Zbyszek It works for me, thanks! -- Jan Synacek

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from /etc/fstab. Hm, wouldn't it be enough to simply pass through the options like with mounts, using

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Mon, Sep 29, 2014 at 01:23:30PM +0200, Jan Synacek wrote: Ping, could anybody comment, please? C'mon, it's been four days, two of that being the weekend. Sorry for that, it felt like way over a week already... -- Jan Synacek Software

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-25 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from /etc/fstab. Hm, wouldn't it be enough to simply pass through the options like with mounts, using the Options= option? This might be less work

[systemd-devel] [PATCH] swap: introduce Discard property

2014-09-24 Thread Jan Synacek
Process possible discard values from /etc/fstab. --- man/systemd.swap.xml | 14 + src/core/execute.c| 25 src/core/execute.h| 1 + src/core/load-fragment-gperf.gperf.m4 | 1 + src/core/swap.c

Re: [systemd-devel] Incorrect logic when /etc/machine-id is missing

2014-09-23 Thread Jan Synacek
Simon McVittie simon.mcvit...@collabora.co.uk writes: On 22/09/14 10:27, Jan Synacek wrote: If /etc/machine-id is missing on the system, the first open() call should probably handle that case. That's actually not true (at least on my system), because the underlying filesystem is read-only

[systemd-devel] Incorrect logic when /etc/machine-id is missing

2014-09-22 Thread Jan Synacek
/mounting of machine-id supposed to work? Cheers, -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-18 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Mon, Sep 15, 2014 at 2:00 PM, Jan Synacek jsyna...@redhat.com wrote: David Herrmann dh.herrm...@gmail.com writes: Your original patch is right, too. But I'm not sure which one to prefer. Given that we export systemd-sysctl as rpm macro, I

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Fri, Sep 12, 2014 at 11:21 AM, Jan Synacek jsyna...@redhat.com wrote: The prefix is always tested against normalized property names. --- src/sysctl/sysctl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/sysctl/sysctl.c b

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Mon, Sep 15, 2014 at 10:00 AM, Jan Synacek jsyna...@redhat.com wrote: David Herrmann dh.herrm...@gmail.com writes: Nevertheless, the documentation should clearly state which input is expected and the current code is definitely wrong

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Mon, Sep 15, 2014 at 11:26 AM, Jan Synacek jsyna...@redhat.com wrote: David Herrmann dh.herrm...@gmail.com writes: Hi On Mon, Sep 15, 2014 at 10:00 AM, Jan Synacek jsyna...@redhat.com wrote: David Herrmann dh.herrm...@gmail.com writes

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Mon, Sep 15, 2014 at 1:22 PM, Jan Synacek jsyna...@redhat.com wrote: David Herrmann dh.herrm...@gmail.com writes: A path isn't necessarily a file-system path. With sysctl, we have to ways to specify entries: 1) You can specify them via

[systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-12 Thread Jan Synacek
The prefix is always tested against normalized property names. --- src/sysctl/sysctl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c index 8ce9870..0cb0875 100644 --- a/src/sysctl/sysctl.c +++ b/src/sysctl/sysctl.c @@ -256,12 +256,6 @@ static

<    1   2