[systemd-devel] [PATCH] udev: properly detect reference to unexisting part of PROGRAM's result

--- src/udev/udev-event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c index 0b3ade0..5998be2 100644 --- a/src/udev/udev-event.c +++ b/src/udev/udev-event.c @@ -254,6 +254,8 @@ subst: cpos++;

[systemd-devel] [PATCH] udev: properly detect reference to unexisting part of PROGRAM's result

--- src/udev/udev-event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c index 0b3ade0..de31fee 100644 --- a/src/udev/udev-event.c +++ b/src/udev/udev-event.c @@ -254,6 +254,8 @@ subst: cpos++;

[systemd-devel] [PATCH] service: don't create extra cgroup for control process when reloading SysV service

Unfortunately common practice in initscripts is to have reload as an alias for restart (https://fedoraproject.org/wiki/Packaging:SysVInitScript). In that case the newly started process will be killed immediately after the reload process ends and its cgroup is destroyed. --- src/core/service.c |

[systemd-devel] [PATCH] util: always consider glusterfs as a network filesystem

--- src/shared/util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index dd67c22..6f73387 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -1500,7 +1500,8 @@ bool fstype_is_network(const char *fstype) { nfs\0

[systemd-devel] [PATCH 2/2] machine: quote a scope name in machine_save

Currently serialization in machined does not work for some names because parse_env_file is dropping backslashes from values. Than gc deletes the machine because it is unable to find the scope. --- src/machine/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[systemd-devel] [PATCH 1/2] EnvironmentFile: don't drop backslashes inside single quotes

--- src/shared/fileio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/fileio.c b/src/shared/fileio.c index f101269..0eb131d 100644 --- a/src/shared/fileio.c +++ b/src/shared/fileio.c @@ -446,11 +446,12 @@ static int parse_env_file_internal(

[systemd-devel] [PATCH] conf-files: really work under different root

search_and_fopen_* and conf_files_list function accept root parameter, but they are not using it. This leads to an issue with systemd-tmpfiles --root. The files and dirs are created in the correct location, but on the base of configuration from the normal root. --- src/shared/conf-files.c | 14

[systemd-devel] [PATCH] sysv: order initscripts which provide $network before network.target

Due to recent changes where $network maps to network-online.target it is not guaranteed that initscript which provides networking will be terminated after network.target during shutdown which is against LSB. --- src/sysv-generator/sysv-generator.c | 5 + 1 file changed, 5 insertions(+) diff

[systemd-devel] [PATCH 1/3] unit: check correct variable after strdup

--- src/core/unit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/unit.c b/src/core/unit.c index 447f201..b3f9832 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -2302,7 +2302,7 @@ int unit_deserialize(Unit *u, FILE *f, FDSet *fds) {

[systemd-devel] [PATCH 1/2] libudev: fix move_later comparison

At the beginning move_later is set to -1, but it is set to different value only if expression !move_later is true. --- src/libudev/libudev-enumerate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libudev/libudev-enumerate.c b/src/libudev/libudev-enumerate.c index

[systemd-devel] [PATCH 2/2] random-seed: we should return errno of failed loop_write

--- src/random-seed/random-seed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/random-seed/random-seed.c b/src/random-seed/random-seed.c index 4776c07..afbd500 100644 --- a/src/random-seed/random-seed.c +++ b/src/random-seed/random-seed.c @@ -157,7 +157,7 @@ int

[systemd-devel] [PATCH] core/cgroup: first print then free

--- src/core/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/cgroup.c b/src/core/cgroup.c index 3eeb475..513450a 100644 --- a/src/core/cgroup.c +++ b/src/core/cgroup.c @@ -395,8 +395,8 @@ static int unit_create_cgroups(Unit *u, CGroupControllerMask mask) {

[systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

--- src/shared/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index 3a4d196..c68ab09 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -383,7 +383,9 @@ char *split_quoted(const char *c, size_t *l, char **state) {

[systemd-devel] [PATCH] journald: assert target instead of page

--- src/journal/journal-gatewayd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/journal/journal-gatewayd.c b/src/journal/journal-gatewayd.c index b7acfba..0957dcb 100644 --- a/src/journal/journal-gatewayd.c +++ b/src/journal/journal-gatewayd.c @@ -399,7 +399,7 @@

[systemd-devel] [PATCH] dbus-manager: check return of unit_dbus_path

Reply of dbus_message_new_method_return was check twice and path from unit_dbus_path was not. --- src/core/dbus-manager.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c index 9cdecfc..003825a 100644 ---

[systemd-devel] [PATCH] systemctl: don't mangle name when it is a path

systemctl enable, disable, ... can also accept full path and in this case we don't need to alter it (rhbz#866346). --- src/systemctl/systemctl.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index

[systemd-devel] [PATCH] systemctl: append .service when unit does not have valid suffix

systemctl status a and systemctl status a.service lead to same output but systemctl status a.b and systemctl status a.b.service do not. --- src/shared/unit-name.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/src/shared/unit-name.c b/src/shared/unit-name.c index

[systemd-devel] [PATCH] udevd: add missing : to getopt_long 'e'

Parameter -e is set without additional argument in getopt and this leads to segfault when calling 'systemd-udevd -e'. --- src/udev/udevd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index ebd601e..ffc48a0 100644 --- a/src/udev/udevd.c

[systemd-devel] [PATCH] coredumpctl: check return of strndup

--- src/journal/coredumpctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/journal/coredumpctl.c b/src/journal/coredumpctl.c index f9cebb7..4f0ed58 100644 --- a/src/journal/coredumpctl.c +++ b/src/journal/coredumpctl.c @@ -262,7 +262,7 @@ static int retrieve(const void

[systemd-devel] [PATCH] systemctl: add command list-dependencies

systemctl list-dependencies lists all unit's dependecies and recursively expands all subsidiary target units into a tree. Primary purpose for this command is to show all units which are enabled in specified target. --- man/systemctl.xml | 11 +++ src/shared/util.c | 2 +

[systemd-devel] [PATCH] pager: add K to less environment

Using less as a pager sometimes breaks terminal when output is interrupted by ctrl-c. Reproducer: run 'sudo journalctl' ctrl-c. Thanks mbr...@redhat.com for the solution. --- src/shared/pager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/pager.c

[systemd-devel] [PATCH] journalctl: add --revert option to show the newest lines first

--- man/journalctl.xml | 7 ++ src/journal/journalctl.c | 59 +++- 2 files changed, 60 insertions(+), 6 deletions(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index 5ed0e1f..768c588 100644 --- a/man/journalctl.xml +++

[systemd-devel] [PATCH] journalctl: add --reverse option to show the newest lines first

--- man/journalctl.xml | 8 +++ src/journal/journalctl.c | 58 +++- 2 files changed, 60 insertions(+), 6 deletions(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index 5ed0e1f..ca940fe 100644 --- a/man/journalctl.xml +++

[systemd-devel] [PATCH 1/5] systemd-python: add missing check for return of PyDict_SetItem in _reader.c

--- src/python-systemd/_reader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/python-systemd/_reader.c b/src/python-systemd/_reader.c index 7f200d5..d3d45cc 100644 --- a/src/python-systemd/_reader.c +++ b/src/python-systemd/_reader.c @@ -208,7 +208,7 @@ static PyObject*

[systemd-devel] [PATCH 3/5] tpmfiles: add missing parenthesis

--- src/tmpfiles/tmpfiles.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 6b3f70e..ba22073 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -321,7 +321,7 @@ static int dir_cleanup(

[systemd-devel] [PATCH 5/5] manager: print p and then free it

--- src/core/manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/manager.c b/src/core/manager.c index ec12a75..5d1959e 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -2473,9 +2473,9 @@ static int create_generator_dir(Manager *m, char **generator,

[systemd-devel] [PATCH 2/5] systemctl: check if iterator was initialized succesfully

--- src/systemctl/systemctl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index c67c6c9..99286cf 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -2084,7 +2084,11 @@ static int

[systemd-devel] [PATCH] systemctl: mangle unit name in is-enabled

--- src/systemctl/systemctl.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 99286cf..72e9c55 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -3982,6 +3982,7 @@ static

[systemd-devel] [PATCH] condition: add option ConditionArchitecture

--- TODO | 2 -- man/systemd.unit.xml.in | 8 src/core/condition.c | 16 src/core/condition.h | 1 + src/core/load-fragment-gperf.gperf.m4 | 1 + 5 files changed, 26 insertions(+), 2

[systemd-devel] [PATCH 1/2] sd-bus: check c-path for null instead of path

--- src/libsystemd-bus/sd-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-bus/sd-bus.c b/src/libsystemd-bus/sd-bus.c index 5f2ede0..6acc59e 100644 --- a/src/libsystemd-bus/sd-bus.c +++ b/src/libsystemd-bus/sd-bus.c @@ -1944,7 +1944,7 @@ static int

[systemd-devel] [PATCH 2/2] log: fix error codes handling in catalog_list_items

Previously r was set to zero and so if(r0) was never true. Also it does not make sense to print error code from previous loop. --- src/journal/catalog.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/journal/catalog.c b/src/journal/catalog.c index

[systemd-devel] [PATCH] catalog: fix error codes handling in catalog_list_items

Previously r was set to zero and so if(r0) was never true. --- src/journal/catalog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/journal/catalog.c b/src/journal/catalog.c index 6b195f6..7ae7b3e 100644 --- a/src/journal/catalog.c +++ b/src/journal/catalog.c @@

[systemd-devel] [PATCH 1/5] journalctl: check return of strjoin

--- src/journal/journalctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index 86895b8..002ff7c 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -1035,7 +1035,7 @@ int main(int argc, char *argv[]) {

[systemd-devel] [PATCH 2/5] sd-id128: properly check position in buffer

--- src/libsystemd-id128/sd-id128.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libsystemd-id128/sd-id128.c b/src/libsystemd-id128/sd-id128.c index 68c4987..a6345c8 100644 --- a/src/libsystemd-id128/sd-id128.c +++ b/src/libsystemd-id128/sd-id128.c @@ -176,6 +176,9 @@ _public_ int

[systemd-devel] [PATCH 3/5] tty-ask-password-agent: free passwords

--- src/tty-ask-password-agent/tty-ask-password-agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask-password-agent/tty-ask-password-agent.c index 3f5706e..1f55e32 100644 ---

[systemd-devel] [PATCH 4/5] journal: close fd in sd_journal_send

--- src/journal/journal-send.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/journal/journal-send.c b/src/journal/journal-send.c index 4b9109a..ae7f5e8 100644 --- a/src/journal/journal-send.c +++ b/src/journal/journal-send.c @@ -200,7 +200,9 @@ finish: _public_ int

[systemd-devel] [PATCH 5/5] libsystemd-bus: initalize handle_cmsg to false

--- src/libsystemd-bus/bus-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-bus/bus-socket.c b/src/libsystemd-bus/bus-socket.c index 145f454..1a0d926 100644 --- a/src/libsystemd-bus/bus-socket.c +++ b/src/libsystemd-bus/bus-socket.c @@ -877,7 +877,7 @@

[systemd-devel] [PATCH 1/2] crypt-setup-generator: correctly check return of strdup

--- src/cryptsetup/cryptsetup-generator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cryptsetup/cryptsetup-generator.c b/src/cryptsetup/cryptsetup-generator.c index ac0ed58..b31329d 100644 --- a/src/cryptsetup/cryptsetup-generator.c +++

[systemd-devel] [PATCH 2/2] logind-dbus: initialize result variable

--- src/login/logind-dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c index 4176902..05cc1fd 100644 --- a/src/login/logind-dbus.c +++ b/src/login/logind-dbus.c @@ -1137,7 +1137,7 @@ static int

[systemd-devel] [PATCH] systemd-delta: add support for drop-in snippets

--- TODO | 3 - src/delta/delta.c | 179 ++ 2 files changed, 166 insertions(+), 16 deletions(-) diff --git a/TODO b/TODO index 9adec5e..96d90d8 100644 --- a/TODO +++ b/TODO @@ -95,9 +95,6 @@ Features: kmod static-nodes

[systemd-devel] [PATCH] systemctl: add --plain option to list-dependencies

This patch adds more script-friendly output for list-dependencies. --- man/systemctl.xml | 9 + src/systemctl/systemctl.c | 50 +++ 2 files changed, 42 insertions(+), 17 deletions(-) diff --git a/man/systemctl.xml b/man/systemctl.xml

[systemd-devel] [PATCH] systemd-delta: add support for drop-in snippets

--- TODO | 3 - man/systemd-delta.xml | 7 +++ src/delta/delta.c | 170 ++ 3 files changed, 164 insertions(+), 16 deletions(-) diff --git a/TODO b/TODO index 84ede8c..eab5f87 100644 --- a/TODO +++ b/TODO @@ -74,9 +74,6 @@

[systemd-devel] [PATCH] systemd-delta: add support for drop-in snippets

--- TODO | 3 - man/systemd-delta.xml | 7 ++ src/delta/delta.c | 182 -- 3 files changed, 170 insertions(+), 22 deletions(-) diff --git a/TODO b/TODO index 62016e1..3af9c33 100644 --- a/TODO +++ b/TODO @@ -89,9 +89,6 @@

[systemd-devel] [PATCH] systemd-delta: add support for drop-in snippets

--- TODO | 3 - man/systemd-delta.xml | 7 ++ src/delta/delta.c | 184 -- 3 files changed, 170 insertions(+), 24 deletions(-) diff --git a/TODO b/TODO index 62016e1..3af9c33 100644 --- a/TODO +++ b/TODO @@ -89,9 +89,6 @@

[systemd-devel] [PATCH] core: read debug from kernel commandline and set log level and target

--- TODO| 3 --- man/kernel-command-line.xml | 12 man/systemd.xml | 16 src/core/main.c | 4 4 files changed, 32 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index f8a1b1b..7883b7e 100644 --- a/TODO

[systemd-devel] [PATCH] service: allow service to inhibit respawn with special return code

In some cases, like wrong configuration, restarting after error exit code does not help, so administrator can specify RestartIgnoreCodes which will not cause restart of a service. --- man/systemd.service.xml |7 src/core/load-fragment-gperf.gperf.m4 |1 +

[systemd-devel] [PATCH] systemctl: add add-wants and add-requires verbs

--- TODO | 1 - man/systemctl.xml | 27 ++ src/core/dbus-manager.c| 85 + src/core/org.freedesktop.systemd1.conf | 8 +++ src/shared/install.c | 87

[systemd-devel] [PATCHi v2] systemctl: add add-wants and add-requires verbs

--- Changes in v2 - new selinux_unit_access_check_strv - only one dbus call AddInstallDependencyUnitFiles - small change in manpage TODO | 1 - man/systemctl.xml | 21 src/core/dbus-manager.c| 84

[systemd-devel] [PATCH v3] systemctl: add add-wants and add-requires verbs

--- Changes in v3 - move don't load logic to unit_file_load - --help message should be finally fine TODO | 1 - man/systemctl.xml | 21 src/core/dbus-manager.c| 84 ++---

[systemd-devel] [PATCH v4] systemctl: add add-wants and add-requires verbs

--- Changes in v4 - renamed install_dependency - dependency - removed the enum with dependencies and used the general one instead - add an error meesage in the case that --root is used and it fails - changes in manpage TODO | 1 - man/systemctl.xml

[systemd-devel] [PATCH] shell-completion/bash: add add-wants and add-requires

--- shell-completion/bash/systemctl.in | 12 1 file changed, 12 insertions(+) diff --git a/shell-completion/bash/systemctl.in b/shell-completion/bash/systemctl.in index afa80da..30ba668 100644 --- a/shell-completion/bash/systemctl.in +++ b/shell-completion/bash/systemctl.in @@

[systemd-devel] [PATCH] environment: append unit_id to error messages regarding EnvironmentFile

--- src/core/execute.c | 6 +++--- src/core/execute.h | 2 +- src/shared/env-util.c | 7 --- src/shared/env-util.h | 2 +- src/test/test-fileio.c | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/core/execute.c b/src/core/execute.c index b165b33..f515934

[systemd-devel] [PATCH v2] environment: append unit_id to error messages regarding EnvironmentFile

--- I have swapped parameters in test-fileio in previous version src/core/execute.c | 6 +++--- src/core/execute.h | 2 +- src/shared/env-util.c | 7 --- src/shared/env-util.h | 2 +- src/test/test-fileio.c | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git

[systemd-devel] [PATCH] sd-pppoe: include ppp_defs.h

On older kernels before this patch: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e8b671460410c8fd996c8a1c228b718c547cc236 ppp-ioctl.h did not pull in ppp_defs.h which results in build errors --- src/libsystemd-network/sd-pppoe.c | 1 + 1 file changed, 1 insertion(+)

[systemd-devel] [PATCH] dbus: return non-zero return value in the case that prefix won't match

strv_extend returns 0 in the case of success which means that else if (bus_track_deserialize_item(m-deserialized_subscribed, l) == 0) log_warning(Unknown serialization item '%s', l); will be printed when value is added correctly. --- src/core/dbus.c| 2 +- src/core/manager.c | 2 +- 2

[systemd-devel] [PATCH] selinux-access: fix broken ternary operator

it seems to be a typo introduced by ebcf1f97de4f6b1580ae55eb56b1a3939fe6b602 -_r = selinux_access_check(_b, _m, _u-source_path ?:_u-fragment_path, (permission), _error); \ +({ Unit *_unit = (unit); selinux_generic_access_check(bus,message, _unit-fragment_path ?:

[systemd-devel] [PATCH] console-getty.service: don't start when /dev/console is missing

From: Jan Pazdziora jpazdzi...@redhat.com Create minimal image which runs systemd FROM rhel7.1 RUN yum install -y /usr/bin/ps ENV container docker CMD [ /usr/sbin/init ] When you run the container without -t, the process /sbin/agetty --noclear --keep-baud console 115200 38400

[systemd-devel] [PATCH] systemctl: list-units -r should not fail with older systemd in container

Older version of systemd does not have d-bus method ListUnitsFiltered, so systemctl -r will fail just with: Failed to list units: Method ListUnitsFiltered with signature as on interface org.freedesktop.systemd1.Manager doesn't exist So lets skip such machines. --- src/systemctl/systemctl.c | 6

[systemd-devel] [PATCH] man: mention that tools like imjournal will not work with Storage=none

Manpage for journald.conf mentions that syslog will still work if you set Storage=none, but this is not true for some specific setups. For example rhel7 and combination of journal, rsyslog and imjournal plugin. --- man/journald.conf.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [systemd-devel] systemctl --user roadmap question

That comment explains why --user was removed when centos7 was released. Although now we know that it will remain as it is in upstream, we don't plan to revert the removal in el7, since we are afraid of potential regressions that it might cause. I personally saw couple of logs where users had some

Re: [systemd-devel] chkconfig on preferred to --add?

I think the behaviour is correct, chkconfig --add is kinda sysv equivalent of systemctl preset. systemctl enable should be the same as chkconfig on. Lukas čt 23. 5. 2019 v 20:40 odesílatel Lennart Poettering napsal: > On Do, 23.05.19 10:29, Roger Pack (rogerdpa...@gmail.com) wrote: > > > As a

Re: [systemd-devel] systemd219 and Realtime priority

Hi! I think you should contact the Red Hat support with this question. Most of the distribution have CONFIG_RT_GROUP_SCHED disabled since in the general use cases people don't use it at all. RHEL is an exception here, since we keep that feature on, despite the recommendation of upstream, to cover