---
src/libsystemd/sd-bus/PORTING-DBUS1 | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/libsystemd/sd-bus/PORTING-DBUS1
b/src/libsystemd/sd-bus/PORTING-DBUS1
index 0253a42..f2ebcd7 100644
--- a/src/libsystemd/sd-bus/PORTING-DBUS1
+++
---
src/libsystemd/sd-bus/PORTING-DBUS1 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libsystemd/sd-bus/PORTING-DBUS1
b/src/libsystemd/sd-bus/PORTING-DBUS1
index f2ebcd7..6205e32 100644
--- a/src/libsystemd/sd-bus/PORTING-DBUS1
+++ b/src/libsystemd/sd-bus/PORTING-DBUS1
?id=721861
Thanks,
--
Lukasz Skalski
Samsung RD Institute Poland
Samsung Electronics
l.skal...@samsung.com
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
should also keep this discussion focused on technical solutions
rather than some politics (drop the gvariant and speak only dbus1
marshalling again or not?).
Cheers
Thanks,
--
Lukasz Skalski
Samsung RD Institute Poland
Samsung Electronics
l.skal...@samsung.com
On 04/28/2014 02:22 PM, Manuel Reimer wrote:
Lukasz Skalski l.skalski at samsung.com writes:
You can define which RTC (/dev/rtcX) should be read -
(rtc1) RTC used to set the system time option in kernel menuconfig.
Yes, this is possible. But my RTC does not exist until I do the following
On 11/22/2013 02:46 PM, David Herrmann wrote:
Hi
Hi,
On Fri, Nov 22, 2013 at 2:09 PM, Lennart Poettering
lenn...@poettering.net wrote:
On Thu, 21.11.13 17:26, Lukasz Skalski (l.skal...@partner.samsung.com) wrote:
Hi all,
Macro __LINE__ in #define assert_cc() (src/shared/macro.h
Please find patch in attachement for review - it fix problem
with undefined references in some test-libsystemd-*-sym.c tests.
---
Makefile.am |5 +
1 file changed, 5 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 728b860..9e03f0a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@
On 11/25/2013 02:03 PM, Kay Sievers wrote:
On Mon, Nov 25, 2013 at 1:56 PM, Lukasz Skalski
l.skal...@partner.samsung.com wrote:
Please find patch in attachement for review - it fix problem
with undefined references in some test-libsystemd-*-sym.c tests.
It looks a bit weird to add library
Now code form src/shared don't use code of shared libs directly.
It solves cyclic dependencies in the same way as sd_utf_is_valid()
from src/libsystemd-bus/sd-utf8.c and src/shared/utf8.c.
---
src/libsystemd-bus/sd-bus.c | 64 +
);
+return r;
+}
+
+*l = strv_uniq(x);
}
-*l = strv_uniq(x);
return 0;
}
--
Lukasz Skalski
Samsung RD Institute Poland
Samsung Electronics
l.skal...@partner.samsung.com
---
src/libsystemd-bus/bus-kernel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/libsystemd-bus/bus-kernel.c b/src/libsystemd-bus/bus-kernel.c
index 84d84df..f2b130b 100644
--- a/src/libsystemd-bus/bus-kernel.c
+++ b/src/libsystemd-bus/bus-kernel.c
@@ -593,7 +593,8 @@
I added also assert_return(!bus-is_kernel, -ENOTSUP) to sd_bus_get_owner()
function until ioctl(KDBUS_CMD_NAME_QUERY) is not implemented yet.
---
src/libsystemd-bus/bus-control.c | 52 ++--
1 file changed, 18 insertions(+), 34 deletions(-)
diff --git
Serial=4294967295 field in message dump generated by bus_message_dump()
function for synthetic messages isn't good readable.
---
src/libsystemd-bus/bus-dump.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/libsystemd-bus/bus-dump.c
/test-bus-kernel-monitor.c
new file mode 100644
index 000..27642d2
--- /dev/null
+++ b/src/libsystemd-bus/test-bus-kernel-monitor.c
@@ -0,0 +1,179 @@
+/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
+
+/***
+ This file is part of systemd.
+
+ Copyright 2013 Lukasz Skalski
---
src/libsystemd-bus/bus-kernel.c | 16
src/libsystemd-bus/bus-kernel.h | 2 ++
2 files changed, 18 insertions(+)
diff --git a/src/libsystemd-bus/bus-kernel.c b/src/libsystemd-bus/bus-kernel.c
index ca36eb8..603aa97 100644
--- a/src/libsystemd-bus/bus-kernel.c
+++
ENXIO, ESRCH and EADDRNOTAVAIL are also returned by ioctl(KDBUS_CMD_MSG_SEND)
when we have unicast signal messages (signals with a DESTINATION field).
---
src/libsystemd-bus/bus-kernel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libsystemd-bus/bus-kernel.c
destination - the unique bus name for the destination for the signal
or NULL to emit to all listeners.
This path makes libsystemd-bus API more consistent and similar
to GDBUS API, for reference:
gboolean g_dbus_connection_emit_signal (GDBusConnection *connection,
---
src/libsystemd-bus/bus-dump.c | 2 +-
src/libsystemd-bus/bus-error.c | 3 +--
src/libsystemd-bus/bus-kernel.c| 12 +++-
src/libsystemd-bus/bus-message.c | 12 +++-
src/libsystemd-bus/bus-signature.c | 13 -
5 files changed, 12 insertions(+), 30
wrong though.
There's no strong reason to limit usage to public functions. It's just
a simple macro really.
On Mon, Dec 9, 2013 at 2:09 PM, Lukasz Skalski
l.skal...@partner.samsung.com wrote:
---
src/libsystemd-bus/bus-dump.c | 2 +-
src/libsystemd-bus/bus-error.c | 3 +--
src
On 12/10/2013 08:24 PM, Lennart Poettering wrote:
On Wed, 04.12.13 14:44, Lukasz Skalski (l.skal...@partner.samsung.com) wrote:
ENXIO, ESRCH and EADDRNOTAVAIL are also returned by ioctl(KDBUS_CMD_MSG_SEND)
when we have unicast signal messages (signals with a DESTINATION
field).
Well, but you
On 12/10/2013 09:42 PM, Lennart Poettering wrote:
On Tue, 10.12.13 21:27, Lukasz Skalski (lukasz.skal...@op.pl) wrote:
On 12/10/2013 08:24 PM, Lennart Poettering wrote:
On Wed, 04.12.13 14:44, Lukasz Skalski (l.skal...@partner.samsung.com) wrote:
ENXIO, ESRCH and EADDRNOTAVAIL are also
log_assert_failed_return macro generates a lot of logs when we use
bus_message_dump() function without checking masks in creds.
---
src/libsystemd-bus/bus-dump.c | 93 +++
1 file changed, 59 insertions(+), 34 deletions(-)
diff --git
Due to this patch, 'busctl monitor' prints all method calls,
method errors and signals both for dbus and kdbus.
---
src/libsystemd-bus/bus-control.c | 6 ++
src/libsystemd-bus/bus-match.c | 10 ++
src/libsystemd-bus/bus-match.h | 1 +
src/libsystemd-bus/busctl.c | 2 +-
4
added eavesdrop=true to dbus-daemon,
it broke compatibility with older client libraries anyway.
S
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
Lukasz Skalski
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6ada38a..f85e86e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -801,7 +801,7 @@ AM_CONDITIONAL(ENABLE_MULTI_SEAT_X, [test
$have_multi_seat_x = yes])
#
Due to this patch, sd_bus_release_name() function
returns the same code errors for kdbus and dbus1
if we try release non-existing name or foreign
name.
---
src/libsystemd-bus/bus-control.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libsystemd-bus/bus-control.c
---
src/bus-driverd/bus-driverd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bus-driverd/bus-driverd.c b/src/bus-driverd/bus-driverd.c
index ce2e1b2..d2b3e08 100644
--- a/src/bus-driverd/bus-driverd.c
+++ b/src/bus-driverd/bus-driverd.c
@@ -247,7 +247,7 @@ static int
Due to this patch, message dump (for message which includes boolean
type) is more consistent with dbus-send (which display true/false
instead of yes/no for boolean). It's only simple 'cosmetics change'.
** For dbus-send **
dbus-send --system --dest=org.freedesktop.DBus --type=method_call
RequestName return codes should be consistent with
Dbus Specification.
VALUE - DESCRIPTION
1 - The caller is now the primary owner of the name, replacing any previous
owner,
2 - The name already had an owner (QUEUE flag was not specified),
3 - The name already has an owner (QUEUE flag was
Please ignore this patch - it contains errors. Sorry.
BR,
Lukasz
On 12/17/2013 01:48 PM, Lukasz Skalski wrote:
RequestName return codes should be consistent with
Dbus Specification.
VALUE - DESCRIPTION
1 - The caller is now the primary owner of the name, replacing any previous
owner,
2
RequestName return codes should be consistent with Dbus Specification.
VALUE - DESCRIPTION
1-The caller is now the primary owner of the name, replacing any previous owner,
2-The name already had an owner (QUEUE flag was not specified),
3-The name already has an owner (QUEUE flag was specified),
On 12/17/2013 05:16 PM, Lennart Poettering wrote:
On Tue, 17.12.13 15:54, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
On Tue, Dec 17, 2013 at 02:31:42PM +0100, Lukasz Skalski wrote:
RequestName return codes should be consistent with Dbus Specification.
VALUE - DESCRIPTION
1
RequestName return codes should be consistent with Dbus Specification.
VALUE - DESCRIPTION
1-The caller is now the primary owner of the name, replacing any previous owner,
2-The name already had an owner (QUEUE flag was not specified),
3-The name already has an owner (QUEUE flag was specified),
Flags for a name entry (KDBUS_NAME_*) should be set for
cmd_name-flags (not conn_flags)
---
src/bus-driverd/bus-driverd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bus-driverd/bus-driverd.c b/src/bus-driverd/bus-driverd.c
index b11eb55..f28dc57 100644
---
see above, path name, interface name and others string are in
the same place. Problem is with signature positions. Any ideas on what
could be causing the problem?
BR,
--
Lukasz Skalski
Samsung RD Institute Poland
Samsung Electronics
l.skal...@partner.samsung.com
On 01/11/2014 11:48 PM, Zbigniew Jędrzejewski-Szmek wrote:
On Thu, Jan 02, 2014 at 10:52:44AM +0100, Lukasz Skalski wrote:
As you can see above, path name, interface name and others string
are in the same place. Problem is with signature positions. Any
ideas on what could be causing the problem
---
src/libsystemd/bus-message.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libsystemd/bus-message.c b/src/libsystemd/bus-message.c
index 0c8604c..1a2039b 100644
--- a/src/libsystemd/bus-message.c
+++ b/src/libsystemd/bus-message.c
@@ -1935,7 +1935,7 @@ static size_t
-proxyd
to systemd-bus-driverd;
Regards,
Kangkai
Hi Kangkai,
Here you can find some real benchmarking numbers:
http://lists.freedesktop.org/archives/dbus/2014-January/016074.html
--
Lukasz Skalski
Samsung RD Institute Poland
Samsung Electronics
l.skal...@partner.samsung.com
-completion/bash/systemd-analyze \
Shouldn't we install those files conditionally, based on --enable-kdbus ?
No, busctl can be used also with standard dbus.
BR,
--
Lukasz Skalski
Samsung RD Institute Poland
Samsung Electronics
l.skal...@samsung.com
---
src/login/logind-user.c | 8 +++-
units/systemd-logind.service.in | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/login/logind-user.c b/src/login/logind-user.c
index d48eca4..3847496 100644
--- a/src/login/logind-user.c
+++ b/src/login/logind-user.c
@@
Commit 710fc9779b7c (kdbus repo) introduced attaching items[]
instead of name[] in kdbus_cmd_conn_info struct. Commit 581fe6c81
(systemd repo) caught up with this change, but item size was not
properly calculated.
---
src/libsystemd/sd-bus/bus-control.c | 11 +--
1 file changed, 5
'ListQueuedOwners' method should return 'NameHasNoOwner' error
if chosen name is not available on bus.
---
src/bus-proxyd/bus-proxyd.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c
index 4f44825..52498f3 100644
---
'GetConnectionUnixProcessID', 'GetConnectionUnixUser' and
'GetConnectionSELinuxSecurityContext' methods should return
'NameHasNoOwner' error (if chosen name is not available on bus)
with more detailed description - like dbus-1:
Could not get PID of name 'org.freedesktop.test': no such name.
Could
---
src/bus-proxyd/bus-proxyd.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c
index 52498f3..6ff0e8c 100644
--- a/src/bus-proxyd/bus-proxyd.c
+++ b/src/bus-proxyd/bus-proxyd.c
@@ -845,7 +845,7 @@ static
Change-Id: I64f7c6b446f6d92057c35cc3d4e29bd2bad8f75b
---
src/resolve/resolved.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/resolve/resolved.c b/src/resolve/resolved.c
index ef416e5..abd6314 100644
--- a/src/resolve/resolved.c
+++ b/src/resolve/resolved.c
@@ -22,6 +22,7 @@
#include
Set proper kdbus_cmd_list object size, otherwise:
dbus-send --system --dest=org.freedesktop.DBus --type=method_call \
print-reply / org.freedesktop.DBus.ListQueuedOwners
string:org.freedesktop.systemd1
Error org.freedesktop.DBus.Error.InvalidArgs: Invalid argument
diff --git
This patch fixes also problem with ReleaseName call in
systemd-bus-proxyd.
diff --git a/names.c b/names.c
index 5f57aa3..e85ba45 100644
--- a/names.c
+++ b/names.c
@@ -266,6 +266,7 @@ static int kdbus_name_release(struct kdbus_name_registry
*reg,
* for items for connection.
GetConnectionCredentials method was added to dbus-1 specification
more than one year ago. This method should return [...] as many
credentials as possible for the process connected to the server,
but at this moment only UnixUserID and ProcessID are defined
by the specification. We should add
diff --git a/test/test-message.c b/test/test-message.c
index 03ac71e..0cae942 100644
--- a/test/test-message.c
+++ b/test/test-message.c
@@ -28,7 +28,7 @@
* maximum number of queued messages from the same indvidual user after the
* the un-accounted value has been hit
*/
-#define
---
src/bus-proxyd/bus-proxyd.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c
index a7818f5..fc70cce 100644
--- a/src/bus-proxyd/bus-proxyd.c
+++ b/src/bus-proxyd/bus-proxyd.c
@@ -829,6 +829,10 @@ static int process_driver(sd_bus
This patch doesn't work as I expected so please skip it - sorry for the
confusion.
On 01/05/2015 05:03 PM, Lukasz Skalski wrote:
To keep compatibility with dbus-1, before we use synthetic_reply_method_*()
functions, we should overwrite 'sender' field - otherwise functions
diff --git a/test/test-free.c b/test/test-free.c
index 01dca80..f666da3 100644
--- a/test/test-free.c
+++ b/test/test-free.c
@@ -14,6 +14,22 @@
#include kdbus-enum.h
#include kdbus-test.h
+static int sample_ioctl_call(struct kdbus_test_env *env)
+{
+ int ret;
+ struct
To keep compatibility with dbus-1, before we use synthetic_reply_method_*()
functions, we should overwrite 'sender' field - otherwise functions
sd_bus_message_new_method_return() and sd_bus_message_new_method_error() never
set 'destination' field.
Thanks to this we have proper 'destination'
diff --git a/doc/kdbus.message.xml b/doc/kdbus.message.xml
index c25000d..5e7c7a3 100644
--- a/doc/kdbus.message.xml
+++ b/doc/kdbus.message.xml
@@ -393,7 +393,7 @@ struct kdbus_msg {
For a message to be accepted as reply, it must be a direct
message to the
Signed-off-by: Lukasz Skalski l.skal...@samsung.com
diff --git a/doc/kdbus.message.xml b/doc/kdbus.message.xml
index c25000d..5e7c7a3 100644
--- a/doc/kdbus.message.xml
+++ b/doc/kdbus.message.xml
@@ -393,7 +393,7 @@ struct kdbus_msg {
For a message to be accepted as reply
GetConnectionCredentials method was added to dbus-1 specification
more than one year ago. This method should return [...] as many
credentials as possible for the process connected to the server,
but at this moment only UnixUserID, LinuxSecurityLabel and
ProcessID are defined by the specification.
GetConnectionCredentials method was added to dbus-1 specification
more than one year ago. This method should return [...] as many
credentials as possible for the process connected to the server,
but at this moment only UnixUserID, LinuxSecurityLabel and
ProcessID are defined by the specification.
On 04/13/2015 01:46 PM, Daniel Mack wrote:
Hi Lukasz,
Hi,
[+dbus ML]
On 04/10/2015 04:20 PM, Lukasz Skalski wrote:
Currently I'm working on some testsuite (let's call it dbus1-spec-test)
for dbus-1 specification. My idea is to test dbus-1 specification
coverage on systems with dbus
58 matches
Mail list logo
