Re: [systemd-devel] [PATCH] nspawn: fix whitespace and typo in partition table blurb

2015-02-23 Thread Martin Pitt
Hey Jan, Jan Synacek [2015-02-23 15:22 +0100]: - fix additional typo on the same line, doh Applied, thanks! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] heads-up: chasing journal(?) related regression in 219 causing boot hang/fail

2015-02-22 Thread Martin Pitt
git master (reverts cleanly) makes things work perfectly again. I haven't drilled down into the patch itself yet, that's not something I want to start doing on a Sunday :-) Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer

Re: [systemd-devel] heads-up: chasing journal(?) related regression in 219 causing boot hang/fail

2015-02-20 Thread Martin Pitt
if/when it's failing) How many open fds does sd-journald have? Highest fd is 25, so I'd say trivial. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] feature request: dlopen

2015-02-22 Thread Martin Pitt
the results of the big Debian systemd debate at all, did you? :-) Pretty please do some actual research about the situtation first, and keep apart libsystemd (harmless, works with any init system) from systemd (the init system, pid 1, services around it, etc). Martin -- Martin Pitt

Re: [systemd-devel] [PATCH] unit: When stopping due to BindsTo=, log which unit caused it

2015-02-26 Thread Martin Pitt
touch it. We mostly want this BindsTo= for mounts where the .device units *do* exist, so that when they go away we can clean up the mount (mostly for hotpluggable devices and removable media). I'll have a deeper look ASAP. Martin -- Martin Pitt| http://www.piware.de Ubuntu

[systemd-devel] [PATCH] core/mount: only add dependencies to active units for dynamic mounts [was: Re: unit: When stopping due to BindsTo=, log which unit caused it]

2015-02-26 Thread Martin Pitt
Hey all, Martin Pitt [2015-02-26 16:50 +0100]: IMHO it would be prudent to skip adding the BindsTo= if at the time of creating the .mount unit the backing .device unit doesn't actually exist. In that case it's a mount which isn't managed by systemd, and we shouldn't touch it. We mostly want

Re: [systemd-devel] Programmatically setting udev properties

2015-01-30 Thread Martin Pitt
the approach that e. g. the gvfs tests use (see test/gvfs-testbed in the source tree). Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list

Re: [systemd-devel] Programmatically setting udev properties

2015-01-30 Thread Martin Pitt
/IRC/etc.) if you are interested. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http

Re: [systemd-devel] Synchronization Between Services at Shutdown

2015-04-03 Thread Martin Pitt
Hello, Dan Williams [2015-04-02 9:51 -0500]: On Thu, 2015-04-02 at 16:31 +0200, Martin Pitt wrote: wpa_supplicant and NM already have Before=network.target which is even stronger. But that doesn't help -- it's D-Bus which we need to leave running longer, as dbus going down early tears

Re: [systemd-devel] heads-up: chasing journal(?) related regression in 219 causing boot hang/fail

2015-04-11 Thread Martin Pitt
. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [RFC] core: introduce ExitOnIdle= and ExitOnIdleSec=

2015-04-21 Thread Martin Pitt
by itself. So I see no use case for idle timer based cleanup. Can you please explain why they are better than on-demand cleanup? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) signature.asc

Re: [systemd-devel] [PATCH] core: don't change removed devices to state tentative [was: Re: [PATCH] unit: When stopping due to BindsTo=, log which unit caused it]

2015-04-24 Thread Martin Pitt
! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

[systemd-devel] [PATCH] util: Fix assertion in split() on missing '

2015-04-22 Thread Martin Pitt
test.service to get the same assertion. Of course this syntax is invalid, but systemd certainly shouldn't spill its guts that hard, but just reject the broken .service file. Simple fix with test case attached. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu

Re: [systemd-devel] [systemd-commits] TODO

2015-04-29 Thread Martin Pitt
nothing to do with it) Thanks, Martin (who is happy that this excruciating bug finally seems fixed) [1] Every time I use this a small kitten comes back to life! -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-13 Thread Martin Pitt
/102 This is reproducible in a container with udev running, see the small reproducer in the bug trail. This is on my plate to investigate/fix, I just got interrupted by a couple of security issues, so not this week. Martin -- Martin Pitt| http://www.piware.de Ubuntu

[systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Martin Pitt
of be liberal what you accept I think the extra space(s) should just be ignored; or should that count as an error and the unit get rejected? Thanks, Martin [1] https://launchpad.net/bugs/1454173 -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
, but it shows the wrong state) Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http

Re: [systemd-devel] tentative state and unmount on mapper

2015-05-18 Thread Martin Pitt
by the device_update_found_one() state transition from tentative to dead which we must never do as there is no way to know when a tentative device is actually dead. We must only transition to dead from plugged. Testing/feedback appreciated! Martin -- Martin Pitt| http

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
of the .device units to happen at the right and intended time (when we actually have a proper state), and thus have the intended state tentative instead of dead. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [correct PATCH v2] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
Martin Pitt [2015-05-17 15:54 +0200]: This fixes the original systemd immediately unmounts my mounts bug, but not for very long: If you remount or unmount just one mount on a tentative device, mountinfo changes, and device_found_node() now calls device_update_found_one() with add == 0

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-17 Thread Martin Pitt
to exhibit the bugs, as Dimitri's plan9 example shows there are other cases where file systems aren't on a real /dev/ device. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

[systemd-devel] [PATCH] core: Fix assertion with empty Exec*= paths

2015-05-14 Thread Martin Pitt
Martin Pitt [2015-05-13 17:01 +0200]: I got a report [1] that you can trivially crash systemd (pid1) at boot by creating a unit with an Exec= line with a modifier and a space: $ cat /tmp/foo.service [Service] ExecStart=- /bin/echo hello $ systemd-analyze verify /tmp/foo.service

Re: [systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Martin Pitt
Lennart Poettering [2015-05-13 17:55 +0200]: On Wed, 13.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: So, obviously we need to fix the crash; but I was wondering what the desired behaviour should be? In the sense of be liberal what you accept I think the extra space(s) should

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-14 Thread Martin Pitt
, if don't have the corresponding device nodes at all, we shouldn't try to react to hotplug events and clean up mounts. I. e. the tentative concept does not really apply there. But I have misunderstood the intent. Thanks for considering, Martin -- Martin Pitt| http

[systemd-devel] [PATCH v3] hostname: Allow comments in /etc/hostname

2015-05-18 Thread Martin Pitt
, I called the function read_hostname_config() and give it a path argument. This is mostly so that we can write tests for it, but maybe one of these days we actually want to use it for other purposes (reading hostnames from container root fs). Martin -- Martin Pitt| http

[systemd-devel] [PATCH v3] dev-root.device is not active, results in an umount spree

2015-05-19 Thread Martin Pitt
code in master is overzealous, this patch is overcautious, this needs some more thought and work; I don't have an updated patch yet. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) From

Re: [systemd-devel] [correct PATCH v2] dev-root.device is not active, results in an umount spree

2015-05-19 Thread Martin Pitt
Lennart Poettering [2015-05-18 23:04 +0200]: On Mon, 18.05.15 16:08, Martin Pitt (martin.p...@ubuntu.com) wrote: Martin Pitt [2015-05-17 15:54 +0200]: This fixes the original systemd immediately unmounts my mounts bug, but not for very long: If you remount or unmount just one mount

[systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
Hello all, I have a better fix now. Martin Pitt [2015-05-19 8:59 +0200]: - Boot, dev-foo.device becomes DEVICE_FOUND_MOUNT/tentative - Do some more mounts from /dev/foo, e. g. mkdir /tmp/etc /tmp/boot mount -o bind /etc /tmp/etc mount -o bind /boot /tmp/boot

Re: [systemd-devel] tentative state and unmount on mapper

2015-05-19 Thread Martin Pitt
. So far I found CONFIG_DM_UEVENT on kernel and some switches on lvm, --enable-udev_sync, --enable-udev_rules, --with-udev-prefix=. That's still a preferable fix for non-containers of course. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer

Re: [systemd-devel] tentative state and unmount on mapper

2015-05-19 Thread Martin Pitt
with situations with a mounted device not being in /dev. Sorry for the confusion! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list

[systemd-devel] [PATCH] hostname: Allow comments in /etc/hostname

2015-05-18 Thread Martin Pitt
(HOST_NAME_MAX) this could be written more efficiently. Thanks, Martin [1] https://launchpad.net/bugs/1053048 -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) From 0d5195a617df34abcd200a49c5560f46337e5e74 Mon Sep 17 00:00

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
you replied to). The v2 patches do create the .device right from the start in state tentative (that was the intention judging by the comments, it just doesn't actually behave that way) and thus .mounts do get bound to the .devices. Martin -- Martin Pitt| http

Re: [systemd-devel] Reduce unit-loading time

2015-05-17 Thread Martin Pitt
solution. We found that it makes a significant improvement on ARM boards with slow MMC cards. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-17 Thread Martin Pitt
feeling that Dimitri's use case with a plan9 file system would still break with the /dev/root special case fix if the file system wasn't the root fs but e. g. /home, and you try to bind-mount anything from it. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu

[systemd-devel] [PATCH v2] hostname: Allow comments in /etc/hostname

2015-05-18 Thread Martin Pitt
Hey Thomas, Thomas H.P. Andersen [2015-05-18 11:49 +0200]: On Mon, May 18, 2015 at 11:33 AM, Martin Pitt martin.p...@ubuntu.com wrote: This currently uses read_full_file() and strv_split_newlines() which is relatively expensive (although, in most cases there will only be one line

Re: [systemd-devel] Reduce unit-loading time

2015-05-18 Thread Martin Pitt
://launchpad.net/ubuntu/+source/ureadahead -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http

[systemd-devel] [PATCH] cryptsetup: Implement offset and skip options

2015-04-16 Thread Martin Pitt
-- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) From e345e310d710a2cc58f529229d26068e7a3cfbfb Mon Sep 17 00:00:00 2001 From: Martin Pitt martin.p...@ubuntu.com Date: Thu, 16 Apr 2015 06:44:07 -0500 Subject: [PATCH

[systemd-devel] [PATCH v2] cryptsetup: Implement offset and skip options

2015-04-16 Thread Martin Pitt
Hello again, Martin Pitt [2015-04-16 6:55 -0500]: This simple patch adds offset=. While I was at it I also added skip=. I attached my script for testing this to the fd.o bug. Zbigniew reviewed it on https://bugs.freedesktop.org/show_bug.cgi?id=87717 , thanks! This updated patch makes s

Re: [systemd-devel] 'is-enabled' supported for legacy sysvinit scripts?

2015-04-13 Thread Martin Pitt
of systemd... For the record, this is tracked in https://bugs.debian.org/705254 Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd

Re: [systemd-devel] [PATCH v2] cryptsetup: Implement offset and skip options

2015-04-17 Thread Martin Pitt
) log_warning(skip= ignored with type %s, arg_type); But patch looks fine without this too. For the archives: Lennart reviewed that on the fd.o bug and pointed out some other issues (adding to crypttab.5, and cleaner struct init). This is in master now. Martin -- Martin Pitt

Re: [systemd-devel] fsckd needs to go

2015-04-06 Thread Martin Pitt
is very similar to what we have now, so this mostly amounts to maintaining fsckd in the systemd sources vs. maintaining it separately in Debian/Ubuntu. I'd be interested in what RHEL/SUSE/Arch/etc. want to do. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer

Re: [systemd-devel] fsckd needs to go

2015-04-06 Thread Martin Pitt
, and instead discuss what's wrong with the code. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] recent udev dependency change delays plymouth and udev

2015-04-07 Thread Martin Pitt
: you really shouldn't fsck the root fs that late in the boot anyway. The initrd should fskc the root fs *before* mounting it. Right, that recently happened in Debian now, and will happen in the next Ubuntu release too. Thanks, Martin -- Martin Pitt| http

Re: [systemd-devel] Synchronization Between Services at Shutdown

2015-04-04 Thread Martin Pitt
Lennart Poettering [2015-04-03 14:06 +0200]: Well, it sounds really wrong btw, if NM shuts down the ifaces just because it got kicked off the bus... That's massively wrong. It doesn't -- wpa_supplicant does. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer

Re: [systemd-devel] fsckd needs to go

2015-04-08 Thread Martin Pitt
. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] fsckd needs to go

2015-04-08 Thread Martin Pitt
/broken and switch off the machine. That's a lot riskier :-) Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) signature.asc Description: Digital signature

Re: [systemd-devel] fsckd needs to go -- possible compromise?

2015-04-08 Thread Martin Pitt
during boot instead of leaving the user in the dark why booting is stuck, but it stays noninteractive. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] Synchronization Between Services at Shutdown

2015-04-02 Thread Martin Pitt
already have Before=network.target which is even stronger. But that doesn't help -- it's D-Bus which we need to leave running longer, as dbus going down early tears down all dbus clients as well prematurely, thus rendering the above dependencies useless. Martin -- Martin Pitt

Re: [systemd-devel] Synchronization Between Services at Shutdown

2015-04-02 Thread Martin Pitt
/show_bug.cgi?id=89847 I don't really have a good solution, the don't really stop dbus is a relatively safe hack that's appropriate for the we need to release in two weeks freeze. Obviously the really good solution is to get kdbus, then dbus will always be available :-) Martin -- Martin Pitt

Re: [systemd-devel] [ANNOUNCE] Separating gudev from systemd

2015-05-20 Thread Martin Pitt
, there are epochs in Debian, and I'm sure RPM has these too, but they might not be available everywhere and are generally frowned upon) Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
the removed mount and call device_found_node() with the removal. I'll debug this more closely ASAP, just need to finish something else first. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
Martin Pitt [2015-05-19 15:17 +0200]: My first hunch is that this is caused by calling mount_load_proc_self_mountinfo() in mount_dispatch_io() (src/core/mount.c:1682) *before* it goes through that new SET_FOREACH() loop. That call will already see the removed mount and call device_found_node

[systemd-devel] [PATCH] audit: Fix journal failing on unsupported audit in containers [was: journal: don't complain about audit socket errors in a container.]

2015-05-20 Thread Martin Pitt
will boot fine (including journalling) without audit support, and as soon as the kernel gets fixed it'll automagically start working in containers as well. Lennart, WDYT? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer

Re: [systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
to implement that, can you check if this fixes the issue for you? It does, and it looks much more straightforward now. Many thanks for your patience, this was a hairy thing to untangle.. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com

Re: [systemd-devel] Reduce unit-loading time

2015-05-19 Thread Martin Pitt
-- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] audit: Fix journal failing on unsupported audit in containers [was: journal: don't complain about audit socket errors in a container.]

2015-05-20 Thread Martin Pitt
Lennart Poettering [2015-05-20 14:57 +0200]: On Wed, 20.05.15 13:53, Martin Pitt (martin.p...@ubuntu.com) wrote: -cached_use = true; +/* bind() fails in namespaces (containers), so check that too */ +static const

Re: [systemd-devel] Automatic user ACL management

2015-05-17 Thread Martin Pitt
to do for environments with multiple users. But indeed using static group memberships will achieve this first user to grab a device will keep owning it behaviour. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

[systemd-devel] [PATCH v2] dev-root.device is not active, results in an umount spree

2015-05-17 Thread Martin Pitt
Hello again, Martin Pitt [2015-05-17 13:02 +0200]: - Alternative: Fix device_found_node() to create a .device with the correct (tentative) state if the device doesn't exist in /dev/ or udev (yet). Then manager_load_unit() would not create a dead stub .device any more, but use

Re: [systemd-devel] [PATCH] audit: Fix journal failing on unsupported audit in containers [was: journal: don't complain about audit socket errors in a container.]

2015-05-20 Thread Martin Pitt
LXC containers, but that's not a systemd problem; I'll talk to LXC upstream about that). With these two fixes, should we now remove the scary warning in README? AFAICS there is no need to turn auditing off on the host any more. Thanks! Martin -- Martin Pitt| http

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-06-02 Thread Martin Pitt
proposed and which are superseded; but this one looks good to me. Thank you! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel

[systemd-devel] Is SystemCallFilter working for you?

2015-06-09 Thread Martin Pitt
? In particular, could you check if you have HAVE_SECCOMP and test-execute succeeds (as root) for you? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Martin Pitt
for a long time. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-09 Thread Martin Pitt
unwieldy than losing the line comments IMHO. That said, I'll abide to Lennart's final decision to that of course. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] Is SystemCallFilter working for you?

2015-06-10 Thread Martin Pitt
Hello again, Martin Pitt [2015-06-09 13:00 +0200]: I was about to (re-)enable seccomp support in our systemd packages, and to write an integration test for it. However, it seems that this currently does not seem to work at all. For the archives: Not sure what went wrong yesterday, today

Re: [systemd-devel] Weird udev issue: char device replaced by regular file on suspend

2015-06-25 Thread Martin Pitt
/dev/ttyUSB0. (We didn't get any report about this so far, so I doubt it's actually modemmanager -- it just illustrates how this could happen in principle). Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] no tar balls at release time

2015-06-23 Thread Martin Pitt
also handles package builds straight from a git checkout (for CI). Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-27 Thread Martin Pitt
-- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-27 Thread Martin Pitt
packages Ubuntu (or Debian) builds. *nod* Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http

[systemd-devel] abstracting chkconfig vs. update-rc.d [was: non-merged /usr changes]

2015-05-27 Thread Martin Pitt
/remove_initd /etc/init.d/example.com-coffeed So we could make systemctl just call this if it's available, and otherwise do nothing for init.d scripts. I'll cook a patch for this. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-27 Thread Martin Pitt
sounds good. With getting rid of a few large patches (like the chkconfig → update-rc. ones, or the man page paths), doing CI more often on my distro side will also become a much less manual process. Thanks for having this post-mortem discussion, this is useful! Martin -- Martin Pitt

Re: [systemd-devel] [PATCH] path-util: Fix path_is_mount_point for files

2015-05-28 Thread Martin Pitt
Hello Lennart, Lennart Poettering [2015-05-28 19:44 +0200]: On Wed, 27.05.15 10:07, Martin Pitt (martin.p...@ubuntu.com) wrote: -int fd_is_mount_point(int fd) { +int fd_is_mount_point(int fd, const char *parent) { Hmm, now I am confused? Why parent? I really think this should work

Re: [systemd-devel] [PATCH v3] systemctl: Don't skip SysV init.d scripts when enabling/disabling units

2015-05-28 Thread Martin Pitt
Lennart Poettering [2015-05-28 19:23 +0200]: Looks good. Please push. For the archives: Pushed. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd

Re: [systemd-devel] [PATCH 0/2] Using XML entities for paths in manpages

2015-05-28 Thread Martin Pitt
Hey Filipe, Lennart Poettering [2015-05-28 19:35 +0200]: On Wed, 27.05.15 02:38, Filipe Brandenburger (filbran...@google.com) wrote: As suggested by Martin Pitt, for better support of distros with non-merged /usr. This doesn't get us 100% there but I'd say it gets us much closer

Re: [systemd-devel] [PATCH v3] systemctl: drop hardcoded chkconfig invocation

2015-05-28 Thread Martin Pitt
Lennart Poettering [2015-05-28 19:22 +0200]: Looks good. Please push! For the archives: Pushed. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd

Re: [systemd-devel] disabling ctrl+alt+del

2015-05-28 Thread Martin Pitt
ctrl-alt-del.target job). If that's bothering, you, create an /etc/systemd/system/ctrl-alt-del.target with just [Unit] and a Description= and nothing else, then you don't get an error message any more. This will also override the builtin Alias= in reboot.target. Martin -- Martin Pitt

[systemd-devel] [PATCH] build-sys: pass originally configured --enable-split-usr to distcheck

2015-05-28 Thread Martin Pitt
. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) From 00bed6f7a42f5bb8479f415f61349a63a8d6dba0 Mon Sep 17 00:00:00 2001 From: Martin Pitt martin.p...@ubuntu.com Date: Fri, 29 May 2015 07:39:53 +0200 Subject

Re: [systemd-devel] [PATCH] build-sys: fix typo

2015-05-29 Thread Martin Pitt
Hey Karel, Karel Zak [2015-05-29 13:42 +0200]: There is nothing like systemd_verify_* in Makefile.am. The bug has been invisible because automake uses the default CFLAGS when component CFLAGS are undefined. Applied, looks/works fine. Thanks! Martin -- Martin Pitt

Re: [systemd-devel] systemctl disable service not working as expected

2015-05-29 Thread Martin Pitt
the library (libpulse) from the user session. It's not very common to enable a system-wide daemon with the .service file. So presumably it's just from that? Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [PATCH] build-sys: Stop depending on current configure options for EXTRA_DIST

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 12:20 +0200]: From all I can see this looks fine. Please push. Pushed. -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd

Re: [systemd-devel] [PATCH] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
the whole thing a lot cleaner. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http

Re: [systemd-devel] [PATCH] build-sys: pass originally configured --enable-split-usr to distcheck

2015-05-29 Thread Martin Pitt
, but it shouldn't be too hard, there's plenty of them :-) On my TODO now. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
the regression. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) From eb23ac596bd57e10f64dad45e0c98e60ef460359 Mon Sep 17 00:00:00 2001 From: Martin Pitt martin.p...@ubuntu.com Date: Wed, 27 May 2015 09:56:03

Re: [systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

2015-05-29 Thread Martin Pitt
don't support that yet? That would be a bit ugly, but bearable, I guess, and it'll sort itself out over time. Or are there any worse issues there? Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
push. Pushed with the above change. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH] cryptsetup: craft a unique ID with the source device

2015-05-29 Thread Martin Pitt
Harald Hoyer [2015-05-29 16:50 +0200]: I was more thinking about symlinks pointing to the same device. Naïvely I'd think that resolving symlinks would still be more readable than major/minor numbers; why would that be worse? Thanks, Martin -- Martin Pitt| http

Re: [systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:50 +0200]: Looks good too. Please push! Pushed. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing

[systemd-devel] [PATCH v2 2/2] path-util: Change path_is_mount_point() symlink arg from bool to flags

2015-05-29 Thread Martin Pitt
Hello, and this is the second part which updates the signature of path_is_mount_point() to replace bool allow_symlink to an openat()-like flags. This patch does not change visible behaviour, it's just a stylistic issue. Martin -- Martin Pitt| http://www.piware.de Ubuntu

Re: [systemd-devel] [PATCH] core/namespace: Protect /usr instead of /home with ProtectSystem=yes

2015-05-31 Thread Martin Pitt
Hey Jason, Jason Pleau [2015-05-31 12:51 -0400]: A small typo in ee818b8 caused /home to be put in read-only instead of /usr when ProtectSystem was enabled (ie: not set to no). Argh, thanks for spotting and the patch! Applied. Martin -- Martin Pitt| http

Re: [systemd-devel] bcache broke in udev 220

2015-06-01 Thread Martin Pitt
. The simple attached patch fixes this, could you please apply it? Applied, thank you! http://cgit.freedesktop.org/systemd/systemd/commit/?id=19672f1e5f Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] sd-device: fix invalid property strv pointers

2015-06-01 Thread Martin Pitt
: http://cgit.freedesktop.org/systemd/systemd/commit/?id=d854ba50 Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) signature.asc Description: Digital signature

Re: [systemd-devel] abstracting chkconfig vs. update-rc.d [was: non-merged /usr changes]

2015-05-27 Thread Martin Pitt
on this, our initscripts maintainer. Did you mean to CC: him? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd

Re: [systemd-devel] [PATCH 1/2] corrected Subject: systemctl: add support for LSB init.d script enabling/disabling

2015-05-27 Thread Martin Pitt
Meh, copypaste fail, Subject: should have been systemctl: add support for LSB init.d script enabling/disabling -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [PATCH 1/1] Ensure that /run/systemd/network exists

2015-05-27 Thread Martin Pitt
- d /run/systemd/netif/links 0755 systemd-network systemd-network - d /run/systemd/netif/leases 0755 systemd-network systemd-network - ? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

[systemd-devel] [PATCH 2/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
an issue for e. g. Debian or third-party packages which want to support multiple init systems. This patch calls both chkconfig (or install_initd with the previous patch) and handles the native unit in that case. Thanks for considering, Martin -- Martin Pitt| http

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
need this? systemctl calls stuff one by one in a loop anyway? Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
. If there is both a script and a unit for the same name we need a second patch, will post that separately as 2/2 as it's unrelated to this change. Thanks for considering, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
it that way. I care more about getting some abstraction than getting an LSB compatible one :-) Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] abstracting chkconfig vs. update-rc.d [was: non-merged /usr changes]

2015-05-27 Thread Martin Pitt
. But anyway, this is moot. We won't call those from systemd after all, but instead introduce /usr/lib/systemd/systemd-sysv-install. Thanks! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

[systemd-devel] [PATCH v2 1/2] systemctl: drop hardcoded chkconfig invocation

2015-05-27 Thread Martin Pitt
change. I tested this with both --enable-chkconfig and --disable-chkconfig, and with make dist (*cough*) This doesn't have a manpage yet (as it's not an user-callable program); where should this be documented? Just adding to README? Thanks, Martin -- Martin Pitt| http

[systemd-devel] [PATCH v2 2/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
Hello, same rationale and patch as before, just unfuzzed against the updated systemctl: drop hardcoded chkconfig invocation. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) From

<    1   2   3   4   5   >