Re: [systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
On Tue, Mar 24, 2015 at 11:32 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Mar 24, 2015 at 7:11 PM, Shawn Landden sh...@churchofgit.com wrote: /* Enforce the values of /etc/localtime */ if (getenv(TZ)) { -fprintf(stderr, Warning: Ignoring the TZ variable.\n\n

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: On Fri, Mar 27, 2015 at 8:16 AM, Tom Gundersen t...@jklm.no wrote: [...] * Current expression may modify/interact with a global state which may cause

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 4:02 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/30/2015 10:32 PM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 1:35 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: Heyja Should this not be dropped and *DE write,integrate/implement an graphical

[systemd-devel] [PATCH] macro: allow assert_se() assertions to also be optimized when NDEBUG is set

2015-03-30 Thread Shawn Landden
replaces log with assert() to remove strings. saves 3kB from text section of systemd. --- src/shared/macro.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/shared/macro.h b/src/shared/macro.h index 7f89951..8cbff01 100644 --- a/src/shared/macro.h +++

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 8:34 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 30 Mar 2015 19:30:02 -0700 Shawn Landden shawnland...@gmail.com пишет: What do you feel is missing from systemctl show? It is only suppose to show fields that have been changed by humans (even

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-27 Thread Shawn Landden
On Thu, Mar 26, 2015 at 5:47 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Mar 27, 2015 at 12:30:53AM +0100, Tom Gundersen wrote: On Thu, Mar 26, 2015 at 9:19 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 24.03.15 11:11, Shawn Landden (sh...@churchofgit.com) wrote

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-27 Thread Shawn Landden
On Thu, Mar 26, 2015 at 1:19 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 24.03.15 11:11, Shawn Landden (sh...@churchofgit.com) wrote: Will result in slightly smaller binaries, and cuts out the branch, even if the expression is still executed. I am sorry, but the whole point

Re: [systemd-devel] [PATCH] CODING_STYLE: this also help with unaligned memory accesses

2015-03-27 Thread Shawn Landden
On Thu, Mar 26, 2015 at 1:31 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 24.03.15 11:16, Shawn Landden (sh...@churchofgit.com) wrote: And those arches don't get much testing too. --- CODING_STYLE | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 8:38 AM, Djalal Harouni tix...@opendz.org wrote: On Mon, Mar 30, 2015 at 07:32:35PM -0700, Shawn Landden wrote: On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: On Fri, Mar 27, 2015

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 7:19 AM, Dimitri John Ledkov dimitri.j.led...@intel.com wrote: On 31 March 2015 at 15:08, Shawn Landden shawnland...@gmail.com wrote: On Tue, Mar 31, 2015 at 12:31 AM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/31/2015 02:30 AM, Shawn Landden wrote

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 10:35 AM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 30.03.15 19:30, Shawn Landden (shawnland...@gmail.com) wrote: What do you feel is missing from systemctl show? It is only suppose to show fields that have been changed by humans (even the developer

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 12:31 AM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/31/2015 02:30 AM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 4:02 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/30/2015 10:32 PM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 1:35

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
On Mon, Mar 23, 2015 at 4:42 AM, Stef Walter st...@redhat.com wrote: On 23.03.2015 12:11, Shawn Landden wrote: On Sun, Mar 22, 2015 at 10:32 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 19.03.15 14:39, David Herrmann (dh.herrm...@gmail.com) wrote: Hmm, so

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH] bootchart: remove duplicated code, prevent creating empty files

2015-03-23 Thread Shawn Landden
on IRC Signed-off-by: Shawn Landden sh...@churchofgit.com --- src/bootchart/bootchart.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/bootchart/bootchart.c b/src/bootchart/bootchart.c index 99ffb86..71dffc9 100644 --- a/src/bootchart/bootchart.c +++ b/src/bootchart/bootchart.c

[systemd-devel] [PATCH] timedatectl: fix when queried system has differn't timezone

2015-03-23 Thread Shawn Landden
Also allow getting time from time(2) when BUS_TRANSPORT_MACHINE. --- src/timedate/timedatectl.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index 9e04f8f..7c9bd11 100644 --- a/src/timedate/timedatectl.c +++

[systemd-devel] [PATCH] timedatectl: fix when queried system has differn't timezone

2015-03-23 Thread Shawn Landden
Also allow getting time from time(2) when BUS_TRANSPORT_MACHINE. v2: check for error --- src/timedate/timedatectl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index 9e04f8f..44d329e 100644 ---

[systemd-devel] [PATCH] bootchart: more useful error message for common error

2015-03-23 Thread Shawn Landden
Reported-by: tfirg_ on IRC Signed-off-by: Shawn Landden sh...@churchofgit.com --- src/bootchart/store.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index 607cc5e..dfa681f 100644 --- a/src/bootchart/store.c +++ b/src/bootchart

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-27 Thread Shawn Landden
. This also eliminates one directory. All of these are handled by units: sleep.target shutdown.target etc... On Fri, Feb 20, 2015 at 02:31:00PM -0800, Shawn Landden wrote: --- Makefile.am | 6 +- src/core/shutdown.c | 420 - src

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 6:22 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Feb 26, 2015 at 08:04:08AM +, Jan Janssen wrote: Shawn Landden shawn at churchofgit.com writes: void strv_free(char **l) { -strv_clear(l); +char **k

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Fri, Feb 27, 2015 at 9:03 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: We need two operations: sorting kernels to list them, and picking (I On Fri, Feb 27, 2015 at 08:58:04AM -0800, Shawn Landden wrote: On Thu, Feb 26, 2015 at 6:22 PM, Zbigniew Jędrzejewski-Szmek zbys

[systemd-devel] sd_id128_equal borked

2015-02-27 Thread Shawn Landden
_sd_pure_ static inline int sd_id128_equal(sd_id128_t a, sd_id128_t b) { return memcmp(a, b, 16) == 0; } this should either be return memcmp(a, b, 16); or return bool -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd

[systemd-devel] [PATCH] core/socket: Add REMOTE_IP environment variable for Accept=true

2015-03-04 Thread Shawn Landden
Fix handling of abstract unix domain sockets too. v2 --- TODO | 2 -- man/systemd.socket.xml | 5 - src/core/service.c | 24 src/shared/socket-util.c | 25 +++-- 4 files changed, 47 insertions(+), 9 deletions(-) diff

Re: [systemd-devel] [PATCH] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-04 Thread Shawn Landden
On Wed, Mar 4, 2015 at 7:58 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 03, 2015 at 04:21:30PM -0800, Shawn Landden wrote: also switch to inttypes.h --- src/udev/udev-builtin-usb_id.c | 35 ++- 1 file changed, 18 insertions

[systemd-devel] [PATCH] core/socket: Add REMOTE_IP environment variable for Accept=true

2015-03-04 Thread Shawn Landden
Fix handling of abstract unix domain sockets too. --- TODO | 2 -- man/systemd.socket.xml | 5 - src/core/service.c | 24 src/shared/socket-util.c | 25 +++-- 4 files changed, 47 insertions(+), 9 deletions(-) diff

Re: [systemd-devel] [PATCH] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-04 Thread Shawn Landden
Oh wait, I c, yes I had same question. On Wed, Mar 4, 2015 at 8:07 PM, Shawn Landden sh...@churchofgit.com wrote: On Wed, Mar 4, 2015 at 7:58 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 03, 2015 at 04:21:30PM -0800, Shawn Landden wrote: also switch to inttypes.h

[systemd-devel] [PATCH] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-03 Thread Shawn Landden
also switch to inttypes.h --- src/udev/udev-builtin-usb_id.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/udev/udev-builtin-usb_id.c b/src/udev/udev-builtin-usb_id.c index ab0d96e..0223421 100644 --- a/src/udev/udev-builtin-usb_id.c

Re: [systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 12:04 AM, Jan Janssen medhe...@web.de wrote: Shawn Landden shawn at churchofgit.com writes: void strv_free(char **l) { -strv_clear(l); +char **k; + +if (!l) +return; + +for (k = l; *k; k

[systemd-devel] [v3 1/4] man: these binaries are internal APIs

2015-02-27 Thread Shawn Landden
--- man/systemd-halt.service.xml | 1 - man/systemd-shutdownd.service.xml | 1 - man/systemd-suspend.service.xml | 1 - 3 files changed, 3 deletions(-) diff --git a/man/systemd-halt.service.xml b/man/systemd-halt.service.xml index c94e2a1..7e7f8f2 100644 --- a/man/systemd-halt.service.xml

[systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-20 Thread Shawn Landden
: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright 2015 Shawn Landden + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software

Re: [systemd-devel] feature request: dlopen

2015-02-22 Thread Shawn Landden
mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [systemd-devel] A use case for staged startup

2015-02-21 Thread Shawn Landden
-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-27 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. If TZDIR is set, glibc will look there rather than /usr/share/zoneinfo. See tzset(3). --- src/timedate/timedatectl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. avoid calling gmtime_r() and localtime_r() twice deduplicate some strings v2 --- src/timedate/timedatectl.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. v3 --- src/timedate/timedatectl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index ab5c8a1..d529a0a 100644 ---

[systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. --- src/timedate/timedatectl.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index ab5c8a1..8daae54

[systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-24 Thread Shawn Landden
Will result in slightly smaller binaries, and cuts out the branch, even if the expression is still executed. --- src/shared/macro.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/shared/macro.h b/src/shared/macro.h index 7f89951..02219ea 100644 ---

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
On Mon, Mar 23, 2015 at 12:13 PM, Stef Walter st...@redhat.com wrote: Sorry about the encrypted email ... I hit the wrong button. On 23.03.2015 19:07, Shawn Landden wrote: On Mon, Mar 23, 2015 at 8:56 AM, Kay Sievers k...@vrfy.org wrote: On Mon, Mar 23, 2015 at 3:49 PM, Stef Walter st

Re: [systemd-devel] systemd not honoring LD_LIBRARY_PATH?

2015-03-27 Thread Shawn Landden
-- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] timedated: add LocalTimeUSec via dbus

2015-03-23 Thread Shawn Landden
On Mon, Mar 23, 2015 at 6:52 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Mar 23, 2015 at 04:24:38AM -0700, Shawn Landden wrote: --- src/timedate/timedated.c | 24 1 file changed, 24 insertions(+) diff --git a/src/timedate/timedated.c b/src

Re: [systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
Actually you missed that free_sysvstub_hashmap does not tolerate NULL pointers. On Sun, Apr 26, 2015 at 11:21 AM, Shawn Landden sh...@churchofgit.com wrote: On Sun, Apr 26, 2015 at 11:15 AM, Thomas H.P. Andersen pho...@gmail.com wrote: Hi Shawn, I fixed this a few hours ago. I also updated

Re: [systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
, Apr 26, 2015 at 12:04 PM, Thomas H.P. Andersen pho...@gmail.com wrote: On Sun, Apr 26, 2015 at 8:31 PM, Thomas H.P. Andersen pho...@gmail.com wrote: On Sun, Apr 26, 2015 at 8:23 PM, Shawn Landden sh...@churchofgit.com wrote: Actually you missed that free_sysvstub_hashmap does not tolerate NULL

[systemd-devel] [PATCH 1/2] path-util: fix fd_is_mount_point

2015-04-26 Thread Shawn Landden
(coverity) --- src/shared/path-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/path-util.c b/src/shared/path-util.c index 925bb28..95bfafc 100644 --- a/src/shared/path-util.c +++ b/src/shared/path-util.c @@ -627,7 +627,7 @@ fallback_fstat:

[systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
(coverity) --- src/sysv-generator/sysv-generator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 5ecd750..714ce8f 100644 --- a/src/sysv-generator/sysv-generator.c +++

Re: [systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
in on my end. On Sun, Apr 26, 2015 at 7:58 PM, Shawn Landden sh...@churchofgit.com wrote: (coverity) --- src/sysv-generator/sysv-generator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index

[systemd-devel] [PATCH] sysv-generator: do not dereference uninitilized data or NULL pointer

2015-04-26 Thread Shawn Landden
(coverity) v2 --- src/sysv-generator/sysv-generator.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 5ecd750..f56d727 100644 --- a/src/sysv-generator/sysv-generator.c +++

Re: [systemd-devel] [PATCH 5/6] network: fix strict aliasing issue

2015-04-12 Thread Shawn Landden
On Sun, Apr 12, 2015 at 12:43 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 11.03.15 08:13, Shawn Landden (sh...@churchofgit.com) wrote: We shouldn't assume 64-bit arch with the way we do math either. (although I will submit a patch to glibc to add a uint64_t union alias) Hmm

Re: [systemd-devel] [PATCH] network: allow domain names up to 255 characters

2015-04-12 Thread Shawn Landden
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [PATCH] network: allow domain names up to 255 characters

2015-04-12 Thread Shawn Landden
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd-network src/udev

2015-04-11 Thread Shawn Landden
: Shawn Landden sh...@churchofgit.com Date: Tue Mar 10 20:45:15 2015 -0700 sd-dhcp-client: fix strict aliasing issue diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index 4224e01..a477ccc 100644 --- a/src/libsystemd-network/sd-dhcp

Re: [systemd-devel] sd_event_run

2015-04-11 Thread Shawn Landden
as _new(). Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com

Re: [systemd-devel] sd_event_run

2015-04-11 Thread Shawn Landden
On Sat, Apr 11, 2015 at 6:01 PM, Shawn Landden shawnland...@gmail.com wrote: On Sat, Apr 11, 2015 at 4:52 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Apr 10, 2015 at 06:14:40PM +0200, Lennart Poettering wrote: On Sat, 14.03.15 12:19, Tom Gundersen (t...@jklm.no) wrote

[systemd-devel] [PATCH] sd-dhcp-client: shutup gcc aliasing warning

2015-04-11 Thread Shawn Landden
we only access this as void* so there is no violation --- src/libsystemd-network/sd-dhcp-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index c44392e..bf57d4b 100644 ---

[systemd-devel] [PATCH] bootchart: fix check for no fd

2015-04-05 Thread Shawn Landden
found with coverty report --- src/bootchart/store.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index f19427e..f159cba 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -476,7 +476,7 @@ catch_rename:

<    1   2   3