Re: [systemd-devel] ipv6 configuration error

2016-05-27 Thread Tom Gundersen
On Fri, May 27, 2016 at 5:11 PM, Michał Zegan wrote: > Hello, I have encountered a very interesting problem: I have a wired > ipv4 network configured via systemd-network, and an ipv6 sit tunnel. > The problem is it does not start. trying to restart systemd-networkd > gives the error like both loc

Re: [systemd-devel] network unit Match by router advertisement?

2016-05-20 Thread Tom Gundersen
On Wed, May 11, 2016 at 7:31 PM, Lennart Poettering wrote: > On Wed, 11.05.16 11:32, Brian Kroth (bpkr...@gmail.com) wrote: > > > Hi again all, > > > > TL;DR: would it be possible (or make sense) to have systemd Match rules > for > > network units that could match on some artifact of the network

Re: [systemd-devel] [RFC] the chopping block

2016-02-11 Thread Tom Gundersen
On Thu, Feb 11, 2016 at 6:06 PM, Lennart Poettering wrote: > Heya! > > So I am thinking about some spring cleaning, and would love to remove > the following bits from the systemd package: > All this looks good to me. > 1) systemd-initctl (i.e. the /dev/initctl SysV compat support). Last >t

Re: [systemd-devel] Where is DHCP Address stored?

2015-11-28 Thread Tom Gundersen
On Sat, Nov 28, 2015 at 4:42 PM, J Decker wrote: > On Sat, Nov 28, 2015 at 7:36 AM, Tom Gundersen wrote: >> On Sat, Nov 28, 2015 at 4:33 PM, J Decker wrote: >>> Okay maybe it's not stored anywhere >>> >>> I was just having a plethora of network iss

Re: [systemd-devel] Where is DHCP Address stored?

2015-11-28 Thread Tom Gundersen
On Sat, Nov 28, 2015 at 4:33 PM, J Decker wrote: > Okay maybe it's not stored anywhere > > I was just having a plethora of network issues after updating. > > After finding others were reporting issues with the linux kernel 4.2.5 > I rollback to the prior stable 4.1.6... that resolved some of t

Re: [systemd-devel] DHCPC Events?

2015-11-19 Thread Tom Gundersen
This is not really exposed nicely. There is a C library sd-network, which will give you the events you want, but it is not yet public (you can still copy it out of git of course). On Nov 12, 2015 05:24, "J Decker" wrote: > Should I have not said specifically Arch linux? > Is it something that can

Re: [systemd-devel] Fwd: [PATCH] Add support for detecting NIC partitions on Dell Servers

2015-11-10 Thread Tom Gundersen
On Tue, Nov 10, 2015 at 2:29 PM, Jordan Hargrave wrote: > On Tue, Nov 10, 2015 at 4:53 AM, Kay Sievers wrote: >> On Tue, Nov 10, 2015 at 5:49 AM, Jordan Hargrave wrote: >>> Cleaned up linux coding style >>> >>> This patch will integrate some of the features of biosdevname into systemd. >>> The c

Re: [systemd-devel] Secret machine-id for RFC 7217 stable addresses

2015-10-08 Thread Tom Gundersen
Hi Lubomir, Sorry not to have responded to this earlier, but as I was just reminded of this, here are my take: On Mon, Sep 7, 2015 at 7:49 PM, Lubomir Rintel wrote: > the RFC 7217 specifies an algorithm for generating an IPv6 host address > that stays stable in a particular network but changes w

Re: [systemd-devel] Persistent virtio device name removal

2015-09-02 Thread Tom Gundersen
lt;https://github.com/systemd/systemd/commit/54683f0f9b97a8f88aaf4fbb45b4d729057b101c> On Fri, Jul 4, 2014 at 1:31 AM, Tom Gundersen wrote: > On Fri, Jul 4, 2014 at 12:55 AM, Michael Marineau > wrote: >> Working on bumping to 215 over here in CoreOS land, but I've got a >>

Re: [systemd-devel] Configurability for systemd logging API

2015-07-30 Thread Tom Gundersen
On Thu, Jul 30, 2015 at 8:16 AM, SF Markus Elfring wrote: >>> Such messages correspond to specific data structures. >>> * The log origin and log level are repeated there while the recorded >>> information might occasionally not be detailed enough. >>> I find that such details can be better han

Re: [systemd-devel] Configurability for systemd logging API

2015-07-29 Thread Tom Gundersen
Hi Markus, On Wed, Jul 29, 2015 at 8:54 PM, SF Markus Elfring wrote: > Programs from the systemd software library output also some log messages > as it is usual for such server applications. > > Such messages correspond to specific data structures. > * The log origin and log level are repeated th

Re: [systemd-devel] kdbus, udev and systemd in the initramfs

2015-07-29 Thread Tom Gundersen
On Wed, Jul 29, 2015 at 2:23 PM, Michael Biebl wrote: > 2015-07-29 5:40 GMT+02:00 Tom Gundersen : >> On Wed, Jul 29, 2015 at 1:21 AM, Michael Biebl wrote: >>> something I was wondering regarding kdbus and udev. >>> If udev wants to drop the netlink transport and inste

Re: [systemd-devel] kdbus, udev and systemd in the initramfs

2015-07-28 Thread Tom Gundersen
On Wed, Jul 29, 2015 at 5:40 AM, Tom Gundersen wrote: > On Wed, Jul 29, 2015 at 1:21 AM, Michael Biebl wrote: >> something I was wondering regarding kdbus and udev. >> If udev wants to drop the netlink transport and instead rely on kdbus, >> would this mean, systemd bec

Re: [systemd-devel] kdbus, udev and systemd in the initramfs

2015-07-28 Thread Tom Gundersen
On Wed, Jul 29, 2015 at 1:21 AM, Michael Biebl wrote: > something I was wondering regarding kdbus and udev. > If udev wants to drop the netlink transport and instead rely on kdbus, > would this mean, systemd becomes mandatory in the initramfs to setup > kdbus before udev is run? _If_ udev drops n

Re: [systemd-devel] [PATCH] Remove accelerometer helper

2015-06-29 Thread Tom Gundersen
On Sat, Jun 27, 2015 at 10:02 PM, Kay Sievers wrote: > On Fri, May 22, 2015 at 3:42 PM, Bastien Nocera wrote: >> It's moved to the iio-sensor-proxy D-Bus service. >> --- >> .gitignore | 1 - >> Makefile.am| 15 -- >> rules/61-acceleromet

Re: [systemd-devel] systemd-nspawn: cannot join existing macvlan

2015-06-18 Thread Tom Gundersen
On Thu, Jun 18, 2015 at 9:10 PM, Lennart Poettering wrote: > On Sat, 30.05.15 19:55, Kai Krakow (hurikha...@gmail.com) wrote: > >> The next issue with your argument is: AFAIR nspawn doesn't create a macvlan >> interface based on the machine name. You have to pass the name of a physical >> interfac

Re: [systemd-devel] Regression: loop device detach errors in 220

2015-06-03 Thread Tom Gundersen
1]: Failed to finalize _ loop devices, ignoring > > https://bugs.archlinux.org/task/45111 > > c32eb440bab953a0169cd207dfef5cad16dfb340 is the first bad commit > Author: Tom Gundersen > Date: Tue Apr 14 16:25:06 2015 +0200 > > libudev: ma

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo & utab

2015-06-02 Thread Tom Gundersen
On Tue, Jun 2, 2015 at 1:53 PM, Karel Zak wrote: > On Mon, Jun 01, 2015 at 05:06:56PM +0200, Tom Gundersen wrote: >> > -(void) >> > sd_event_source_set_description(m->mount_utab_event_source, >> > "mount-utab-dispatch"); >> >

Re: [systemd-devel] [PATCH] mount-setup: create /run/systemd/netif/links/ before accessing

2015-06-02 Thread Tom Gundersen
On Mon, Jun 1, 2015 at 9:16 PM, Robert Schwebel wrote: > systemd-timesyncd breaks with > > Starting Network Time Synchronization... > [FAILED] Failed to start Network Time Synchronization. > > when we have timesyncd activated and systemd-networkd not. Create > directory before using it. Hm, t

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo & utab

2015-06-01 Thread Tom Gundersen
Hi Karel, On Mon, Jun 1, 2015 at 2:07 PM, Karel Zak wrote: > The current implementation directly monitor /proc/self/mountinfo and > /run/mount/utab files. It's really not optimal because utab file is > private libmount stuff without any official guaranteed semantic. > > The libmount since v2.26 p

Re: [systemd-devel] sd-device: fix invalid property strv pointers

2015-06-01 Thread Tom Gundersen
On Mon, Jun 1, 2015 at 11:39 AM, Martin Pitt wrote: > With our 220 package I still get a broken environment in udev > callouts, even with Tom's recent fix 0e3e605 applied. > > Curiously it works for devices like "lo" which don't have a lot of > properties, but for "real" wlan devices I get invalid

Re: [systemd-devel] udev --daemon is broken again

2015-05-31 Thread Tom Gundersen
On Sun, May 31, 2015 at 9:45 PM, Tom Gundersen wrote: > On Sun, May 31, 2015 at 8:45 PM, Abdó Roig-Maranges > wrote: >> >> Andrei Borzenkov writes: >> >>> Was not it fixed by >>> 693d371d30fee1da58365121801445b404416ada? >> >> No. >

Re: [systemd-devel] udev --daemon is broken again

2015-05-31 Thread Tom Gundersen
On Sun, May 31, 2015 at 8:45 PM, Abdó Roig-Maranges wrote: > > Andrei Borzenkov writes: > >> Was not it fixed by >> 693d371d30fee1da58365121801445b404416ada? > > No. > > The first time it broke was due to the udev manager wanting to be used by a > single process, and was fixed in 040e689654ef08c63

Re: [systemd-devel] Questions about socket activated services

2015-05-30 Thread Tom Gundersen
On Sat, May 30, 2015 at 3:36 PM, cee1 wrote: > Which service type should a socket activated service be? > 1. For systemd-udevd.service and systemd-journald.service, they are notify > type > 2. For dbus.service, it is simple type A service can be of type 'simple' if all that other services care a

Re: [systemd-devel] 'udevadm settle' brakes lvm on top of imsm raid

2015-05-28 Thread Tom Gundersen
On Thu, May 28, 2015 at 10:10 AM, Oleg Samarin wrote: > Hi! > > I have an imsm raid-1 device /dev/md126 assembled of /dev/sda and /dev/sdb. > I have a lvm group on top of /dev/md126p2 with some logical volumes. All > this work fine with Fedora 21. > > I'm trying to fresh install Fedora 22 in some

Re: [systemd-devel] [PATCH] Fix systemd.resource-control(5) volume number.

2015-05-27 Thread Tom Gundersen
On Wed, May 27, 2015 at 9:47 PM, Patrick Donnelly wrote: > Signed-off-by: Patrick Donnelly We don't use s-o-b in systemd, so dropped this when applying. Also adjusted the subject line a bit (for future reference). Thanks for the patch! Pushed. Cheers, Tom > --- > man/systemd.slice.xml | 2 +-

Re: [systemd-devel] [PATCH] fix extraneous space in equality check

2015-05-27 Thread Tom Gundersen
Applied. Thanks! Tom On Wed, May 27, 2015 at 9:02 PM, Jonathan Boulle wrote: > --- > src/core/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/core/main.c b/src/core/main.c > index c39815b10675..212ab901b18f 100644 > --- a/src/core/main.c > +++ b/src/core/main

Re: [systemd-devel] crda broken with systemd 220

2015-05-27 Thread Tom Gundersen
On Tue, May 26, 2015 at 11:53 AM, Michał Bartoszkiewicz wrote: > Hello, > > it seems that udev from systemd 220 does passes empty environment to a > process spawned by a RUN rule. > execve("/usr/sbin/crda", ["/usr/sbin/crda"], [/* 0 vars */]) = 0 > This breaks crda, as it expects to see COUNTRY in

Re: [systemd-devel] 220 udev boot regression: timeout, giving up waiting for workers to finish

2015-05-27 Thread Tom Gundersen
On Wed, May 27, 2015 at 6:23 PM, Tom Gundersen wrote: > On Wed, May 27, 2015 at 6:16 PM, Filipe Brandenburger > wrote: >> Hi Tom, >> >> On Wed, May 27, 2015 at 8:45 AM, Tom Gundersen wrote: >>> It appears a few people see this, but I was not able to reproduce. I

Re: [systemd-devel] 220 udev boot regression: timeout, giving up waiting for workers to finish

2015-05-27 Thread Tom Gundersen
On Wed, May 27, 2015 at 6:16 PM, Filipe Brandenburger wrote: > Hi Tom, > > On Wed, May 27, 2015 at 8:45 AM, Tom Gundersen wrote: >> It appears a few people see this, but I was not able to reproduce. If >> anyone could reproduce with this patch applied [0], it would be most

Re: [systemd-devel] 220 udev boot regression: timeout, giving up waiting for workers to finish

2015-05-27 Thread Tom Gundersen
On Tue, May 26, 2015 at 5:11 PM, Martin Pitt wrote: > Hello Tom, all, > > with 220 I get a severe boot time regression: > > $ systemd-analyze > Startup finished in 30.751s (kernel) + 11.706s (userspace) = 42.458s > > which used to be > > $ systemd-analyze > Startup finished in 703ms (kerne

Re: [systemd-devel] [PATCH] missing: add more IFLA_VXLAN_* defines

2015-05-27 Thread Tom Gundersen
Applied. Thanks! Tom On Tue, May 26, 2015 at 7:48 AM, Michael Olbrich wrote: > Otherwise building faild with kernel headers < v3.16 > --- > configure.ac | 2 +- > src/shared/missing.h | 11 +-- > 2 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/

Re: [systemd-devel] Adding additional network interfaces "dynamically", after networkd startup finishes

2015-05-27 Thread Tom Gundersen
On Wed, May 27, 2015 at 2:03 PM, Peter Lemenkov wrote: > Hello All! > My network is managed via systemd-networkd. I'm trying to create > additional network bridge after another one service (VPN) is started. > > Right now I'm having a ExecStartPost directive, which creates > /run/systemd/network, c

Re: [systemd-devel] 220 udev boot regression: timeout, giving up waiting for workers to finish

2015-05-26 Thread Tom Gundersen
On Tue, May 26, 2015 at 9:04 PM, Christian Hesse wrote: > Martin Pitt on Tue, 2015/05/26 17:11: >> Hello Tom, all, >> >> with 220 I get a severe boot time regression: >> >> $ systemd-analyze >> Startup finished in 30.751s (kernel) + 11.706s (userspace) = 42.458s >> >> which used to be >> >>

Re: [systemd-devel] 220 udev boot regression: timeout, giving up waiting for workers to finish

2015-05-26 Thread Tom Gundersen
On Tue, May 26, 2015 at 9:04 PM, Christian Hesse wrote: > Martin Pitt on Tue, 2015/05/26 17:11: >> Hello Tom, all, >> >> with 220 I get a severe boot time regression: >> >> $ systemd-analyze >> Startup finished in 30.751s (kernel) + 11.706s (userspace) = 42.458s >> >> which used to be >> >>

Re: [systemd-devel] inotify_add_watch() failed: Bad file descriptor

2015-05-26 Thread Tom Gundersen
On Tue, May 26, 2015 at 10:14 AM, Christian Hesse wrote: > Hello everybody, > > with systemd v220 I see inotify errors from udevd. I get this once: > > systemd-udevd: inotify_add_watch(9, /dev/sr0, 10) failed: Bad file descriptor > > And a lot of these: > > systemd-udevd: inotify_add_watch(9, /dev

Re: [systemd-devel] [PATCH] treewide: fix typos

2015-05-26 Thread Tom Gundersen
Applied. Thanks! Tom On Tue, May 26, 2015 at 7:17 PM, Torstein Husebø wrote: > --- > NEWS| 4 ++-- > man/journal-remote.conf.xml | 2 +- > src/libsystemd/sd-bus/bus-control.c | 2 +- > src/libsystemd/sd-bus/bus-creds.c | 6 +++--- > src/shared/architect

Re: [systemd-devel] 220 udev boot regression: timeout, giving up waiting for workers to finish

2015-05-26 Thread Tom Gundersen
On Tue, May 26, 2015 at 5:11 PM, Martin Pitt wrote: > Hello Tom, all, > > with 220 I get a severe boot time regression: > > $ systemd-analyze > Startup finished in 30.751s (kernel) + 11.706s (userspace) = 42.458s > > which used to be > > $ systemd-analyze > Startup finished in 703ms (kerne

[systemd-devel] [PATCH 4/6] udevd: move main-loop to sd-event

2015-05-25 Thread Tom Gundersen
--- src/udev/udevd.c | 378 ++- 1 file changed, 177 insertions(+), 201 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index c9b0ed5..8cffd81 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -41,6 +41,8 @@ #include #inc

[systemd-devel] [PATCH 6/6] udevd: event - port spawn_wait() to sd-event

2015-05-25 Thread Tom Gundersen
This allows us to drop the special sigterm handling in spawn_wait() as this will now be passed directly to the worker event loop. We now log failing processe at 'warning' leve, otherwise the behavior is unchanged. --- src/test/test-udev.c| 7 -- src/udev/udev-event.c | 177 +++

[systemd-devel] [PATCH 3/6] udevd: explicitly try to start event queue when it may be possible

2015-05-25 Thread Tom Gundersen
Rather than trying to schedule new events on every main-loop iteration, do it explicitly when processing an event finishes, a worker is killed, a new uevent is received, or the event queue is explicitly restarted. --- src/udev/udevd.c | 13 ++--- 1 file changed, 10 insertions(+), 3 delet

[systemd-devel] [PATCH 5/6] units: udevd - hook up watchdog support

2015-05-25 Thread Tom Gundersen
--- units/systemd-udevd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/units/systemd-udevd.service.in b/units/systemd-udevd.service.in index 32f04d9..e7216d6 100644 --- a/units/systemd-udevd.service.in +++ b/units/systemd-udevd.service.in @@ -23,3 +23,4 @@ RestartSec=0 ExecStart=@

[systemd-devel] [PATCH 2/6] udevd: only check for changed config before scheduling new events

2015-05-25 Thread Tom Gundersen
Also move builtin and rules initialization from main loop to event_queue_start(). No functional change. --- src/udev/udevd.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 91fe3d9..e309def

[systemd-devel] [PATCH 1/6] udevd: introduce manager_exit() and manager_reload()

2015-05-25 Thread Tom Gundersen
The behavior is mostly unchanged, but rather than only ever calling these functions at fixed points in the event loop, they are called directly whenever they are invoked. --- src/udev/udevd.c | 80 +++- 1 file changed, 44 insertions(+), 36 dele

Re: [systemd-devel] [PATCH] swap: use swapon -o

2015-05-25 Thread Tom Gundersen
Applied. Thanks! Tom On Mon, May 25, 2015 at 12:11 PM, Karel Zak wrote: > This patch simplify swapon usage in systemd. The command swapon(8) > since util-linux v2.26 supports "-o ". The idea is exactly the > same like for mount(8). The -o specifies options in fstab-compatible > way. For systemd

Re: [systemd-devel] [PATCH] build-sys: fix headers installation

2015-05-25 Thread Tom Gundersen
Applied. Thanks! Tom On Mon, May 25, 2015 at 1:35 PM, Marc-Antoine Perennou wrote: > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 4933e6f..8e38010 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -3128,7 +3128,7

Re: [systemd-devel] [PATCH 2/2] build-sys: don't dist generated files

2015-05-25 Thread Tom Gundersen
Applied, with minor fix. Please verify that it still works for you! Tom On Mon, May 25, 2015 at 11:18 AM, Marc-Antoine Perennou wrote: > --- > Makefile.am | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 9420879..4933e6f

Re: [systemd-devel] [PATCH 1/2] build-sys: always include src/boot/efi in tarballs

2015-05-25 Thread Tom Gundersen
Applied. Thanks! Tom On Mon, May 25, 2015 at 11:18 AM, Marc-Antoine Perennou wrote: > currently it would only be included if configure was ran with --enable-gnuefi > --- > Makefile.am | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/Makefile.am b/Makefile

Re: [systemd-devel] [PATCH] Correct path to systemd-fsck in generated systemd-fsck-root.service

2015-05-24 Thread Tom Gundersen
On Sun, May 24, 2015 at 10:33 PM, Mike Gilbert wrote: > --- > Makefile.am| 1 + > src/shared/generator.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index f84a28d..70d4dc0 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -1

Re: [systemd-devel] [PATCH] core: if PR_SET_CHILD_SUBREAPER fails, log_error instead of warning

2015-05-24 Thread Tom Gundersen
On Sat, May 23, 2015 at 6:04 PM, Cristian Rodríguez wrote: > It was a warning when we still supported kernel < 3.4. current > minimum version is 3.7. Hm, we don't actually fail out here, but we still try to continue. Isn't 'warning' more appropriate in that case? Cheers, Tom > src/core/main.c

Re: [systemd-devel] [PATCH] nspawn: be verbose about interface names

2015-05-24 Thread Tom Gundersen
On Fri, May 22, 2015 at 4:02 PM, Umut Tezduyar Lindskog wrote: > Allowed interface name is relatively small. Lets not make > users go in to the source code to figure out what happened. > > --machine=debian-tree conflicts with > --machine=debian-tree2 > > ex: Failed to add new veth \ > int

Re: [systemd-devel] udev now crashes in daemon mode

2015-05-24 Thread Tom Gundersen
Hi Mantas, On Sun, May 24, 2015 at 11:40 AM, Mantas Mikulėnas wrote: > So, udev v220 crashes in my initramfs with the following message: > >> starting version v220 >> Assertion 'manager->pid == getpid()' failed at src/udev/udevd.c:568, >> function ev >> Aborting. > > It seems main calls manager

Re: [systemd-devel] [PATCH] Remove accelerometer helper

2015-05-22 Thread Tom Gundersen
On Fri, May 22, 2015 at 3:42 PM, Bastien Nocera wrote: > It's moved to the iio-sensor-proxy D-Bus service. Nice! When was this released? Should we expect all distros to have picked up this yet? > --- > .gitignore | 1 - > Makefile.am| 1

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-21 Thread Tom Gundersen
On Mon, May 18, 2015 at 6:55 PM, Lennart Poettering wrote: > On Fri, 15.05.15 22:49, Tom Gundersen (t...@jklm.no) wrote: > >> On Fri, May 15, 2015 at 10:02 PM, Lennart Poettering >> wrote: >> > On Fri, 15.05.15 12:56, Michael Marineau (michael.marin...@coreos.com) &g

Re: [systemd-devel] networkd: dbus API for networkd reconfiguration at run-time

2015-05-21 Thread Tom Gundersen
On Tue, May 19, 2015 at 10:40 AM, Rauta, Alin wrote: > Hi Lennart, > > Thanks for the answers. > > One more questions. Just a curiosity of mine. > > Currently, a user has to write scripts if he wants to save the run-time > configuration in networkd format or to use a configuration management tool

Re: [systemd-devel] [PATCH] networkd: fix systemd-networkd-wait-online with multiple NICs

2015-05-21 Thread Tom Gundersen
On Wed, May 20, 2015 at 8:05 PM, Michael Marineau wrote: > I haven't retested HEAD yet but up through 219 it would report 'no-carrier > configuring' which seems bogus since it shouldn't be configuring an > interface in such a state "no-carrier configuring" could easily happen as we would enslave

Re: [systemd-devel] [PATCH] Fixed incorrect type for MTU

2015-05-21 Thread Tom Gundersen
On Thu, May 21, 2015 at 12:54 PM, dmoneil2 wrote: > The parser uses size_t for MTU however the structure is defined with unsigned > int > as the target type resulting in a value corruption for the next field of the > structure. > > dmoneil2 (1): > Fixed issue with corruption of speed value whe

Re: [systemd-devel] [PATCH] networkd: fix systemd-networkd-wait-online with multiple NICs

2015-05-20 Thread Tom Gundersen
On Tue, Apr 21, 2015 at 11:59 PM, Nick Owens wrote: > hello tom, > > On Mon, Apr 20, 2015 at 2:32 PM, Tom Gundersen wrote: >> On Fri, Apr 3, 2015 at 12:48 AM, Michael Marineau >> wrote: >>> On Thu, Apr 2, 2015 at 3:08 PM, Nick Owens wrote: >>>&g

Re: [systemd-devel] [ANNOUNCE] Separating gudev from systemd

2015-05-19 Thread Tom Gundersen
On Wed, May 20, 2015 at 8:24 AM, Martin Pitt wrote: > Hey David, > > David Herrmann [2015-05-19 17:06 +0200]: >> We're about to remove gudev from the systemd repository, as it is in >> no way related to the systemd code-base, nor used by the systemd >> project. > > This makes sense indeed. gudev u

Re: [systemd-devel] systemd-networkd and systemd-nspawn: missing host-side network

2015-05-19 Thread Tom Gundersen
On Mon, Apr 27, 2015 at 6:50 AM, Kai Krakow wrote: > I've created a container with systemd-nspawn, "machinectl enable"d it, then > added machines.target to my default target (systemctl enable > machines.target) so that containers will be autostarted on boot. That works > so far. > > But I discover

Re: [systemd-devel] networkd failing sporadically failing to bring up network device

2015-05-19 Thread Tom Gundersen
On Tue, Apr 7, 2015 at 5:46 PM, Richard Maw wrote: > On Sat, Apr 04, 2015 at 12:08:04PM +0100, Sitsofe Wheeler wrote: >> Hi, >> >> I've noticed that networkd occasionally fails to bring up one of two >> network interfaces on boot (this happens about once every 70 or so >> boots). The machine in qu

Re: [systemd-devel] [PATCH 2/2] udev: Allow detection of udevadm settle timeout

2015-05-19 Thread Tom Gundersen
On Sat, May 2, 2015 at 12:21 PM, Nir Soffer wrote: > On Tue, Apr 21, 2015 at 12:41 AM, Tom Gundersen wrote: >> On Mon, Apr 13, 2015 at 3:04 PM, Nir Soffer wrote: >>> On Sat, Apr 11, 2015 at 6:58 PM, David Herrmann >>> wrote: >>>>> A program running th

Re: [systemd-devel] Setting UseDomains=yes by default DHCP

2015-05-19 Thread Tom Gundersen
It seems this thread was already resolved, just wanted to add one comment: On Mon, May 18, 2015 at 2:26 PM, Zbigniew Jędrzejewski-Szmek wrote: > So to mount a successful spoof, the attacker needs to > a) control the dhcp server domain option to return a domain under attacker > control Notice th

Re: [systemd-devel] networkd-218 seems to ignore .link files

2015-05-19 Thread Tom Gundersen
On Tue, May 19, 2015 at 6:57 PM, Jan Engelhardt wrote: > > On Tuesday 2015-05-19 18:38, Tom Gundersen wrote: >>>> > # networkctl status --no-pager eth0 >>>> > ??● 3: eth0 >>>> >Link File: n/a >>>> > Network File:

Re: [systemd-devel] networkd-218 seems to ignore .link files

2015-05-19 Thread Tom Gundersen
On Tue, Apr 21, 2015 at 6:26 PM, Lennart Poettering wrote: > On Tue, 21.04.15 14:47, Tom Gundersen (t...@jklm.no) wrote: > >> > I'm having a similar problem while running systemd version-219. Did you >> > work >> > out what was wrong? >> > &

Re: [systemd-devel] How to set primary slave in active-backup mode (bonding)

2015-05-19 Thread Tom Gundersen
On Thu, Apr 9, 2015 at 4:29 PM, Mikhail Morfikov wrote: > I usually have two network interfaces on my laptops (one eth and one > wlan), and when I was using sysvinit I also was configuring the bond > interface via the /etc/network/interfaces file so the two interfaces > could work in the active-ba

Re: [systemd-devel] unaligned write in dhcp_identifier_set_iaid

2015-05-19 Thread Tom Gundersen
On Tue, Feb 24, 2015 at 7:22 PM, Michael Olbrich wrote: > there is an unaligned write in dhcp_identifier_set_iaid() and I'm not quite > sure what the correct fix is: > > int dhcp_identifier_set_iaid(int ifindex, uint8_t *mac, size_t mac_len, > uint32_t *_id) { > [...] > *_id = (id & 0xfff

Re: [systemd-devel] systemd-nspawn trouble

2015-05-18 Thread Tom Gundersen
On Sun, May 17, 2015 at 5:30 PM, Michael Biebl wrote: > 2015-05-15 22:16 GMT+02:00 Tom Gundersen : >> on-demand I agree with Lennart that it makes the most sense to simply >> unconditionally load the modules. If this is undesirable the solution >> should be to teach the ke

Re: [systemd-devel] [PATCH v2] networkd: do not change kernel forwarding parameters when IPForwarding is unset

2015-05-15 Thread Tom Gundersen
On Fri, May 15, 2015 at 10:02 PM, Lennart Poettering wrote: > On Fri, 15.05.15 12:56, Michael Marineau (michael.marin...@coreos.com) wrote: > >> (build time option to ./configure that is) > > I guess I'd be OK with that... It would be a shame if we started diverging on the defaults I think. Would

Re: [systemd-devel] systemd-nspawn trouble

2015-05-15 Thread Tom Gundersen
On Wed, Apr 22, 2015 at 2:36 PM, Michael Biebl wrote: > 2015-04-22 14:26 GMT+02:00 Lennart Poettering : >> On Wed, 22.04.15 14:22, Michael Biebl (mbi...@gmail.com) wrote: >>> 2015-04-22 14:14 GMT+02:00 Lennart Poettering : >>> > On Wed, 22.04.15 14:09, Michael Biebl (mbi...@gmail.com) wrote: >>> >

Re: [systemd-devel] Will *.network replace resolv.conf? What about "Options single-request"?

2015-05-15 Thread Tom Gundersen
On Mon, May 4, 2015 at 2:57 PM, Christian Brunotte wrote: > systemd.network(5) with Options like "DNS=" and "Domains=" looks like > /etc/resolv.conf will soon be superfluous. In many setups, yes, but we will not aim at bug-for-bug compatibility or anything like that. We are open to adding feature

Re: [systemd-devel] [PATCH 3/3] networkd: add man for vti6 tunnel

2015-04-29 Thread Tom Gundersen
Applied. Thanks! Tom On Wed, Apr 22, 2015 at 10:44 AM, Susant Sahani wrote: > --- > man/systemd.netdev.xml | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/man/systemd.netdev.xml b/man/systemd.netdev.xml > index f413739..3bfd01b 100644 > --- a/man/systemd.netdev.xml

Re: [systemd-devel] [PATCH 2/3] networkd: introduce vti6 tunnel

2015-04-29 Thread Tom Gundersen
Applied. Thanks! Tom On Wed, Apr 22, 2015 at 10:44 AM, Susant Sahani wrote: > This patch add support to create vti6 tunnel > > test: > > vt6.network > [Match] > Name=wlan0 > > [Network] > Tunnel=ip6vti > > vti6.netdev > [NetDev] > Name=ip6vti > Kind=vti6 > > [Tunnel] > Local=2a00:ffde:4567:edde:

Re: [systemd-devel] [PATCH 1/3] networkd: tunnel improve logging

2015-04-29 Thread Tom Gundersen
Applied. Thanks! Tom On Wed, Apr 22, 2015 at 10:44 AM, Susant Sahani wrote: > Replaces a lof ot strerror() usage with log_netdev_error_errno() > --- > src/network/networkd-netdev-tunnel.c | 240 > ++- > 1 file changed, 64 insertions(+), 176 deletions(-) > > diff

Re: [systemd-devel] [PATCH] core: fix event source annotations

2015-04-29 Thread Tom Gundersen
Applied. Thanks! Tom On Wed, Apr 29, 2015 at 8:29 PM, Mantas Mikulėnas wrote: > These looked like a mass-replace gone slightly wrong – two statements > with no { }'s, and no error checking. > --- > src/core/busname.c | 4 +++- > src/core/manager.c | 5 - > src/core/socket.c | 3 ++- > 3 fi

Re: [systemd-devel] udev leaves dangling symlinks

2015-04-23 Thread Tom Gundersen
as a side effect). This was broken by: > > commit 3c0bab4aaf70b2383aa4cbabf6059c48744e8960 > Author: Tom Gundersen > Date: Fri Mar 6 18:22:35 2015 +0100 > > udevd: event - make db loading lazy in REMOVE event handling > > But udev_node_remove() needs the DB to know ab

Re: [systemd-devel] networkd-218 seems to ignore .link files

2015-04-21 Thread Tom Gundersen
On Tue, Apr 14, 2015 at 7:08 PM, Andrew Cooks wrote: > On Tue, Jan 13, 2015 at 6:46 AM, Jan Engelhardt wrote: >> >> >> On Monday 2015-01-12 18:29, Tom Gundersen wrote: >> >> In systemd-218, I have configured the following testcase: >> >> >

Re: [systemd-devel] [PATCH] networkd man: fix man and config name.

2015-04-21 Thread Tom Gundersen
On Tue, Apr 21, 2015 at 1:16 PM, Susant Sahani wrote: > > > On 04/21/2015 04:33 PM, Lennart Poettering wrote: >> >> On Tue, 21.04.15 13:34, Susant Sahani (sus...@redhat.com) wrote: >> >>> Rename bond confs and man as well. >>> --- >>> man/systemd.netdev.xml | 28 >>>

Re: [systemd-devel] [PATCH 2/2] udev: Allow detection of udevadm settle timeout

2015-04-20 Thread Tom Gundersen
On Mon, Apr 13, 2015 at 3:04 PM, Nir Soffer wrote: > On Sat, Apr 11, 2015 at 6:58 PM, David Herrmann wrote: >>> A program running this tool can detect a timeout (expected) or an error >>> (unexpected), and can change the program flow based on this result. >>> >>> Without this, the only way to det

Re: [systemd-devel] [PATCH] networkd: fix systemd-networkd-wait-online with multiple NICs

2015-04-20 Thread Tom Gundersen
On Fri, Apr 3, 2015 at 12:48 AM, Michael Marineau wrote: > On Thu, Apr 2, 2015 at 3:08 PM, Nick Owens wrote: >> hi, sorry for the delay. >> >> from >> http://www.freedesktop.org/software/systemd/man/systemd-networkd-wait-online.service.html: >> >> "By default, it will wait for all links it is aw

Re: [systemd-devel] [PATCH] networkd: fix systemd-networkd-wait-online with multiple NICs

2015-04-20 Thread Tom Gundersen
On Wed, Mar 25, 2015 at 9:49 PM, wrote: > From: mischief > > when checking interface status, systemd-networkd-wait-online > will continue to wait if any interface is still configuring or > being processed by udev. this patch allows it to return if any > one interface is degraded/routable, as per

Re: [systemd-devel] [PATCH] networkd: Add support for bond option.

2015-04-20 Thread Tom Gundersen
Sorry for the delay. Applied. Thanks! Tom On Mon, Mar 9, 2015 at 10:58 AM, Susant Sahani wrote: > This patch adds configurational support for bond option. > > Test conf: > > bond.netdev > > --- > [NetDev] > Name=bond1 > Kind=bond > > [Bond] > ArpAllTargets=all > PrimaryReselect=better > ArpInter

Re: [systemd-devel] [PATCH] networkd vxlan: Add support for enabling UDP checksums

2015-04-20 Thread Tom Gundersen
Sorry for the delay. Applied. Thanks! Tom On Thu, Mar 5, 2015 at 5:32 PM, Susant Sahani wrote: > Add UDPCheckSum option to enable transmitting UDP checksums when doing > VXLAN/IPv4. Add UDP6ZeroChecksumRx, and UDP6ZeroChecksumTx > options to enable sending zero checksums and receiving zero > che

Re: [systemd-devel] udev interface naming for SR-IOV VFs

2015-04-20 Thread Tom Gundersen
On Tue, Apr 14, 2015 at 12:11 PM, Ido Barkan wrote: > We are implementing support for SR-IOV network cards. Afer the changing of > the number of VFs on the card and programmatically querying for all links > (we use libnl for this) we observe that *during the iteration* over the links > some of the

Re: [systemd-devel] SD_BUS_VTABLE_CAPABILITY

2015-04-16 Thread Tom Gundersen
On Thu, Apr 16, 2015 at 5:57 PM, Andy Lutomirski wrote: >> We have several uses of this, see my mail to Jiri regarding >> CAP_SYS_BOOT for instance: >> https://lkml.org/lkml/2015/4/16/219 > > I read that, but I disagree with you. > > CAP_SYS_BOOT is the privilege to directly hard-reboot the syst

Re: [systemd-devel] SD_BUS_VTABLE_CAPABILITY

2015-04-16 Thread Tom Gundersen
On Thu, Apr 16, 2015 at 4:52 PM, Andy Lutomirski wrote: > Unshare your user namespace, set things up right, and systemd > or any other server will see you as having all capabilities. You've > fixed that in kdbus, but you haven't (and probably can't!) fix it in > the legacy code, and that legacy c

Re: [systemd-devel] SD_BUS_VTABLE_CAPABILITY

2015-04-16 Thread Tom Gundersen
Hi Andy, On Thu, Apr 16, 2015 at 2:55 AM, Andy Lutomirski wrote: > Yesterday, I discovered SD_BUS_VTABLE_CAPABILITY. Are there any > examples in which it does anything? Please note that you need to be using kdbus to get any capabilities transported, so in dbus1 this does nothing (as on dbus1 us

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd

2015-04-14 Thread Tom Gundersen
On Tue, Apr 14, 2015 at 4:21 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Apr 14, 2015 at 07:19:42AM -0700, Tom Gundersen wrote: >> src/libsystemd/sd-device/sd-device.c |9 ++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >

Re: [systemd-devel] [RFC 1/6] proxy-discoveryd: Basic core added

2015-04-13 Thread Tom Gundersen
On Mon, Apr 13, 2015 at 12:05 PM, Tomasz Bursztyka wrote: >>> +int manager_new(Manager **ret); >>> +Manager *manager_free(Manager *m); >>> + >>> +DEFINE_TRIVIAL_CLEANUP_FUNC(Manager*, manager_free); >>> +#define _cleanup_manager_free_ _cleanup_(manager_freep) >> >> We generally try to avoid this d

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd

2015-04-05 Thread Tom Gundersen
On Sun, Apr 5, 2015 at 11:50 AM, Lennart Poettering wrote: > On Fri, 03.04.15 13:23, Tom Gundersen (tome...@kemper.freedesktop.org) wrote: > >> >> -tags = strdupa(value); >> +FOREACH_WORD_SEPARATOR(word, l, value, ":", state) { >

Re: [systemd-devel] networkd: Is auto-negotiation turned off when specifying parameters in a link file?

2015-04-03 Thread Tom Gundersen
On Fri, Apr 3, 2015 at 4:47 PM, Lennart Poettering wrote: > On Thu, 02.04.15 13:11, Paul Menzel (paulepan...@users.sourceforge.net) wrote: > >> Dear systemd folks, >> >> >> some network cards with certain cables and devices take up to five >> seconds so that the link is up [1]. >> >> $ sud

Re: [systemd-devel] systemd from git doesn't boot properly in fedora rawhide

2015-04-03 Thread Tom Gundersen
On Fri, Apr 3, 2015 at 11:14 AM, Jan Synáček wrote: > From the following commit onward, systemd doesn't boot properly in > Rawhide. Some device units time out and I'm then dropped into an > emergency shell. > > commit f4ac4d1a82e2c468761fffa333323841ad886221 > Author:

Re: [systemd-devel] [RFC][PATCH 1/2] libsystemd: add sd-device library

2015-04-01 Thread Tom Gundersen
After discussing this with Kay, I went ahead and pushed this. Feedback still welcome of course. Cheers, Tom On Wed, Apr 1, 2015 at 3:00 PM, Tom Gundersen wrote: > This provides equivalent functionality to libudev-device, but in the > systemd style. The public API only caters to cr

Re: [systemd-devel] [RFC][PATCH] udev: net_id - support multi-function, multi-port enpo* device names

2015-04-01 Thread Tom Gundersen
I pushed a version of this only handling the multi-port devices. We can deal with multi-function if and when they appear in the wild. -t On Wed, Apr 1, 2015 at 4:52 PM, Tom Gundersen wrote: > I'd argue that having firmware labels for such devices makes no sense, but > they exist, s

[systemd-devel] [RFC][PATCH] udev: net_id - support multi-function, multi-port enpo* device names

2015-04-01 Thread Tom Gundersen
I'd argue that having firmware labels for such devices makes no sense, but they exist, so make sure we handle them as best as we can. --- src/udev/udev-builtin-net_id.c | 64 -- 1 file changed, 43 insertions(+), 21 deletions(-) diff --git a/src/udev/udev-b

[systemd-devel] [RFC][PATCH 2/2] libudev: device - replace by a thin wrapper around sd-device

2015-04-01 Thread Tom Gundersen
@@ +/*** + This file is part of systemd. + + Copyright 2008-2012 Kay Sievers + Copyright 2015 Tom Gundersen + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation

[systemd-devel] [RFC][PATCH 1/2] libsystemd: add sd-device library

2015-04-01 Thread Tom Gundersen
new file mode 100644 index 000..59ec1a6 --- /dev/null +++ b/src/libsystemd/sd-device/device-internal.h @@ -0,0 +1,125 @@ +/*** + This file is part of systemd. + + Copyright 2008-2012 Kay Sievers + Copyright 2014 Tom Gundersen + + systemd is free software; you can redistribute it and/or

Re: [systemd-devel] [PATCH] nspawn: fallback on bind mount when mknod fails

2015-03-29 Thread Tom Gundersen
On Mar 29, 2015 5:18 PM, "Alban Crequy" wrote: > > From: Alban Crequy > > Some systems abusively restrict mknod, even when the device node already > exists in /dev. This is unfortunate because it prevents systemd-nspawn > from creating the basic devices in /dev in the container. > > This patch im

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-27 Thread Tom Gundersen
On Fri, Mar 27, 2015 at 2:04 PM, Djalal Harouni wrote: > Hi Shawn, > > On Thu, Mar 26, 2015 at 11:21:54PM -0700, Shawn Landden wrote: >> On Thu, Mar 26, 2015 at 5:47 PM, Djalal Harouni wrote: >> > On Fri, Mar 27, 2015 at 12:30:53AM +0100, Tom Gundersen wrote: >> &

Re: [systemd-devel] Providing DNS for DHCPServer configuration

2015-03-27 Thread Tom Gundersen
Hi Ash, We do want some functionality like this. However, I don't think we should simply default to assuming the DHCP server is also a DNS server. The way it should work is to pass to the client all the (non restricted, i.e., where Domains= is not set, or includes the wildcard) DNS servers configu

  1   2   3   4   5   6   7   8   9   10   >