Re: [systemd-devel] [PATCH 4/4] systemctl: unit_find_paths(): unify error handling in two code pathes

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
"two code paths". 1/4 and 4/4 are fine, but I think it's better to have them applied adjacent to the remaing two, so I leave them for now too. Zbyszek On Fri, Dec 19, 2014 at 05:08:10PM +0300, Ivan Shapovalov wrote: > --- > src/systemctl/systemctl.c | 63 > ++---

Re: [systemd-devel] [PATCH 1/4] path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 05:08:07PM +0300, Ivan Shapovalov wrote: > --- > src/shared/install.c | 16 > src/shared/path-lookup.c | 16 > src/shared/path-lookup.h | 4 > src/systemctl/systemctl.c | 6 +- > 4 files changed, 21 insertions(+), 21 delet

Re: [systemd-devel] [PATCH] machine: add reference to machine-dbus.h to Makefile.am

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 02, 2015 at 09:45:23AM -0800, Filipe Brandenburger wrote: > On Mon, Dec 29, 2014 at 3:22 PM, Filipe Brandenburger > wrote: > > Commit 003dffde2c1b93 ("machined: Move image discovery logic into > > src/shared, > > so that we can make use of it from nspawn") moved some definitions from

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 03:25:33PM +0100, Igor Bukanov wrote: > On 5 January 2015 at 15:08, Daniel J Walsh wrote: > > chcon -t bin_t /usr/bin/rsync, should stop SELinux from interfering, or > > set the rsync_client boolean. > > > > http://danwalsh.livejournal.com/61646.html > > Yes, that solved t

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 02:55:11PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > SO_PEERCRED apparently returns the euid/egid of the original > > process. The UNIX "saved" uid was invented precisely to allow > > temporarily lowering the euid and later on returning to

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 12:01:35AM +0100, Michael Biebl wrote: > Hi, > > > 2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > > On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: > >> +link = strjoin(arg_dest, "/",

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 03:28:09AM +0100, Lennart Poettering wrote: > On Mon, 05.01.15 16:03, Lennart Poettering (lenn...@poettering.net) wrote: > > > On Mon, 05.01.15 15:02, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > > What we can

Re: [systemd-devel] [PATCH] Clarify path escaping and reference systemd-escape

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 04:35:34PM -0500, Chris Atkinson wrote: > See Bug 87688 (https://bugs.freedesktop.org/show_bug.cgi?id=87688). > This patch adds more detail to the description of how path escaping > operates and provides a pointer to the systemd-escape program. Either > would serve to answer

Re: [systemd-devel] Relative links in tmpfiles.d/etc.conf

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 03, 2015 at 12:07:59PM +0100, Umut Tezduyar Lindskog wrote: > Hi, > > Our /etc is a sym link and due to that all the links created by > tmpfiles.d/etc.conf are wrong. Is there a reason why the links are > relative? They are relative so that if you're looking into a container (or a syst

Re: [systemd-devel] systemd console messages (crippled)

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 02:51:50PM +0300, Nikolai Zhubr wrote: > Hi people, > > I'm now fighting with opensuse 13.2 failing to mount some or all > disks at boot, obviously resulting in unusable system. This > distribution is systemd-based, hence I'm here. While I haven't yet > exactly understood m

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 11:15:47PM +0100, Jouke Witteveen wrote: > On Thu, Jan 1, 2015 at 7:15 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: > >> --- > >> > >> This fixes #87251 > > &g

Re: [systemd-devel] [PATCH v2] bootchart: ship a configuration that will boot without sysvinit compat

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 28, 2014 at 07:18:16PM +0100, Gabriel de Perthuis wrote: > Change the default through /etc/systemd/bootchart.conf. > Keep the /sbin/init default in the source code, in case > some users rely on that. No, as a rule, all files in /etc installed by systemd can only contain comments. Boot-w

Re: [systemd-devel] [PATCH] gitignore: add another test

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
Already fixed by Lennart. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] sysv-generator: avoid wrong orderings for failing units

2015-01-07 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 07, 2015 at 01:44:17PM +0100, Michael Biebl wrote: > sysv-generator: initialize units before use to ensure correct > ordering > > The original loop called fix_order() on each service immediately after > loading it, but fix_order() would reference other units which were not > loaded ye

Re: [systemd-devel] [PATCH] Add usernames as arguments to tmpfiles ignore directives.

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 08, 2015 at 01:37:57PM +0100, Thomas Blume wrote: > Currently, systemd can only ignore files specified by their path, during > tmpdir cleanup. This patch adds the feature to give usernames as argument. > > During cleanup the file ownership is checked and files that match the > specifi

Re: [systemd-devel] [PATCH 1/2] test-verbs: add unit tests for verbs minilib

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 20, 2014 at 03:31:21PM -0800, Filipe Brandenburger wrote: > Hi, > > On Sat, Dec 20, 2014 at 8:19 AM, Dave Reisner wrote: > > --- > > Makefile.am | 9 +- > > src/test/test-verbs.c | 78 > > +++ > > 2 files changed, 86 ins

Re: [systemd-devel] [PATCH] man (5) machine-info: add hostnamed chassis type "embedded"

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 20, 2014 at 03:09:19PM +0100, Peter Mattern wrote: > man machine-info lacks hostnamed chassis type "embedded" as introduced in > 218. The following lines should fix this. > > --- > man/machine-info.xml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man/ma

Re: [systemd-devel] Fw: [PATCH] systemd-nspawn bash autocompletion

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
Applied. On Thu, Jan 08, 2015 at 09:51:49PM +0100, Carlos Morata Castillo wrote: > -complete -F _systemd_nspawn systemd-nspawn > +complete -F _systemd_nspawn systemd_nspawn This looks like a typo. I skipped that part. Zbyszek ___ systemd-devel mailing

Re: [systemd-devel] [PATCH udev v5] udev: Add builtin/rule to export evdev information as udev properties

2015-01-11 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 11, 2015 at 08:47:19PM +0100, Carlos Garnacho wrote: > This rule is only run on tablet/touchscreen devices, and extracts their size > in millimeters, as it can be found out through their struct input_absinfo. > > The first usecase is exporting device size from tablets/touchscreens. Thi

Re: [systemd-devel] [systemd-commits] src/core

2015-01-12 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 12, 2015 at 05:03:51AM -0800, Daniel Mack wrote: > src/core/mount.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > New commits: > commit 0c47569ac9eb365ebeb9342f47fb98d52bcc4704 > Author: Daniel Mack > Date: Mon Jan 12 13:46:39 2015 +0100 > > core/mount: use is

Re: [systemd-devel] [PATCH] Add usernames as arguments to tmpfiles ignore directives.

2015-01-12 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 12, 2015 at 03:11:08PM +0100, Thomas Blume wrote: > On Donnerstag 2015-01-08 21:29, Zbigniew Jędrzejewski-Szmek wrote: > > >On Thu, Jan 08, 2015 at 01:37:57PM +0100, Thomas Blume wrote: > >>Currently, systemd can only ignore files specified by their path, duri

Re: [systemd-devel] Wierd Segfault in sd_rtnl_message_unref (libnss_myhostname.so.2 by sshd )

2015-01-12 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 12, 2015 at 10:08:30PM +0100, Svenne Krap wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hi. > > On Arch X64 using 218-1 (first packaging of 218) I have run into the > following wierd problem. > > When trying to connect to a ssh server running dualstack (both ipv4

Re: [systemd-devel] [PATCH 02/11] sd-dhcp6-lease: Revise address iteration functions

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:12PM +0200, Patrik Flykt wrote: > Revise the address iteration functions so that one helper function > resets the iterator to the start of the address list while the > second one fetches addresses one by one. > > The test case is also updated. > --- > src/libsystemd-

Re: [systemd-devel] [PATCH 03/11] sd-icmp6-nd: Update Router Advertisement handling

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:13PM +0200, Patrik Flykt wrote: > As the IPv6 prefixes are needed, update the ICMPv6 Router Advertisement > code to dynamically allocate a suitably sized buffer. Iterate through > the ICMPv6 options one by one returning error if the option length is > too big to fit th

Re: [systemd-devel] [PATCH 05/11] sd-icmp6-nd: Add helper function to get the IPv6 link MTU

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:15PM +0200, Patrik Flykt wrote: > Update MTU according to the latest value received. > --- > src/libsystemd-network/sd-icmp6-nd.c | 30 ++ > src/systemd/sd-icmp6-nd.h| 2 ++ > 2 files changed, 32 insertions(+) > > diff --git a

Re: [systemd-devel] [PATCH 06/11] test-icmp6-rs: Add trivial test case for a MTU that is not present

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:16PM +0200, Patrik Flykt wrote: > --- > src/libsystemd-network/test-icmp6-rs.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/src/libsystemd-network/test-icmp6-rs.c > b/src/libsystemd-network/test-icmp6-rs.c > index be64d33.

Re: [systemd-devel] [PATCH 07/11] sd-icmp6-nd: Parse ICMPv6 prefix information

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:17PM +0200, Patrik Flykt wrote: > Save each new onlink IPv6 prefix and attach an expiry timer to it. > If the prefixes overlap, take the shorter prefix and write a debug > message about the event. Once the prefix is resent in a Router > Advertisement, update the timer.

Re: [systemd-devel] [PATCH 10/11] networkd-dhcp6: Assign DHCPv6 addresses and prefix lengths

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:20PM +0200, Patrik Flykt wrote: > Once IPv6 addresses have been acquired, assign these to the interface > with the prefix lengths taken from the ICMPv6 Router Advertisement > handling code. The preferred and valid IPv6 address lifetimes are > handed to the kernel which

Re: [systemd-devel] [PATCH 11/11] sd_dhcp6_lease: Support DNS and NTP options

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:21PM +0200, Patrik Flykt wrote: > Store arrays of found DNS and NTP IPv6 addresses and strings of DNS > search domains and NTP host names as specified in RFC 3646 and RFC > 5908. > --- > src/libsystemd-network/dhcp6-internal.h | 3 + > src/libsystemd-network/d

Re: [systemd-devel] [PATCH 00/11] DHCPv6 address assignment

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:10PM +0200, Patrik Flykt wrote: > > Hi, > > Here is a patch set covering on-link prefix detection and using the prefix > length information when setting DHCPv6 addresses. > > To be able to have a correct prefix for the IPv6 adresses, the prefixes > need to be

Re: [systemd-devel] [PATCH] TODO: DHCPv6 Information Request has been implemented

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 03:10:35PM +0200, Patrik Flykt wrote: > On Tue, 2015-01-13 at 14:32 +0200, Patrik Flykt wrote: > > Just a trivial TODO update, I'll push it right away. > > Patch applied. > > Patrik Yeah, there's no need to sent this to the mailing list. It is unlikely to be wrong, a

Re: [systemd-devel] make install busted in git

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 03:16:52PM +0100, Jan Engelhardt wrote: > > On Tuesday 2015-01-13 15:07, Mike Gilbert wrote: > >> > >> /usr/bin/xsltproc -o man/bootup.7 --nonet --xinclude --stringparam > >> man.output.quietly 1 --stringparam funcsynopsis.style ansi > >> --stringparam man.authors.section

Re: [systemd-devel] [PATCH 1/2] machinectl: use GNU basename, not the XPG version

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 11, 2015 at 02:50:15PM -0300, Cristian Rodríguez wrote: > --- > src/machine/machinectl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c > index 749170e..980fba1 100644 > --- a/src/machine/machinectl.c > +++

Re: [systemd-devel] [RFC] hwdb: add MOUSE_WHEEL_CLICK_ANGLE as property

2015-01-14 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 14, 2015 at 03:57:03PM +1000, Peter Hutterer wrote: > On Mon, Jan 12, 2015 at 09:48:55AM +1000, Peter Hutterer wrote: > > Most mice have a wheel click angle of 15 degrees, i.e. 24 clicks per full > > wheel rotation. Some mice, like the Logitech M325 have a larger angle. To > > allow use

Re: [systemd-devel] Should a unit be able to start, while its OnFailure unit is active?

2015-01-14 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 14, 2015 at 04:24:15PM +0100, jean-pierre.bog...@continental-corporation.com wrote: > Hi all, > > I'd like to have your opinion on the following problem: > > In case a unit fails, we are using an OnFailure unit to > handle the error (e. g. reset the config of the failed > unit) an

Re: [systemd-devel] [RFC] hwdb: add MOUSE_WHEEL_CLICK_ANGLE as property

2015-01-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 15, 2015 at 07:21:31AM +1000, Peter Hutterer wrote: > On Wed, Jan 14, 2015 at 01:07:40PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Wed, Jan 14, 2015 at 03:57:03PM +1000, Peter Hutterer wrote: > > > On Mon, Jan 12, 2015 at 09:48:55AM +1000, Peter Hutterer wrote:

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 15, 2015 at 02:31:22PM +0100, Reindl Harald wrote: > > Am 15.01.2015 um 14:40 schrieb Nikolai Zhubr: > >15.01.2015 16:07, Cristian Rodríguez: > >>The readahead collector is no longer included in systemd. > > > >Hm. It is still there in not-very-old opensuse 13.2 ... > >Anyway. Where ha

Re: [systemd-devel] Making udev emit a signal when it is done loading modules

2015-01-17 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 17, 2015 at 09:44:00AM +0100, Hans de Goede wrote: > We would like > udev to emit a signal (ABI to be discussed) when it is done > trying to load modules for everything which was already enumerated > when it starts, iow when there are no new device events pending > anymore when udev doe

[systemd-devel] [PATCH 03/11] tmpfiles: make sure not to concatenate non-absolute path

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
If the path is absolute was only checked later. Also do not check if path if absolute if we just specified it starting with a slash. --- src/tmpfiles/tmpfiles.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 8811f

[systemd-devel] [PATCH 01/11] tmpfiles: simplification

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
Certain conditions were checked more than once. Warning message is improved. --- This is a sprawling set of changes to add ACL support to tmpfiles. The patches are not entirely clean, you can see how my understanding of the problem evolved :) Comments, suggestions for improved syntax, etc., very m

[systemd-devel] [PATCH 02/11] tmpfiles: detect all combinations of + and !

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
The same algorithm as with - and @ in ExecStart= is used. --- src/tmpfiles/tmpfiles.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 91ae62da45..8811f27482 100644 --- a/src/tmpfiles/tmpfil

[systemd-devel] [PATCH 04/11] tmpfiles: attach an array of items to each path

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
Zbigniew Jędrzejewski-Szmek systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by @@ -113,6 +114,12 @@ typedef struct Item { bool done:1; } Item; +typedef struct ItemArray { +Item *items; +

[systemd-devel] [PATCH 06/11] tmpfiles: make recursive operation generic

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
--- src/tmpfiles/tmpfiles.c | 52 ++--- 1 file changed, 19 insertions(+), 33 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 7081b4dc57..d563989790 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -

[systemd-devel] [PATCH 05/11] tmpfiles: add 'a' type to set ACLs

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
--- Makefile.am | 5 +++ man/tmpfiles.d.xml| 32 - src/journal/coredump.c| 6 +--- src/journal/journalctl.c | 6 +--- src/journal/journald-server.c | 5 --- src/login/logind-acl.c| 2 -- src/shared/acl-util.c | 66

[systemd-devel] [PATCH 11/11] TODO: tmpfiles

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
--- TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/TODO b/TODO index d443209414..4d0fb06dbf 100644 --- a/TODO +++ b/TODO @@ -682,6 +682,8 @@ Features: * tmpfiles: - apply "x" on "D" too (see patch from William Douglas) + - replace F with f+. + - instead of ignoring unknown fiel

[systemd-devel] [PATCH 10/11] shared/acl-util: add mask only when needed, always add base ACLs

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
For ACLs to be valid, a set of entries for user, group, and other must be always present. Always add those entries. While at it, only add the mask ACL if it is actually required, i.e. when at least on ACL for non-owner group or user exists. --- man/tmpfiles.d.xml | 20 +- src/shared

[systemd-devel] [PATCH 07/11] tmpfiles: make t and a globby, add their recursive versions T and A

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
For types which adapt existing files it is generally more useful to accept globs. In analogy to z and Z, add recursive versions using uppercase letters. Technically, making a accept globs is backwards incompatible, but in practice it probably isn't yet widely used and we can assume that most peop

[systemd-devel] [PATCH 08/11] tmpfiles: implement augmenting of existing ACLs

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
This is much more useful in practice (equivalent to setfacl -m). --- man/tmpfiles.d.xml | 28 +++-- src/shared/acl-util.c | 49 +--- src/shared/acl-util.h | 3 ++- src/tmpfiles/tmpfiles.c | 54 ---

[systemd-devel] [PATCH 09/11] tmpfiles: use ACL magic on journal directories

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
--- README | 11 +++ configure.ac | 1 + tmpfiles.d/systemd.conf.m4 | 8 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/README b/README index fa95433ecb..c72209262e 100644 --- a/README +++ b/README @@ -178,14 +178,9 @@ USERS AND

Re: [systemd-devel] [PATCH 05/11] tmpfiles: add 'a' type to set ACLs

2015-01-19 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 19, 2015 at 12:07:16PM -0500, Chris Atkinson wrote: > s/aditional/additional/ Thanks. It is fixed by one of the later patches fortunately. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org

Re: [systemd-devel] [PATCH] initial sysv-generator test suite

2015-01-20 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 20, 2015 at 04:19:24PM +0100, Martin Pitt wrote: > Hello all, > > We've had numerous problems with the SysV generator in the past, and > we just recently introduced another regression: init.d scripts which > end in ".sh" are now totally broken. > > Thus I think it's high time to write

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 11:08:44AM +0100, Martin Pitt wrote: > So I expect if it gets dropped upstream, a lot of distros (and all the > major ones) will have to bring that back; it's IMHO better to just > maintain it upstream by the distro maintainers. Exactly. Dropping it would be just busy work f

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 10:46:03AM +0100, Martin Pitt wrote: > Keeping track of which alias symlinks we actually want is error prone, and > restricting the creation of services for enabled init.d scripts would reduce > the utility of the generator (for manual starting disabled init.d scripts) as >

Re: [systemd-devel] systemd-vconsole-setup fails very slowly

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 07:15:12PM -0800, Andy Lutomirski wrote: > Hi all- > > When running virtme (a simple vm gadget) on Fedora 21, the slowest > part of bootup by far appears to be systemd-vconsole-setup: > > # time /usr/lib/systemd/systemd-vconsole-setup > putfont: PIO_FONT trying ... > .

Re: [systemd-devel] [PATCH] build: export symbols to integrate mainloops

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 21, 2015 at 10:59:45PM -0200, Lucas De Marchi wrote: > --- > src/libsystemd/libsystemd.sym.m4 | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/libsystemd/libsystemd.sym.m4 > b/src/libsystemd/libsystemd.sym.m4 > index 19a49f4..41418b9 100644 > --- a/src/libsystemd/libsy

Re: [systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

2015-01-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 14, 2015 at 02:51:41AM -0300, Cristian Rodríguez wrote: > Otherwise, if the directory contains other directories we fail > at fopen in load_sysv() with EISDIR. > --- > src/sysv-generator/sysv-generator.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sr

Re: [systemd-devel] Unwants

2015-01-22 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 22, 2015 at 01:54:37PM +, Dimitri John Ledkov wrote: > Is there a way to remove / override wants that are specified via > .wants directory, .d snippet with "Wants=", or wants specified in the > unit itself? > > I thought that creating a symlink to /dev/null from a higher up > direc

Re: [systemd-devel] systemd-sysv-generator *.service: File exists

2015-01-22 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 22, 2015 at 10:05:48PM +0100, poma wrote: > > Buena noches, > > Maybe someone knows how to get rid of these messages? Does systemd-216-17.fc21.x86_64 help? Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://l

Re: [systemd-devel] systemd-sysv-generator *.service: File exists

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 11:53:03AM +0100, Martin Pitt wrote: > poma [2015-01-23 11:38 +0100]: > > I should have checked before, nx*3.5 files that was causing this noise is > > the backup leftover from nx4 testing. > > Removing these two files, there is no need to upgrade. > > This almost certainl

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 03:12:11PM +0100, Lennart Poettering wrote: > On Fri, 23.01.15 14:57, Christian Seiler (christ...@iwakd.de) wrote: > > > Am 2015-01-23 14:27, schrieb Lennart Poettering: > > >>Yes, it does, although only in the general systemd.unit(5), not in the > > >>specific options, so

Re: [systemd-devel] [PATCH] systemctl: bugfix for systemctl reboot command with argument

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 08:21:57PM +0900, Sangjung Woo wrote: > According to systemctl man page, 'systemctl reboot [arg]' should work > without any errors. However, it does not work because of 'Invalid number > of arguments' error, except for 'reboot [arg]'. This patch fixes the bug > so that both

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 05:29:46PM +, Topi Miettinen wrote: > On 01/23/15 03:06, Lennart Poettering wrote: > > On Sun, 18.01.15 23:57, Topi Miettinen (toiwo...@gmail.com) wrote: > > > >> Don't use recvmsg(2) return value to check for too long packets > >> (it doesn't work) but MSG_TRUNC flag.

Re: [systemd-devel] Examples in man pages (was: Re: service.d/.conf files and multi-valued options)

2015-01-24 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 24, 2015 at 02:13:00PM +0100, Christian Seiler wrote: > Am 23.01.2015 um 15:20 schrieb Zbigniew Jędrzejewski-Szmek: > > I think it would be great to have an Examples section in > > systemd.{unit, service,socket,path,...} giving a semi-realistic > > example of a u

Re: [systemd-devel] [PATCH] po: update Russian translation

2015-01-24 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 09:04:31PM +0300, Sergey Ptashnick wrote: > Add strings for importd. > From 64baca737227adef94b9b02000ce018777b1c989 Mon Sep 17 00:00:00 2001 > From: Sergey Ptashnick <0comff...@inbox.ru> > Date: Fri, 23 Jan 2015 20:56:36 +0300 > Subject: [PATCH] po: update Russian translat

Re: [systemd-devel] [PATCH] libudev-monitor: ensure proper string termination

2015-01-24 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 24, 2015 at 10:39:56AM +0200, Topi Miettinen wrote: > Leave space for the terminating zero when reading and make sure > that the last byte is zero. This also makes the check for long packets > equivalent to code before 9c89c1ca: reject also packets with size 8192. > --- > src/libudev/l

Re: [systemd-devel] [PATCH] build-sys: use -fno-semantic-interposition if available

2015-01-25 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 25, 2015 at 06:46:12PM -0300, Cristian Rodríguez wrote: > GCC5 introduces -fno-semantic-interposition allowing > better code generation in shared libraries at the cost > of making interposition of exported symbols impossible > (i.e, a 3rd party shared library overriding sd_notify() will

[systemd-devel] [PATCH] system-update-generator: accept a dangling symlink

2015-01-25 Thread Zbigniew Jędrzejewski-Szmek
The offline update mechanism is explicitly designed to work with a separate /var. systemd-update-generator is supposed to run early, before filesystems are mounted, so it cannot check if the /system-update symlink actually points to anything. The update is run *after* filesystems are mounted, so i

Re: [systemd-devel] BUG: several bugs in core/main.c (v218)

2015-01-25 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 25, 2015 at 03:37:09AM +0100, Tomasz Pawlak wrote: > core/main.c:1519 > /* Make sure we leave a core dump without panicing the >* kernel. */ > if (getpid() == 1) { > install_crash_handler(); > > r = mount_cgroup_controllers(arg_join_contr

Re: [systemd-devel] [PATCH] treewide: fix multiple typos

2015-01-26 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 26, 2015 at 03:29:14PM +0100, Torstein Husebø wrote: > --- > NEWS | 8 > TODO | 2 +- > man/crypttab.xml | 2 +- > man/networkctl.xml| 2 +- > man/sd_event_add_child.xml

Re: [systemd-devel] Unwants

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 01:36:41PM +0100, Lennart Poettering wrote: > On Thu, 22.01.15 13:54, Dimitri John Ledkov (dimitri.j.led...@intel.com) > wrote: > > > Is there a way to remove / override wants that are specified via > > .wants directory, .d snippet with "Wants=", or wants specified in the

Re: [systemd-devel] Examples in man pages

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 03:19:51PM +0100, Christian Seiler wrote: > Just a heads-up: while reading the "Unwants" thread I noticed that > dependencies are the only types of lists in unit files that can't be > reset, so my example in there actually doesn't work, so please don't > commit my patch just

Re: [systemd-devel] Unwants

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 03:50:49PM +, Dimitri John Ledkov wrote: > On 27 January 2015 at 15:18, Christian Seiler wrote: > > Am 27.01.2015 um 15:45 schrieb Zbigniew Jędrzejewski-Szmek: > >> On Tue, Jan 27, 2015 at 01:36:41PM +0100, Lennart Poettering wrote: > >&g

Re: [systemd-devel] [systemd-commits] 5 commits - TODO configure.ac man/systemd.link.xml units/container-ge...@.service.m4.in units/systemd-resolved.service.in

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 09:30:16AM -0800, Lennart Poettering wrote: > TODO |6 +- > configure.ac |8 +--- > man/systemd.link.xml | 16 +++- > units/container-ge...@.service.m4.in |4 ++-- > un

Re: [systemd-devel] Unwants

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 10:30:48PM +0100, Lennart Poettering wrote: > On Tue, 27.01.15 15:45, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > Yes, I think attempting any kind of dependency removal *from loaded > > units* would be very complicated, and would requir

Re: [systemd-devel] [systemd-commits] src/journal

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 01:53:17AM +0100, Lennart Poettering wrote: > On Mon, 19.01.15 10:43, Zbigniew Jędrzejewski-Szmek > (zbys...@kemper.freedesktop.org) wrote: > > > src/journal/journalctl.c | 28 ++-- > > 1 file changed, 14 insert

Re: [systemd-devel] [PATCH 04/11] tmpfiles: attach an array of items to each path

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:59:24AM +0100, Lennart Poettering wrote: > On Mon, 19.01.15 01:20, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > The data structure used by tmpfiles is changed: instead of hashmaps > > mapping {path → Item*} we now have hashmaps co

Re: [systemd-devel] [systemd-commits] src/journal

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 03:50:42AM +0100, Lennart Poettering wrote: > On Wed, 28.01.15 03:47, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Wed, Jan 28, 2015 at 01:53:17AM +0100, Lennart Poettering wrote: > > > On Mon, 19.01.15 10:43, Zbigniew Jędrzejews

Re: [systemd-devel] Swap gets activated twice (through fstab and gpt generators)

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 26, 2015 at 10:08:02AM +0100, Martin Pitt wrote: > Peter Mattern [2015-01-23 14:03 +0100]: > > According to man > > (http://www.freedesktop.org/software/systemd/man/systemd-gpt-auto-generator.html, > > see section "Description") systemd-gpt-auto-generator is supposed to behave > > like

Re: [systemd-devel] Swap gets activated twice (through fstab and gpt generators)

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 05:47:07PM -0700, Chris Murphy wrote: > On Tue, Jan 27, 2015 at 5:28 PM, "Jóhann B. Guðmundsson" > wrote: > > > > On 01/28/2015 12:24 AM, Lennart Poettering wrote: > >> > >> On Tue, 27.01.15 17:17, Chris Murphy (li...@colorremedies.com) wrote: > >> > > >The problem is

Re: [systemd-devel] Swap gets activated twice (through fstab and gpt generators)

2015-01-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 10:25:32PM -0700, Chris Murphy wrote: > On Tue, Jan 27, 2015 at 8:19 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > You also need swap if you want to use all of your memory. If you have > > no swap, allocating close to 100% RAM becomes very dangerou

Re: [systemd-devel] [systemd-commits] src/journal

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 01:11:55PM +0100, Lennart Poettering wrote: > On Wed, 28.01.15 04:04, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Wed, Jan 28, 2015 at 03:50:42AM +0100, Lennart Poettering wrote: > > > On Wed, 28.01.15 03:47, Zbigniew Jęd

Re: [systemd-devel] [PATCH] sysv-generator: Replace Provides: symlinks with real units

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:56:17PM +0100, Michael Biebl wrote: > 2015-01-28 1:44 GMT+01:00 Lennart Poettering : > > I am not a fan of this stuff either. I really don't like the TOCTOU > > behaviour I must say... > > > > If this is really just about ".bak", then we can add it to the list of > > suff

Re: [systemd-devel] [PATCH 01/12] fsckd daemon for inter-fsckd communication

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:20:40PM +0100, Didier Roche wrote: > > From d0f49b4e0994b9a1dd2738da18c5a2a6708b444f Mon Sep 17 00:00:00 2001 > From: Didier Roche > Date: Mon, 26 Jan 2015 15:35:50 +0100 > Subject: [PATCH 01/12] fsckd daemon for inter-fsckd communication > > Add systemd-fsckd multipl

Re: [systemd-devel] [PATCH 04/12] Add some plymouth functionality to connect and send, messages

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:22:04PM +0100, Didier Roche wrote: > > From 7afe9270e3210668053089caaff8a1dd790a48f5 Mon Sep 17 00:00:00 2001 > From: Didier Roche > Date: Mon, 26 Jan 2015 17:07:32 +0100 > Subject: [PATCH 04/12] Add some plymouth functionality to connect and send > messages > > Conn

Re: [systemd-devel] [PATCH 05/12] Connect and send to plymouth progress report

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:22:30PM +0100, Didier Roche wrote: > > From c60d4f41e279dd5ed7134d97d95549aac1f38e69 Mon Sep 17 00:00:00 2001 > From: Didier Roche > Date: Mon, 26 Jan 2015 16:29:30 +0100 > Subject: [PATCH 05/12] Connect and send to plymouth progress report > > Try to connect and send

Re: [systemd-devel] [PATCH 06/12] Support cancellation of fsck in progress

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:22:54PM +0100, Didier Roche wrote: > > From 104cf82ba28941e907f277a713f834ceb3d909f0 Mon Sep 17 00:00:00 2001 > From: Didier Roche > Date: Mon, 26 Jan 2015 16:40:52 +0100 > Subject: [PATCH 06/12] Support cancellation of fsck in progress > > Grab in fsckd plymouth watc

Re: [systemd-devel] [PATCH 10/12] Add fsckd service and socket, retarget systemd-fsck

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:24:32PM +0100, Didier Roche wrote: > > From 000f1b6ff4f5f80a2a13309590d255de6d6526ec Mon Sep 17 00:00:00 2001 > From: Didier Roche > Date: Mon, 26 Jan 2015 17:30:00 +0100 > Subject: [PATCH 10/12] Add fsckd service and socket, retarget systemd-fsck > > systemd-fsckd ca

Re: [systemd-devel] [PATCH 11/12] Add man page and references to it.

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:24:55PM +0100, Didier Roche wrote: > > From 6b13d8fb248bf4176f1ad7e1d4736683462bf196 Mon Sep 17 00:00:00 2001 > From: Didier Roche > Date: Mon, 26 Jan 2015 17:34:59 +0100 > Subject: [PATCH 11/12] Add man page and references to it. > > Add man page explaining the plymo

Re: [systemd-devel] [PATCH 12/12] Add mock fsck process

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:25:17PM +0100, Didier Roche wrote: > > From aefe0667ed62d5d7e17193c0f5ae302ed57e4727 Mon Sep 17 00:00:00 2001 > From: Didier Roche > Date: Mon, 26 Jan 2015 17:46:36 +0100 > Subject: [PATCH 12/12] Add mock fsck process > > --- > test/mocks/fsck | 27 ++

Re: [systemd-devel] [PATCH] systemd-udevd.service: restore mount propagation

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 02:09:37PM +0100, Martin Pitt wrote: > Lennart Poettering [2015-01-28 13:33 +0100]: > > Hmm, yeah, we apparently only add that for file systems listed in > > /etc/fstab... > > > > If you change the "get_mount_parameters_fragment()" invocation at the > > beginning of mount_a

Re: [systemd-devel] [PATCH 06/12] Support cancellation of fsck in progress

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 03:21:27PM +, Dimitri John Ledkov wrote: > On 28 January 2015 at 14:53, Zbigniew Jędrzejewski-Szmek > wrote: > > > > On Wed, Jan 28, 2015 at 02:22:54PM +0100, Didier Roche wrote: > > > > > > > > From 104cf82ba28941e907f277a

Re: [systemd-devel] initializing _cleanup_* variables [was: [PATCH 01/12] fsckd daemon for inter-fsckd communication]

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 04:06:30PM +, Dimitri John Ledkov wrote: > On 28 January 2015 at 15:47, Martin Pitt wrote: > > Hey Zbyszek, > > > > Zbigniew Jędrzejewski-Szmek [2015-01-28 15:37 +0100]: > >> > +static int handle_requests(int socket_fd) { >

Re: [systemd-devel] [PATCH] systemd-udevd.service: restore mount propagation

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 05:24:19PM +0100, Lennart Poettering wrote: > On Wed, 28.01.15 16:29, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Wed, Jan 28, 2015 at 02:09:37PM +0100, Martin Pitt wrote: > > > Lennart Poettering [2015-01-28 13:33 +0100]:

Re: [systemd-devel] BUG: several bugs in core/main.c (v218)

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 27, 2015 at 01:57:58AM +0100, Lennart Poettering wrote: > On Mon, 26.01.15 23:45, Tomasz Pawlak (toma...@wp.pl) wrote: > > > > Actually it *is* protected, see kill(2). Signals are ignored for PID 1 > > > unless it installed handlers for them. Nevertheless, we probably want to > > > abo

Re: [systemd-devel] BUG: several bugs in core/main.c (v218)

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 29, 2015 at 12:17:08AM +0100, Tomasz Pawlak wrote: > On Sun, 25.01.15 03:37, Tomasz Pawlak (tomazzi at wp.pl) wrote: > ---> > I've replied in the 2nd part of this td - btw, can someone merge those parts? That ship has already sailed. Your client did not set In-reply-to. BTW., could yo

Re: [systemd-devel] [systemd-commits] 2 commits - src/journal src/shared

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 28, 2015 at 05:48:01PM -0800, Lennart Poettering wrote: > Revert "journal: do not check for number of files" > > This reverts commit b914ea8d379b446c4c9fac4ba181771676ef38cd. > > We really need to put a limit on all our resources, everywhere, and in > particula

Re: [systemd-devel] [TOOL] Check-undocumented arguments and bash autocompletions

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 11, 2015 at 09:46:47PM +0100, Carlos Morata Castillo wrote: > Hi, > > I've updated the tool today to work with verbs and some cache issues. Sorry for the delayed reply. This seems useful, to catch regressions, and to see how much stuff is still undocumented. > >./check-undocumented.sh

Re: [systemd-devel] Autocompletion by default in containers and typo on systemctl.in

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 10, 2015 at 01:29:11AM +0100, Carlos Morata Castillo wrote: > Hi, > > 1- It'll be nice if when you "nspawn" a container it'll have > autocompletion enabled by default. > > Just need to execute this line: > . /usr/share/bash-completion/bash_completion > > > (This file is /usr/share/b

Re: [systemd-devel] [PATCH] Updates in bash autocompletions

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 10, 2015 at 02:08:21AM +0100, Carlos Morata Castillo wrote: > Hi, > > I did ./check-undocumented.sh -b (my script just submitted) and checked > the results. > > > Cheers. > > --- > shell-completion/bash/coredumpctl | 2 +- > shell-completion/bash/hostnamectl | 2 +- > sh

Re: [systemd-devel] [PATCH 1/2] systemd-helpers

2015-01-28 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 10, 2015 at 01:33:05PM +0100, Carlos Morata Castillo wrote: > Hi, > > As stated here, we should use a library for bash autocompletions (maybe even > with include guards). > http://cgit.freedesktop.org/systemd/systemd/commit/shell-completion/bash/localectl?id=a72d698d0d9ff9c158155b44cd

<    1   2   3   4   5   6   7   8   9   10   >