[systemd-devel] [PATCH 0/2] systemd serialization on switch-root

2014-03-05 Thread harald
From: Harald Hoyer har...@redhat.com If systemctl switch-root is called with a specific INIT or /proc/cmdline contains init=, then systemd would not serialize itsself. Let systemctl check, if the new init is in the standard systemd installation path and if so, clear the INIT parameter

[systemd-devel] [PATCH 1/2] util: add files_same() helper function

2014-03-05 Thread harald
From: Harald Hoyer har...@redhat.com files_same() returns 1, if the files are the same 0, if the files have different inode/dev numbers errno, for any stat error --- src/shared/util.c | 20 +--- src/shared/util.h | 2 ++ 2 files changed, 15 insertions(+), 7 deletions

[systemd-devel] [PATCH 2/2] systemctl: for switch-root check, if we switch to a systemd init

2014-03-05 Thread harald
From: Harald Hoyer har...@redhat.com If systemctl switch-root is called with a specific INIT or /proc/cmdline contains init=, then systemd would not serialize itsself. Let systemctl check, if the new init is in the standard systemd installation path and if so, clear the INIT parameter, to let

[systemd-devel] [PATCH 2/2] [V2] systemctl: for switch-root check, if we switch to a systemd init

2014-03-05 Thread harald
From: Harald Hoyer har...@redhat.com If systemctl switch-root is called with a specific INIT or /proc/cmdline contains init=, then systemd would not serialize itsself. Let systemctl check, if the new init is in the standard systemd installation path and if so, clear the INIT parameter, to let

[systemd-devel] [PATCH 1/2] [V3] util: add files_same() helper function

2014-03-06 Thread harald
From: Harald Hoyer har...@redhat.com files_same() returns 1, if the files are the same 0, if the files have different inode/dev numbers errno, for any stat error --- src/shared/util.c | 22 +++--- src/shared/util.h | 2 ++ 2 files changed, 17 insertions(+), 7

[systemd-devel] [PATCH 0/2] [V3] systemd serialization on switch-root

2014-03-06 Thread harald
From: Harald Hoyer har...@redhat.com If systemctl switch-root is called with a specific INIT or /proc/cmdline contains init=, then systemd would not serialize itsself. Let systemctl check, if the new init is in the standard systemd installation path and if so, clear the INIT parameter

[systemd-devel] [PATCH 2/2] [V4] systemctl: for switch-root check, if we switch to a systemd init

2014-03-06 Thread harald
From: Harald Hoyer har...@redhat.com If systemctl switch-root is called with a specific INIT or /proc/cmdline contains init=, then systemd would not serialize itsself. Let systemctl check, if the new init is in the standard systemd installation path and if so, clear the INIT parameter, to let

[systemd-devel] [PATCH] systemctl: refuse to do kexec, if no kernel is loaded

2014-03-18 Thread harald
From: Harald Hoyer har...@redhat.com Doing a kexec with no kernel loaded would currently issue a normal reboot. This might not be wanted, if the goal of kexec is to circumvent the boot loader. Better fail to kexec, than to reboot into a maybe broken setup. --- src/systemctl/systemctl.c | 11

[systemd-devel] [PATCH] udevadm-settle: fixed return code for empty queue

2014-05-20 Thread harald
From: Harald Hoyer har...@redhat.com If the udev queue is empty and /run/udev/queue does not exist, udevadm settle would return with EXIT_FAILURE, because the inotify on /run/udev/queue would fail with ENOENT. This patch lets udevadm settle exit with EXIT_SUCCESS in this case. --- src/udev

[systemd-devel] [PATCH] Added arch tuple for PPC64LE

2014-08-08 Thread harald
From: Harald Hoyer har...@redhat.com Thanks to Brent Baude bba...@redhat.com, who checked with the debian guys, that this is correct and provided the patch. --- src/shared/architecture.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/architecture.h b/src/shared

[systemd-devel] [PATCH] Removed PPC 32 bit LE architecture

2014-08-08 Thread harald
From: Harald Hoyer har...@redhat.com According to Brent Baude bba...@redhat.com, who provided the patch, IBM doesn't want to support the PPC 32 bit LE architecture at all. --- src/shared/architecture.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/shared/architecture.h b/src/shared

[systemd-devel] [PATCH] journalctl: add -t --identifier=STRING option

2014-08-19 Thread harald
From: Harald Hoyer har...@redhat.com This turns journalctl to the counterpart of systemd-cat. Messages sent with systemd-cat --identifier foo --prioritiy debug can now be shown with journalctl --identifier foo --prioritiy debug --identifier is not merged with --unit to make a clear

[systemd-devel] [PATCH] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer har...@redhat.com removes code duplication --- Makefile.am| 1 + src/core/main.c| 2 +- src/core/shutdown.c| 77 +- src/core/switch-root.c | 6 ++-- src/core/switch-root.h | 2 +- 5 files changed, 13

[systemd-devel] [PATCH V2] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer har...@redhat.com removes code duplication --- Removed all references to /mnt in switch_root() and the bogus comment. Makefile.am| 1 + src/core/main.c| 2 +- src/core/shutdown.c| 77 +- src/core

[systemd-devel] [PATCH V3] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer har...@redhat.com removes code duplication also move switch-root to shared --- V2: - Removed all references to /mnt in switch_root() and the bogus comment. V3: - moved switch-root.[ch] to shared - added switch to mount MS_MOVE or MS_BIND the old dirs Makefile.am

[systemd-devel] [PATCH V4] use the switch_root function in shutdown

2014-08-21 Thread harald
From: Harald Hoyer har...@redhat.com removes code duplication also move switch-root to shared --- V2: - Removed all references to /mnt in switch_root() and the bogus comment. V3: - moved switch-root.[ch] to shared - added switch to mount MS_MOVE or MS_BIND the old dirs V4: - mkdir_p_label

[systemd-devel] [PATCH] journal: handle multiline syslog messages

2013-08-01 Thread harald
From: Harald Hoyer har...@redhat.com Since the journal can handle multiple lines just well natively, and rsyslog can be configured to handle them as well, there is no need to truncate messages from syslog() after the first newline. Reproducer: 1. Add following four lines to /etc/rsyslog.conf

[systemd-devel] [PATCH] 60-persistent-storage.rules: add NVMe disks and partitions

2014-02-10 Thread harald
From: Harald Hoyer har...@redhat.com Although NVMe PCIe SSD are not named sd*, they can be queried with scsi_id and handled equally. --- rules/60-persistent-storage.rules | 5 + 1 file changed, 5 insertions(+) diff --git a/rules/60-persistent-storage.rules b/rules/60-persistent

[systemd-devel] [PATCH] log_error(), if inotify_add_watch() fails

2013-02-13 Thread harald
From: Harald Hoyer har...@redhat.com --- src/login/sd-login.c| 3 +++ src/shared/ask-password-api.c | 1 + src/shared/util.c | 1 + src/tty-ask-password-agent/tty-ask-password-agent.c | 2 ++ 4 files changed

[systemd-devel] [PATCH] selinux-access:log_callback() increase buffer for audit logging

2013-02-13 Thread harald
From: Harald Hoyer har...@redhat.com As per https://bugzilla.redhat.com/show_bug.cgi?id=883043#c5 we can increase the buffer used with audit_log_user_avc_message() safely to 4096 bytes. --- src/core/selinux-access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core

[systemd-devel] [PATCH] run systemd-vconsole-setup.service before systemd-ask-password-console.service

2013-02-14 Thread harald
From: Harald Hoyer har...@redhat.com --- units/systemd-vconsole-setup.service.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/units/systemd-vconsole-setup.service.in b/units/systemd-vconsole-setup.service.in index 18faa63..c6d7a96 100644 --- a/units/systemd-vconsole

[systemd-devel] [PATCH] bootchart: parse /etc/os-release rather than system-release

2013-02-14 Thread harald
From: Harald Hoyer har...@redhat.com Also parse it early, so that we can get it in the initramfs. --- src/bootchart/bootchart.c | 9 - src/bootchart/bootchart.h | 2 +- src/bootchart/svg.c | 15 +++ 3 files changed, 12 insertions(+), 14 deletions(-) diff --git a/src

[systemd-devel] [PATCH] honor SELinux labels, when creating and writing config files

2013-02-14 Thread harald
From: Harald Hoyer har...@redhat.com see https://bugzilla.redhat.com/show_bug.cgi?id=881577 --- Makefile.am | 2 + src/core/unit.c | 3 +- src/hostname/hostnamed.c | 7 ++-- src/locale/localed.c | 7 ++-- src/login/logind-dbus.c | 4 +- src/shared/label.c

[systemd-devel] [PATCH] cryptsetup-generator: Add JobTimeoutSec=0 for all known crypt devices

2013-03-01 Thread harald
From: Harald Hoyer har...@redhat.com put JobTimeoutSec=0 in device-unit.d/JobTimeoutSec0.conf files This helps with grabbing a cup of coffee while booting and not have the crypto password dialog timeout and systemd in a failed state. --- src/cryptsetup/cryptsetup-generator.c | 62

[systemd-devel] [PATCH] fstab-generator: If we wait indefinitely for a mount, wait also for the device

2013-03-01 Thread harald
From: Harald Hoyer har...@redhat.com Write out JobTimeoutSec=0 for the device the mountpoint (which does not timeout) waits for. This helps with grabbing a cup of coffee while booting and not have the crypto password dialog timeout and systemd in a failed state. --- src/fstab-generator/fstab

[systemd-devel] [PATCH] fstab-generator: default to ro

2013-03-01 Thread harald
From: Harald Hoyer har...@redhat.com If no ro or rw is specified on the kernel command line, mount root read-only on /sysroot by default --- src/fstab-generator/fstab-generator.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/fstab-generator/fstab

[systemd-devel] [PATCH 2/4] fstab-generator: skip generation, if sysroot.mount already exists

2013-03-04 Thread harald
From: Harald Hoyer har...@redhat.com --- src/fstab-generator/fstab-generator.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/fstab-generator/fstab-generator.c b/src/fstab-generator/fstab-generator.c index fade192..3b8329b 100644 --- a/src/fstab-generator

[systemd-devel] [PATCH] bootchart: add parameter -C to expand process names to the full cmdline

2013-03-06 Thread harald
From: Harald Hoyer har...@redhat.com --- src/bootchart/bootchart.c | 7 ++- src/bootchart/bootchart.h | 3 ++- src/bootchart/log.c | 39 +-- src/bootchart/svg.c | 37 + 4 files changed, 74 insertions(+), 12

[systemd-devel] [PATCH 1/3] bootchart: add parameter -C to expand process names to the full cmdline

2013-03-06 Thread harald
From: Harald Hoyer har...@redhat.com --- src/bootchart/bootchart.c | 7 ++- src/bootchart/bootchart.h | 3 ++- src/bootchart/log.c | 33 +++-- src/bootchart/svg.c | 39 +-- 4 files changed, 72 insertions(+), 10

[systemd-devel] [PATCH 2/3] bootchart: rename global len to samples_len

2013-03-06 Thread harald
From: Harald Hoyer har...@redhat.com --- src/bootchart/bootchart.c | 32 src/bootchart/bootchart.h | 2 +- src/bootchart/log.c | 2 +- src/bootchart/svg.c | 4 ++-- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/bootchart

[systemd-devel] [PATCH 3/3] bootchart: use _cleanup_fclose_

2013-03-06 Thread harald
From: Harald Hoyer har...@redhat.com --- src/bootchart/log.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/bootchart/log.c b/src/bootchart/log.c index 43999f2..ccec03f 100644 --- a/src/bootchart/log.c +++ b/src/bootchart/log.c @@ -57,7 +57,7 @@ double

[systemd-devel] [PATCH] fstab-generator: fsck /sysroot before we mount it rw

2013-03-07 Thread harald
From: Harald Hoyer har...@redhat.com --- src/fstab-generator/fstab-generator.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/fstab-generator/fstab-generator.c b/src/fstab-generator/fstab-generator.c index 910bbc1..b5fe0fa 100644 --- a/src/fstab

[systemd-devel] [PATCH] cryptsetup-generator: use _cleanup_ where possible

2013-03-08 Thread harald
From: Harald Hoyer har...@redhat.com --- src/cryptsetup/cryptsetup-generator.c | 209 +++--- 1 file changed, 65 insertions(+), 144 deletions(-) diff --git a/src/cryptsetup/cryptsetup-generator.c b/src/cryptsetup/cryptsetup-generator.c index 38a7cfa..0a51db8 100644

[systemd-devel] [PATCH] mount: fix manual network mounts

2013-03-08 Thread harald
From: Harald Hoyer har...@redhat.com Now works as expected for me. $ mount 192.168.2.2:/Public /mnt/test $ systemctl status mnt-test.mount mnt-test.mount - /mnt/test Loaded: loaded (/proc/self/mountinfo) Active: active (mounted) since Fr 2013-03-08 16:24:38 CET; 11s ago

[systemd-devel] [PATCH V2] mount: fix network mounts

2013-03-08 Thread harald
From: Harald Hoyer har...@redhat.com Now works as expected for me. $ mount 192.168.2.2:/Public /mnt/test $ systemctl status mnt-test.mount mnt-test.mount - /mnt/test Loaded: loaded (/proc/self/mountinfo) Active: active (mounted) since Fr 2013-03-08 16:24:38 CET; 11s ago

[systemd-devel] [PATCH V3] mount: fix manual network mounts

2013-03-08 Thread harald
From: Harald Hoyer har...@redhat.com Now works as expected for me. $ mount 192.168.2.2:/Public /mnt/test $ systemctl status mnt-test.mount mnt-test.mount - /mnt/test Loaded: loaded (/proc/self/mountinfo) Active: active (mounted) since Fr 2013-03-08 16:24:38 CET; 11s ago

[systemd-devel] [PATCH V4] mount: fix manual network mounts

2013-03-08 Thread harald
From: Harald Hoyer har...@redhat.com Now works as expected for me. $ mount 192.168.2.2:/Public /mnt/test $ systemctl status mnt-test.mount mnt-test.mount - /mnt/test Loaded: loaded (/proc/self/mountinfo) Active: active (mounted) since Fr 2013-03-08 16:24:38 CET; 11s ago

[systemd-devel] [PATCH] mount: fix network umounts

2013-03-08 Thread harald
From: Harald Hoyer har...@redhat.com Now works as expected for me. $ mount 192.168.2.2:/Public /mnt/test $ systemctl status mnt-test.mount mnt-test.mount - /mnt/test Loaded: loaded (/proc/self/mountinfo) Active: active (mounted) since Fr 2013-03-08 16:24:38 CET; 11s ago

[systemd-devel] [PATCH] core: do not serialize targets on switch-root

2013-03-12 Thread harald
From: Harald Hoyer har...@redhat.com Targets in the initrd can differ from targets on the switched root. Do not assume these targets are active. --- src/core/main.c| 8 src/core/manager.c | 6 +++--- src/core/manager.h | 2 +- src/core/unit.c| 7 +-- src/core/unit.h| 2

[systemd-devel] [PATCH] transaction: if a job wants to be started before a target, set the target dead

2013-03-12 Thread harald
From: Harald Hoyer har...@redhat.com Not sure, if this is the correct place to enforce this, but it seems to work. --- src/core/transaction.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/core/transaction.c b/src/core/transaction.c index 4a8d90e..3fed57a 100644 --- a/src/core

[systemd-devel] [PATCH V2] core: do not serialize targets on switch-root

2013-03-12 Thread harald
From: Harald Hoyer har...@redhat.com Targets in the initrd can differ from targets on the switched root. Do not assume these targets are active. --- src/core/main.c| 8 src/core/manager.c | 9 ++--- src/core/manager.h | 2 +- src/core/unit.c| 4 ++-- src/core/unit.h| 2

[systemd-devel] [PATCH V3] core: do not serialize targets on switch-root

2013-03-12 Thread harald
From: Harald Hoyer har...@redhat.com Targets in the initrd can differ from targets on the switched root. Do not assume these targets are active. --- src/core/main.c| 8 src/core/manager.c | 9 ++--- src/core/manager.h | 2 +- 3 files changed, 11 insertions(+), 8 deletions

[systemd-devel] [PATCH 1/2] add initrd-fs.target and root-fs.target

2013-03-12 Thread harald
From: Harald Hoyer har...@redhat.com Instead of using local-fs*.target in the initrd, use root-fs.target for sysroot.mount and initrd-fs.target for /sysroot/usr and friends. Using local-fs.target would mean to carry over the activated local-fs.target to the isolated initrd-switch-root.target

[systemd-devel] [PATCH 2/2] mount: fix network umounts of manual remote-fs mounts

2013-03-12 Thread harald
From: Harald Hoyer har...@redhat.com Revert 6bde0b3, which pulls in remote-fs-pre.target and with this i.e. NetworkManager-wait-online.service. Solve the remote-fs problem with using PartOf. remote-fs.target is part of multi-user.target, and therefore active by default. By using UNIT_PART_OF

[systemd-devel] [PATCH] fstab-generator: handle mount units with x-rootfs.mount

2013-03-14 Thread harald
From: Harald Hoyer har...@redhat.com Mount units with x-rootfs.mount are now ordered before root-fs.target. As we sometimes construct /sysroot mounts in /etc/fstab in the initrd, we want these to be mounted before the root-fs.target is active. --- src/fstab-generator/fstab-generator.c | 10

[systemd-devel] [RFC PATCH] Make initrd-fs.target the default target in the initrd

2013-03-14 Thread harald
From: Harald Hoyer har...@redhat.com First, rename root-fs.target to initrd-root-fs.target to clarify its usage. Mount units with x-initrd-rootfs.mount are now ordered before initrd-root-fs.target. As we sometimes construct /sysroot mounts in /etc/fstab in the initrd, we want these to be mounted

[systemd-devel] [PATCH V2] Make initrd-fs.target the default target in the initrd

2013-03-14 Thread harald
From: Harald Hoyer har...@redhat.com First, rename root-fs.target to initrd-root-fs.target to clarify its usage. Mount units with x-initrd-rootfs.mount are now ordered before initrd-root-fs.target. As we sometimes construct /sysroot mounts in /etc/fstab in the initrd, we want these to be mounted

[systemd-devel] [PATCH V3] Make initrd-fs.target the default target in the initrd

2013-03-14 Thread harald
From: Harald Hoyer har...@redhat.com First, rename root-fs.target to initrd-root-fs.target to clarify its usage. Mount units with x-initrd-rootfs.mount are now ordered before initrd-root-fs.target. As we sometimes construct /sysroot mounts in /etc/fstab in the initrd, we want these to be mounted

[systemd-devel] [PATCH FINAL] Make initrd.target the default target in the initrd

2013-03-14 Thread harald
From: Harald Hoyer har...@redhat.com First, rename root-fs.target to initrd-root-fs.target to clarify its usage. Mount units with x-initrd-rootfs.mount are now ordered before initrd-root-fs.target. As we sometimes construct /sysroot mounts in /etc/fstab in the initrd, we want these to be mounted

[systemd-devel] [PATCH FINAL FINAL] Make initrd.target the default target in the initrd

2013-03-14 Thread harald
From: Harald Hoyer har...@redhat.com First, rename root-fs.target to initrd-root-fs.target to clarify its usage. Mount units with x-initrd-rootfs.mount are now ordered before initrd-root-fs.target. As we sometimes construct /sysroot mounts in /etc/fstab in the initrd, we want these to be mounted

[systemd-devel] [PATCH] journalctl: add short version for _SYSTEMD_UNIT=

2013-03-18 Thread harald
From: Harald Hoyer har...@redhat.com Instead of typing the rather unusual: $ journalctl _SYSTEMD_UNIT=sshd.service one can now type $ journalctl sshd.service -- Logs begin at So 2013-02-24 20:54:44 CET, end at Mo 2013-03-18 14:01:01 CET. -- Mär 18 07:48:26 lenovo sshd[400]: Server listening

[systemd-devel] [PATCH] journalctl: fix logic with parameter -u

2013-03-19 Thread harald
From: Harald Hoyer har...@redhat.com When using -p and -b in combination with -u, the output is not what you would expect. The reason is the sd_journal_add_disjunction() call in add_matches_for_unit() and add_matches_for_user_unit(), which adds two ORs without taking the other conditions to every

[systemd-devel] [PATCH V2] journalctl: fix logic with parameter -u

2013-03-22 Thread harald
From: Harald Hoyer har...@redhat.com When using -p and -b in combination with -u, the output is not what you would expect. The reason is the sd_journal_add_disjunction() call in add_matches_for_unit() and add_matches_for_user_unit(), which adds two ORs without taking the other conditions to every

[systemd-devel] [PATCH] cryptsetup-generator: Add JobTimeoutSec=0 for all known crypt devices

2013-04-03 Thread harald
From: Harald Hoyer har...@redhat.com put JobTimeoutSec=0 in device-unit.d/JobTimeoutSec0.conf files This helps with grabbing a cup of coffee while booting and not have the crypto password dialog timeout and systemd in a failed state. This is even needed for timeout=0 in /etc/crypttab! --- src

[systemd-devel] [PATCH V2] cryptsetup-generator: add JobTimeoutSec=0 for the decrypted crypt devices

2013-04-03 Thread harald
From: Harald Hoyer har...@redhat.com The password query for a crypto device currently times out after 90s, which is too short to grab a cup of coffee when a machine boots up. The resulting decrypted device /dev/mapper/luks-uuid might not be a mountpoint (but part of a LVM PV or raid array

[systemd-devel] [PATCH V3] cryptsetup-generator: add JobTimeoutSec=0 for the decrypted crypt devices

2013-04-04 Thread harald
From: Harald Hoyer har...@redhat.com The password query for a crypto device currently times out after 90s, which is too short to grab a cup of coffee when a machine boots up. The resulting decrypted device /dev/mapper/luks-uuid might not be a mountpoint (but part of a LVM PV or raid array

[systemd-devel] [PATCH] Do not serialize environment, when switching root

2013-04-08 Thread harald
From: Harald Hoyer har...@redhat.com When switching root, i.e. LANG can be set to the locale of the initramfs or C, if it was unset. When systemd deserializes LANG in the real root this would overwrite the setting previously gathered by locale_set(). To reproduce, boot with an initramfs without

[systemd-devel] [PATCH] core/execute.c: debug log final execve() with argv[]

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com https://bugzilla.redhat.com/show_bug.cgi?id=772073 --- src/core/execute.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/core/execute.c b/src/core/execute.c index 5083af9..c881e56 100644 --- a/src/core/execute.c +++ b/src/core/execute.c

[systemd-devel] [PATCH V2] core/execute.c: debug log final execve() with argv[]

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com https://bugzilla.redhat.com/show_bug.cgi?id=772073 --- src/core/execute.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/core/execute.c b/src/core/execute.c index 5083af9..c881e56 100644 --- a/src/core/execute.c +++ b/src/core/execute.c

[systemd-devel] [PATCH V3] core/execute.c: debug log final execve() with argv[]

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com https://bugzilla.redhat.com/show_bug.cgi?id=772073 --- src/core/execute.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/core/execute.c b/src/core/execute.c index 5083af9..c881e56 100644 --- a/src/core/execute.c +++ b/src/core/execute.c

[systemd-devel] [PATCH V4] core/execute.c: debug log final execve() with argv[]

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com https://bugzilla.redhat.com/show_bug.cgi?id=772073 --- src/core/execute.c | 12 1 file changed, 12 insertions(+) diff --git a/src/core/execute.c b/src/core/execute.c index 5083af9..fabd38e 100644 --- a/src/core/execute.c +++ b/src/core/execute.c

[systemd-devel] [PATCH] systemctl: clarify usage of --all versus list-unit-files

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com Novice users might think, that $ systemctl --all is equal to $ systemctl list-unit-files https://bugzilla.redhat.com/show_bug.cgi?id=748512 --- man/systemctl.xml | 4 +++- src/systemctl/systemctl.c | 4 +++- 2 files changed, 6 insertions(+), 2

[systemd-devel] [PATCH] service: Support environment variable substition for PIDFile=

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com RFE: https://bugzilla.redhat.com/show_bug.cgi?id=840260 $ cat test.service [Unit] Description=test [Service] PIDFile=${PIDFILE} EnvironmentFile=/etc/test-file ExecStart=/bin/bash -c 'sleep 1 jobs -p $$PIDFILE; exit 0' Type=forking $ cat /etc/test-file

[systemd-devel] [PATCH V2] service: Support environment variable substition for PIDFile=

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com RFE: https://bugzilla.redhat.com/show_bug.cgi?id=840260 $ cat test.service [Unit] Description=test [Service] PIDFile=${PIDFILE} EnvironmentFile=/etc/test-file ExecStart=/bin/bash -c 'sleep 1 jobs -p $$PIDFILE; exit 0' Type=forking $ cat /etc/test-file

[systemd-devel] [PATCH V3] service: Support environment variable substition for PIDFile=

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com This patch adds environment variable substition for PIDFile=. To read the environment files only once, ExecContext holds a copy of the environment gathered. RFE: https://bugzilla.redhat.com/show_bug.cgi?id=840260 $ cat test.service [Unit] Description=test

[systemd-devel] [PATCH V4] service: Support environment variable substition for PIDFile=

2013-04-10 Thread harald
From: Harald Hoyer har...@redhat.com This patch adds environment variable substition for PIDFile=. To read the environment files only once, ExecContext holds a copy of the environment gathered. RFE: https://bugzilla.redhat.com/show_bug.cgi?id=840260 $ cat test.service [Unit] Description=test

[systemd-devel] [PATCH] cryptsetup-generator: add support for rd.luks.key=

2013-04-11 Thread harald
From: Harald Hoyer har...@redhat.com Also clarify rd.luks.uuid and luks.uuid in the manual. https://bugzilla.redhat.com/show_bug.cgi?id=905683 --- man/kernel-command-line.xml | 2 ++ man/systemd-cryptsetup-generator.xml | 26 +- src/cryptsetup/cryptsetup

[systemd-devel] [PATCH] journal: add one more level on top with AND

2013-04-11 Thread harald
From: Harald Hoyer har...@redhat.com When using -p and -b in combination with -u, the output is not what you would expect. The reason is the sd_journal_add_disjunction() call in add_matches_for_unit() and add_matches_for_user_unit(), which adds two ORs without taking the other conditions to every

[systemd-devel] [PATCH V2] cryptsetup-generator: add support for rd.luks.key=

2013-04-11 Thread harald
From: Harald Hoyer har...@redhat.com Also clarify rd.luks.uuid and luks.uuid in the manual. https://bugzilla.redhat.com/show_bug.cgi?id=905683 --- Fixed some whitespace error. man/kernel-command-line.xml | 2 ++ man/systemd-cryptsetup-generator.xml | 26

[systemd-devel] [PATCH 0/2] journalctl arguments and filtering

2013-04-12 Thread harald
From: Harald Hoyer har...@redhat.com This patch series improves the argument handling of journalctl. It ANDs all parameter like -b --unit= -p and multiple --unit= can be specified. The output of: # journalctl -u sshd.service -u crond.service -u sshd.service -b -p 0..7 is now, what you would

[systemd-devel] [PATCH 2/2] journalctl: specify --unit= and --user-unit multiple times

2013-04-12 Thread harald
From: Harald Hoyer har...@redhat.com Previously only one --unit= or --user-unit could be specified. With this patch, journalcrtl can show multiple units. $ journalctl -u systemd-udevd.service -u sshd.service -u crond.service -b -- Logs begin at Sa 2013-03-23 11:08:45 CET, end at Fr 2013-04-12 09

[systemd-devel] [PATCH] cryptsetup: set the timeout to 0 by default

2013-04-12 Thread harald
From: Harald Hoyer har...@redhat.com cryptsetup itself has no timeout as default from the beginning. So the default timeout has been 0 from the beginning. https://bugzilla.redhat.com/show_bug.cgi?id=949702 --- src/cryptsetup/cryptsetup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[systemd-devel] [PATCH] core/device.c: fix possible segfault

2013-04-12 Thread harald
From: Harald Hoyer har...@redhat.com https://bugs.freedesktop.org/show_bug.cgi?id=63189 better fail than segfault systemd[1]: Failed to load device unit: Invalid argument systemd[1]: Failed to process udev device event: Invalid argument --- src/core/device.c | 5 - 1 file changed, 4

[systemd-devel] [PATCH V2] core/device.c: fix possible segfault

2013-04-12 Thread harald
From: Harald Hoyer har...@redhat.com https://bugs.freedesktop.org/show_bug.cgi?id=63189 better fail than segfault systemd[1]: Failed to load device unit: Invalid argument systemd[1]: Failed to process udev device event: Invalid argument --- V2: Now checking for (r 0) rather than (r). src

[systemd-devel] [PATCH] RFC: stack_size_guess() and LINE_MAX limitation for MESSAGE

2013-04-15 Thread harald
From: Harald Hoyer har...@redhat.com Introduce stack_size_guess() and alloca_maybe_safe() and get rid of the LINE_MAX limitation for MESSAGE in sd_journal_printv*() Harald Hoyer (2): util: add stack_size_guess() and alloca_maybe_safe() journal: get rid of LINE_MAX in sd_journal_printv

[systemd-devel] [PATCH] util: add stack_size_guess() and alloca_maybe_safe()

2013-04-15 Thread harald
From: Harald Hoyer har...@redhat.com stack_size_guess() guesses the remaining stack size in bytes. alloca_maybe_safe() returns NULL, if the allocation would exceed the remaining stack. --- CODING_STYLE | 7 +++ Makefile.am | 7 +++ configure.ac | 35

[systemd-devel] [PATCH] journal: get rid of LINE_MAX in sd_journal_printv*()

2013-04-15 Thread harald
From: Harald Hoyer har...@redhat.com use stack_size_guess() to get rid of LINE_MAX --- src/journal/journal-send.c | 99 +++-- src/journal/test-journal-send.c | 92 +- 2 files changed, 156 insertions(+), 35 deletions

[systemd-devel] [PATCH 0/2] V2 RFC: stack_size_guess() and LINE_MAX limitation for MESSAGE

2013-04-15 Thread harald
From: Harald Hoyer har...@redhat.com Introduce stack_size_guess() and alloca_maybe_safe() and get rid of the LINE_MAX limitation for MESSAGE in sd_journal_printv*() V2: added missing test-stack.c Harald Hoyer (2): util: add stack_size_guess() and alloca_maybe_safe() journal: get rid

[systemd-devel] [PATCH 1/2 V2] util: add stack_size_guess() and alloca_maybe_safe()

2013-04-15 Thread harald
From: Harald Hoyer har...@redhat.com stack_size_guess() guesses the remaining stack size in bytes. alloca_maybe_safe() returns NULL, if the allocation would exceed the remaining stack. --- V2: added missing src/shared/test-stack.c CODING_STYLE| 7 +++ Makefile.am

[systemd-devel] [PATCH 2/2] journal: get rid of LINE_MAX in sd_journal_printv*()

2013-04-15 Thread harald
From: Harald Hoyer har...@redhat.com use stack_size_guess() to get rid of LINE_MAX --- src/journal/journal-send.c | 99 +++-- src/journal/test-journal-send.c | 92 +- 2 files changed, 156 insertions(+), 35 deletions

[systemd-devel] [PATCH] shell-completion/bash/systemctl: add completion for properties

2013-04-16 Thread harald
From: Harald Hoyer har...@redhat.com --- TODO| 2 -- shell-completion/bash/systemctl | 13 - 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index f90c66b..22c26a3 100644 --- a/TODO +++ b/TODO @@ -1,8 +1,6 @@ Bugfixes

[systemd-devel] [PATCH] login/sd-login.c: make use of _cleanup_free_ and friends

2013-04-17 Thread harald
From: Harald Hoyer har...@redhat.com --- Due to the heavy modification, I send this to the list for review. src/login/sd-login.c | 200 --- 1 file changed, 61 insertions(+), 139 deletions(-) diff --git a/src/login/sd-login.c b/src/login/sd

[systemd-devel] [PATCH V2] cryptsetup: ask for password, if key file cannot be accessed

2013-04-18 Thread harald
From: Harald Hoyer har...@redhat.com If the key file cannot be accessed, we can at least ask for the password. --- Remove access() call and check the return value of crypt_activate_by_keyfile_offset() src/cryptsetup/cryptsetup.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src

[systemd-devel] [PATCH] systemd-analyse: add tree command

2013-04-23 Thread harald
From: Harald Hoyer har...@redhat.com tree prints a tree of the critical chain of units $ ./systemd-analyze tree graphical.target @1.226s └─multi-user.target @1.226s └─nfs-lock.service @961ms +265ms └─rpcbind.service @958ms +1ms └─network.target @957ms └─NetworkManager.service

[systemd-devel] [PATCH V2] systemd-analyse: add critical-chain command

2013-04-23 Thread harald
From: Harald Hoyer har...@redhat.com critical-chain prints a tree of the critical chain of units $ ./systemd-analyze critical-chain graphical.target @1.226s └─multi-user.target @1.226s └─nfs-lock.service @961ms +265ms └─rpcbind.service @958ms +1ms └─network.target @957ms

[systemd-devel] [PATCH V3] systemd-analyse: add critical-chain command

2013-04-24 Thread harald
From: Harald Hoyer har...@redhat.com critical-chain prints a tree of the critical chain of units $ ./systemd-analyze critical-chain graphical.target @1.226s └─multi-user.target @1.226s └─nfs-lock.service @961ms +265ms └─rpcbind.service @958ms +1ms └─network.target @957ms

[systemd-devel] [PATCH] systemd: record the userspace timestamp early

2013-04-24 Thread harald
From: Harald Hoyer har...@redhat.com The time for systemd initialization and selinux policy loading is accounted to the initrd or the kernel, which is wrong. Instead of: Startup finished in 5.559s (firmware) + 36ms (loader) + 665ms (kernel) + 975ms (initrd) + 1.410s (userspace) = 8.647s

[systemd-devel] [PATCH] dbus-manager.c: log error, why switch-root is refused

2013-04-25 Thread harald
From: Harald Hoyer har...@redhat.com --- src/core/dbus-manager.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c index 1f5a7d9..74b31fd 100644 --- a/src/core/dbus-manager.c +++ b/src/core/dbus-manager.c @@ -1503,8 +1503,10

[systemd-devel] [PATCH] shared/log.c: log_struct_internal(): handle multiple lines

2013-06-26 Thread harald
From: Harald Hoyer har...@redhat.com Handle VAR=line1\nline2\nline3 and split into VAR length line1\nline2\nline3 \n --- src/shared/log.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/src/shared/log.c b/src/shared/log.c index

[systemd-devel] [PATCH] Log failing start conditions

2013-06-26 Thread harald
From: Harald Hoyer har...@redhat.com $ systemctl status dracut-initqueue.service dracut-initqueue.service - dracut initqueue hook Loaded: loaded (/usr/lib/systemd/system/dracut-initqueue.service; static) Active: inactive (dead) start condition failed at Wed 2013-06-26 13:01:05 UTC

[systemd-devel] [PATCH 1/2] Do not set LANG=C in every child environment.

2013-06-27 Thread harald
From: Harald Hoyer har...@redhat.com LANG does not have to be set and setting it to default to the default does not add any value. --- src/core/locale-setup.c | 8 1 file changed, 8 deletions(-) diff --git a/src/core/locale-setup.c b/src/core/locale-setup.c index d7113b9..daf81d0

[systemd-devel] [PATCH 2/2] util.c:is_locale_utf8(): check, if C was set on purpose

2013-06-27 Thread harald
From: Harald Hoyer har...@redhat.com If you have a ASCII only terminal, there is no way to set the charmap to ANSI_X3.4-1968, other than using LC_CTYPE=C. We don't want to assume a UTF-8 capable terminal in this case and only do so, if LANG, LC_ALL and LC_CTYPE are unset. --- src/shared/util.c

[systemd-devel] [PATCH 3/6] hashmap.h: HASHMAP_FOREACH* iterate until ITERATOR_LAST

2010-09-24 Thread harald
From: Harald Hoyer har...@redhat.com --- src/hashmap.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/hashmap.h b/src/hashmap.h index ac5a8ae..64a468d 100644 --- a/src/hashmap.h +++ b/src/hashmap.h @@ -77,12 +77,12 @@ void* hashmap_first(Hashmap *h); void

[systemd-devel] [PATCH 5/6] readahead-collect: handle btrfs FIEMAP

2010-09-24 Thread harald
From: Harald Hoyer har...@redhat.com Some files on btrfs do not have a physical extent. Just return an increasing number. --- src/readahead-collect.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/readahead-collect.c b/src/readahead-collect.c index 7983b31

[systemd-devel] [PATCH 1/6] readahead-replay: use posix_fadvise instead of readahead

2010-09-24 Thread harald
From: Harald Hoyer har...@redhat.com --- src/readahead-replay.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/readahead-replay.c b/src/readahead-replay.c index 1f1ec52..c93f147 100644 --- a/src/readahead-replay.c +++ b/src/readahead-replay.c @@ -85,8 +85,8

[systemd-devel] [PATCH] ratelimit: removed n_printed

2011-02-21 Thread harald
From: Harald Hoyer har...@redhat.com Removed n_printed and renamed n_printed to num. This is not a logging rate limiter anymore. --- src/ratelimit.c | 14 -- src/ratelimit.h |8 +++- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/src/ratelimit.c b/src

[systemd-devel] [PATCH] {locale, vconsole}-setup.c: unconditionally read config file settings

2011-05-03 Thread harald
From: Harald Hoyer har...@redhat.com systemd-vconsole-setup did not process any configuration files, if it found at least one parameter on the kernel command line. First we should read all config file parameter settings and let them be overwritten by kernel command line parameters afterwards

[systemd-devel] [PATCH 1/3] umount: umount, until all umounts failed

2011-05-05 Thread harald
From: Harald Hoyer har...@redhat.com --- src/umount.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/umount.c b/src/umount.c index 3d328e0..31e91ec 100644 --- a/src/umount.c +++ b/src/umount.c @@ -551,6 +551,8 @@ static int dm_points_list_detach(MountPoint

[systemd-devel] [PATCH 3/3] shutdown: pivot_root to a tmpfs directory to properly umount root

2011-05-05 Thread harald
From: Harald Hoyer har...@redhat.com umount /boot mount a tmpfs on /boot mount bind all needed dirs pivot_root to /boot umount all mountpoints as before see root be umounted properly and all dm devices deconstructed --- src/shutdown.c | 154

[systemd-devel] [PATCH] readahead-collect.c: ignore EPERM for fanotify

2011-05-24 Thread harald
From: Harald Hoyer har...@redhat.com There are files, which we are not allowed to read. Happens for example, if selinux is activated. --- src/readahead-collect.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/readahead-collect.c b/src/readahead-collect.c index

  1   2   3   4   5   6   7   8   9   10   >