[systemd-devel] Regression: loop device detach errors in 220

2015-06-03 Thread Jan Janssen
Hi, systemd-shutdown in 220 has errors when detaching loop devices: systemd-shutdown[1]: Failed to detach loop devices: Invalid argument cgroup: option or name mismatch, new: 0x0 "", old: 0x4 "systemd" systemd-shutdown[1]: Failed to detach loop devices: Invalid argument systemd-shutdown[1]: Fail

Re: [systemd-devel] [PATCH v3] journalctl: Improve boot ID lookup

2015-05-20 Thread Jan Janssen
Works fine. Don't forget to close the bug, though. :P On 2015-05-19 00:37, Lennart Poettering wrote: On Fri, 01.05.15 15:15, Jan Janssen (medhe...@web.de) wrote: This method should greatly improve offset based lookup, by simply jumping from one boot to the next boot. It starts at the jo

[systemd-devel] [PATCH v3] journalctl: Improve boot ID lookup

2015-05-01 Thread Jan Janssen
This method should greatly improve offset based lookup, by simply jumping from one boot to the next boot. It starts at the journal head to get the a boot ID, makes a _BOOT_ID match and then comes from the opposite journal direction (tail) to get to the end that boot. After flushing the matches and

Re: [systemd-devel] [PATCH v2] journalctl: Improve boot ID lookup

2015-04-25 Thread Jan Janssen
On 2015-04-08 16:14, Jan Janssen wrote: On 2015-04-08 14:39, Lennart Poettering wrote: On Thu, 02.04.15 17:08, Jan Janssen (medhe...@web.de) wrote: This method should greatly improve offset based lookup. We now don't have to aggregate the full boot listing just so we can jump to a spe

Re: [systemd-devel] [PATCH] systemctl: Use logind for --firmware-setup if possible

2015-04-08 Thread Jan Janssen
What's the point in retrying if you got EOPNOTSUPP the first time? :P Jan On 2015-04-08 18:24, Lennart Poettering wrote: On Wed, 08.04.15 16:49, Jan Janssen (medhe...@web.de) wrote: Awesome! Thanks! Applied! (Though I took the liberty to swap the order around, to first try direct access

[systemd-devel] [PATCH] systemctl: Use logind for --firmware-setup if possible

2015-04-08 Thread Jan Janssen
--- src/systemctl/systemctl.c | 43 ++- 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index ae87e44..caa8d07 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -291

Re: [systemd-devel] [PATCH v2] journalctl: Improve boot ID lookup

2015-04-08 Thread Jan Janssen
On 2015-04-08 14:39, Lennart Poettering wrote: On Thu, 02.04.15 17:08, Jan Janssen (medhe...@web.de) wrote: This method should greatly improve offset based lookup. We now don't have to aggregate the full boot listing just so we can jump to a specific position, which can be a real pain o

[systemd-devel] [PATCH v4] Add reboot to EFI support

2015-04-03 Thread Jan Janssen
--- Changes in v4: - better logind API naming - don't write to efi vars if they don't change man/systemctl.xml | 10 +++ shell-completion/bash/systemctl.in | 2 +- shell-completion/zsh/_systemctl.in | 1 + src/login/logind-dbus.c| 9

[systemd-devel] [PATCH v3] Add reboot to EFI support

2015-04-03 Thread Jan Janssen
--- Hi, Changes in v3: - call the feature reboot to firmware everywhere - make the login interface a property and methods to change it and don't couple it with a reboot action - changed/added policykit action defaulting to auth_admin_keep. Please change this if something else is desired.

[systemd-devel] [PATCH v2] journalctl: Improve boot ID lookup

2015-04-02 Thread Jan Janssen
This method should greatly improve offset based lookup. We now don't have to aggregate the full boot listing just so we can jump to a specific position, which can be a real pain on big journals just for a mere "-b -1" case. As an additional benefit --list-boots should improve slightly too, because

Re: [systemd-devel] [PATCH v2] Add reboot to EFI support

2015-04-02 Thread Jan Janssen
Hi, On 2015-04-02 11:34, Lennart Poettering wrote: On Thu, 26.03.15 16:09, Jan Janssen (medhe...@web.de) wrote: Heya, Hmm, so we already support passing special reboot() parameters, and this is done by manipulating a file in /run, without introducing any new targets. To me it appears that

[systemd-devel] [RFC/PATCH] journalctl: Improve boot ID lookup

2015-04-01 Thread Jan Janssen
This method shouldn't provide any noticeable speedup for the --list-boots case, but any offset based lookup should be greatly improved. We now don't have to aggregate the full boot listing just so we can jump to specific position, which can be a real pain on big journals just for a mere "-b -1" cas

Re: [systemd-devel] journalctl not showing most boots/logs

2015-03-27 Thread Jan Janssen
after moving away the file system@00050e650144ab12-15158e9a9df4f071.journal~ which caused the "unused data" message, I get # journalctl --list-boots | wc -l 101 # journalctl -F _BOOT_ID | wc -l 158 2015-03-27 21:23 GMT+01:00 Jan Janssen : On 2015-03-27 21:06, Michael Biebl wrote: 201

Re: [systemd-devel] journalctl not showing most boots/logs

2015-03-27 Thread Jan Janssen
On 2015-03-27 21:06, Michael Biebl wrote: 2015-03-27 20:45 GMT+01:00 Jan Janssen : Martin Pitt ubuntu.com> writes: Hello all, in [1] I just got a report that "journalctl --list-boots" (with persistant journal) only shows a few old boots, but not current ones. I checked this

Re: [systemd-devel] journalctl not showing most boots/logs

2015-03-27 Thread Jan Janssen
Martin Pitt ubuntu.com> writes: > > Hello all, > > in [1] I just got a report that "journalctl --list-boots" (with > persistant journal) only shows a few old boots, but not current ones. > I checked this on my system (which has had persistant journal for a > while), and confirm that: What does

[systemd-devel] [PATCH v2] Add reboot to EFI support

2015-03-26 Thread Jan Janssen
--- man/systemctl.xml | 6 +++- src/libsystemd/sd-bus/bus-common-errors.h | 1 + src/login/logind-dbus.c | 49 +++-- src/login/org.freedesktop.login1.conf | 8 + src/shared/efivars.c | 52

Re: [systemd-devel] [PATCH 1/2] systemctl: Add reboot to firmware support

2015-03-17 Thread Jan Janssen
> Gesendet: Dienstag, 17. März 2015 um 13:41 Uhr > Von: "Dimitri John Ledkov" > An: "Jan Janssen" > Cc: "systemd Mailing List" > Betreff: Re: [systemd-devel] [PATCH 1/2] systemctl: Add reboot to firmware > support > > On 17 March 2015

Re: [systemd-devel] [PATCH 1/2] systemctl: Add reboot to firmware support

2015-03-17 Thread Jan Janssen
Dimitri John Ledkov intel.com> writes: > Both gummyboot and grub-efi have a menu option to reboot into > firmware, is that not enough? Why do we need to have it from userspace > / the booted system? > There can be plenty of reasons why the firmware won't provide you with an option. One of them

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-17 Thread Jan Janssen
> Gesendet: Sonntag, 15. März 2015 um 19:58 Uhr > Von: "Kay Sievers" > An: "Zbigniew Jędrzejewski-Szmek" > Cc: "Jan Janssen" , systemd-devel@lists.freedesktop.org > Betreff: Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable > b

Re: [systemd-devel] [PATCH 1/2] systemctl: Add reboot to firmware support

2015-03-17 Thread Jan Janssen
-update-the-osindications-efi-variable-from-command-line > Gesendet: Sonntag, 15. März 2015 um 11:56 Uhr > Von: "Jan Janssen" > An: systemd-devel@lists.freedesktop.org > Cc: "Jan Janssen" > Betreff: [PATCH 1/2] systemctl: Add reboot to firmware support > >

[systemd-devel] [PATCH 1/2] systemctl: Add reboot to firmware support

2015-03-15 Thread Jan Janssen
--- man/systemctl.xml | 10 shell-completion/bash/systemctl.in | 2 +- shell-completion/zsh/_systemctl.in | 1 + src/shared/efivars.h | 7 +++--- src/systemctl/systemctl.c | 48 ++ 5 files changed, 60 insertion

[systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Jan Janssen
--- man/systemctl.xml | 26 shell-completion/bash/systemctl.in | 8 - shell-completion/zsh/_systemctl.in | 2 ++ src/fsck/fsck.c| 63 + src/shared/efivars.h | 21 +++-- src/systemc

[systemd-devel] [PATCH] networkd: Make DHCP client ID creation configurable

2015-03-03 Thread Jan Janssen
--- man/systemd.network.xml | 8 src/network/networkd-dhcp4.c | 16 src/network/networkd-network-gperf.gperf | 1 + src/network/networkd-network.c | 9 + src/network/networkd.h | 11 +++ 5 files c

Re: [systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-28 Thread Jan Janssen
On 2015-02-28 02:02, Shawn Landden wrote: On Thu, Feb 26, 2015 at 12:04 AM, Jan Janssen mailto:medhe...@web.de>> wrote: Shawn Landden churchofgit.com <http://churchofgit.com>> writes: > void strv_free(char **l) { > -strv_clear(l);

[systemd-devel] Cannot acquire DHCP lease

2015-02-26 Thread Jan Janssen
Hi, since commit commit 5bac5235934fabe5a3e6a9d47f4812f81034c427, networkd cannot acquire DHCP leases on my router if I dual boot with windows. It seems to be that my router is borked since I do get leases after resetting it to factory defaults, but once booting into the other OS, DHCP doesn'

Re: [systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-26 Thread Jan Janssen
Shawn Landden churchofgit.com> writes: > void strv_free(char **l) { > -strv_clear(l); > +char **k; > + > +if (!l) > +return; > + > +for (k = l; *k; k++) > +free(*k); > + > free(l); > } What are you trying to achieve here?

Re: [systemd-devel] [RFC PATCH 2/2] localed: add LANGUAGE= fallback when LANG= is specified

2015-02-01 Thread Jan Janssen
Zbigniew Jędrzejewski-Szmek in.waw.pl> writes: > I think the implementation is fine, since it is rather trivial, but I'm > less certain about the implications of setting LANGUAGE in addtion to > LANG. > > Zbyszek Isn't this something that should be in glibc's lang/locale handling code?

Re: [systemd-devel] What's the correct way to configure encrypted volume and mount point?

2015-01-30 Thread Jan Janssen
John Lane jelmail.com> writes: > $ mount /home/myuser/data > mount: special device /dev/mapper/keyring does not exist Your crypttab entry uses "noauto" as an option. This means that it won't get activated and no plain text device is created. Hence your manual mount can only fail. > I'm guessi

[systemd-devel] [PATCH rebased 3/3] cryptsetup-generator: Add support for naming luks devices on kernel cmdline

2014-12-02 Thread Jan Janssen
--- man/kernel-command-line.xml | 2 ++ man/systemd-cryptsetup-generator.xml | 19 +++ src/cryptsetup/cryptsetup-generator.c | 32 ++-- 3 files changed, 47 insertions(+), 6 deletions(-) diff --git a/man/kernel-command-line.xml b/man/kernel-c

[systemd-devel] [PATCH rebased 1/3] cryptsetup-generator: Split main() into more functions and use hasmaps

2014-12-02 Thread Jan Janssen
--- man/systemd-cryptsetup-generator.xml | 9 +- src/cryptsetup/cryptsetup-generator.c | 380 +- 2 files changed, 199 insertions(+), 190 deletions(-) diff --git a/man/systemd-cryptsetup-generator.xml b/man/systemd-cryptsetup-generator.xml index 3abb39d..ff94e88

[systemd-devel] [PATCH rebased 2/3] cryptsetup-generator: Add support for UUID-specific key files on kernel command line

2014-12-02 Thread Jan Janssen
--- man/systemd-cryptsetup-generator.xml | 11 --- src/cryptsetup/cryptsetup-generator.c | 17 ++--- 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/man/systemd-cryptsetup-generator.xml b/man/systemd-cryptsetup-generator.xml index ff94e88..d4a9cc7 100644 --- a

Re: [systemd-devel] Cannot use systemctl after heavy swapping

2014-11-14 Thread Jan Janssen
On 2014-11-14 16:06, Michal Schmidt wrote: On 11/14/2014 03:20 PM, Jan Janssen wrote: I think there might be something wrong with how the rate limiting works in manager.c. Just recently, firefox went nuts and got the whole system swapping like crazy. After manual OOM killing, the system is

[systemd-devel] Cannot use systemctl after heavy swapping

2014-11-14 Thread Jan Janssen
Hi, I think there might be something wrong with how the rate limiting works in manager.c. Just recently, firefox went nuts and got the whole system swapping like crazy. After manual OOM killing, the system is back to normal, but I can't seem to do any service management with systemctl afterwa

[systemd-devel] [PATCH 2/3] cryptsetup-generator: Add support for UUID-specific key files on kernel command line

2014-11-07 Thread Jan Janssen
--- man/systemd-cryptsetup-generator.xml | 11 --- src/cryptsetup/cryptsetup-generator.c | 17 ++--- 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/man/systemd-cryptsetup-generator.xml b/man/systemd-cryptsetup-generator.xml index ff94e88..d4a9cc7 100644 --- a

[systemd-devel] [PATCH 3/3] cryptsetup-generator: Add support for naming luks devices on kernel cmdline

2014-11-07 Thread Jan Janssen
--- man/kernel-command-line.xml | 2 ++ man/systemd-cryptsetup-generator.xml | 19 +++ src/cryptsetup/cryptsetup-generator.c | 32 ++-- 3 files changed, 47 insertions(+), 6 deletions(-) diff --git a/man/kernel-command-line.xml b/man/kernel-c

[systemd-devel] [PATCH 1/3] cryptsetup-generator: Split main() into more functions and use hasmaps

2014-11-07 Thread Jan Janssen
--- man/systemd-cryptsetup-generator.xml | 9 +- src/cryptsetup/cryptsetup-generator.c | 380 +- 2 files changed, 199 insertions(+), 190 deletions(-) diff --git a/man/systemd-cryptsetup-generator.xml b/man/systemd-cryptsetup-generator.xml index 3abb39d..ff94e88

Re: [systemd-devel] Leak mempool/hashmap

2014-11-06 Thread Jan Janssen
On 2014-11-06 19:05, Lennart Poettering wrote: On Thu, 06.11.14 18:36, Jan Janssen (medhe...@web.de) wrote: Hi, I just noticed that mempool/hashmap leaks memory. It's as simple as this to trigger: #include "hashmap.h" int main(int argc, const char *argv[]) {

[systemd-devel] Leak mempool/hashmap

2014-11-06 Thread Jan Janssen
Hi, I just noticed that mempool/hashmap leaks memory. It's as simple as this to trigger: #include "hashmap.h" int main(int argc, const char *argv[]) { Hashmap *m = hashmap_new(&string_hash_ops); hashmap_free(m); } ___ systemd-devel ma

[systemd-devel] [PATCH v2] journalctl: Unify boot id lookup into common function get_boots

2014-10-23 Thread Jan Janssen
--- Changes in v2: - Properly initialize count to zero src/journal/journalctl.c | 134 +-- 1 file changed, 59 insertions(+), 75 deletions(-) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index dfde0a9..7ce5ff6 100644 --- a/src/journ

[systemd-devel] [PATCH] journalctl: Unify boot id lookup into common function get_boots

2014-10-10 Thread Jan Janssen
--- src/journal/journalctl.c | 133 +-- 1 file changed, 58 insertions(+), 75 deletions(-) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index 328e40b..550b610 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -82

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-08 Thread Jan Janssen
On 2014-10-08 14:59, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Oct 08, 2014 at 08:24:49AM +0200, Jan Janssen wrote: Gesendet: Mittwoch, 08. Oktober 2014 um 01:40 Uhr Von: "Zbigniew Jędrzejewski-Szmek" An: "Jan Janssen" Cc: systemd-devel@lists.freedesktop.org Betreff

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-07 Thread Jan Janssen
> Gesendet: Mittwoch, 08. Oktober 2014 um 01:40 Uhr > Von: "Zbigniew Jędrzejewski-Szmek" > An: "Jan Janssen" > Cc: systemd-devel@lists.freedesktop.org > Betreff: Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique > skipping values > &

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-06 Thread Jan Janssen
*bump* On 2014-09-06 10:36, Jan Janssen wrote: sd_journal_enumerate_unique will lock its mmap window to prevent it from being released by calling mmap_cache_get with keep_always=true. This call may return windows that are wider, but compatible with the parameters provided to it. This can

[systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-09-06 Thread Jan Janssen
sd_journal_enumerate_unique will lock its mmap window to prevent it from being released by calling mmap_cache_get with keep_always=true. This call may return windows that are wider, but compatible with the parameters provided to it. This can result in a mismatch where the window to be released can

Re: [systemd-devel] [PATCH] journalctl: Fix --list-boots and --boot

2014-08-31 Thread Jan Janssen
On 2014-08-31 15:32, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Aug 31, 2014 at 10:47:25AM +0200, Jan Janssen wrote: >> >> >> On 2014-08-30 23:46, Zbigniew Jędrzejewski-Szmek wrote: >>> On Fri, Aug 29, 2014 at 06:11:35PM +0200, Jan Janssen wrote: >>>>

[systemd-devel] [PATCH v2] journalctl: Allow to disable line cap with --lines=all

2014-08-31 Thread Jan Janssen
--- man/journalctl.xml | 13 +++-- src/journal/journalctl.c | 42 +++--- 2 files changed, 30 insertions(+), 25 deletions(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index d4e0316..acd75a6 100644 --- a/man/journalctl.xml +++ b/man/journ

Re: [systemd-devel] [PATCH] journalctl: Fix --list-boots and --boot

2014-08-31 Thread Jan Janssen
On 2014-08-30 23:46, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Aug 29, 2014 at 06:11:35PM +0200, Jan Janssen wrote: For some reason, sd_journal_query_unique() and sd_journal_add_match() don't work as they used to. There's a chance boots will be skipped; in my case only 60 of 393

[systemd-devel] [PATCH] journalctl: Allow to disable line cap with --pager-end

2014-08-30 Thread Jan Janssen
--lines=0 hardly makes sense with --pager-end, so give it some new meaning. --- man/journalctl.xml | 6 +++--- src/journal/journalctl.c | 12 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index d4e0316..5c8d78c 100644 --

[systemd-devel] test-ipv4ll never finishes

2014-08-30 Thread Jan Janssen
Hi, on my system, test-ipv4ll waits forever on an epoll: $ strace ./test-ipv4ll execve("./test-ipv4ll", ["./test-ipv4ll"], [/* 64 vars */]) = 0 brk(0) = 0x7f387087e000 access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory) open("/etc/ld.s

[systemd-devel] [PATCH] journalctl: Fix --list-boots and --boot

2014-08-29 Thread Jan Janssen
For some reason, sd_journal_query_unique() and sd_journal_add_match() don't work as they used to. There's a chance boots will be skipped; in my case only 60 of 393 boots show up. Therefore, do sd_journal_query_unique() first and then iterate over those to query their timespec. https://bugs.freedes

[systemd-devel] [PATCH] cryptsetup-generator: Allow specifiying a name on the kernel command line

2014-08-29 Thread Jan Janssen
--- man/systemd-cryptsetup-generator.xml | 8 ++-- src/cryptsetup/cryptsetup-generator.c | 32 +--- 2 files changed, 23 insertions(+), 17 deletions(-) diff --git a/man/systemd-cryptsetup-generator.xml b/man/systemd-cryptsetup-generator.xml index 3abb39d..44c8658

Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-29 Thread Jan Janssen
On 2014-08-29 04:28, Andrei Borzenkov wrote: В Thu, 28 Aug 2014 19:36:53 +0200 Jan Janssen пишет: On Thursday 28 August 2014 11:33:44 Ivan Shapovalov wrote: On Thursday 28 August 2014 at 06:25:51, Jan Janssen wrote: Ivan Shapovalov gmail.com> writes: On Wednesday 27 August 2014 at 03

Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-28 Thread Jan Janssen
On Thursday 28 August 2014 11:33:44 Ivan Shapovalov wrote: > On Thursday 28 August 2014 at 06:25:51, Jan Janssen wrote: > > Ivan Shapovalov gmail.com> writes: > > > On Wednesday 27 August 2014 at 03:16:10, Zbigniew Jędrzejewski-Szmek > > > wrote: > > > >

Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-27 Thread Jan Janssen
Ivan Shapovalov gmail.com> writes: > > On Wednesday 27 August 2014 at 03:16:10, Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Aug 26, 2014 at 10:21:59PM +0200, Lennart Poettering wrote: > > > On Wed, 27.08.14 00:17, Ivan Shapovalov (intelfx100 gmail.com) wrote: > > > > This patchset allows

Re: [systemd-devel] Networkd randomly doesn't configure network

2014-06-15 Thread Jan Janssen
I had a couple of boots with this patch applied and it seems to fix the issue, thanks. Jan On 2014-06-14 19:13, Tom Gundersen wrote: On Sat, Jun 14, 2014 at 3:36 PM, Jan Janssen wrote: systemd-networkd randomly refuses to set up my network card at boot. Thanks for the report and the logs

[systemd-devel] Behavior regarding ReadWriteDirectories= and otheres

2014-06-15 Thread Jan Janssen
Hi, while booting this morning I noticed that a service I wrote which had a very paranoid PrivateTmp=yes ReadOnlyDirectories=/ ReadWriteDirectories=/var/cache/something which used to work quite nicely was failing to start. It seems that ever since the recent changes wit

Re: [systemd-devel] Networkd randomly doesn't configure network

2014-06-14 Thread Jan Janssen
It's in the original mail. But I'll attach it anyway. On 2014-06-14 15:52, Tom Gundersen wrote: Hi Jan, Could you attach your home.network file (in particular the [Match] section)? Cheers, Tom On Sat, Jun 14, 2014 at 3:36 PM, Jan Janssen wrote: Hi, systemd-networkd randomly

[systemd-devel] Networkd randomly doesn't configure network

2014-06-14 Thread Jan Janssen
Hi, systemd-networkd randomly refuses to set up my network card at boot. It gets its proper persistent name but no IP address is assigned, regardless of whether I use a static configuration or DCHP. A simple "systemctl restart systemd-networkd.service" fixes it. I'm using a up to date Arch Linux a

Re: [systemd-devel] [HEADS-UP] It's release time!

2014-02-22 Thread Jan Janssen
On 02/18/2014 01:33 PM, Tom Gundersen wrote: On Tue, Feb 18, 2014 at 1:20 PM, Jan Janssen wrote: the *.link files for networkd completely lack documentation. They are documented in udev(8). Let me know if anything is unclear or lacking. And in general, I would say that networkd could

Re: [systemd-devel] [HEADS-UP] It's release time!

2014-02-18 Thread Jan Janssen
> Gesendet: Dienstag, 18. Februar 2014 um 13:33 Uhr > Von: "Tom Gundersen" > An: "Jan Janssen" > Cc: "systemd Mailing List" > Betreff: Re: [systemd-devel] [HEADS-UP] It's release time! > > On Tue, Feb 18, 2014 at 1:20 PM, Jan Janssen

Re: [systemd-devel] [HEADS-UP] It's release time!

2014-02-18 Thread Jan Janssen
Lennart Poettering poettering.net> writes: > > Heya! > > It's release time again! It has been more than 4 months now since the > last release. That's kinda emberassing, since we actually intended to go > for a 2-3 week cycle... The big dbus transition took some time however. > > Aynway, I just

[systemd-devel] [PATCH] man: cryptsetup-1.6.3 now allows partition device file in system mode

2014-02-07 Thread Jan Janssen
--- man/crypttab.xml | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/man/crypttab.xml b/man/crypttab.xml index 5f386e5..c563851 100644 --- a/man/crypttab.xml +++ b/man/crypttab.xml @@ -305,14 +305,7 @@ Use TrueCrypt in system

[systemd-devel] [PATCH] man: cryptsetup now allows partition device file in system mode

2014-02-06 Thread Jan Janssen
--- man/crypttab.xml | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/man/crypttab.xml b/man/crypttab.xml index 5f386e5..c563851 100644 --- a/man/crypttab.xml +++ b/man/crypttab.xml @@ -305,14 +305,7 @@ Use TrueCrypt in system

[systemd-devel] [PATCH] Make hibernation test work for swap files

2013-10-31 Thread Jan Janssen
Suspend to disk works for swap files too (even if it is located on an ecrypted file system): https://www.kernel.org/doc/Documentation/power/swsusp-and-swap-files.txt --- src/shared/sleep-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/sleep-config.c b/src/sh

Re: [systemd-devel] removal of RD_TIMESTAMP support in initrd

2013-07-23 Thread Jan Janssen
On 07/23/2013 01:16 AM, Tom Gundersen wrote: On Tue, Jul 23, 2013 at 12:44 AM, Lennart Poettering wrote: I do understand that you are currently not running systemd in the initrd [1], so for you for now this is indeed a loss of functionality. I am sorry for that, but please understand this as ge

[systemd-devel] [PATCH] man: Fix exmaple to use the new --boot syntax

2013-07-19 Thread Jan Janssen
--- man/journalctl.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index da43bf2..fab28e6 100644 --- a/man/journalctl.xml +++ b/man/journalctl.xml @@ -853,7 +853,7 @@ Show all kernel logs from last boot: -

Re: [systemd-devel] [PATCH v5] journalctl: Add support for showing messages from a previous boot

2013-07-18 Thread Jan Janssen
17:26, Jan Janssen (medhe...@web.de) wrote: Applied this one now. If people start complaining about its speed we can reinvestigate and do find some way for optimization... We need to think about negative matches. Looking for previous boots with negative matches should work nicely. The bisection

Re: [systemd-devel] test-tables failure

2013-07-16 Thread Jan Janssen
On 07/16/2013 04:33 PM, Lennart Poettering wrote: On Tue, 16.07.13 14:57, Jan Janssen (medhe...@web.de) wrote: Hi, test-tables fails on my system. The one it's failing on is: syscall: 222 → (null) → -1 syscall_max() tells me that I have 351 syscalls, so I guess there is a logic err

[systemd-devel] test-tables failure

2013-07-16 Thread Jan Janssen
Hi, test-tables fails on my system. The one it's failing on is: syscall: 222 → (null) → -1 syscall_max() tells me that I have 351 syscalls, so I guess there is a logic error in the test case? This is on a pretty old x86 machine. Jan ___ systemd-d

[systemd-devel] [PATCH 3/3 v2] cryptsetup: Add tcrypt support

2013-07-13 Thread Jan Janssen
Tcrypt uses a different approach to passphrases/key files. The passphrase and all key files are incorporated into the "password" to open the volume. So, the idea of slots that provide a way to open the volume with different passphrases/key files that are independent from each other like with LUKS d

[systemd-devel] [PATCH 2/3 v2] cryptsetup: Move attaching of the device out of main

2013-07-13 Thread Jan Janssen
--- src/cryptsetup/cryptsetup.c | 222 +++- 1 file changed, 114 insertions(+), 108 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index 994a0e0..e84ebba 100644 --- a/src/cryptsetup/cryptsetup.c +++ b/src/cryptsetup/crypt

[systemd-devel] [PATCH 1/3 v2] cryptsetup: Move password query out of main

2013-07-13 Thread Jan Janssen
Also use _cleanup_free_ where possible. --- src/cryptsetup/cryptsetup.c | 153 +--- 1 file changed, 72 insertions(+), 81 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index 347394d..994a0e0 100644 --- a/src/cryptsetup/c

Re: [systemd-devel] [PATCH 3/3 (rebased)] cryptsetup: Add tcrypt support

2013-07-12 Thread Jan Janssen
On 07/12/2013 08:36 PM, Lennart Poettering wrote: On Tue, 09.07.13 21:15, Jan Janssen (medhe...@web.de) wrote: +if (*key_file) { +r = read_one_line_file(*key_file, &passphrase); +if (r < 0) { +log_error("Failed to r

[systemd-devel] [PATCH 3/3 (rebased)] cryptsetup: Add tcrypt support

2013-07-09 Thread Jan Janssen
Tcrypt uses a different approach to passphrases/key files. The passphrase and all key files are incorporated into the "password" to open the volume. So, the idea of slots that provide a way to open the volume with different passphrases/key files that are independent from each other like with LUKS d

[systemd-devel] [PATCH 3/3] cryptsetup: Add tcrypt support

2013-07-02 Thread Jan Janssen
Tcrypt uses a different approach to passphrases/key files. The passphrase and all key files are incorpaorated into the "password" to open the volume. So, the idea of slots that provide a way to open the volume with different passphrases/key files that are independent from each other like with LUKS

[systemd-devel] [PATCH 2/3] cryptsetup: Move attaching of the device out of main

2013-07-02 Thread Jan Janssen
--- src/cryptsetup/cryptsetup.c | 229 +++- 1 file changed, 121 insertions(+), 108 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index 994a0e0..cb48009 100644 --- a/src/cryptsetup/cryptsetup.c +++ b/src/cryptsetup/crypt

[systemd-devel] [PATCH 1/3] cryptsetup: Move password query out of main

2013-07-02 Thread Jan Janssen
Also use _cleanup_free_ where possible. --- src/cryptsetup/cryptsetup.c | 153 +--- 1 file changed, 72 insertions(+), 81 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index 347394d..994a0e0 100644 --- a/src/cryptsetup/c

[systemd-devel] [PATCH] scope: Silence compiler warning

2013-07-01 Thread Jan Janssen
--- src/core/dbus-scope.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/dbus-scope.c b/src/core/dbus-scope.c index bddf8f4..f6cfe38 100644 --- a/src/core/dbus-scope.c +++ b/src/core/dbus-scope.c @@ -93,7 +93,7 @@ static int bus_scope_set_transient_property(

[systemd-devel] [PATCH v5] journalctl: Add support for showing messages from a previous boot

2013-06-28 Thread Jan Janssen
Unfortunately, order of sd_journal_enumerate_unique() is undefined, so we have to sort the boot IDs. For that we seach for any log entry with a specific boot ID and then use the realtime stamp to order everything. --- Hi, I redid the boot ID look up to use enumerate_unique. This is quite fast if

[systemd-devel] [PATCH] journal-verify: Use proper printf placeholder

2013-06-27 Thread Jan Janssen
--- src/journal/journal-verify.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/journal/journal-verify.c b/src/journal/journal-verify.c index 781b1ee..3405811 100644 --- a/src/journal/journal-verify.c +++ b/src/journal/journal-verify.c @@ -67,7 +67,7 @@ static int jo

[systemd-devel] [PATCH] test: Add list testcase

2013-06-26 Thread Jan Janssen
/test/test-list.c @@ -0,0 +1,109 @@ +/*** + This file is part of systemd + + Copyright 2013 Jan Janssen + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either version

[systemd-devel] [PATCH] libudev: Use correct type for sizeof

2013-06-22 Thread Jan Janssen
--- src/udev/udev-rules.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c index 7a4fb70..fe65e2d 100644 --- a/src/udev/udev-rules.c +++ b/src/udev/udev-rules.c @@ -1614,7 +1614,7 @@ struct udev_rules *udev_rules_new(struct udev *ude

Re: [systemd-devel] [PATCH v4] journalctl: Add support for showing messages from a previous boot

2013-06-15 Thread Jan Janssen
On 06/14/2013 10:43 PM, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jun 12, 2013 at 02:41:15PM +0200, Jan Janssen wrote: Unfortunately, to get a chronological list of boot IDs, we need to search through the journal. sd_journal_enumerate_unique() doesn't help us here, because the ord

Re: [systemd-devel] [PATCH] udev hwdb: Store binary database in libdir, not in /etc

2013-06-14 Thread Jan Janssen
On 06/14/2013 01:08 PM, Tom Gundersen wrote: That said, I don't think libdir is appropriate as this data is not under the control of the package manager (as it is generated at install-time rather than at build-time, it would for instance not be suitable for sharing between hosts). I guess localst

[systemd-devel] [PATCH v4] journalctl: Add support for showing messages from a previous boot

2013-06-12 Thread Jan Janssen
Unfortunately, to get a chronological list of boot IDs, we need to search through the journal. sd_journal_enumerate_unique() doesn't help us here, because the order of returned values is undefined. An initial search for the reference boot ID is performed. We then start a search filtering by SD_MES

[systemd-devel] [PATCH] gitignore: Add test-journal-interleaving

2013-06-12 Thread Jan Janssen
--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 7534ac1..d1e2ae9 100644 --- a/.gitignore +++ b/.gitignore @@ -109,6 +109,7 @@ /test-job-type /test-journal /test-journal-enum +/test-journal-interleaving /test-journal-match /test-journal-send /t

[systemd-devel] Compile errors with -Og

2013-06-12 Thread Jan Janssen
Hi, I just tried compiling with -Og and I get these compiler errors. Those don't appear with any other optimization level, so I'm suspecting a compiler but here. But since I'm no C expert, I thought it would be best if I share this here to see if I'm right about this or whether this just shows so

Re: [systemd-devel] [PATCH v3] journalctl: Add support for showing messages from a previous boot

2013-06-10 Thread Jan Janssen
On 06/10/2013 12:15 AM, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jun 05, 2013 at 02:32:35PM +0200, Jan Janssen wrote: --b ---this-boot - -Show data only from

[systemd-devel] [PATCH v3] journalctl: Add support for showing messages from a previous boot

2013-06-05 Thread Jan Janssen
Unfortunately, to get a chronological list of boot IDs, we need to search through the journal. sd_journal_enumerate_unique() doesn't help us here, because order of returned values is undefined. An initial search for the reference boot ID is performed. We then start a search filtering by SD_MESSAGE

Re: [systemd-devel] [PATCH v2] journalctl: Add support for showing messages from a previous boot

2013-06-04 Thread Jan Janssen
Sorry, I failed to hit Reply-All. On 06/04/2013 07:10 PM, Lennart Poettering wrote: On Tue, 04.06.13 18:47, Jan Janssen (medhe...@web.de) wrote: On 06/04/2013 04:42 PM, Lennart Poettering wrote: On Thu, 30.05.13 17:24, Jan Janssen (medhe...@web.de) wrote: I like this idea! The format to

[systemd-devel] [PATCH v2] journalctl: Add support for showing messages from a previous boot

2013-05-30 Thread Jan Janssen
The format to specify the boot ID is inspired by git's ^n syntax and it even allows to look into the future. Unfortunately, to get a chronological list of boot IDs, we need search through the journal. sd_journal_enumerate_unique() doesn't help us here, because order of returned values is undefined

[systemd-devel] [PATCH] journalctl: Add support for showing messages from a previous boot

2013-05-29 Thread Jan Janssen
The format to specify the boot ID is inspired by git's ^n syntax and it even allows to look into the future. Unfortuneately, to get a chronological list of boot IDs, we need to first iterate over all journal entries. sd_journal_enumerate_unique() doesn't help us here, because order of returned val

[systemd-devel] [PATCH 2/2] man: Document missing options

2013-05-17 Thread Jan Janssen
--- man/hostnamectl.xml| 8 man/journalctl.xml | 10 ++ man/localectl.xml | 8 man/timedatectl.xml| 8 src/hostname/hostnamectl.c | 1 + src/journal/coredumpctl.c | 1 + src/locale/localectl.c | 1 + src/timedate/timeda

[systemd-devel] [PATCH 1/2] Fix --no-ask-password

2013-05-17 Thread Jan Janssen
--- src/hostname/hostnamectl.c | 6 +++--- src/locale/localectl.c | 12 src/timedate/timedatectl.c | 14 +- 3 files changed, 20 insertions(+), 12 deletions(-) diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c index 064581a..7c45ce5 100644 --- a/src

[systemd-devel] [PATCH 3/3] util: Fix grammar in comment

2013-03-07 Thread Jan Janssen
--- src/shared/util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index b7ba7fb..c493a34 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -3607,8 +3607,8 @@ void execute_directory(const char *directory, DIR *d, char *argv[

[systemd-devel] [PATCH 1/3] man: Fix id attributes

2013-03-07 Thread Jan Janssen
--- man/sd-readahead.xml | 2 +- man/sd_readahead.xml | 2 +- man/systemd-activate.xml | 2 +- man/systemd-update-utmp-runlevel.service.xml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/man/sd-readahead.xm

[systemd-devel] [PATCH 2/3] man: Unify title for configuration files

2013-03-07 Thread Jan Janssen
--- man/hostname.xml | 2 +- man/localtime.xml | 2 +- man/machine-id.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/hostname.xml b/man/hostname.xml index 84a2961..f89332e 100644 --- a/man/hostname.xml +++ b/man/hostname.xml @@ -24,7 +24,7 @@ -

[systemd-devel] [PATCH] systemctl: Don't give re-activation warning if unit is masked

2013-02-15 Thread Jan Janssen
--- src/systemctl/systemctl.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 4c91a18..0ff3e0a 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -1319,7 +

Re: [systemd-devel] Calendar timer events on non-24/7 systems

2013-02-06 Thread Jan Janssen
On Wednesday 06 February 2013 13:14:00 Kay Sievers wrote: > This will all be implemented in the future, and work a bit like > anacron, it just isn't done yet. > > Kay Thanks. It's nice to know that it's intended to be implemented in the future. Jan ___

Re: [systemd-devel] Calendar timer events on non-24/7 systems

2013-02-06 Thread Jan Janssen
On Tuesday 05 February 2013 11:19:29 David Strauss wrote: > On Tue, Feb 5, 2013 at 8:54 AM, Jan Janssen wrote: > > It would be nice if timers got scheduled based on their last time they got > > triggered. > > They have always supported this, even before we added calendar-b

  1   2   >