Re: [systemd-devel] [PATCH] rfkill: Add systemd integration

2018-12-10 Thread Karel Zak
don't know. All thread: https://lore.kernel.org/util-linux/0ce3309a-009a-7c00-3a2c-e4917b894...@suse.cz/T/#m221ad50b88792236c10c507f9163b57761c254a7 Karel -- Karel Zak http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-

Re: [systemd-devel] systemd 210 - mount/umount/remount

2016-10-18 Thread Karel Zak
invasive than umount. Or use LVM snapshots ;-) Karel -- Karel Zak <k...@redhat.com> http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [packaging] split of systemd package

2015-11-12 Thread Karel Zak
funcA; funcB; }; where $(VERSION) is always different, then you can be sure that people won't be able to link against the symbols and mix libsystemd with systemd binaries from different versions. Karel -- Karel Zak <k...@redhat.com> http://kar

Re: [systemd-devel] systemd-nspawn and process spawning using nsenter issue

2015-11-04 Thread Karel Zak
sns" command to list namespaces where /proc/$pid/ns/* is different to /proc/$ppid/ns/*, but not sure how usable it will be and what information list. Suggestions & comments? Karel -- Karel Zak <k...@redhat.com> http://karelzak.blogspot.com __

Re: [systemd-devel] SMACK runtime vs build-time checks? (aka: tmp.mount broke my boot)

2015-10-27 Thread Karel Zak
but if you have mount(8) with smack (util-linux --with-smack) and you have kernel with disabled smack than mount(8) removes smack mount options before it calls mount(2) syscall. It means that your fstab is always valid independently on your kernel. The same we use for SELin

Re: [systemd-devel] Stricter handling of failing mounts during boot under systemd - crap idea !

2015-07-02 Thread Karel Zak
. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-03 Thread Karel Zak
The current implementation directly monitor /proc/self/mountinfo and /run/mount/utab files. It's really not optimal because utab file is private libmount stuff without any official guaranteed semantic. The libmount since v2.26 provides API to monitor mount kernel userspace changes. This patch

Re: [systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-02 Thread Karel Zak
then I'm going to update the patch. No problem ;-) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] mount: use libmount to monitor mountinfo utab

2015-06-01 Thread Karel Zak
The current implementation directly monitor /proc/self/mountinfo and /run/mount/utab files. It's really not optimal because utab file is private libmount stuff without any official guaranteed semantic. The libmount since v2.26 provides API to monitor mount kernel userspace changes. This patch

[systemd-devel] [PATCH] build-sys: fix typo

2015-05-29 Thread Karel Zak
There is nothing like systemd_verify_* in Makefile.am. The bug has been invisible because automake uses the default CFLAGS when component CFLAGS are undefined. --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index d6010c5..ed5135d

[systemd-devel] [PATCH] swap: use swapon -o

2015-05-25 Thread Karel Zak
This patch simplify swapon usage in systemd. The command swapon(8) since util-linux v2.26 supports -o list. The idea is exactly the same like for mount(8). The -o specifies options in fstab-compatible way. For systemd it means that it does not have to care about things like discard or another

Re: [systemd-devel] [PATCH] swap: use swapon -o

2015-05-21 Thread Karel Zak
behaviour. Maybe the generator should be also updated to stop generate Priority:. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

[systemd-devel] [PATCH] swap: use swapon -o

2015-05-20 Thread Karel Zak
This patch simplify swapon usage in systemd. The command swapon(8) since util-linux v2.26 supports -o list. The idea is exactly the same like for mount(8). The -o specifies options in fstab-compatible way. For systemd it means that it does not have to care about things like discard or another

[systemd-devel] [PATCH] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-18 Thread Karel Zak
Currently we have no way how to specify dependencies between fstab entries (or another units) in the /etc/fstab. It means that users are forced to bypass fstab and write .mount units manually. The patch introduces new systemd fstab options: x-systemd.requires=PATH - to specify dependence an

[systemd-devel] [PATCH] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-15 Thread Karel Zak
Currently we have no way how to specify dependencies between fstab entries (or another units) in the /etc/fstab. It means that users are forced to bypass fstab and write .mount units manually. The patch introduces new systemd fstab options: x-systemd.requires=PATH - to specify dependence an

[systemd-devel] [PATCH v2] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-14 Thread Karel Zak
Currently we have no way how to specify dependencies between fstab entries (or another units) in the /etc/fstab. It means that users are forced to bypass fstab and write .mount units manually. The patch introduces new systemd fstab options: x-systemd.requires=PATH - to specify dependence an

Re: [systemd-devel] [PATCH v2] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-14 Thread Karel Zak
On Thu, May 14, 2015 at 01:27:40PM +0200, Karel Zak wrote: +static int write_requires_mounts_for(FILE *f, const char *opts) { +_cleanup_free_ char **optsv = NULL, **paths = NULL, *res = NULL; _cleanup_strv_free_ **optsv = NULL, **paths = NULL; Do I need to resend the patch

Re: [systemd-devel] [PATCH] fstab-generator: add x-systemd.{after, requires-mounts-for}=

2015-05-13 Thread Karel Zak
On Wed, May 13, 2015 at 06:35:58AM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 20:37:15 +0200 Karel Zak k...@redhat.com пишет: On Tue, May 12, 2015 at 07:29:33PM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 18:04:50 +0200 Karel Zak k...@redhat.com пишет: Currently we

[systemd-devel] [PATCH] fstab-generator: add x-systemd.{after, requires-mounts-for}=

2015-05-12 Thread Karel Zak
defaults /dev/sdc2 /mnt/high ext4 defaults overlay /mnt/merged overlay lowerdir=/mnt/low,upperdir=/mnt/high/data,workdir=/mnt/high/work,x-systemd.requires-mounts-for=/mnt/low\040/mnt/high References: https://bugzilla.redhat.com/show_bug.cgi?id=812826 Signed-off-by: Karel Zak k

Re: [systemd-devel] [PATCH] fstab-generator: add x-systemd.{after, requires-mounts-for}=

2015-05-12 Thread Karel Zak
On Tue, May 12, 2015 at 07:29:33PM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 18:04:50 +0200 Karel Zak k...@redhat.com пишет: Currently we have no way how to specify dependencies between fstab entries (or another units) in the /etc/fstab. It means that users are forced to bypass

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-14 Thread Karel Zak
you do not need systemd to listen for the changes. findmnt --first-only --poll=umount /mnt/foo rmdir /mnt/foo Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-11 Thread Karel Zak
. Or to turn this around: instead of patching systemd the better idea would probably be to teach overlayfs name_to_handle_at() support, so +1 -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-10 Thread Karel Zak
://ftp.kernel.org/pub/linux/utils/util-linux/v2.26/libmount-docs/libmount-Table-of-filesystems.html#mnt-table-find-mountpoint Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH] Re: fstab mounts get unmounted during boot (.device unit bouncing?) -- solution

2015-02-23 Thread Karel Zak
On Thu, Feb 12, 2015 at 05:33:26PM +0100, Martin Pitt wrote: \o/ looking forward to let /etc/mtab die a bit more :-) util-linux v2.26 (released last week) provides --enable-libmount-force-mountinfo configure option to make mtab's grave more robust. Karel -- Karel Zak k

Re: [systemd-devel] [PATCH] Re: fstab mounts get unmounted during boot (.device unit bouncing?) -- solution

2015-02-12 Thread Karel Zak
this problem for now, I'll very probably add a new build-system option to disable libmount mtab parsing at all. The heuristic which libmount uses to decide between mtab and mountinfo is unnecessary in mainstream distros. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] [PATCH] Re: fstab mounts get unmounted during boot (.device unit bouncing?) -- solution

2015-02-12 Thread Karel Zak
On Thu, Feb 12, 2015 at 12:25:33PM +0100, Karel Zak wrote: On Thu, Feb 12, 2015 at 10:40:15AM +0100, Martin Pitt wrote: So explicitly specify the file that we actually want to parse. [1] first boot after a distro upgrade, or a package bug, or administrators configuring it explicitly

Re: [systemd-devel] [PATCH] Re: fstab mounts get unmounted during boot (.device unit bouncing?) -- solution

2015-02-12 Thread Karel Zak
. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] Re: fstab mounts get unmounted during boot (.device unit bouncing?) -- solution

2015-02-12 Thread Karel Zak
/util-linux/commit/60d29f827b94097fb718dcb02fad6ccb571bdb2b so don't use Martin's patch on systems with util-linux 2.26 (now -rc2, stable next week). Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing

Re: [systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

2015-01-16 Thread Karel Zak
(and systemd already depends on util-linux). Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-18 Thread Karel Zak
); } while (1); } -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-17 Thread Karel Zak
, but this is irrelevant for systemd. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-12 Thread Karel Zak
On Fri, Dec 12, 2014 at 08:11:54PM +0100, Lennart Poettering wrote: On Fri, 05.12.14 15:54, Karel Zak (k...@redhat.com) wrote: I guess it's enough to add the 'fd' to systmed sd_event_add_io() and call mnt_table_parse_mtab() when a change is detected. (As already implemeted in the original

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-10 Thread Karel Zak
On Wed, Dec 10, 2014 at 01:53:09AM +0100, Lennart Poettering wrote: On Tue, 09.12.14 12:30, Karel Zak (k...@redhat.com) wrote: On Mon, Dec 08, 2014 at 08:10:08PM +0100, Lennart Poettering wrote: Any idea when you intend to realease this new API in a release or even in a stable one

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-09 Thread Karel Zak
On Mon, Dec 08, 2014 at 08:10:08PM +0100, Lennart Poettering wrote: Any idea when you intend to realease this new API in a release or even in a stable one? I'd like to have v2.26-rc1 this month. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-05 Thread Karel Zak
() and call mnt_table_parse_mtab() when a change is detected. (As already implemeted in the original Chris' patch.) usable example: https://github.com/karelzak/util-linux/blob/master/libmount/src/monitor.c#L345 Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-01 Thread Karel Zak
? sure, libmount encodes/decodes all when read/write the files. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [PATCH v2 5/5] mount: auto-detect iSCSI and FCoE as requiring network

2014-12-01 Thread Karel Zak
monitoring. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [RFC 4/4] add remote-fs dependencies if needed after change

2014-11-19 Thread Karel Zak
in properly in mnt_table_parse_mtab Fixed in util-linux git tree. Thanks. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [systemd-devel] remote-fs ordering, iSCSI and _netdev

2014-11-07 Thread Karel Zak
type and it uses /sys, but I have no clue how reliable it's. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd

Re: [systemd-devel] remote-fs ordering, iSCSI and _netdev

2014-10-31 Thread Karel Zak
On Thu, Oct 30, 2014 at 03:04:59PM -0700, Chris Leech wrote: On Thu, Oct 30, 2014 at 12:10:16PM +0100, Karel Zak wrote: On Tue, Oct 28, 2014 at 02:29:35AM +0100, Lennart Poettering wrote: On Mon, 27.10.14 14:10, Chris Leech (cle...@redhat.com) wrote: So for any mounts to remote block

Re: [systemd-devel] [PATCH v3] Bootchart: use /proc/pid/mountinfo for root bdev

2014-10-31 Thread Karel Zak
/torvalds/linux.git/tree/Documentation/filesystems/proc.txt#n1589 Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [PATCH] manager: do not print anything while passwords are being queried

2014-10-30 Thread Karel Zak
opinion about the lock type (flock or the tty ioctls), but I'd like to use the same concept (locks) for all tty components (agetty, plymouth and systemd-ask-password) without exceptions. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] remote-fs ordering, iSCSI and _netdev

2014-10-30 Thread Karel Zak
. IMHO you can implement it as optional feature #ifdef HAVE_LIBMOUNT to optionally use mnt_table_parse_mtab() from libmount rather than directly parse /proc/self/mountinfo. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-24 Thread Karel Zak
On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: Karel Zak k...@redhat.com writes: Karel, any chance you can add a -o option to swapon? No problem, added to TODO. I'll implement it next week. Implemented, it's in util-linux git tree, will be in v2.26. Would you please let me

[systemd-devel] [PATCH] fsck: re-enable fsck -l

2014-10-22 Thread Karel Zak
The -l (lock) has been temporary disabled due to conflict with udev (https://bugs.freedesktop.org/show_bug.cgi?id=79576) The problem is fixed since util-linux v2.25 (Jul 2014). --- README | 3 ++- src/fsck/fsck.c | 13 - 2 files changed, 6 insertions(+), 10 deletions(-)

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Karel Zak
native syntax. Karel, any chance you can add a -o option to swapon? No problem, added to TODO. I'll implement it next week. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-01 Thread Karel Zak
to extend, easy to parse (let's imagine /proc/swaps/sda1/{discard,priority,...} files :) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org

[systemd-devel] [PATCH 2/2] bootchart: ask for --rel when failed to initialize graph start time

2014-07-31 Thread Karel Zak
We always read system uptime before log start time. So the uptime should be always smaller number, except it includes system suspend time. It seems better to ask for --rel and exit() than try to be smart and try to recovery from this situation or generate huge messy graphs. ---

[systemd-devel] [PATCH 1/2] bootchart: don't parse /proc/uptime, use CLOCK_BOOTTIME

2014-07-31 Thread Karel Zak
* systemd-bootchart always parses /proc/uptime, although the information is unnecessary when --rel specified * use /proc/uptime is overkill, since Linux 2.6.39 we have clock_gettime(CLOCK_BOOTTIME, ...). The backend on kernel side is get_monotonic_boottime() in both cases. * main() uses if

Re: [systemd-devel] lastlog and friends

2014-07-30 Thread Karel Zak
On Tue, Jul 29, 2014 at 09:28:42PM +0200, Lennart Poettering wrote: On Tue, 29.07.14 14:43, Karel Zak (k...@redhat.com) wrote: systemd TODO: - Replace utmp, wtmp, btmp, and lastlog completely with journal Can someone elaborate and provide more details, ideas

[systemd-devel] lastlog and friends

2014-07-29 Thread Karel Zak
in applications like login(1), who(1) or PAM. Maybe it would be better than add an extra abstraction layer (by any library). Not sure, too many question :-) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel

Re: [systemd-devel] lastlog and friends

2014-07-29 Thread Karel Zak
idea which has to be implement in on journal side. I'd like to know the long-term goal to avoid some future misunderstanding/flames :-) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH] always check asprintf return code

2014-07-25 Thread Karel Zak
There is a small number of the places in sources where we don't check asprintf() return code and assume that after error the function returns NULL pointer via the first argument. That's wrong, after error the content of pointer is undefined. --- src/core/unit-printf.c

[systemd-devel] [PATCH 1/2] tools: add script to detect repeating words in docs

2014-07-23 Thread Karel Zak
/check-repwords.sh b/tools/check-repwords.sh new file mode 100755 index 000..f2aa327 --- /dev/null +++ b/tools/check-repwords.sh @@ -0,0 +1,97 @@ +#!/bin/bash +# +# Check all files specified on command line for repeating words +# +# Copyright (C) 2014 Karel Zak k...@redhat.com +# based on util

Re: [systemd-devel] [PATCH] rules: add by-parttypeuuid rule for GPT labeled partitions

2014-05-13 Thread Karel Zak
(well, this is from git tree, will be in v2.25 :-) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] fstab-generator: local-fs.target waits for nofail mounts

2014-04-09 Thread Karel Zak
if the device does not exist -- it's evaluated before FS check. Note that fsck(8) itself does not check filesystems, and fsck.type helpers does not have a clue about nofail at all. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

[systemd-devel] [PATCH 1/2] build-sys: move python helpers to tools directory

2014-02-10 Thread Karel Zak
Note that make-man-rules.py is missing in EXTRA_DIST=, this patch fixes this mistake too. --- Makefile.am | 13 +- make-directive-index.py | 320 -- make-man-index.py | 136 -- make-man-rules.py

[systemd-devel] [PATCH 2/2] build-sys: add check-includes build target and script

2014-02-10 Thread Karel Zak
--- Makefile.am | 8 tools/check-includes.pl | 23 +++ 2 files changed, 31 insertions(+) create mode 100755 tools/check-includes.pl diff --git a/Makefile.am b/Makefile.am index e3c1145..09a827b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4937,6

Re: [systemd-devel] fstrim cron job

2014-02-06 Thread Karel Zak
util-linux 2.24.184-663b-dirty 0 Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] remove duplicate includes

2014-01-21 Thread Karel Zak
On Wed, Nov 20, 2013 at 10:54:15PM +0100, Lennart Poettering wrote: On Tue, 19.11.13 02:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, Nov 18, 2013 at 02:48:14PM +0100, Karel Zak wrote: A few trivial patches... the duplications found by https://raw.github.com

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Karel Zak
support and at that point just hard-code things like /usr/bin/mount; there is no need really for a configuration switch here. Yep. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

[systemd-devel] remove duplicate includes

2013-11-18 Thread Karel Zak
A few trivial patches... the duplications found by https://raw.github.com/karelzak/util-linux/master/tools/checkincludes.pl Karel ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH 05/10] nss-myhostname: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/nss-myhostname/netlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/nss-myhostname/netlink.c b/src/nss-myhostname/netlink.c index 47a41f5..d61ecdf 100644 --- a/src/nss-myhostname/netlink.c +++ b/src/nss-myhostname/netlink.c @@ -31,7 +31,6 @@ #include limits.h #include

[systemd-devel] [PATCH 03/10] sysctl: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/sysctl/sysctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c index 67c7872..449e0ca 100644 --- a/src/sysctl/sysctl.c +++ b/src/sysctl/sysctl.c @@ -30,7 +30,6 @@ #include log.h #include strv.h #include util.h -#include strv.h #include

[systemd-devel] [PATCH 10/10] backlight: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/backlight/backlight.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c index 9ec29f7..bf76703 100644 --- a/src/backlight/backlight.c +++ b/src/backlight/backlight.c @@ -24,7 +24,6 @@ #include fileio.h #include libudev.h #include

[systemd-devel] [PATCH 04/10] shared: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/shared/label.c | 1 - src/shared/util.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/shared/label.c b/src/shared/label.c index 5c7cc1c..4a26ba9 100644 --- a/src/shared/label.c +++ b/src/shared/label.c @@ -20,7 +20,6 @@ ***/ #include errno.h -#include sys/stat.h #include

[systemd-devel] [PATCH 01/10] udev: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/udev/mtd_probe/probe_smartmedia.c | 1 - src/udev/v4l_id/v4l_id.c | 4 2 files changed, 5 deletions(-) diff --git a/src/udev/mtd_probe/probe_smartmedia.c b/src/udev/mtd_probe/probe_smartmedia.c index feadb50..a007cce 100644 --- a/src/udev/mtd_probe/probe_smartmedia.c

[systemd-devel] [PATCH 02/10] systemctl: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/systemctl/systemctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 737cd67..54479db 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -65,7 +65,6 @@ #include spawn-polkit-agent.h #include install.h

[systemd-devel] [PATCH 09/10] core: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/core/shutdown.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/shutdown.c b/src/core/shutdown.c index b5eb8b1..bcf2eec 100644 --- a/src/core/shutdown.c +++ b/src/core/shutdown.c @@ -24,7 +24,6 @@ #include sys/reboot.h #include linux/reboot.h #include sys/wait.h -#include

[systemd-devel] [PATCH 07/10] libudev: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/libudev/libudev-device-private.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libudev/libudev-device-private.c b/src/libudev/libudev-device-private.c index cba08d2..cb4947f 100644 --- a/src/libudev/libudev-device-private.c +++ b/src/libudev/libudev-device-private.c @@ -24,7

[systemd-devel] [PATCH 08/10] journal: remove duplicate includes

2013-11-18 Thread Karel Zak
--- src/journal/journalctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index a509104..c44be74 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -48,7 +48,6 @@ #include fileio.h #include build.h #include pager.h

Re: [systemd-devel] is mounting subvolumes with a read-only root subvolume allowed?

2013-11-14 Thread Karel Zak
stupid issue: http://www.spinics.net/lists/linux-btrfs/msg25502.html ... but it seems that btrfs guys are fine with this feature. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH] SMACK: assign * label to /tmp when using SMACK.

2013-11-12 Thread Karel Zak
On Tue, Nov 12, 2013 at 03:16:17PM +0100, Karel Zak wrote: On Fri, Nov 01, 2013 at 09:19:27AM -0700, Kok, Auke-jan H wrote: On Fri, Nov 1, 2013 at 12:57 AM, Karel Zak k...@redhat.com wrote: On Thu, Oct 31, 2013 at 01:20:18PM -0700, Kok, Auke-jan H wrote: BTW, for SELinux we remove

Re: [systemd-devel] [PATCH] SMACK: assign * label to /tmp when using SMACK.

2013-11-01 Thread Karel Zak
mount options? I'll prepare the patch. BTW, the options should be also documented in mount.8 man page :-) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http

Re: [systemd-devel] [PATCH] SMACK: assign * label to /tmp when using SMACK.

2013-10-31 Thread Karel Zak
MS_SLOPPY to kernel :-) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] SMACK: assign * label to /tmp when using SMACK.

2013-10-31 Thread Karel Zak
...). -- for selinux we check for /sys/fs/selinux or /selinux. It would be easer than play nasty games with -s. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-10-07 Thread Karel Zak
in last years, no new features at all... Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Patches to use -.mount without /etc/fstab

2013-10-01 Thread Karel Zak
and continue as usually. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Patches to use -.mount without /etc/fstab

2013-10-01 Thread Karel Zak
On Tue, Oct 01, 2013 at 03:40:00PM +0200, Thomas Bächler wrote: Am 01.10.2013 15:26, schrieb Karel Zak: 2. If /etc/fstab is missing, systemd must create a valid fstab (in this case /run/fstab) so that fsck runs properly. Not following on this one really... If fsck fails if it doesn't

Re: [systemd-devel] [PATCH] units: cleanup agetty command line

2013-06-04 Thread Karel Zak
On Mon, Jun 03, 2013 at 06:00:45PM +0100, Colin Guthrie wrote: 'Twas brillig, and Karel Zak at 03/06/13 13:28 did gyre and gimble: * term type is optional (default is 'linux' for virtual terminals and 'vt102' for serial lines) It may no longer matter (especially if the fix mentioned

[systemd-devel] [PATCH] units: cleanup agetty command line

2013-06-03 Thread Karel Zak
* baud rate is optional and unnecessary for virtual terminals * term type is optional (default is 'linux' for virtual terminals and 'vt102' for serial lines) * long options are more user-friendly ... all this is supported since util-linux v2.20 (Aug 2011). Signed-off-by: Karel Zak k

Re: [systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

2013-02-18 Thread Karel Zak
this pseudo UUID. And it is not the first ugly UUID (see FAT) or HFS (UUID based on md5). Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org

Re: [systemd-devel] systemd-fsck change fsck arguments to -a - -y

2013-02-18 Thread Karel Zak
going to improve fsck.cramfs to accept -a and -y xfs: fsck.xfs is dummy shell script, does nothing, accepts everything:-) btrfs: has --repair, it seems like synonym for -a (I'll ask for more details at btrfs lists) ntfs (-3g): does not support options at all Karel -- Karel

Re: [systemd-devel] systemd-fsck change fsck arguments to -a - -y

2013-02-18 Thread Karel Zak
On Mon, Feb 18, 2013 at 11:52:31AM +0100, Karel Zak wrote: On Wed, Feb 13, 2013 at 03:32:46AM +0100, Lennart Poettering wrote: Hmm, I wonder if -a or -y is the way to go. Karel, as util-linux/fsck maintainer, do you have an opinion whether we should use -a or -y for automatic, non

Re: [systemd-devel] systemd-fsck change fsck arguments to -a - -y

2013-02-11 Thread Karel Zak
-- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] when will mount / df get fixed?

2012-10-01 Thread Karel Zak
concept was planned independently on systemd. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/5] build-sys: move common libraries to separate Makefile

2012-06-19 Thread Karel Zak
recursive make, the result is one Makefile. It's split of *automake* files. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [systemd-devel] [PATCH] fstab-generator: ignore devices with fstype ignore

2012-06-18 Thread Karel Zak
entirely. Hmm, shouldn't we rather remove the over-loading of the fstype in util-linux instead of adding that to systemd. +1 -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [RFC] link against util-linux for fstab parsing

2012-02-18 Thread Karel Zak
); like libc free() all mnt_free_* functions accept NULL. -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH ] Adding /etc/fstab.d/*.fstab support

2012-01-20 Thread Karel Zak
don't have to be stored on the same place like filesystems description. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [PATCH ] Adding /etc/fstab.d/*.fstab support

2012-01-20 Thread Karel Zak
a discussion about this topic on lists where we usually announce util-linux release: https://lkml.org/lkml/2012/1/20/104 We will see... Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd

Re: [systemd-devel] Considering fuse+sshfs mounts as network

2012-01-11 Thread Karel Zak
that this feature has been requested by fuse developers, because with this notation we can support subtype specific /sbin/mount.type[.subtype] helpers. The 'sshfs#example.com' is horrible hack. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] PATCH: do not run fsck on tmpfs mountpoint

2011-11-02 Thread Karel Zak
fsck and everything would be fine. I think we can use the blacklist always, add a new option seems like overkill. If the list makes sense for -a then the same list should be usable for non-all mode too. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] PATCH: do not run fsck on tmpfs mountpoint

2011-11-02 Thread Karel Zak
On Wed, Nov 02, 2011 at 03:39:37PM +0100, Kay Sievers wrote: On Wed, Nov 2, 2011 at 15:27, Karel Zak k...@redhat.com wrote: On Wed, Nov 02, 2011 at 12:15:29PM +0100, Kay Sievers wrote: On Wed, Nov 2, 2011 at 11:21, Frederic Crozat fcro...@suse.com wrote: Le mardi 01 novembre 2011 à 16:54

Re: [systemd-devel] /run DoS

2011-05-09 Thread Karel Zak
the same path (e.g. /run/user) for all users, make the content of the directory invisible for other users and effectively control resources. All this is supported by kernel ;-) Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com

Re: [systemd-devel] [PATCH 2/2] Adding binary to shutdown the system

2010-10-06 Thread Karel Zak
; +goto error; +} +} +} what about exec( swapoff -a ); exec( umount -a ); Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] Compiling in a sandbox

2010-07-09 Thread Karel Zak
standard tool to extract data fields from ELF files. Anyone? man readelf and if I good remember autotools use also objdump. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel