[systemd-devel] Why does nspawn check if in a user session?

session membership as a sloppy proxy for that. If that's the case, wouldn't it be more correct and robust to check for other processes in "/sys/fs/cgroup/.../cgroup.procs"? -- Happy hacking, ~ Luke Shumaker ___ systemd-devel mailing list systemd-devel@list

[systemd-devel] Why does nspawn need two child processes?

namespace? -- Happy hacking, ~ Luke Shumaker ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] time-sync.target

d's sd_pid_notify_with_fds(). If you're writing C anyway, it may be easier to patch systemd-timesyncd to send the additional message when it sends the "STATUS=Syncronized..." message, rather than wrapping it. -- Happy hacking, ~ Luke Shumaker ___

Re: [systemd-devel] time-sync.target

referable to patch timesyncd, instead of having to install separate wrapper to fix the behavior. But for today, it works. -- Happy hacking, ~ Luke Shumaker ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Using systemd --user to manage graphical sessions?

screen via `vncserver` (of course, managed as a systemd user unit :-) ). The only problem I have with this setup is that dunst (my desktop notification daemon) isn't happy running multiple instances on different displays. I think it's because it isn't happy sharing

[systemd-devel] [PATCH] cg_path_get_user_unit(): Did not correctly parse user-unit templates.

It ran either skip_session() or skip_user_manager(), then ran skip_slices() iff skip_session() ran. It needs to run skip_slices() in either case. Included is a test case demonstrating why. --- src/shared/cgroup-util.c| 19 --- src/test/test-cgroup-util.c | 1 + 2 files

Re: [systemd-devel] [PATCH] cg_path_get_user_unit(): Did not correctly parse user-unit templates.

to a Ruby idiom, and I've been working with some Ruby recently. -- Happy hacking, ~ Luke Shumaker ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCHv2] cg_path_get_user_unit(): Did not correctly parse user-unit templates.

It ran either skip_session() or skip_user_manager(), then ran skip_slices() iff skip_session() ran. It needs to run skip_slices() in either case. Included is a test case demonstrating why. --- src/shared/cgroup-util.c| 18 -- src/test/test-cgroup-util.c | 1 + 2 files

Re: [systemd-devel] [PATCH] nspawn: When exiting with an error, make the error code meaningful.

At Sun, 29 Jun 2014 12:31:13 +0100, Djalal Harouni wrote: On Sat, Jun 28, 2014 at 12:09:56PM -0400, Luke Shumaker wrote: This is accomplished by having wait_for_container() return a positive error code when we would like that error code to make its way to the user. This is at odds

[systemd-devel] [PATCH v2 2/3] nspawn: Fix regression with exit status

Commit 113cea8 introduced a bug that caused the exit code of systemd-nspawn to not reflect the exit code of the program executed in the container. --- src/nspawn/nspawn.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/src/nspawn/nspawn.c

[systemd-devel] [PATCH v2 3/3] nspawn: log a warning on failure from wait_for_terminate()

This is at the suggestion of Djalal Harouni on the mailing list, and reflects the behavior of shared/util.c:wait_for_terminate_and_warn(). --- src/nspawn/nspawn.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index

[systemd-devel] [PATCH] nspawn: When exiting with an error, make the error code meaningful.

This is accomplished by having the return value of wait_for_container be interpreted as a negative version of the exit status code. --- src/nspawn/nspawn.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index

[systemd-devel] nspawn: When exiting with an error, make the exit code meaningful.

These two patches both do the same thing, in slightly different ways. They fix a regression intruduced in commit 113cea8 (present in v213 and 214) where the exit status of nspawn does not reflect the exit status of the containered process. Happy hacking, ~ Luke Shumaker

[systemd-devel] [PATCH] nspawn: When exiting with an error, make the error code meaningful.

This is accomplished by having wait_for_container() return a positive error code when we would like that error code to make its way to the user. This is at odds with the CODING_STYLE rule that error codes should be returned as negative values. --- src/nspawn/nspawn.c | 21 +

[systemd-devel] [PATCH 1/2] ptyfwd: Set the size of the PTY base on the size of stdout, not stdin.

--- src/shared/ptyfwd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/ptyfwd.c b/src/shared/ptyfwd.c index 7225b93..85a0ddc 100644 --- a/src/shared/ptyfwd.c +++ b/src/shared/ptyfwd.c @@ -305,7 +305,7 @@ static int process_pty_loop(int master, sigset_t *mask,

[systemd-devel] nspawn (ptyfwd): Correctly handle output redirection

to this. Happy hacking, ~ Luke Shumaker ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 2/2] ptyfwd: Don't set the output prop of stdin, nor the input props of stdout.

It was calling cfmakeraw(3) on the properties for STDIN_FILENO; cfmakeraw sets both input and output properties. If (and only if) stdin and stdout are the same device is this correct. Otherwise, we must change only the input properties of stdin, and only the output properties of stdout. ---