[systemd-devel] crda broken with systemd 220

2015-05-26 Thread Michał Bartoszkiewicz
Hello, it seems that udev from systemd 220 does passes empty environment to a process spawned by a RUN rule. execve(/usr/sbin/crda, [/usr/sbin/crda], [/* 0 vars */]) = 0 This breaks crda, as it expects to see COUNTRY in its environment. -- Michał Bartoszkiewicz mbartoszkiew...@gmail.com

Re: [systemd-devel] systemd-networkd and bonding config

2015-03-05 Thread Michał Bartoszkiewicz
On Thu, Mar 5, 2015 at 3:47 PM, Tom Gundersen t...@jklm.no wrote: The kernel creates bond0 itself. This is confusing and we should probably request the kernel to stop doing that (patch needed). You can use options bonding max_bonds=0 to disable the creation of bond0. -- Michał Bartoszkiewicz

Re: [systemd-devel] [PATCH] only build and install systemd-bus-proxyd if --enable-kdbus

2014-09-25 Thread Michał Bartoszkiewicz
On Thu, Sep 25, 2014 at 11:32 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Applied. Isn't systemd-stdio-bridge used also on non-kdbus systems? -- Michał Bartoszkiewicz mbartoszkiew...@gmail.com ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH] timer: name the stamp file consistently

2014-06-26 Thread Michał Bartoszkiewicz
The stamp file for systemd --user timers was named stamp-foo.timer if XDG_DATA_HOME was unset, but foo.timer otherwise. --- src/core/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/timer.c b/src/core/timer.c index 6f2deda..e69dfbd 100644 --- a/src/core/timer.c

[systemd-devel] [PATCH] journald: make MaxFileSec really default to 1month

2014-06-26 Thread Michał Bartoszkiewicz
journald.conf(5) states that the default for MaxFileSec is one month, but the code didn't respect that. --- src/journal/journald-server.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c index a4600e3..58410a2 100644 ---

[systemd-devel] [PATCH] core: use correct format string for UIDs

2014-06-25 Thread Michał Bartoszkiewicz
--- src/core/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/main.c b/src/core/main.c index 6981e72..8ee12ef 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -1548,7 +1548,7 @@ int main(int argc, char *argv[]) { log_info(Running

Re: [systemd-devel] [PATCH] rules: only run systemd-sysctl when a network device is added

2013-06-16 Thread Michał Bartoszkiewicz
/conf/enp1s0/forwarding=1 after a reboot with the patch applied. This works because systemd-sysctl runs from 99-systemd.rules, so the name has already been changed by earlier rules. -- Michał Bartoszkiewicz mbartoszkiew...@gmail.com ___ systemd-devel

[systemd-devel] [PATCH] journal: correctly convert usec_t to timespec.

2013-05-15 Thread Michał Bartoszkiewicz
Use timespec_store instead of (incorrectly) doing it inline. --- src/journal/journald-server.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c index cc52b8a..b717b92 100644 --- a/src/journal/journald-server.c

Re: [systemd-devel] [bug] (char*)NULL should be used in variadic functions

2013-02-04 Thread Michał Bartoszkiewicz
excercise of making our sources less readable... Or am I missing something here? I believe it is legal (but glibc doesn't seem to do it) to define NULL simply as 0, so sizeof NULL == sizeof(int), which can be different from sizeof(void*). -- Michał Bartoszkiewicz mbartoszkiew...@gmail.com

[systemd-devel] [PATCH] core: do not make sockets dependent on lo

2013-01-12 Thread Michał Bartoszkiewicz
/sys/subsystem/net/devices/lo is never considered active, so sockets with BindToDevice=lo would never be activated. --- src/core/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/socket.c b/src/core/socket.c index fcbcdbe..d755040 100644 --- a/src/core/socket.c

[systemd-devel] [PATCH] localed: create /etc/X11/xorg.conf.d if needed

2012-12-28 Thread Michał Bartoszkiewicz
Use mkdir_p_label instead of mkdir_parents_label, so that the final directory component is created too. --- src/locale/localed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locale/localed.c b/src/locale/localed.c index 04268a1..bb2a3a2 100644 --- a/src/locale/localed.c

[systemd-devel] [PATCH] man: fix parameter in systemd-fstab-generator(8)

2012-12-28 Thread Michał Bartoszkiewicz
There is no parameter named luks.fstab. --- man/systemd-fstab-generator.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-fstab-generator.xml b/man/systemd-fstab-generator.xml index 2decec6..b265b6c 100644 --- a/man/systemd-fstab-generator.xml +++