Re: [systemd-devel] [PATCH] hostnamed: regard convertible chassis type as laptop

[Jani Nikula]

On Mon, 27 Feb 2017, David Herrmann  wrote:
> Turned into a github PR [1]. Can we continue the discussion there?

Sure thing. Thanks, David!

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] hostnamed: regard convertible chassis type as laptop

[David Herrmann]

Hey Jani!

On Fri, Feb 24, 2017 at 4:16 PM, Jani Nikula  wrote:
> On Fri, 24 Feb 2017, Jani Nikula  wrote:
>> While both the DMI and ACPI data are regarded as unreliable in hostnamed
>> source, consumers of the chassis type use it to make rather drastic
>> policy decisions.
>
> BTW, since the implementation seems to think the data is unreliable,
> perhaps it would be prudent to say so in hostnamectl documentation, so
> the consumers of the data might be more thoughtful about what to use it
> for?

Turned into a github PR [1]. Can we continue the discussion there?

Thanks
David

[1] https://github.com/systemd/systemd/pull/5475
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] hostnamed: regard convertible chassis type as laptop

[Jani Nikula]

On Fri, 24 Feb 2017, Jani Nikula  wrote:
> While both the DMI and ACPI data are regarded as unreliable in hostnamed
> source, consumers of the chassis type use it to make rather drastic
> policy decisions.

BTW, since the implementation seems to think the data is unreliable,
perhaps it would be prudent to say so in hostnamectl documentation, so
the consumers of the data might be more thoughtful about what to use it
for?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] hostnamed: regard convertible chassis type as laptop

[Jani Nikula]

Currently the DMI convertible chassis type is disregarded by
hostnamed. The fallback ACPI data might indicate either laptop or
tablet. For example, Lenovo Yoga 910 is convertible per DMI data, but
tablet per ACPI data, and therefore receives tablet chassis type. Regard
convertibles as laptops to avoid the risk of them being labeled as
tablets.

While both the DMI and ACPI data are regarded as unreliable in hostnamed
source, consumers of the chassis type use it to make rather drastic
policy decisions. For example, Gnome forcefully autosuspends all tablet
type machines when the screen is blanked, regardless of other
autosuspend options. Arguably that's a bug in Gnome (and it's being
argued at [1]), but some of the issues there, and elsewhere, can be
mitigated by considering convertibles as laptops here.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=764723

---

Alas, I failed to build systemd, so I'm afraid you'll have to consider
this a bug report more than a real submission. :(
---
 src/hostname/hostnamed.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c
index 4657cf8c77b2..bcc3d457403b 100644
--- a/src/hostname/hostnamed.c
+++ b/src/hostname/hostnamed.c
@@ -187,6 +187,7 @@ static const char* fallback_chassis(void) {
 case 0x9: /* Laptop */
 case 0xA: /* Notebook */
 case 0xE: /* Sub Notebook */
+case 0x1F: /* Convertible */
 return "laptop";
 
 case 0xB: /* Hand Held */
-- 
2.1.4

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] hostnamed: regard convertible chassis type as laptop

[systemd github import bot]

Patchset imported to github.
To create a pull request, one of the main developers has to initiate one via:


--
Generated by https://github.com/haraldh/mail2git
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel