Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Michael Marineau
On Aug 14, 2014 1:21 AM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 04.08.14 10:05, Michael Marineau (michael.marin...@coreos.com) wrote: Patch looks pretty good, though I'd really prefer if we could do the UseDomain= thing as discussed in the other mail, and not propagate

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 02:21, Lennart Poettering (lenn...@poettering.net) wrote: On Mon, 04.08.14 10:05, Michael Marineau (michael.marin...@coreos.com) wrote: Patch looks pretty good, though I'd really prefer if we could do the UseDomain= thing as discussed in the other mail, and not propagate

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Tom Gundersen
On Thu, Aug 14, 2014 at 1:11 PM, Lennart Poettering lenn...@poettering.net wrote: UseDomain= should have the effect of adding the domains from dhcp option 15 and 119 to the list of domains for the interface. And sd_network_get_link_domains() should then return a single list, of deduplicated

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 13:27, Tom Gundersen (t...@jklm.no) wrote: On Thu, Aug 14, 2014 at 1:11 PM, Lennart Poettering lenn...@poettering.net wrote: UseDomain= should have the effect of adding the domains from dhcp option 15 and 119 to the list of domains for the interface. And

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Tom Gundersen
On Thu, Aug 14, 2014 at 1:47 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 14.08.14 13:27, Tom Gundersen (t...@jklm.no) wrote: On Thu, Aug 14, 2014 at 1:11 PM, Lennart Poettering lenn...@poettering.net wrote: UseDomain= should have the effect of adding the domains from dhcp

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-13 Thread Lennart Poettering
On Mon, 04.08.14 18:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Does this make any sense? Opinions? Yes, totally makes sense. But the name UseDomains is confusing though. IIUC, we have two separate concepts: 1. using a specific interface (and a set of DNS resolvers tied to

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-13 Thread Lennart Poettering
On Mon, 04.08.14 10:05, Michael Marineau (michael.marin...@coreos.com) wrote: Patch looks pretty good, though I'd really prefer if we could do the UseDomain= thing as discussed in the other mail, and not propagate DHCP-supplied domain names unless explicitly requested. This would means we

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Lennart Poettering
On Wed, 30.07.14 00:37, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: +_public_ int sd_network_get_domainname(int ifindex, char **domainname) { +_cleanup_free_ char *s = NULL, *p = NULL; +int r; + +assert_return(ifindex 0, -EINVAL); +

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Aug 04, 2014 at 05:21:46PM +0200, Lennart Poettering wrote: On Wed, 30.07.14 00:37, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: +_public_ int sd_network_get_domainname(int ifindex, char **domainname) { +_cleanup_free_ char *s = NULL, *p = NULL; +int

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Lennart Poettering
On Tue, 29.07.14 14:48, Michael Marineau (michael.marin...@coreos.com) wrote: When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. Hmm, we really should figure out how we want to support all of this in the long run, between

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Lennart Poettering
On Mon, 04.08.14 17:27, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, Aug 04, 2014 at 05:21:46PM +0200, Lennart Poettering wrote: On Wed, 30.07.14 00:37, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: +_public_ int sd_network_get_domainname(int ifindex,

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Mantas Mikulėnas
On Aug 4, 2014 7:05 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 29.07.14 14:48, Michael Marineau (michael.marin...@coreos.com) wrote: When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. Hmm, we really should

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Aug 04, 2014 at 06:05:05PM +0200, Lennart Poettering wrote: On Tue, 29.07.14 14:48, Michael Marineau (michael.marin...@coreos.com) wrote: When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. Hmm, we really should

[systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-04 Thread Michael Marineau
When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- This is a refresh of the patch on recent master with a little bit of cleanup from the last. Regarding the robustness/correctness/etc of setting the domain resolv.conf attribute

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-02 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jul 29, 2014 at 04:54:24PM -0700, Michael Marineau wrote: On Tue, Jul 29, 2014 at 3:37 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Jul 29, 2014 at 02:48:18PM -0700, Michael Marineau wrote: When the code for generating resolv.conf was moved from networkd to

[systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-07-29 Thread Michael Marineau
When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- This is a resend, rebased since some recent changes changed how this patch needed to be implemented. src/network/networkd-link.c| 13 +

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-07-29 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jul 29, 2014 at 02:48:18PM -0700, Michael Marineau wrote: When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- This is a resend, rebased since some recent changes changed how this patch needed to be implemented.

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-07-29 Thread Michael Marineau
On Tue, Jul 29, 2014 at 3:37 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Jul 29, 2014 at 02:48:18PM -0700, Michael Marineau wrote: When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- This is a resend,

[systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-07-22 Thread Michael Marineau
When the code for generating resolv.conf was moved from networkd to resolved the DHCP domain name code was dropped. --- src/network/networkd-link.c| 2 ++ src/network/sd-network.c | 4 src/resolve/resolved-link.c| 31 +++