[systemd-devel] [PATCH 1/2] libudev: fix move_later comparison

2013-09-13 Thread Lukas Nykryn 
At the beginning move_later is set to -1, but it is set to different
value only if expression !move_later is true.
---
 src/libudev/libudev-enumerate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libudev/libudev-enumerate.c b/src/libudev/libudev-enumerate.c
index bc1e37d..8146f27 100644
--- a/src/libudev/libudev-enumerate.c
+++ b/src/libudev/libudev-enumerate.c
@@ -300,7 +300,7 @@ _public_ struct udev_list_entry 
*udev_enumerate_get_list_entry(struct udev_enume
 /* skip to be delayed devices, and move the to
  * the point where the prefix changes. We can
  * only move one item at a time. */
-if (!move_later) {
+if (move_later == -1) {
 move_later_prefix = 
devices_delay_later(udev_enumerate-udev, entry-syspath);
 
 if (move_later_prefix  0) {
-- 
1.8.3.1

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/2] libudev: fix move_later comparison

2013-09-13 Thread Harald Hoyer 
On 09/13/2013 02:12 PM, Lukas Nykryn wrote:
 At the beginning move_later is set to -1, but it is set to different
 value only if expression !move_later is true.
 ---
  src/libudev/libudev-enumerate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/libudev/libudev-enumerate.c b/src/libudev/libudev-enumerate.c
 index bc1e37d..8146f27 100644
 --- a/src/libudev/libudev-enumerate.c
 +++ b/src/libudev/libudev-enumerate.c
 @@ -300,7 +300,7 @@ _public_ struct udev_list_entry 
 *udev_enumerate_get_list_entry(struct udev_enume
  /* skip to be delayed devices, and move the to
   * the point where the prefix changes. We can
   * only move one item at a time. */
 -if (!move_later) {
 +if (move_later == -1) {
  move_later_prefix = 
 devices_delay_later(udev_enumerate-udev, entry-syspath);
  
  if (move_later_prefix  0) {
 

looks good! please push
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/2] libudev: fix move_later comparison

2013-09-13 Thread Harald Hoyer 
On 09/13/2013 03:25 PM, Harald Hoyer wrote:
 On 09/13/2013 02:12 PM, Lukas Nykryn wrote:
 At the beginning move_later is set to -1, but it is set to different
 value only if expression !move_later is true.
 ---
  src/libudev/libudev-enumerate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/libudev/libudev-enumerate.c 
 b/src/libudev/libudev-enumerate.c
 index bc1e37d..8146f27 100644
 --- a/src/libudev/libudev-enumerate.c
 +++ b/src/libudev/libudev-enumerate.c
 @@ -300,7 +300,7 @@ _public_ struct udev_list_entry 
 *udev_enumerate_get_list_entry(struct udev_enume
  /* skip to be delayed devices, and move the to
   * the point where the prefix changes. We can
   * only move one item at a time. */
 -if (!move_later) {
 +if (move_later == -1) {
  move_later_prefix = 
 devices_delay_later(udev_enumerate-udev, entry-syspath);
  
  if (move_later_prefix  0) {

 
 looks good! please push
 

pushed
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel