Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-04-23 Thread Lennart Poettering
On Fri, 27.02.15 03:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: I'm not sure we want this... Can you add some justification? Do they share code? I am pretty sure we don't want this. shutdown.c really belongs in src/core/. It's a binary that replaces PID 1 during shutdown, and

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 6:26 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: I'm not sure we want this... Can you add some justification? Do they share code? I found it confusing what parts each of these handled, and some code sharing is possible, but none is shared currently. This

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 27, 2015 at 08:52:34AM -0800, Shawn Landden wrote: On Thu, Feb 26, 2015 at 6:26 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: I'm not sure we want this... Can you add some justification? Do they share code? I found it confusing what parts each of these handled,

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
I'm not sure we want this... Can you add some justification? Do they share code? On Fri, Feb 20, 2015 at 02:31:00PM -0800, Shawn Landden wrote: --- Makefile.am | 6 +- src/core/shutdown.c | 420 - src/power/Makefile| 28

[systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-20 Thread Shawn Landden
--- Makefile.am | 6 +- src/core/shutdown.c | 420 - src/power/Makefile| 28 +++ src/power/shutdown.c | 420 + src/power/shutdownd.c | 461