Re: [systemd-devel] [Patch] build issues on ppc

2012-12-19 Thread Lukáš Nykrýn 
Lennart Poettering píše v Út 18. 12. 2012 v 18:20 +0100:
 On Tue, 18.12.12 17:56, Lukáš Nykrýn (lnyk...@redhat.com) wrote:
 
  Hello,
  systemd-196 won't build on ppc
  https://bugzilla.redhat.com/show_bug.cgi?id=888255. I think that
  sufficient patch would be:
  
  diff --git a/Makefile.am b/Makefile.am
  index 804cc04..acbb12b 100644
  --- a/Makefile.am
  +++ b/Makefile.am
  @@ -1068,7 +1068,8 @@ libsystemd_core_la_SOURCES = \
  src/core/syscall-list.c \
  src/core/syscall-list.h \
  src/core/audit-fd.c \
  -   src/core/audit-fd.h
  +   src/core/audit-fd.h \
  +   src/libsystemd-daemon/sd-daemon.c
 
 Hmm, but libsystemd_core_la_LIBADD already pulls in
 libsystemd-daemon.la. So why pull the .c file in too? This doesn't look
 like the right fix to me.
 
 Lennart
 
Sorry I overlooked it. But then I am not sure, why the build is failing.

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [Patch] build issues on ppc

2012-12-19 Thread Lennart Poettering 
On Wed, 19.12.12 11:13, Lukáš Nykrýn (lnyk...@redhat.com) wrote:

  Hmm, but libsystemd_core_la_LIBADD already pulls in
  libsystemd-daemon.la. So why pull the .c file in too? This doesn't look
  like the right fix to me.
  
 Sorry I overlooked it. But then I am not sure, why the build is failing.

Neither am I. Given that this is specific to PPC might be worth pinging
a PPC guru about this for help?

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [Patch] build issues on ppc

2012-12-18 Thread Lukáš Nykrýn 
Hello,
systemd-196 won't build on ppc
https://bugzilla.redhat.com/show_bug.cgi?id=888255. I think that
sufficient patch would be:

diff --git a/Makefile.am b/Makefile.am
index 804cc04..acbb12b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1068,7 +1068,8 @@ libsystemd_core_la_SOURCES = \
src/core/syscall-list.c \
src/core/syscall-list.h \
src/core/audit-fd.c \
-   src/core/audit-fd.h
+   src/core/audit-fd.h \
+   src/libsystemd-daemon/sd-daemon.c

 if HAVE_KMOD
 libsystemd_core_la_SOURCES += \

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [Patch] build issues on ppc

2012-12-18 Thread Lennart Poettering 
On Tue, 18.12.12 17:56, Lukáš Nykrýn (lnyk...@redhat.com) wrote:

 Hello,
 systemd-196 won't build on ppc
 https://bugzilla.redhat.com/show_bug.cgi?id=888255. I think that
 sufficient patch would be:
 
 diff --git a/Makefile.am b/Makefile.am
 index 804cc04..acbb12b 100644
 --- a/Makefile.am
 +++ b/Makefile.am
 @@ -1068,7 +1068,8 @@ libsystemd_core_la_SOURCES = \
 src/core/syscall-list.c \
 src/core/syscall-list.h \
 src/core/audit-fd.c \
 -   src/core/audit-fd.h
 +   src/core/audit-fd.h \
 +   src/libsystemd-daemon/sd-daemon.c

Hmm, but libsystemd_core_la_LIBADD already pulls in
libsystemd-daemon.la. So why pull the .c file in too? This doesn't look
like the right fix to me.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel