Re: [systemd-devel] fstab-generator: why nofail=true removes "Before=$post" in .mount
On Thu, Aug 8, 2013 at 7:35 AM, WANG Chao wrote: > In add_mount(), if nofail=true, "Before=$post" won't be added to > xxx.mount: > > [..] > if (post && !noauto && !nofail && !automount) > fprintf(f, > "Before=%s\n", > post); > > why doing this? The way things currently work you can use 'nofail' when you want your boot to be unaffected by a missing device. If we change this as you suggest, then a missing device will lead to a long timeout (which delays boot by a couple of minutes). That's not really wrong (it doesn't contradict the fstab manpage), but would obviously limit the usefulness of 'nofail'. Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] fstab-generator: why nofail=true removes "Before=$post" in .mount
Hi, all I have a question after looking fstab-generator.c. I hope someone can help me. In add_mount(), if nofail=true, "Before=$post" won't be added to xxx.mount: [..] if (post && !noauto && !nofail && !automount) fprintf(f, "Before=%s\n", post); why doing this? If nofail=true, that means $post "Wants" this xxx.mount. And no matter xxx.mount fails or not, $post will be reached (if post is a target unit). I think it's more reasonable to try do xxx.mount before $post. So I'd like to keep "Before=$post" in the nofail=true case. I coud post a patch, but I think it's best to consult to you guys first in case I'm missing something. Thanks WANG Chao ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
